1
1
openmpi/ompi/mca/pml/cm
Nathan Hjelm e968ddfe64 start bug fixes (#1729)
* mpi/start: fix bugs in cm and ob1 start functions

There were several problems with the implementation of start in Open
MPI:

 - There are no checks whatsoever on the state of the request(s)
   provided to MPI_Start/MPI_Start_all. It is erroneous to provide an
   active request to either of these calls. Since we are already
   looping over the provided requests there is little overhead in
   verifying that the request can be started.

 - Both ob1 and cm were always throwing away the request on the
   initial call to start and start_all with a particular
   request. Subsequent calls would see that the request was
   pml_complete and reuse it. This introduced a leak as the initial
   request was never freed. Since the only pml request that can
   be mpi complete but not pml complete is a buffered send the
   code to reallocate the request has been moved. To detect that
   a request is indeed mpi complete but not pml complete isend_init
   in both cm and ob1 now marks the new request as pml complete.

 - If a new request was needed the callbacks on the original request
   were not copied over to the new request. This can cause osc/pt2pt
   to hang as the incoming message callback is never called.

Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>

* osc/pt2pt: add request for gc after starting a new request

Starting a new receive may cause a recursive call into the pt2pt
frag receive function. If this happens and the prior request is
on the garbage collection list it could cause problems. This commit
moves the gc insert until after the new request has been posted.

Signed-off-by: Nathan Hjelm <hjelmn@me.com>
2016-06-02 20:22:40 -04:00
..
Makefile.am Purge whitespace from the repo 2015-06-23 20:59:57 -07:00
owner.txt add owner files to opa/ompi/orte mca directories 2015-02-22 15:10:23 -07:00
pml_cm_cancel.c * Implement matched probe for the CM PML. Required adding a peer field to 2012-03-22 22:55:59 +00:00
pml_cm_component.c pml/cm: use the priority of the mtl component 2015-10-19 12:32:42 -06:00
pml_cm_component.h Purge whitespace from the repo 2015-06-23 20:59:57 -07:00
pml_cm_recvreq.c Purge whitespace from the repo 2015-06-23 20:59:57 -07:00
pml_cm_recvreq.h pml/cm: update for request changes 2016-05-25 15:35:32 -06:00
pml_cm_request.c Purge whitespace from the repo 2015-06-23 20:59:57 -07:00
pml_cm_request.h Refactor the request completion (#1422) 2016-05-24 18:20:51 -05:00
pml_cm_sendreq.c Purge whitespace from the repo 2015-06-23 20:59:57 -07:00
pml_cm_sendreq.h pml/cm: update for request changes 2016-05-25 15:35:32 -06:00
pml_cm_start.c start bug fixes (#1729) 2016-06-02 20:22:40 -04:00
pml_cm.c Update code base to use the new opal_free_list_t 2015-02-24 10:05:45 -07:00
pml_cm.h start bug fixes (#1729) 2016-06-02 20:22:40 -04:00
post_configure.sh * Fix up some direct-calling issues for the PML/MTL 2006-07-06 15:12:38 +00:00