Pak Lui
e3fdfdbd9c
Fix some typos here and there.
...
This commit was SVN r16058.
2007-09-06 14:56:08 +00:00
Tim Prins
f677ef5c12
Fix build failure on BigRed
...
This commit was SVN r16054.
2007-09-06 12:10:11 +00:00
Pak Lui
3d7b5b306f
Fix a problem with OPAL_ALIGN that causes the upper bytes to get chopped
...
off and bogus addresses to show up for the requests, which in turns causes
message queues not showing up when debugging a 64 bit app on a 32 bit
tvd and dll on only Solaris SPARC.
This commit was SVN r16052.
2007-09-05 23:52:36 +00:00
Pak Lui
99ae2c1c44
Nothing relevent (yet). Just making debugging more enjoyable.
...
This commit was SVN r16051.
2007-09-05 23:21:58 +00:00
Gleb Natapov
b0614931f4
Remove mpool_tree_item from the mpool_tree before unregistering/freeing memory.
...
Otherwise a race exists if another thread allocates already freed memory
which is not removed from the mpool_tree yet.
This commit was SVN r16038.
2007-09-03 10:56:55 +00:00
Josh Hursey
447dc0e6cd
testing
...
This commit was SVN r16032.
2007-08-31 17:59:01 +00:00
Rainer Keller
a3b30749b0
- Only lock/unlock when using threads.
...
Basically revert this part of r16015.
This commit was SVN r16029.
The following SVN revision numbers were found above:
r16015 --> open-mpi/ompi@435e7d80e9
2007-08-31 12:34:48 +00:00
Rainer Keller
9c1c345c07
- head_lock is an opal_atomic_lock_t...
...
This commit was SVN r16028.
2007-08-31 12:20:21 +00:00
Pak Lui
bc34a46969
* complete the fix started in r15915, that is, to prevent negative tags
...
from showing up in the message queue graph. Tags are now casted to int
before the negative checks, since tags by the spec are stored as
mqs_tword_t, an unsigned long long.
This commit was SVN r16027.
The following SVN revision numbers were found above:
r15915 --> open-mpi/ompi@b9ea4c92e7
2007-08-31 03:02:24 +00:00
Shiqing Fan
b1250eba3a
- Some more to be exported.
...
This commit was SVN r16023.
2007-08-30 15:13:08 +00:00
Shiqing Fan
efdcfa3807
- "extern 'C'" has been set twice. Remove one.
...
This commit was SVN r16022.
2007-08-30 15:03:59 +00:00
Shiqing Fan
80fdd5e2a4
- Need to be exported.
...
This commit was SVN r16021.
2007-08-30 14:16:03 +00:00
Gleb Natapov
79011279e5
Remove debug output.
...
This commit was SVN r16016.
2007-08-30 13:29:41 +00:00
Gleb Natapov
435e7d80e9
Remove rc parameter from MCA_BTL_SM_FIFO_WRITE() macro. It cannot fail in
...
current implementation.
This commit was SVN r16015.
2007-08-30 13:21:52 +00:00
Gleb Natapov
690fb95bda
Cleanup send scheduling code.
...
This commit was SVN r16014.
2007-08-30 12:10:04 +00:00
Gleb Natapov
0b0f9d14aa
Mark send request complete on PML level only when absolutely sure there is
...
no more work associated with this request. No more outstanding completions or
packets and send scheduling isn't running in another thread.
This commit was SVN r16013.
2007-08-30 12:08:33 +00:00
Gleb Natapov
fe414047bd
registration may be freed inside mca_mpool_rdma_deregister().
...
This commit was SVN r16012.
2007-08-30 10:52:38 +00:00
Gleb Natapov
091862a25a
Protect access to mca_mpool_base_tree by a lock.
...
This commit was SVN r16011.
2007-08-30 10:51:02 +00:00
Brian Barrett
cfe737d1f9
Fix some mistaken error checks -- errors will be less than zero, not
...
greater than zero
This commit was SVN r16008.
2007-08-29 18:52:51 +00:00
Brian Barrett
f53b14bde5
George noted I had this logic completely backwards. Oops.
...
This commit was SVN r16005.
2007-08-29 16:18:04 +00:00
Gleb Natapov
eac2674f66
The inner voice tells me this is a typo.
...
This commit was SVN r16004.
2007-08-29 13:28:47 +00:00
Brian Barrett
f2d5d663cc
re-enable the disable-dlopen case
...
This commit was SVN r16003.
2007-08-29 03:28:29 +00:00
George Bosilca
756eee571e
Fix Coverty #24 . This test didn't make sense in this branch of the if.
...
This commit was SVN r16001.
2007-08-29 02:02:19 +00:00
Jeff Squyres
466394a878
We only care about the value of ret in the
...
!OMPI_ENABLE_PROGRESS_THREADS case. Reviewed by Brian.
This commit was SVN r16000.
2007-08-29 01:36:17 +00:00
Jeff Squyres
5628084fec
Fix Coverity CID 463: remove unused variable / dead code.
...
This commit was SVN r15999.
2007-08-29 01:30:15 +00:00
Jeff Squyres
8f10c285ef
Fix Coverity CID 466: remove unused variable / dead code.
...
This commit was SVN r15998.
2007-08-29 01:25:03 +00:00
Jeff Squyres
c4a38f47f6
Resolve Coverity CID 467: remove unused variable / dead code.
...
This commit was SVN r15997.
2007-08-29 01:23:18 +00:00
Jeff Squyres
f08cce16db
Fix Coverity CID 468: remove unused variable.
...
This commit was SVN r15996.
2007-08-29 01:21:17 +00:00
Brian Barrett
59b22533f2
Enable RDMA for heterogeneous situations. Currently done by overloading
...
the ompi_convertor_need_buffers function to only return 0 if the convertor
is homogeneous (which it never does on the trunk, but does to on v1.2, but
that's a different issue). Only enable the heterogeneous rdma code for
a btl if it supports it (via a flag), as some btls need some work for this
to work properly. Currently only TCP and OpenIB extensively tested
This commit was SVN r15990.
2007-08-28 21:23:44 +00:00
Brian Barrett
dcf678dbab
Fix heterogeneous issue with non-blocking RML receive, where the sender
...
field could be in the wrong endianness
This commit was SVN r15989.
2007-08-28 20:54:52 +00:00
Gleb Natapov
fa69c5cc10
If a memory on a sender's size is not registered don't register it on a receive
...
side too. Otherwise a content of the recvreq->req_rdma array is replaced later
without freeing previous content and refcount on registration in mpool become
wrong.
This commit was SVN r15978.
2007-08-28 07:43:06 +00:00
Tim Mattox
2c29a2b4ee
Resync the trunk NEWS file's 1.2.4 section with the 1.2 branch NEWS.
...
This commit was SVN r15977.
2007-08-28 04:07:19 +00:00
Rich Graham
bc97d22182
remove tabs. Remove old code that was commented out.
...
This commit was SVN r15975.
2007-08-28 03:08:36 +00:00
Rich Graham
4d58f9aed7
Add comments. Move temporary receive object from a free list object to
...
a stack object.
This commit was SVN r15971.
2007-08-27 21:41:04 +00:00
Pak Lui
75c7d4e03b
Temporary workaround for making Totalview be able to get those opal
...
symbols and load into the library when compiled with a Sun Studio C compiler
This commit was SVN r15970.
2007-08-27 19:04:56 +00:00
Gleb Natapov
e1a1d9d90e
Receive request converter can be accessed in parallel by a thread that receives
...
data and a thread that run RDMA schedule function. Protect access to the
converter by a lock.
This commit was SVN r15967.
2007-08-27 11:41:42 +00:00
Gleb Natapov
33196d972b
post_send() function is called without endpoint lock held from explicit credits
...
update function so eager_rdma_remote.head have to be updated in a thread safe
manner.
This commit was SVN r15966.
2007-08-27 11:37:01 +00:00
Gleb Natapov
32a61c3bf2
Credit fragment is not protected properly from concurrent access. There is a
...
race that can prevent further explicit credits update from been sent. Fix the
race.
This commit was SVN r15965.
2007-08-27 11:34:59 +00:00
Gleb Natapov
065d04dfde
Do not free recvreq while schedule function is running in another thread.
...
This commit was SVN r15964.
2007-08-27 11:31:40 +00:00
Brad Benton
ccda5c9c74
Modified the MCA_BTL_TCP_CONNECTED case in mca_btl_tcp_endpoint_send_handler()
...
to always first check for a NULL frag pointer before trying to send the
fragment. This avoids an issue in multi-threaded execution in which
multiple threads working on the same endpoint can result in a thread
finding itself here with nothing to send.
This commit was SVN r15963.
2007-08-26 23:40:02 +00:00
George Bosilca
475073c684
Be as user friendly as possible and provide more information. Now we make the
...
difference between the user specified length, and the one available from
Open MPI (this allow to se the truncated receives). Moreover, if the
data-type used is named we now print the count as well as the name of
the used data-type.
This commit was SVN r15962.
2007-08-26 23:07:14 +00:00
Jeff Squyres
18db56e270
Fix Coverity defect 675: possible NULL dereference in an error
...
condition.
This commit was SVN r15957.
2007-08-25 12:18:55 +00:00
Jeff Squyres
b69c7688a0
Fix Coverity defect 676: possible NULL dereference in an error
...
condition.
This commit was SVN r15956.
2007-08-25 12:17:02 +00:00
George Bosilca
a6723b34ea
Cleanup the code. Remove all debugging messages.
...
This commit was SVN r15955.
2007-08-24 02:58:09 +00:00
Edgar Gabriel
a2f5cada1a
convert the hiearch component to the new structure. More testing required before we remove the .ompi_ignore flag again.
...
This commit was SVN r15954.
2007-08-23 20:41:29 +00:00
George Bosilca
daaf5a9bf1
Correct the assert macro.
...
This commit was SVN r15953.
2007-08-23 19:48:04 +00:00
George Bosilca
db19f927e8
A lot of cleanups. Verbose is enabled right now as we're tracking down
...
an issue with the ompi_communicator_t structure.
This commit was SVN r15951.
2007-08-23 16:40:07 +00:00
Rainer Keller
b385f8a790
- ompi_comm_set(): PML add_comm may return something != OMPI_SUCCESS
...
Use OMPI_SUCCESS throughout.
- ompi_comm_allocate(): Initialize new_comm=NULL to get rid of
warnings.
This commit was SVN r15948.
2007-08-23 07:40:40 +00:00
Rainer Keller
1b5fa48a29
- Add missing PERUSE_COMM_REQ_REMOVE_FROM_POSTED_Q when matching
...
from the posted generic_recv-queue.
- Move the PERUSE_COMM_MSG_MATCH_POSTED_REQ from
MCA_PML_OB1_RECV_REQUEST_MATCHED to
mca_pml_ob1_recv_frag_match() as suggested by Terry Dontje
Only post, if this is not a probe/iprobe request.
- Do not post PERUSE_COMM_REQ_MATCH_UNEX for probes / iprobes and
do in correct order before PERUSE_COMM_MSG_REMOVE_FROM_UNEX_Q
This commit was SVN r15947.
2007-08-23 07:09:43 +00:00
Rainer Keller
c175801f98
- Initialize in the order of mca_pml_ob1_comm_proc_t...
...
This commit was SVN r15946.
2007-08-23 05:56:22 +00:00