Tim Prins
4033a40e4e
Coding standards...
...
This commit was SVN r16118.
2007-09-13 14:00:59 +00:00
George Bosilca
617ff3a413
Add a MCA parameter for the ELAN MAP ID file.
...
Fix small memory bugs, and track the final segfault. Still some ork to do.
This commit was SVN r16117.
2007-09-12 21:25:35 +00:00
Aurelien Bouteiller
a1f5312afb
Fixed two little warnings
...
This commit was SVN r16116.
2007-09-12 21:07:11 +00:00
Aurelien Bouteiller
ccb3f75e8f
Make sure that the pml v parasite never get loaded when user did not requested FT. This does not break the ability to switch protocol on the fly.
...
This commit was SVN r16114.
2007-09-12 20:47:17 +00:00
George Bosilca
1e7a791349
Remove some of the problems identified by Coverty.
...
This commit was SVN r16112.
2007-09-12 20:13:26 +00:00
Aurelien Bouteiller
828af95be8
Major modification of the vprotocol framework build system. With a better integration in autogen.sh, it allows for generating static-components.h the usual way.
...
NOTE: This build system does not work with the current autogen.sh. Modified one is under heavy testing to make sure it does not have side effects
This commit was SVN r16110.
2007-09-12 18:46:37 +00:00
George Bosilca
7b3dcff267
Coverty: Limit the strcpy to the maximum length of the destination.
...
This commit was SVN r16107.
2007-09-12 18:03:53 +00:00
George Bosilca
bfb4ddc3e2
Coverty: remove dead code.
...
This commit was SVN r16106.
2007-09-12 17:56:33 +00:00
George Bosilca
05ae27c68b
Don't segfault if we receive a fragment for a non existing communicator.
...
Instead, drop it by now.
This commit was SVN r16105.
2007-09-12 17:52:02 +00:00
George Bosilca
c755938eb0
Coverty: release the temporary buffer on error.
...
This commit was SVN r16104.
2007-09-12 17:45:12 +00:00
George Bosilca
2b7ed6262b
Update the communicator lowest_free when we rebuild the communicator list.
...
This commit was SVN r16102.
2007-09-12 16:41:14 +00:00
Shiqing Fan
b1ea3e0054
- add more lines for static import declaration on windows.
...
This commit was SVN r16101.
2007-09-12 15:32:54 +00:00
Shiqing Fan
a0660f4deb
- Just some type casts.
...
This commit was SVN r16100.
2007-09-12 15:29:58 +00:00
Gleb Natapov
07c8fddeef
Fix scheduling of pending send request. It should be scheduled req_lock times.
...
This commit was SVN r16096.
2007-09-12 07:08:38 +00:00
George Bosilca
d8fed2cfa1
Set a default value so that some compilers stop complaining about
...
uninitialized values.
This commit was SVN r16094.
2007-09-11 18:00:53 +00:00
George Bosilca
2e46809995
Only release the comm_reg is we have one.
...
This commit was SVN r16093.
2007-09-11 17:59:40 +00:00
Gleb Natapov
e82a6eec27
Restore check for lowest id. It prevents livelock situation if multiple threads
...
are inside the function and they failed to obtain new cid the first time around.
This commit was SVN r16090.
2007-09-11 15:32:46 +00:00
Gleb Natapov
58a018c16d
The code tries to prevent itself from running for more then one communicator
...
simultaneously, but is doing it incorrectly. If the function is running already
for one communicator and it is called from another thread for other communicator
with lower cid the check comm->c_contextid != ompi_comm_lowest_cid()
will fail and the function will be executed for two different communicators by
two threads simultaneously. There is nothing in the algorithm that prevent it
from been running simultaneously for different communicators as far as I can see,
but ompi_comm_unregister_cid() assumes that it is always called for a communicator
with the lowest cid and this is not always the case. This patch removes bogus
lowest cid check and fix ompi_comm_register_cid() to properly remove cid from
the list.
This commit was SVN r16088.
2007-09-11 13:23:46 +00:00
George Bosilca
8659a864e9
This is the real fix for ticket 317 and ticket 1065 and ticket 278.
...
This commit was SVN r16084.
2007-09-10 22:27:59 +00:00
George Bosilca
8622beda54
This commit should fix the issues with ticket 1065. Now, we correctly
...
duplicate the MPI_UB and MPI_LB datatypes.
This commit was SVN r16083.
2007-09-10 22:13:42 +00:00
Pak Lui
e3fdfdbd9c
Fix some typos here and there.
...
This commit was SVN r16058.
2007-09-06 14:56:08 +00:00
Tim Prins
f677ef5c12
Fix build failure on BigRed
...
This commit was SVN r16054.
2007-09-06 12:10:11 +00:00
Pak Lui
3d7b5b306f
Fix a problem with OPAL_ALIGN that causes the upper bytes to get chopped
...
off and bogus addresses to show up for the requests, which in turns causes
message queues not showing up when debugging a 64 bit app on a 32 bit
tvd and dll on only Solaris SPARC.
This commit was SVN r16052.
2007-09-05 23:52:36 +00:00
Pak Lui
99ae2c1c44
Nothing relevent (yet). Just making debugging more enjoyable.
...
This commit was SVN r16051.
2007-09-05 23:21:58 +00:00
Gleb Natapov
b0614931f4
Remove mpool_tree_item from the mpool_tree before unregistering/freeing memory.
...
Otherwise a race exists if another thread allocates already freed memory
which is not removed from the mpool_tree yet.
This commit was SVN r16038.
2007-09-03 10:56:55 +00:00
Rainer Keller
a3b30749b0
- Only lock/unlock when using threads.
...
Basically revert this part of r16015.
This commit was SVN r16029.
The following SVN revision numbers were found above:
r16015 --> open-mpi/ompi@435e7d80e9
2007-08-31 12:34:48 +00:00
Rainer Keller
9c1c345c07
- head_lock is an opal_atomic_lock_t...
...
This commit was SVN r16028.
2007-08-31 12:20:21 +00:00
Pak Lui
bc34a46969
* complete the fix started in r15915, that is, to prevent negative tags
...
from showing up in the message queue graph. Tags are now casted to int
before the negative checks, since tags by the spec are stored as
mqs_tword_t, an unsigned long long.
This commit was SVN r16027.
The following SVN revision numbers were found above:
r15915 --> open-mpi/ompi@b9ea4c92e7
2007-08-31 03:02:24 +00:00
Shiqing Fan
b1250eba3a
- Some more to be exported.
...
This commit was SVN r16023.
2007-08-30 15:13:08 +00:00
Shiqing Fan
efdcfa3807
- "extern 'C'" has been set twice. Remove one.
...
This commit was SVN r16022.
2007-08-30 15:03:59 +00:00
Shiqing Fan
80fdd5e2a4
- Need to be exported.
...
This commit was SVN r16021.
2007-08-30 14:16:03 +00:00
Gleb Natapov
79011279e5
Remove debug output.
...
This commit was SVN r16016.
2007-08-30 13:29:41 +00:00
Gleb Natapov
435e7d80e9
Remove rc parameter from MCA_BTL_SM_FIFO_WRITE() macro. It cannot fail in
...
current implementation.
This commit was SVN r16015.
2007-08-30 13:21:52 +00:00
Gleb Natapov
690fb95bda
Cleanup send scheduling code.
...
This commit was SVN r16014.
2007-08-30 12:10:04 +00:00
Gleb Natapov
0b0f9d14aa
Mark send request complete on PML level only when absolutely sure there is
...
no more work associated with this request. No more outstanding completions or
packets and send scheduling isn't running in another thread.
This commit was SVN r16013.
2007-08-30 12:08:33 +00:00
Gleb Natapov
fe414047bd
registration may be freed inside mca_mpool_rdma_deregister().
...
This commit was SVN r16012.
2007-08-30 10:52:38 +00:00
Gleb Natapov
091862a25a
Protect access to mca_mpool_base_tree by a lock.
...
This commit was SVN r16011.
2007-08-30 10:51:02 +00:00
Brian Barrett
f53b14bde5
George noted I had this logic completely backwards. Oops.
...
This commit was SVN r16005.
2007-08-29 16:18:04 +00:00
Gleb Natapov
eac2674f66
The inner voice tells me this is a typo.
...
This commit was SVN r16004.
2007-08-29 13:28:47 +00:00
George Bosilca
756eee571e
Fix Coverty #24 . This test didn't make sense in this branch of the if.
...
This commit was SVN r16001.
2007-08-29 02:02:19 +00:00
Jeff Squyres
466394a878
We only care about the value of ret in the
...
!OMPI_ENABLE_PROGRESS_THREADS case. Reviewed by Brian.
This commit was SVN r16000.
2007-08-29 01:36:17 +00:00
Jeff Squyres
c4a38f47f6
Resolve Coverity CID 467: remove unused variable / dead code.
...
This commit was SVN r15997.
2007-08-29 01:23:18 +00:00
Jeff Squyres
f08cce16db
Fix Coverity CID 468: remove unused variable.
...
This commit was SVN r15996.
2007-08-29 01:21:17 +00:00
Brian Barrett
59b22533f2
Enable RDMA for heterogeneous situations. Currently done by overloading
...
the ompi_convertor_need_buffers function to only return 0 if the convertor
is homogeneous (which it never does on the trunk, but does to on v1.2, but
that's a different issue). Only enable the heterogeneous rdma code for
a btl if it supports it (via a flag), as some btls need some work for this
to work properly. Currently only TCP and OpenIB extensively tested
This commit was SVN r15990.
2007-08-28 21:23:44 +00:00
Gleb Natapov
fa69c5cc10
If a memory on a sender's size is not registered don't register it on a receive
...
side too. Otherwise a content of the recvreq->req_rdma array is replaced later
without freeing previous content and refcount on registration in mpool become
wrong.
This commit was SVN r15978.
2007-08-28 07:43:06 +00:00
Rich Graham
bc97d22182
remove tabs. Remove old code that was commented out.
...
This commit was SVN r15975.
2007-08-28 03:08:36 +00:00
Rich Graham
4d58f9aed7
Add comments. Move temporary receive object from a free list object to
...
a stack object.
This commit was SVN r15971.
2007-08-27 21:41:04 +00:00
Pak Lui
75c7d4e03b
Temporary workaround for making Totalview be able to get those opal
...
symbols and load into the library when compiled with a Sun Studio C compiler
This commit was SVN r15970.
2007-08-27 19:04:56 +00:00
Gleb Natapov
e1a1d9d90e
Receive request converter can be accessed in parallel by a thread that receives
...
data and a thread that run RDMA schedule function. Protect access to the
converter by a lock.
This commit was SVN r15967.
2007-08-27 11:41:42 +00:00
Gleb Natapov
33196d972b
post_send() function is called without endpoint lock held from explicit credits
...
update function so eager_rdma_remote.head have to be updated in a thread safe
manner.
This commit was SVN r15966.
2007-08-27 11:37:01 +00:00