Jeff Squyres
d3699fe50e
configure.ac: remove some dead code
...
These variables are not used anywhere, and the comment was out of date.
2015-02-24 13:15:10 -08:00
Jeff Squyres
05f00aface
plm base: ensure mca_base_var_get_value() and mca_base_var_find() succeed
...
This was CID 993712
2015-02-24 15:48:50 -05:00
Ralph Castain
451bd16a10
Remove dead code
2015-02-24 12:41:12 -08:00
Jeff Squyres
4f54fedf05
orterun: ensure to set used_num_procs=true after finding that token
...
This was CID 71687.
2015-02-24 15:25:39 -05:00
Jeff Squyres
1c3cf068a4
nbc ireduce_scatter: ensure to check the correct return code
...
This was CID 1196644 and 1196621
2015-02-24 15:24:11 -05:00
Jeff Squyres
e9980654a8
nbc ireduce_scatter_block: ensure to check the correct return code
...
This was CID 1196643 and 1196615
2015-02-24 15:24:11 -05:00
Jeff Squyres
398ae15533
rmaps_base_frame: remove dead code
...
This was CID 1196641
2015-02-24 15:24:11 -05:00
Jeff Squyres
71ae0ad5ec
oob_tcp_component: add #if OPAL_ENABLE_IPV6 around IPv6-specific code
...
This was CID 1196629
2015-02-24 15:24:11 -05:00
Jeff Squyres
657d2cf77b
io_ompi: check the correct returned value
...
This was CID 731273
2015-02-24 15:24:11 -05:00
Jeff Squyres
b35eb6fe10
nbc ireduce_scatter_block: ensure to check the correct return code
...
This was CID 709594 and 709592
2015-02-24 15:24:10 -05:00
Jeff Squyres
b0acef6f2d
nbc_ireduce_scatter: ensure to check the proper return code
...
This was CID 709229 and 709224.
2015-02-24 15:24:10 -05:00
Jeff Squyres
fd815bba22
bcol basesmuma allreduce: remove redundant assignment
...
This was CID 1196655 and 1196656
2015-02-24 15:24:10 -05:00
Jeff Squyres
3cd36ab12a
openib: fix double free
...
This was CID 1269989
2015-02-24 15:24:10 -05:00
Jeff Squyres
0bd2783b91
oob_usock: don't try to close the socket if it didn't open
...
This was CID 1196663
2015-02-24 15:24:09 -05:00
Jeff Squyres
04d9085c3b
opal_info_support: protect against (group->group_component==NULL)
...
This was CID 1196660
2015-02-24 15:24:09 -05:00
Jeff Squyres
10b93e3f6f
cart_rank: protect against (cart==NULL) possibilities
...
This was CID 1041230
2015-02-24 15:24:09 -05:00
Jeff Squyres
3758e3a242
topo base: ensure topo is != NULL before acting on it
...
This was CID 1041229
2015-02-24 15:24:09 -05:00
Jeff Squyres
f381c5ea8b
crs none: ensure file is != NULL before closing it
...
This was CID 71701
2015-02-24 15:24:09 -05:00
Jeff Squyres
8fd5e75463
crs base: ensure metadata != NULL
...
This was CID 71700
2015-02-24 15:24:08 -05:00
Jeff Squyres
e2223cd9bf
plm_rsh: ensure cwd array is \0-terminated
...
This was CID 72257
2015-02-24 15:24:08 -05:00
Jeff Squyres
1cf197d771
coll_basic_barrier: guard against opal_hibit() returning -1
...
This was CID 1196606 and 1196607
2015-02-24 15:24:08 -05:00
Ralph Castain
332e4fa7aa
Minor fix - relative host name syntax cannot support usernames as you can't know which hosts will be selected
2015-02-24 12:15:28 -08:00
Nathan Hjelm
6dcdb3daf7
mtl/mxm: fix typo from opal_free_list_t update
2015-02-24 11:43:15 -07:00
igor-ivanov
0f44cdd779
Merge pull request #421 from igor-ivanov/pr/fix-oshmem-coverity
...
oshmem: Fix set of coverity issues
2015-02-24 21:40:06 +04:00
Nathan Hjelm
44f93b4832
Merge pull request #407 from hjelmn/opal_free_list
...
Merge opal_free_list_t and ompi_free_list_t
2015-02-24 10:24:27 -07:00
Nathan Hjelm
5ef24000c7
pml/yalla: fix typo in PML_YALLA_FREELIST_INIT
2015-02-24 10:08:54 -07:00
Nathan Hjelm
4443a79af8
mtl/mxm: fix opal_free_list_wait usage error
2015-02-24 10:05:45 -07:00
Jeff Squyres
5894f0c1f2
usnic: update to new mpool API
...
NOTE: Have not added cross-compatibility with v1.8 branch yet
2015-02-24 10:05:45 -07:00
Jeff Squyres
acb1be7dc7
opal_free_list.h: trivial comment fixes
2015-02-24 10:05:45 -07:00
Nathan Hjelm
5f1254d710
Update code base to use the new opal_free_list_t
...
Use of the old ompi_free_list_t and ompi_free_list_item_t is
deprecated. These classes will be removed in a future commit.
This commit updates the entire code base to use opal_free_list_t and
opal_free_list_item_t.
Notes:
OMPI_FREE_LIST_*_MT -> opal_free_list_* (uses opal_using_threads ())
Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2015-02-24 10:05:45 -07:00
Nathan Hjelm
ed78553512
Update opal_free_list_t usage to reflect new class interface.
...
Please verify your components have been updated correctly. Keep in
mind that in terms of threading:
OPAL_FREE_LIST_GET -> opal_free_list_get_st
OPAL_FREE_LIST_RETURN -> opal_free_list_return_st
I used the opal_using_threads() variant anytime it appeared multiple
threads could be operating on the free list. If this is not the case
update to _st. If multiple threads are always in use change to _mt.
2015-02-24 10:05:44 -07:00
Nathan Hjelm
88251a6b94
Combine opal_free_list_t and ompi_free_list_t
...
Historically these two lists were different due to ompi_free_list_t
dependencies in ompi (mpool). Those dependencies have since been moved
to opal so it is safe to (finally) combine them. The combined free
list comes in three flavors:
- Single-threaded. Only to be used when it is guaranteed that no
concurrent access will be made to the free list. Single-threaded
functions are suffixed with _st.
- Mutli-threaded. To be used when the free list may be accessed by
multiple threads despite the setting of opal_using_threads.
Multi-threaded functins are suffixed with _mt.
- Conditionally multi-threaded. Common use case. These functions are
thread-safe if opal_using_threads is set to true.
Compatibility functions for the ompi_free_list_t and the old accessor
functions (OPAL_FREE_LIST_*) are available while the code base is
transitioned to the new class/functions.
Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2015-02-24 10:05:44 -07:00
Igor Ivanov
3e2dd782ea
oshmem: Fix set of coverity issues
...
Signed-off-by: Igor Ivanov <Igor.Ivanov@itseez.com>
2015-02-24 19:03:10 +02:00
Nadezhda Kogteva
c4d6ca6468
grpcomm brcks: fix copy-paste bug which affects performance
2015-02-24 17:06:39 +02:00
Jeff Squyres
b70fa3e2cb
osc_sm: Fix valgrind warning
...
Many thanks to Lisandro Dalcin for contributing this patch.
Fixes open-mpi/ompi#202 .
2015-02-24 03:36:17 -08:00
Jeff Squyres
6c3ddf98ae
revert open-mpi/ompi@c75650e68f
...
That commit was a bad idea.
2015-02-23 15:39:53 -08:00
rhc54
f2f08add87
Merge pull request #418 from jsquyres/pr/minor-orte-compiler-warning-fixes
...
minor orte compiler warning fixes
2015-02-23 14:12:14 -08:00
Jeff Squyres
ece8d09b84
opal_setup_wrappers.m4: avoid some repetitive code
...
Honestly, a bunch of this code could use similar treatment (i.e.,
AC_DEFUN a template that can be used for OPAL/ORTE/OMPI). However, I
don't quite have time for this today. Exercise left for the future reader...
2015-02-23 13:54:50 -08:00
Jeff Squyres
f3fd088493
opal_setup_wrappers.m4: whitespace cleanup
...
No code changes
2015-02-23 13:35:12 -08:00
Jeff Squyres
c75650e68f
opal_finalize: fix minor memory leak
...
This string is strdup'ed in opal_init_util().
2015-02-23 12:34:49 -08:00
Jeff Squyres
226a814c9d
grpcomm_brks: fix minor compiler warning (rc used before set)
...
Also check for OBJ_NEW returning NULL.
2015-02-23 09:04:45 -08:00
Jeff Squyres
600858609e
grpcomm_rcd: fix minor compiler warning (rc used before set)
...
Also check for OBJ_NEW returning NULL.
2015-02-23 09:03:07 -08:00
Jeff Squyres
c7d8563d8d
fcoll_two_phase: fix trivial compiler warning
2015-02-23 08:58:43 -08:00
Howard Pritchard
c9e81b54fb
Merge pull request #412 from hppritcha/topic/owner_files
...
add owner files to opa/ompi/orte mca directories
2015-02-23 09:48:20 -07:00
Jeff Squyres
3e8f468709
mca_base_framework: use the right type for dequeued list items
...
The items on the list are (mca_base_component_list_item_t*)'s, not
(mca_base_component_t*)'s.
2015-02-23 08:30:58 -08:00
Howard Pritchard
61fb62499a
hcoll belongs to MLNX and is active
2015-02-23 09:14:03 -07:00
Mike Dubman
e02121af6f
Merge pull request #411 from miked-mellanox/topic/fix_cov
...
coverity fixes for yalla
2015-02-23 12:01:05 +02:00
Mike Dubman
6b8f9d68e8
Merge pull request #413 from miked-mellanox/topic/revert_mxm_cov_fixes
...
revert mxm cov fixes
2015-02-23 08:56:23 +02:00
Mike Dubman
5b3b04b26e
mxm: revert coverity fixes
...
mxm fails on this commit: 780c93ee57c6e8c788032138a2031b043a8d4858
2015-02-23 07:52:28 +02:00
Gilles Gouaillardet
8d44d7086a
hwloc/base: fix misc memory leaks
...
as reported by Coverity with CIDs 710636 and 1270441
2015-02-23 13:55:04 +09:00