1
1
Граф коммитов

129 Коммитов

Автор SHA1 Сообщение Дата
George Bosilca
bde56ce528 Cleanup the convertor construct function. Do not set any useless values, instead rely on the
calls to convertor_create and convertor_prepare to finish setting up the correct values for
the convertor.

This commit was SVN r9008.
2006-02-13 17:03:36 +00:00
George Bosilca
ecc3e00362 Various cleanups.
This commit was SVN r9002.
2006-02-12 21:36:07 +00:00
George Bosilca
8b525ef21b Include the count when computing the remote size.
This commit was SVN r9001.
2006-02-12 21:34:55 +00:00
George Bosilca
13170eec52 Make sure all datatype files have the correct updated copyright information.
This commit was SVN r8998.
2006-02-12 21:03:01 +00:00
George Bosilca
25020f58c1 Correct the MPI_Indexed bug. Actually it can be triggered by any type of
data, if the packed data is contiguous and the unpacked one is not. The
problem was that the unpack function did not update the bConverted value
to the real number of bytes extracted from the iovecs, but limit the update
to the number of bytes moved into the user buffers. So, if there were some
bytes copied in the internal pending buffer, they were lost because the next
convertor instead of using the correct bConverted (with the total number of
bytes) has only the transfered number. The result of this bug, is a shift to
left by few bytes of the values in the user buffers.
Add a protection against such kind of errors in the new_position.c.

This commit was SVN r8997.
2006-02-12 20:19:22 +00:00
Brian Barrett
566a050c23 Next step in the project split, mainly source code re-arranging
- move files out of toplevel include/ and etc/, moving it into the
    sub-projects
  - rather than including config headers with <project>/include, 
    have them as <project>
  - require all headers to be included with a project prefix, with
    the exception of the config headers ({opal,orte,ompi}_config.h
    mpi.h, and mpif.h)

This commit was SVN r8985.
2006-02-12 01:33:29 +00:00
George Bosilca
3171cc1aee Remove unused variable.
This commit was SVN r8977.
2006-02-11 00:13:09 +00:00
George Bosilca
c9e83658dd Datatype engine went into a "slim-fast" treatement. That's only the first stage ...
This commit was SVN r8965.
2006-02-10 20:56:30 +00:00
George Bosilca
f96f9afc27 Copy the packed buffer when we duplicate a basic datatype.
This commit was SVN r8931.
2006-02-08 05:08:39 +00:00
Brian Barrett
e0a814d3a7 * adjust the buffer position on predefined datatypes as well as user
datatypes when creating from a buffer.

This commit was SVN r8917.
2006-02-07 12:14:41 +00:00
George Bosilca
9d969f2b53 Update the pack/unpack of data-type description (used for one sided). Correctly handle
the predefined types, move the packed_description into the data-type structure.

This commit was SVN r8905.
2006-02-06 19:10:19 +00:00
George Bosilca
697849c694 Add a function to check if the data-type is predefined or not (ompi_ddt_is_predefined).
This commit was SVN r8902.
2006-02-06 17:54:29 +00:00
George Bosilca
6a633829cb Pack/unpack datatype representaion for one-sided communications.
This commit was SVN r8887.
2006-02-02 19:49:29 +00:00
George Bosilca
1c667ea45a Start tracking down all useless things. Here the logic is that the MPI request already has
increased the datatype ref count, and there is no way to have a convertor without a valid
request, so there is no need for the convertor to increase the reference count of the datatype
again. Therefore, if one want to use the datatype for something else than MPI request, one
has to manage the reference counts outside the datatype layer.

This commit was SVN r8769.
2006-01-20 17:10:29 +00:00
George Bosilca
4ae8c291c3 Add MPI_SIGNED_CHAR.
This commit was SVN r8618.
2005-12-31 14:54:57 +00:00
George Bosilca
daceaf6219 The checksum code wasn't supposed to be turned on by default ...
This commit was SVN r8510.
2005-12-15 18:38:59 +00:00
George Bosilca
e008196f50 First implementation of the checksum in the datatype engine. I'm using adler 32
the same algorithm as in the zlib library, as it is supposed to be the fastest
one and still give good error detection. For those who want to activate the
checksum, there is a define at the bottom of the datatype_internal.h file.

This commit was SVN r8509.
2005-12-15 18:36:48 +00:00
George Bosilca
4af8085d3b The return is 0 or 1 so an int it's enought. Thanks Brian for catching this one.
This commit was SVN r8504.
2005-12-15 06:03:55 +00:00
George Bosilca
f8e875c8fb Always export this function.
This commit was SVN r8438.
2005-12-10 22:03:27 +00:00
Rich Graham
137703da29 add some comments.
This commit was SVN r8376.
2005-12-03 00:14:58 +00:00
George Bosilca
b47aa5c142 If pending_length is not zero the datatype engine believe that a partial conversion is still in the buffer attached to the convertor. We have to force it to zero for all new convertors. This bug is still half fixed until I figure out a correct way to do it when we clone a convertor ... Anyway, this future correction will not affect open mpi.
This commit was SVN r8324.
2005-11-30 00:16:58 +00:00
George Bosilca
cae4b603f4 First cut of the checksum capabilities for the convertor. Right now it's always set to zero, but it will change shortly.
This commit was SVN r8305.
2005-11-29 06:33:21 +00:00
Jeff Squyres
ebd97afdac - Make the types of the MCA param variables be "int", not "int32_t"
- Separate out the registration of the MCA params into a standalong
  function that is invoked by ompi_mpi_init() (so that ompi_info can
  see these params)
- Rename the params to "mpi_ddt_*" instead of "datatype_*" so that
  they fit into the common naming scheme

This commit was SVN r8196.
2005-11-18 22:51:11 +00:00
George Bosilca
9359be2190 Add the new dt_copy.c to the Makefile.am
Remove the old function from the dt_unpack.c and activate the new one from dt_copy.c
Add a MCA param ompi_copy_debug to get messages about the local memory copies in the new function.
Slightly change the prototype of the function to keep the compilers happy on some platforms.

This commit was SVN r8142.
2005-11-13 23:00:50 +00:00
George Bosilca
08a29da9a9 New version of the send data to self for the case where both the send and the receive data are
the same.

This commit was SVN r8141.
2005-11-13 22:57:28 +00:00
George Bosilca
405d9794f8 Somehow I miss to remove one of the previous definition for the unavailable data.
This commit was SVN r8080.
2005-11-10 02:59:20 +00:00
George Bosilca
55051b81c4 Activate the protection against unavailable datatypes. They get a flag DT_FLAG_UNAVAILABLE. We check now this flag in all the send/recv operations via the macros on mpi/c/bindings.h.
This flag is inherited by all datatypes create with unavailable datatypes. Basically, we let the user create the wrong datatype but we dont let him using it for any pt2pt communications or any pack/unpack.

This commit was SVN r8069.
2005-11-09 23:43:41 +00:00
George Bosilca
a6fdc2b2b4 Turn off the missing data-type message on MPI_Init.
This commit was SVN r8056.
2005-11-09 17:34:44 +00:00
George Bosilca
de0676a3dd Do not do any local copy into the storage if this convertor is finished. This is usefull in the Pack/Unpack case when there is more data in the packed buffer than the one we try to extract.
This commit was SVN r8054.
2005-11-09 07:46:12 +00:00
George Bosilca
025a8a04c5 More optimization of the data-type description are now possibles. Some corner cases are corrected. As a result we discover more accurately the contiguous part of the data memory layout.
This commit was SVN r8051.
2005-11-09 00:02:39 +00:00
George Bosilca
63ba3bde11 Allow the convertor to remember the last trucated unpack. If the same convertor is used for the next unpack it will put the data back correctly. However, if the BTL/PTL create a new convertor, even if it clone the last one this magic will not happens !
This commit was SVN r8048.
2005-11-08 21:48:48 +00:00
George Bosilca
cdfe5e71fd By default there is no pending length on the convertor.
This commit was SVN r8047.
2005-11-08 21:45:45 +00:00
George Bosilca
7582ae3ef1 A simpler way to get output about the packing/unpacking. Now there are 2 MCA parameters datatype_pack_debug and datatype_unpack_debug. When they are set to 1 the ddt engine will dump a lot of messages. Dont turn them to one by default. But if you notice any problems in the ddt you can turn them to one and send me the output.
First step toward adding memory to the convertor. It will be able to keep partial basic datatype between calls ...

This commit was SVN r8042.
2005-11-08 17:49:51 +00:00
George Bosilca
2b9b5500b9 Change some variable's names.
This commit was SVN r8041.
2005-11-08 17:44:56 +00:00
George Bosilca
c63e4dcef9 When we finish one of the loops take care of the index of the begining of the loop. If it's -1 then we just complete the full datatype ... therefore we have to do something special.
This commit was SVN r8040.
2005-11-08 16:53:31 +00:00
George Bosilca
579398a135 Change some variable names (from pSrc to something more clear like user_memory and/or packed_buffer).
This commit was SVN r8034.
2005-11-08 03:12:58 +00:00
George Bosilca
4ed2da50e9 A step forward. The original displacement for contiguous data with gaps is now correctly computed. At least the original displacement.
This commit was SVN r8031.
2005-11-08 00:03:05 +00:00
George Bosilca
387390355c Shame on me ... there should be extent not displacement.
This commit was SVN r8030.
2005-11-08 00:02:14 +00:00
George Bosilca
ce65ef3c6e And here is the makefile that integrate the new files. Now ... have as much fun as I did :)
This commit was SVN r8029.
2005-11-07 23:25:12 +00:00
George Bosilca
ccbeb6ac5a Take in account the original displacement for contiguous datatypes.
Limit the amount of data to be packed to the remaining on the convertor. This make the things a lot simpler in the pack/unpack functions.

This commit was SVN r8028.
2005-11-07 23:24:13 +00:00
George Bosilca
5641f4f56b Change the name of one of the fields in the end_loop structure.
Update all the macros to reflect the change.
A slightly different version of the boundaries checking function.

This commit was SVN r8027.
2005-11-07 23:22:43 +00:00
George Bosilca
1ddb90bbae Slim fast ... Do as less as possible on the critical path. The most expensive function now is the one that compute the stack when we move to a new position. For this function there are
several versions depending on the type of the data annd the position where we want to go.

This commit was SVN r8026.
2005-11-07 23:21:27 +00:00
George Bosilca
461f607fd3 Add one prototype from the new_position.c
This commit was SVN r8025.
2005-11-07 23:19:54 +00:00
George Bosilca
8df200528d The END_LOOP structure change the name of one of it's fields.
This commit was SVN r8024.
2005-11-07 23:18:57 +00:00
George Bosilca
f7359e24d6 Add some macros in the begining of the file. They are not used right now, but they will be in few days.
Do not ignore the type and extent of the last optimized basic type in some special cases.

Update the last fake END_LOOpP with the correct value for the first_elem_disp field.

This commit was SVN r8023.
2005-11-07 23:17:00 +00:00
George Bosilca
53cb3c2bee Force the data name to the empty string when we call destroy.
This commit was SVN r8022.
2005-11-07 23:14:32 +00:00
George Bosilca
8799d1799a The shiny new pack and unpack functions. The big difference is that the displacement is
never stored on the stack. It is partially stored on the stack depending on the loops
but every time we pack/unpack a basic datatype we take in account again it's displacement.
This approach make the whole logic a lot simpler. In same time I split the big functions
in several basic block.

This commit was SVN r8021.
2005-11-07 23:13:04 +00:00
George Bosilca
334ca349fe Several bug fixes:
- if the alignment of wchar is zero then wchar_t is not supported by the OS. We skip it.
- Now that the definition of end_loop change compute the first_elem_description for all
  predefined datatypes.
- In debug mode print a list of the datatypes that are not supported by the current
   architecture.

This commit was SVN r8020.
2005-11-07 23:10:33 +00:00
George Bosilca
84a89d68dc When we advance the convertor by a multiple of the data size there is a quick optimization.
We can compute the number of complete datatype that we will advance, update the stack and
then compute the new position taking in acount only the remaining bytes.

This commit was SVN r8019.
2005-11-07 23:00:28 +00:00
George Bosilca
288cdaf302 This is the way to compute the position for a convertor under the new rules.
This file is now yet activated. It will became the default after the next
commit.  (checkpoint to start testing on other clusters)

This commit was SVN r8006.
2005-11-07 09:00:52 +00:00