Gilles Gouaillardet
ab78c7f54a
orted/pmix: fix misc resource leak
...
as reported by Coverity with CID 1269844
2015-02-27 19:25:55 +09:00
Mike Dubman
dbc15009b6
Merge pull request #415 from alinask/topic/fix_fork_support_flow
...
Fix the calls to ibv_fork_init and remove btl_openib_want_fork_support.
2015-02-26 21:50:11 +02:00
Nathan Hjelm
883d09376f
Fix coverity #1271536
2015-02-25 11:35:45 -07:00
rhc54
efbb57430b
Merge pull request #419 from nkogteva/master
...
grpcomm brcks: fix copy-paste bug which affects performance
2015-02-25 07:39:55 -08:00
Alina Sklarevich
e4c4e7df5e
Fix the calls to ibv_fork_init and remove btl_openib_want_fork_support.
...
In order to have an effect, ibv_fork_init should be called in the
beginning of the verbs initialization flow - before the calls to the
ibv_create_qp and ibv_create_cq verbs.
These functions are called from the oob/ud code and by the time the
other verbs components (btl openib, pml yalla, ...) call ibv_fork_init,
it's too late. This commit forces the call to ibv_fork_init (if it's
requested) right at the beginning of all the components that are using
verbs.
(ibv_fork_init() can be safely called multiple times)
This commit also removes the btl_openib_want_fork_support mca parameter
and adds a new mca parameter instead - opal_verbs_want_fork_support.
Through this new parameter, fork support may be requested for ALL
components.
The default value for this parameter is set to 1.
Before this commit the btl_openib_want_fork_support parameter didn't
provide fork support for the openib btl if its value was set to 1.
(because when openib called ibv_fork_init, it was already after the
calls to ibv_create_* in oob/ud and thereofre it failed).
2015-02-25 10:58:50 +02:00
Jeff Squyres
a85a392896
Merge pull request #422 from jsquyres/topic/coverity-fixes
...
Some Coverity fixes
2015-02-24 17:00:10 -05:00
Jeff Squyres
05f00aface
plm base: ensure mca_base_var_get_value() and mca_base_var_find() succeed
...
This was CID 993712
2015-02-24 15:48:50 -05:00
Ralph Castain
451bd16a10
Remove dead code
2015-02-24 12:41:12 -08:00
Jeff Squyres
4f54fedf05
orterun: ensure to set used_num_procs=true after finding that token
...
This was CID 71687.
2015-02-24 15:25:39 -05:00
Jeff Squyres
398ae15533
rmaps_base_frame: remove dead code
...
This was CID 1196641
2015-02-24 15:24:11 -05:00
Jeff Squyres
71ae0ad5ec
oob_tcp_component: add #if OPAL_ENABLE_IPV6 around IPv6-specific code
...
This was CID 1196629
2015-02-24 15:24:11 -05:00
Jeff Squyres
0bd2783b91
oob_usock: don't try to close the socket if it didn't open
...
This was CID 1196663
2015-02-24 15:24:09 -05:00
Jeff Squyres
e2223cd9bf
plm_rsh: ensure cwd array is \0-terminated
...
This was CID 72257
2015-02-24 15:24:08 -05:00
Ralph Castain
332e4fa7aa
Minor fix - relative host name syntax cannot support usernames as you can't know which hosts will be selected
2015-02-24 12:15:28 -08:00
Nathan Hjelm
ed78553512
Update opal_free_list_t usage to reflect new class interface.
...
Please verify your components have been updated correctly. Keep in
mind that in terms of threading:
OPAL_FREE_LIST_GET -> opal_free_list_get_st
OPAL_FREE_LIST_RETURN -> opal_free_list_return_st
I used the opal_using_threads() variant anytime it appeared multiple
threads could be operating on the free list. If this is not the case
update to _st. If multiple threads are always in use change to _mt.
2015-02-24 10:05:44 -07:00
Nadezhda Kogteva
c4d6ca6468
grpcomm brcks: fix copy-paste bug which affects performance
2015-02-24 17:06:39 +02:00
Jeff Squyres
226a814c9d
grpcomm_brks: fix minor compiler warning (rc used before set)
...
Also check for OBJ_NEW returning NULL.
2015-02-23 09:04:45 -08:00
Jeff Squyres
600858609e
grpcomm_rcd: fix minor compiler warning (rc used before set)
...
Also check for OBJ_NEW returning NULL.
2015-02-23 09:03:07 -08:00
Howard Pritchard
bf89131f9e
add owner files to opa/ompi/orte mca directories
...
This commit adds an owner file in each of the component directories
for each framework. This allows for a simple script to parse
the contents of the files and generate, among other things, tables
to be used on the project's wiki page. Currently there are two
"fields" in the file, an owner and a status. A tool to parse
the files and generate tables for the wiki page will be added
in a subsequent commit.
2015-02-22 15:10:23 -07:00
Jeff Squyres
15be948d79
wrappers: *_EXTRA_INCLUDES does not exist any more
...
There were a few places where *_EXTRA_INCLUDES (and derivates) were
still being used. This commit removes all of them.
2015-02-20 08:43:25 -08:00
Jeff Squyres
9b716d946e
wrappers: fix errant @{libdir} reference in pkg-config files
...
The RPATH support added a @{libdir} token into
<package>_WRAPPER_EXTRA_LDFLAGS. However, these flags are also
substituted into the pkg-config data files, and they don't understand
the @{foo} notation. So convert @{libdir} into ${libdir}, which
pkg-config *does* understand.
Thanks to Christoph Junghans (@junghans) for notifying us of the issue.
Fixes #406 .
2015-02-20 08:43:19 -08:00
Jeff Squyres
ec62766a71
notifier base: remove unused variables
2015-02-20 07:06:13 -08:00
Elena
48eae25b8f
fixed issue with grpcomm rcd and brks algorithms which led to performance issues: data just for part of processes was unpacked and stored locally during fence, therefore clients were forced to ask daemons for data directly during get request
2015-02-20 16:41:25 +02:00
Ralph Castain
f7c28ea706
Fix bad test - opal_buffer and opal_ptr can support NULL locations
2015-02-17 21:46:23 -08:00
Ralph Castain
852fbca020
Shut coverity up
2015-02-17 21:17:23 -08:00
Ralph Castain
c1282d5b99
The opal_buffer type also generates its own alloc, so need to let it pass thru the check
2015-02-17 21:06:19 -08:00
Ralph Castain
207cc74f87
Correct name of help file
2015-02-17 16:03:20 -08:00
Ralph Castain
624b16e070
Protect the unload attribute function
2015-02-17 14:21:23 -08:00
Ralph Castain
78245e8a33
Continue massaging of the notifier framework. Convert it to an event-driven interface. Add the ability to report job state if requested. Cleanup object declarations.
2015-02-17 12:51:11 -08:00
Gilles Gouaillardet
8dc4f30fae
orte/tools: fix NULL pointer dereference
...
as reported by Coverity with CIDs 1196671 and 1196824
2015-02-17 15:45:06 +09:00
Gilles Gouaillardet
b762766969
orte/util: fix misc memory leaks
...
as reported by Coverity with CIDS 70314, 710653-710657 and 1196741-1196744
2015-02-17 12:27:23 +09:00
Ralph Castain
22f1d29b82
Re-introduce the ORTE notifier framework for logging errors that would otherwise result in abort for persistent systems. Thanks to L. Rajeshnarayanan of Intel for the contribution
...
Subsequent commits will integrate this capability with the state and errmgr frameworks.
2015-02-16 12:46:58 -08:00
Gilles Gouaillardet
8fe8079080
Fix a build failure when configure'd with --without-hwloc
...
see http://mtt.open-mpi.org/index.php?do_redir=2235
2015-02-16 10:31:09 +09:00
Jeff Squyres
3ac1d0dae5
*-info: add "lt_dladvise support" lines
2015-02-11 12:25:20 -08:00
Ralph Castain
2a83d2613a
Cleanup the orte/test/system directory
2015-02-11 10:42:38 -08:00
Ralph Castain
d5775bf9de
Cleanup orte MPI test directory so it all builds again
2015-02-11 10:14:06 -08:00
Ralph Castain
ce56c0a2cf
Oops - remove debug/exit
2015-02-11 10:14:06 -08:00
Jeff Squyres
c9e3f22933
orte mpi tests: fix a bunch of compiler warnings
2015-02-11 12:28:10 -05:00
Jeff Squyres
07179ef669
orte mpi tests: don't use deprecated MPI functions
...
Change MPI_Errhandler_set -> MPI_Comm_set_errhandler
2015-02-11 12:28:10 -05:00
Jeff Squyres
cc7f433c0f
Makefile: this file should not be executable
2015-02-11 07:33:56 -08:00
Ralph Castain
3de8c5c7c6
Cleanup the munge support - the credential cannot be reused for multiple connections
2015-02-10 20:34:35 -08:00
Ralph Castain
46fb850bb0
Continue adding support for options on orte-submit - still need to shift some of the MCA params to job object attributes
2015-02-10 13:56:14 -08:00
Ralph Castain
116fcaff2c
Start adding support for cmd line options to orte-submit
2015-02-10 12:13:21 -08:00
rhc54
cf3f4def48
Merge pull request #386 from marksantcroos/master
...
Add debug option to orte-dvm.
Looks fine - thanks
2015-02-10 11:38:52 -08:00
Ralph Castain
df2cd96772
Display the local/global attribute flag more prominently. Mark the attributes as global in orte-submit so they will be communicated
2015-02-10 10:47:32 -08:00
Mark Santcroos
ff6a69a68d
Add debug option to orte-dvm.
2015-02-10 13:02:23 -05:00
Ralph Castain
063e4c9989
Cleanup the pretty-print of odls cmds as some were missing. Add a new cmd to terminate the DVM, which the HNP will use to trun around and issue an xcast to the DVM.
2015-02-10 08:27:13 -08:00
Ralph Castain
3ae3b96c17
Fix master compilation - a buried header dependency must have been removed.
2015-02-10 07:22:10 -08:00
Elena
948c20d862
added pmix unit test to tarball
2015-02-10 13:41:15 +02:00
Howard Pritchard
b62d9c2c70
ess/alps: fix compile issue for pgi
...
remote -fi-noident cflag option. Wasn't helping anyway
and caused pgi compiles to break.
2015-02-09 20:49:04 -08:00