Edgar Gabriel
a899c0fb38
fcoll/static: fix coverty warnings
...
fix coverty warnings CID 72144, CID 710677, CID 1364164
2016-07-21 13:08:15 -05:00
Edgar Gabriel
195ec89732
fcoll/base: mv coll_array functionis to fcoll base
...
the coll_array functions are truly only used by the fcoll modules, so move
them to fcoll/base. There is currently one exception to that rule (number of aggreagtors
logic), but that function will be moved in a long term also to fcoll/base.
2016-07-14 08:41:14 -05:00
Edgar Gabriel
1f1504ebbb
remove some unused code
2016-07-14 08:41:14 -05:00
Ralph Castain
ac6289dca6
Cleanup the warnings from the ompi layer when compiling optimized under Mac OSX
...
Cleanup per George's comments
2015-12-17 17:39:15 -08:00
Edgar Gabriel
66c1ea5fcb
change the default value of the grouping option. Also add new grouping option which skips the refinement step in the aggregator selection.
2015-11-16 08:17:23 -06:00
Edgar Gabriel
f97655f28e
make sure the iov buffer is initialized to zero, otherwise bad things can happen for 0-byte contributions on a process.
2015-10-15 12:46:01 -05:00
Gilles Gouaillardet
fe351f6801
io: do not cast way the const modifier when this is not necessary
...
update the io framework and mpi c bindings
2015-09-09 09:18:58 +09:00
Edgar Gabriel
70078175ee
fix coverty warning 72107
2015-08-25 09:23:37 -05:00
Edgar Gabriel
a73f9470e0
fix coverty warning 1269829
2015-08-25 09:22:48 -05:00
Edgar Gabriel
7e370948c1
first cut on the fileview for shared filepointers fix.
2015-08-19 17:11:42 -05:00
Edgar Gabriel
072b18e197
Code cleanup for the time breakdown feature in ompio/fcoll
...
- make the internal structure follow the Open MPI naming convention
- provide a single flag/macro which controls the compilation/utilization of this
feature, to avoid that somebody using this has to modify every single
fcoll component. A configure option could be added later if desired.
2015-08-14 08:53:04 -05:00
Edgar Gabriel
db5af26de7
Performance tuning. make sure we catch if the user wants to set the default fileview and replace it with our optimized default file view. Otherwise, performance will suffer. file_get_view should still return the correct filetype, not our optimized default file view. This is the correct version compared to ffa67b96933acafb3cfacf39a074d3dc1fe134ae, which unfortunately broke
...
some test cases in mpi_test_suite. Thanks for @ggouaillardet for reporting this!
2015-08-07 12:49:58 -05:00
Edgar Gabriel
1ae4f8c7e6
Revert "Performance tuning. make sure we catch if the user wants to set the default fileview and replace it with"
...
This reverts commit ffa67b96933acafb3cfacf39a074d3dc1fe134ae.
2015-08-07 09:53:07 -05:00
Edgar Gabriel
ffa67b9693
Performance tuning. make sure we catch if the user wants to set the default fileview and replace it with
...
our optimized default file view. Otherwise, performance will suffer. file_get_view should still return the correct filetype, not our optimized default file view
2015-07-30 19:15:00 -05:00
Edgar Gabriel
9b2a7e41f0
make sure the final number of aggregators is recorded correctly when not using
...
our aggregator selection logic.
2015-07-30 17:24:01 -05:00
Ralph Castain
869041f770
Purge whitespace from the repo
2015-06-23 20:59:57 -07:00
Gilles Gouaillardet
0f08070a1c
ompio: fix misc memory leaks
...
as identified by Coverity with CIDs 72147-72149, 731275 and 1269872
2015-06-17 11:17:54 +09:00
Edgar Gabriel
aa72e5b2ca
fix the selection logic to not overwrite on the new aggregator side the list of
...
aggregators determined by the algorithm.
2015-05-27 22:35:45 -05:00
Gilles Gouaillardet
b6c67e051d
io/ompio: fix misc memory leaks
...
as reported by Coverity with CIDs 72147-72149,72187,72188,731274,731275,741356,
1269889,1269893,1271535 and 1269872
2015-05-20 17:19:39 +09:00
Mangala Jyothi Bhaskar
c4de46e284
Fix number of aggregators used in two phase fcoll
2015-04-16 10:39:10 -05:00
Gilles Gouaillardet
f03d7dce17
ompio: fix deallocation sequence
...
as reported by Coverity with CID 1287034
2015-03-06 14:59:59 +09:00
Gilles Gouaillardet
5b2122381b
ompio: fix misc memory leaks
...
as reported by Coverity with CIDs 72127, 72145, 72146, 72177, 72179,
72186, 731276, 731278, 1269888, 1269890
2015-03-05 16:22:19 +09:00
Jeff Squyres
657d2cf77b
io_ompi: check the correct returned value
...
This was CID 731273
2015-02-24 15:24:11 -05:00
mjbhaskar
74f8ba2acb
A fix for memory corruption problem
2015-01-07 14:34:38 -06:00
Mangala Jyothi Bhaskar
68d78fd718
Aggregator selection logic Part 2 and reorganized Part1
2014-12-16 15:48:40 -06:00
Edgar Gabriel
0758d7570e
part 1 of the fix to get rid of the missing symbols that prevent the sub-modules to be loaded.
2014-11-29 20:01:36 -06:00
Mangala Jyothi Bhaskar
6e5f2c8ae8
Fixed offset data type in communication
...
This commit was SVN r32708.
2014-09-11 14:50:30 +00:00
Edgar Gabriel
ed02927767
- do not set the contiguous memory option in the collective operations. It
...
should not be stored on the file handle anyway, since it is not a property of
the file.
- protect a realloc for zero byte scenarios.
This commit was SVN r32678.
2014-09-07 18:09:43 +00:00
Mangala Jyothi Bhaskar
a5973c3f8c
revamp of the aggregator selection logic, part 1.
...
This commit was SVN r32557.
2014-08-20 19:28:04 +00:00
Edgar Gabriel
e401b68ca5
fix the zero byte fileview problem reported by Mohamad on the mailinglist
...
This commit was SVN r32529.
2014-08-13 23:44:43 +00:00
Edgar Gabriel
d4f83ab929
clean up of the MCA parameters of the fcoll framework. Most parameters are now
...
set/retrieved in ompio instead of the fcoll components.
This commit was SVN r32294.
2014-07-23 19:03:14 +00:00
George Bosilca
750c6c7861
Update the UTK copyright on the topology related files.
...
This commit was SVN r31805.
2014-05-16 22:23:52 +00:00
Edgar Gabriel
217e61e345
add proper typcasts to intptr_t to avoid warnings on 32bit systems.
...
This commit was SVN r30229.
2014-01-10 16:19:04 +00:00
Vishwanath Venkatesan
d37a5faa20
Need not do aggregator selection for one process case
...
So adding a check for this corner case!
This commit was SVN r29622.
2013-11-06 21:05:26 +00:00
George Bosilca
5fae72b9aa
Add the MPI 2.2 MPI_Dist_graph functionality.
...
This patch reshape the way we deal with topologies completely. Where
our topologies were mainly storage components (they were not capable
of creating the new communicator), the new version is built around a
[possibly] common representation (in mca/topo/topo.h), but the functions
to attach and retrieve the topological information are specific to each
component. As a result the ompi_create_cart and ompi_create_graph functions
become useless and have been removed.
In addition to adding the internal infrastructure to manage the topology
information, it updates the MPI interface, and the debuggers support and
provides all Fortran interfaces.
This commit was SVN r28687.
2013-07-01 12:40:08 +00:00
Edgar Gabriel
9daec82f17
- make a fileview of 0 bytes work in ompio
...
- fixes the bug reported in ticket 3619 (which is already closed) also for ompio
This commit was SVN r28575.
2013-05-30 21:33:13 +00:00
Edgar Gabriel
1b1051da6c
fix a bug in the calculation of the explicit offset. Use the opportunity to
...
clean up the code a bit.
This commit was SVN r28537.
2013-05-17 20:22:00 +00:00
Vishwanath Venkatesan
74c418b860
Adding typecasting with intptr_t to remove warnings.
...
This commit was SVN r28278.
2013-04-03 17:07:43 +00:00
Vishwanath Venkatesan
2922fa28a6
Changes to the interface for extracting timing information,
...
to avoid accessing datastructures across frameworks.
This commit was SVN r27543.
2012-10-31 22:03:05 +00:00
Vishwanath Venkatesan
6e3c9754a9
Initialization issue + fixing error in determining minimum value.
...
This commit was SVN r27443.
2012-10-11 23:41:25 +00:00
Vishwanath Venkatesan
9eeb3b5d50
# Extracting timing information for individual components of collective algorithm using a generic queue.
...
# This is triggered based on a mca-paramater and can be used with all collective modules.
# Individual queues maintained for read and write.
# The additional communication to combine data is done at file-close so that the
actual timing of collective-operations will not get affected.
# The queues are initialized in file-open
This commit was SVN r27439.
2012-10-11 21:14:07 +00:00
Vishwanath Venkatesan
c89c9e40be
Code to extract neigbhouing offsets information from OMPIO into a file. Driven by an MCA parameter,
...
turned-off by default.
This commit was SVN r27407.
2012-10-04 21:53:26 +00:00
Vishwanath Venkatesan
640aca6654
Modifying the file view generation to remove the merging of offset-length pair.
...
Its no longer needed as the default file view makes sure the chunks are large enough.
This commit was SVN r27246.
2012-09-05 21:00:47 +00:00
Vishwanath Venkatesan
960c47f604
Changes to io_ompio.c to support data-seiving in two-phase I/O.
...
This commit was SVN r27151.
2012-08-27 21:09:08 +00:00
Vishwanath Venkatesan
dccfd18481
1. Removing two-phase support functions
...
2. Moving nbc headers to a seperate header file and modifying
io_ompio_nbc.c accordingly.
This commit was SVN r26921.
2012-07-31 04:39:13 +00:00
Edgar Gabriel
fb64322dc3
this code section was supposed to be commented out...
...
This commit was SVN r26918.
2012-07-30 20:46:07 +00:00
Edgar Gabriel
91c8577d9d
fix in the offset calculation for explicit offset operations.
...
This commit was SVN r26915.
2012-07-30 20:08:00 +00:00
Ralph Castain
44bd855717
Silence warnings
...
This commit was SVN r26808.
2012-07-19 14:29:32 +00:00
Edgar Gabriel
8ae22cacc1
- remove two functions that were not used anymore
...
- change the location where we mark the file view as contiguous and the
condition on how it is determined to be contiguous
- remove the unnecessary include statements
This commit was SVN r26763.
2012-07-08 12:57:17 +00:00
Edgar Gabriel
3ccd286de1
silence a compiler warning for optimized builds.
...
This commit was SVN r26528.
2012-05-31 13:32:10 +00:00