Gilles Gouaillardet
521317341d
btl/openib: fix a double free
...
as reported by Coverity with CID 1287033
2015-03-06 14:58:11 +09:00
George Bosilca
5905bd2ff9
As the pStack pointer changes during the execution it is not
...
safe to free it. Instead, keep a copy of the original location
to be able to free the correct memory region.
2015-03-05 13:36:21 -05:00
George Bosilca
75479c0f17
Fix some typos.
2015-03-05 12:59:58 -05:00
George Bosilca
3c489ea5d5
Use malloc instead of alloca as some users could use very large arrays
...
of datatypes. Thanks Bogdan Sataric for the bug report.
2015-03-05 12:24:28 -05:00
Alina Sklarevich
1560ed9761
initialize opal_common_verbs_want_fork_support to -1.
...
This way, if the call to ibv_fork_init() fails, the job will still
continue.
2015-03-05 14:29:09 +02:00
Gilles Gouaillardet
e1cc931e1b
btl/tcp: silence CID 710616
2015-03-05 14:20:08 +09:00
Gilles Gouaillardet
852dbafd51
mca/base: fix misc memory leaks
...
as reported by Coverity with CIDs 710628, 1196713 and 1269855
2015-03-05 14:06:18 +09:00
Gilles Gouaillardet
134c866aa9
btl/openib: fix misc memory leaks
...
as reported by Coverity with CIDs 1269848, 1269852 and 1269862
2015-03-05 14:06:18 +09:00
Gilles Gouaillardet
d1b2f043ff
fix misc memory leaks
...
as already reported by Coverity with CIDs
71818, 71819, 72250, 715767, 1196749 and 1274002
2015-03-05 13:58:05 +09:00
Mike Dubman
171d674ca4
Merge pull request #441 from open-mpi/revert-438-topic/use_opal_common_verbs_want_fork_support
...
Revert "create the opal_common_verbs_want_fork_support parameter."
2015-03-04 10:13:00 +02:00
Gilles Gouaillardet
f43b5b46ee
btl/openib: fix heterogeneous support
...
Thanks @bosilca for the pointer
2015-03-04 13:53:05 +09:00
Gilles Gouaillardet
81b0444ef2
btl/openib: fix comment syntax, no code change
...
and silence gcc warning about nested comments
2015-03-04 11:24:14 +09:00
Rolf vandeVaart
edf58eb549
Implement CUDA-aware workaround while fork support worked out
2015-03-03 09:50:01 -05:00
Mike Dubman
98503b56e0
Revert "create the opal_common_verbs_want_fork_support parameter."
2015-03-03 14:28:31 +02:00
Mike Dubman
cc7caf699e
Merge pull request #438 from alinask/topic/use_opal_common_verbs_want_fork_support
...
create the opal_common_verbs_want_fork_support parameter.
2015-03-02 07:43:37 +02:00
Gilles Gouaillardet
04a0438b56
sec/munge: send NULL terminated strings
2015-03-02 12:19:46 +09:00
Alina Sklarevich
8fe42f1bc1
create the opal_common_verbs_want_fork_support parameter.
...
call the opal_common_verbs_mca_register function to make sure that
opal_common_verbs_want_fork_support mca parameter is created and therefore
can be used to control the fork support.
2015-03-01 17:40:49 +02:00
Jeff Squyres
336626dafe
spelling: trivial spelling fix
...
s/interupted/interrupted/gi
2015-02-27 18:30:43 -08:00
Jeff Squyres
4f1139590f
datatypes: trivial spelling fix
...
s/commited/committed/gi
2015-02-27 18:16:01 -08:00
Ralph Castain
d81c372ea2
Remove the "forwarding" of envars when direct launched - there aren't any envars we can forward under that use-case
2015-02-27 12:19:48 -08:00
Rolf vandeVaart
e48bc77342
Fix the coverity fix
2015-02-27 12:49:44 -05:00
Rolf vandeVaart
cfe91d4d0f
Fix compile error for CUDA-aware by using new fork MCA parameter.
2015-02-27 10:00:46 -05:00
Gilles Gouaillardet
e0026224e7
pstat linux: close the files
...
as reported by Coverity with CID 71983
2015-02-27 19:48:01 +09:00
Gilles Gouaillardet
3511475e29
opal/util: fix misc memory leak
...
as reported by Coverity with CID 996174
2015-02-27 19:19:46 +09:00
Gilles Gouaillardet
f33cd58ee9
btl/tcp: fix misc memory leaks
...
as reported by Coverity with CIDs 710615, 710616 and 710618
2015-02-27 19:16:22 +09:00
Gilles Gouaillardet
60404d1953
btl/base: fix misc memory leaks
...
as reported by Coverity as CIDs 71818 71819
2015-02-27 19:06:06 +09:00
George Bosilca
455b465329
Reflect in the naming the location of the variable.
2015-02-26 18:22:23 -05:00
Jeff Squyres
5215dc0db3
shmem base: do not allow framework selection to occur twice
...
Both opal_shmem_base_select() and
opal_shmem_base_best_runnable_component_name() and were calling
opal_shmem_base_runtime_query(), which would do component selection
(and closing of losing components) twice.
Put protection in opal_shmem_base_runtime_query() to return the cached
results the second time. Additionally, make
opal_shmem_base_runtime_query() "own" the cached results
(vs. opal_shmem_base_select).
2015-02-26 14:56:46 -08:00
Jeff Squyres
312b0afb67
shmem base: make these the version-less struct names
...
Minor style commit; no substantive code change.
2015-02-26 14:56:46 -08:00
Jeff Squyres
90a2c3cd99
shmem base: this function had no purpose being public
...
Make it static to the base, and move it up higher in the file so that
multiple functions beneath it can call it.
2015-02-26 14:56:46 -08:00
Jeff Squyres
9666884cf1
shmem: make the base_module_t a real mca_base_module_t
...
This allows the opal_shmem_base_module_t to be properly cast to an
mca_base_module_t.
(this commit is the rationale for the previous shmem C99 .member
initialization commit)
2015-02-26 14:56:46 -08:00
Jeff Squyres
62259a74f5
shmem: use C99 struct initialization
...
Use .member=foo initialization for the shmem framework and components
and modules.
2015-02-26 14:56:46 -08:00
George Bosilca
778ba0317e
Revert "Minor cleanups."
...
This reverts commit 3b4da0bda4
2015-02-26 17:53:58 -05:00
George Bosilca
2c60c18e6f
A better fix for the want_fork_support issue. I noticed a naming
...
conflict where ompi was used down in OPAL. I correctly renamd the
MCA parameter, and created a deprecated synomym for the old
name.
2015-02-26 17:35:54 -05:00
George Bosilca
5c3ce3a737
Merge branch 'master' of github.com:open-mpi/ompi
2015-02-26 17:10:18 -05:00
George Bosilca
aeace0468e
A more sensible fix, move the MCA variable in the verbs common area.
2015-02-26 16:51:09 -05:00
George Bosilca
6777f3ac3c
Add missing qualifiers to the global variable.
2015-02-26 16:25:56 -05:00
Nathan Hjelm
855d422e62
Merge pull request #408 from hjelmn/btl_3_0_mod
...
btl: expose local registration thresholds
2015-02-26 12:57:43 -07:00
Mike Dubman
dbc15009b6
Merge pull request #415 from alinask/topic/fix_fork_support_flow
...
Fix the calls to ibv_fork_init and remove btl_openib_want_fork_support.
2015-02-26 21:50:11 +02:00
Nathan Hjelm
5a47f68fd4
Merge pull request #434 from hjelmn/master
...
Remove ompi_free_list_t
2015-02-26 09:43:36 -07:00
Rolf vandeVaart
bbdcf9ff33
Fix missing cast change from opal_free_list_changes. Fixes warning
2015-02-26 11:24:49 -05:00
Nathan Hjelm
587d3c2e13
Remove ompi_free_list_t
2015-02-26 09:17:57 -07:00
Gilles Gouaillardet
b888768ca3
btl/scif: fix a typo
...
this is likely a typo introduced by open-mpi/ompi@5f1254d710
@hjelmn could you please double check this ?
2015-02-26 13:45:51 +09:00
Nathan Hjelm
8a17e69067
btl/ugni: fix typos introduced by free list update
2015-02-25 12:43:05 -07:00
George Bosilca
f3b58006c8
Merge branch 'master' of github.com:open-mpi/ompi
2015-02-25 12:01:35 -05:00
Jeff Squyres
9381f38a98
libevent2021: remove stale owner.txt file
...
I'm guessing this directory was accidentally left in the tree when
creating the owner.txt files.
2015-02-25 07:37:27 -08:00
Jeff Squyres
f3c9354d4b
usnic: restore compatibility with the v1.8 branch
...
Also include two other minor changes:
1. More C99-style member initialization in the component struct
1. Fix the BTL module member initialization to not be redundant
2015-02-25 05:37:51 -08:00
Nysal Jan K.A
881a9f3d58
Fix cache line size detection on power
...
Due to the nature of the cache architecture on power,
we don't export coherency_line_size for L2 in sysfs.
If we are unable to get the L2 cache line size, try L1.
See open-mpi/ompi#383 for more information.
2015-02-25 17:26:28 +05:30
Alina Sklarevich
e4c4e7df5e
Fix the calls to ibv_fork_init and remove btl_openib_want_fork_support.
...
In order to have an effect, ibv_fork_init should be called in the
beginning of the verbs initialization flow - before the calls to the
ibv_create_qp and ibv_create_cq verbs.
These functions are called from the oob/ud code and by the time the
other verbs components (btl openib, pml yalla, ...) call ibv_fork_init,
it's too late. This commit forces the call to ibv_fork_init (if it's
requested) right at the beginning of all the components that are using
verbs.
(ibv_fork_init() can be safely called multiple times)
This commit also removes the btl_openib_want_fork_support mca parameter
and adds a new mca parameter instead - opal_verbs_want_fork_support.
Through this new parameter, fork support may be requested for ALL
components.
The default value for this parameter is set to 1.
Before this commit the btl_openib_want_fork_support parameter didn't
provide fork support for the openib btl if its value was set to 1.
(because when openib called ibv_fork_init, it was already after the
calls to ibv_create_* in oob/ud and thereofre it failed).
2015-02-25 10:58:50 +02:00
Jeff Squyres
a85a392896
Merge pull request #422 from jsquyres/topic/coverity-fixes
...
Some Coverity fixes
2015-02-24 17:00:10 -05:00
