Jeff Squyres
1504ffb18d
ompi_file_delete: output a better error message
...
Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
2016-12-02 11:08:04 -05:00
Ralph Castain
1e2019ce2a
Revert "Update to sync with OMPI master and cleanup to build"
...
This reverts commit cb55c88a8b7817d5891ff06a447ea190b0e77479.
2016-11-22 15:03:20 -08:00
Ralph Castain
cb55c88a8b
Update to sync with OMPI master and cleanup to build
...
Signed-off-by: Ralph Castain <rhc@open-mpi.org>
2016-11-22 14:24:54 -08:00
Jijo Varghese
25e138ea1d
error correction to the MPI_file operations thread safety lock
...
Signed-off-by: Jijo Varghese <jijo733@gmail.com>
2016-11-17 08:18:49 -05:00
Edgar Gabriel
74441b960b
update the error codes reported by file_delete
2016-10-25 10:15:14 -05:00
Edgar Gabriel
1ba03d38ec
io/ompio: protect remaining functions in multi-threaded scenarios
...
protect the remaining functions where necessary by a mutex lock
to avoid problems in multi-threaded executions. Some functions
do not require that in my opinion, and I provided an explanation
in those cases.
2016-08-25 13:45:51 -05:00
Edgar Gabriel
1cee83cc1b
use the common/ interfaces in file_preallocate instead of the io_ompio_ interfaces.
...
Necessar for avoiding potential deadlock situations in multi-threaded scenarios.
2016-08-25 08:55:12 -05:00
Edgar Gabriel
9c3180160c
io/ompio: Add barrier to file_close and to file_set_size
...
This fixes a bug reported on the mailing for ompio.
https://www.open-mpi.org/community/lists/users/2016/05/29333.php
2016-08-04 11:20:31 -05:00
Edgar Gabriel
c0bd8728fd
io/ompio: move aggregator selection code to a separate file
...
- move all functions related to aggregator selection to a single file
- perform code cleanup fixing many Coverty complains along the way.
2016-08-01 14:04:27 -05:00
Edgar Gabriel
b0fa1fd2a1
move the internal file_open/close functions to common/ompio
2016-07-21 13:08:32 -05:00
Edgar Gabriel
39ae93b87b
modify the fcoll components to use the common/ompio print queues
2016-07-21 13:08:32 -05:00
Edgar Gabriel
fe17410943
next step in making the print_queue functionality move to common/ompio
2016-07-21 13:08:32 -05:00
Edgar Gabriel
195ec89732
fcoll/base: mv coll_array functionis to fcoll base
...
the coll_array functions are truly only used by the fcoll modules, so move
them to fcoll/base. There is currently one exception to that rule (number of aggreagtors
logic), but that function will be moved in a long term also to fcoll/base.
2016-07-14 08:41:14 -05:00
Edgar Gabriel
1ddfd6cdca
io/ompio: fix the preallocate function
...
handle preallocating sizes less than the current file size correctly.
2016-06-14 10:50:32 -05:00
Edgar Gabriel
d6af5444a6
fix the get_byte_offset code
2016-06-03 11:36:53 -05:00
Edgar Gabriel
e65e189671
io/ompio: fix file size after file_preallocate
...
Thanks for @dalcini for reporting
Fixes open-mpi/ompi#1633
2016-05-06 08:20:59 -05:00
Jeff Squyres
f167be1c91
ompio: always return valid info from FILE_GET_INFO
...
MPI-3.1 says that even if no info keys are set on the file, we need to
return a new, empty info.
Thanks to Lisandro Dalcin for identifying the issue.
Fixes open-mpi/ompi#1630
Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
2016-05-05 12:03:29 -07:00
Gilles Gouaillardet
fe351f6801
io: do not cast way the const modifier when this is not necessary
...
update the io framework and mpi c bindings
2015-09-09 09:18:58 +09:00
Nathan Hjelm
156ce6af21
periodic whitespace purge
...
Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2015-08-24 09:32:33 -06:00
Edgar Gabriel
b0461f8d3c
the back pointer from the ompio_file structure to the ompi_file_t structure
...
has to be set earlier in case the user disables the lazy_open option.
2015-08-19 17:11:42 -05:00
Edgar Gabriel
072b18e197
Code cleanup for the time breakdown feature in ompio/fcoll
...
- make the internal structure follow the Open MPI naming convention
- provide a single flag/macro which controls the compilation/utilization of this
feature, to avoid that somebody using this has to modify every single
fcoll component. A configure option could be added later if desired.
2015-08-14 08:53:04 -05:00
Edgar Gabriel
db5af26de7
Performance tuning. make sure we catch if the user wants to set the default fileview and replace it with our optimized default file view. Otherwise, performance will suffer. file_get_view should still return the correct filetype, not our optimized default file view. This is the correct version compared to ffa67b96933acafb3cfacf39a074d3dc1fe134ae, which unfortunately broke
...
some test cases in mpi_test_suite. Thanks for @ggouaillardet for reporting this!
2015-08-07 12:49:58 -05:00
Edgar Gabriel
6f6c01ee8d
free the datatypes that were created using type_dup during file_set_view
2015-08-07 11:50:25 -05:00
Edgar Gabriel
e380f8c235
- fix the delete priority of the ompio component
...
- some application use MPI_File_delete as a collective function (e.g. IOR), which I think is not really covered by the standard. Right now, one process succeeds and theother ones return an error code. Fix that by not returning no error if the file that we try to delete does not exist anymore, to make these applications work.
2015-07-27 15:53:40 -05:00
Edgar Gabriel
b484784dca
make ompio return gracefully in case something goes wrong early in file_open.
2015-07-20 10:03:16 -05:00
Ralph Castain
869041f770
Purge whitespace from the repo
2015-06-23 20:59:57 -07:00
Edgar Gabriel
3b11a8b61c
making the current work compile.
2015-06-18 05:56:51 -05:00
Edgar Gabriel
cc219281ba
checkpoint of the current work, since I need to resync wioth master to fix the compilation problems
2015-06-18 05:20:07 -05:00
Edgar Gabriel
62282a0f06
part 1 of cleaning up the info handling in the ompio component.
2015-01-30 16:13:15 -06:00
Edgar Gabriel
4a5d3e705b
remove an unecessary comm_dup in case the internal file_open function is called from a sharedfp component.
2015-01-28 16:13:50 -06:00
Edgar Gabriel
51cee4a083
call the actual backend functions for file_get_position_shared and file_seek_shared. The sharedfp components
...
do provide the implementations, we just did not invoke them yet.
2015-01-28 13:47:54 -06:00
Edgar Gabriel
0758d7570e
part 1 of the fix to get rid of the missing symbols that prevent the sub-modules to be loaded.
2014-11-29 20:01:36 -06:00
Mangala Jyothi Bhaskar
dc05b709a7
it is ok to not have a sharedfp component selected, as long as no
...
sharedfp functionality is being used. Return an error however if no
sharedfp component is selected and the applications calls a
file_read/write_shared function.
This commit was SVN r32718.
2014-09-12 21:15:58 +00:00
Mangala Jyothi Bhaskar
cd78a3a026
Fixed offset data type in communication
...
This commit was SVN r32710.
2014-09-11 14:51:30 +00:00
Mangala Jyothi Bhaskar
a5973c3f8c
revamp of the aggregator selection logic, part 1.
...
This commit was SVN r32557.
2014-08-20 19:28:04 +00:00
Edgar Gabriel
fabad95b8e
- extend the explicit offset patch to collective explicit offset operations as
...
well
- minor restructuring to support the shared file pointer operations correctly
for explicit offsets
This commit was SVN r32538.
2014-08-15 14:03:29 +00:00
Edgar Gabriel
d773dc8aa5
make arbitrary sequences of explicit and implicit offset operations work properly.
...
This commit was SVN r32537.
2014-08-15 01:49:43 +00:00
Edgar Gabriel
c253c2eec6
fix the condition for the lazy open of shared filepointers.
...
This commit was SVN r29850.
2013-12-09 19:37:21 +00:00
Edgar Gabriel
f7391eca23
Lazy open does not work for the addproc sharedfp component since it starts by
...
spawning a process using MPI_Comm_spawn. For this, the first operation has to
be collective which we can not guarantuee outside of the MPI_File_open
operation.
This commit was SVN r29008.
2013-08-06 20:48:20 +00:00
Edgar Gabriel
ac694b7056
in preparation for the new shared file pointer components to be committed
...
soon:
- add a new abstraction layer to be used internally for some operations
- add a new mca parameter to control lazy intialization of shared file
pointer structures
This commit was SVN r28826.
2013-07-17 21:30:50 +00:00
Vishwanath Venkatesan
74c418b860
Adding typecasting with intptr_t to remove warnings.
...
This commit was SVN r28278.
2013-04-03 17:07:43 +00:00
Vishwanath Venkatesan
2922fa28a6
Changes to the interface for extracting timing information,
...
to avoid accessing datastructures across frameworks.
This commit was SVN r27543.
2012-10-31 22:03:05 +00:00
Vishwanath Venkatesan
9eeb3b5d50
# Extracting timing information for individual components of collective algorithm using a generic queue.
...
# This is triggered based on a mca-paramater and can be used with all collective modules.
# Individual queues maintained for read and write.
# The additional communication to combine data is done at file-close so that the
actual timing of collective-operations will not get affected.
# The queues are initialized in file-open
This commit was SVN r27439.
2012-10-11 21:14:07 +00:00
Vishwanath Venkatesan
960c47f604
Changes to io_ompio.c to support data-seiving in two-phase I/O.
...
This commit was SVN r27151.
2012-08-27 21:09:08 +00:00
Edgar Gabriel
66c5a80dfd
- get rid of a warning about an unused variable
...
- return MPI_ERR_OTHER instead of MPI_SUCCESS for the functions that are not
yet implemented
- add another field to the mca_io_ompio_file_t structure to point back to the
ompi_file_t structure.
This commit was SVN r26908.
2012-07-30 15:29:59 +00:00
Edgar Gabriel
b0954a6a3e
set the internal OMPIO file pointer to the end of the file if file has been
...
opened using the APPEND mode.
This commit was SVN r26692.
2012-06-28 15:15:47 +00:00
Edgar Gabriel
be6ea52bb4
some further cleanup of resources in case of an error.
...
This commit was SVN r26690.
2012-06-28 13:58:23 +00:00
Edgar Gabriel
b7a72feb1d
minor code cleanup and make the MPI_MODE_DELETE_ON_CLOSE work
...
This commit was SVN r26685.
2012-06-27 20:54:58 +00:00
Edgar Gabriel
288d044097
get rid of the fcache framework. It was not being used as originally intended.
...
This commit was SVN r26668.
2012-06-26 19:53:26 +00:00
Vishwanath Venkatesan
738a67b704
Removing duplicate code while setting default file view and using internal file-set-view for setting the default file view
...
This commit was SVN r25679.
2011-12-21 21:50:47 +00:00