Jeff Squyres
60ffe713b8
common syms: whitelist bison-generated common symbols
...
Bison generates some common symbols that we can't do anything about,
so whitelist them.
2016-01-16 03:53:14 -08:00
Artem Polyakov
2abb2972ac
Fix Mellanox copyrights with respect to the following PRs:
...
* https://github.com/open-mpi/ompi/pull/1184
* https://github.com/open-mpi/ompi/pull/1188
* https://github.com/open-mpi/ompi/pull/1197
* https://github.com/open-mpi/ompi/pull/1202
* https://github.com/open-mpi/ompi/pull/1210
* https://github.com/open-mpi/ompi/pull/1216
* https://github.com/open-mpi/ompi/pull/1236
* https://github.com/open-mpi/ompi/pull/1237
* https://github.com/open-mpi/ompi/pull/1248
* https://github.com/open-mpi/ompi/pull/1260
* https://github.com/open-mpi/ompi/pull/1264
2015-12-30 00:12:19 +06:00
Gilles Gouaillardet
cebde2a753
coll/tuned: add missing #include "opal/util/output.h"
...
Thanks Marco Atzeri for contributing the original patch
2015-12-24 14:41:17 +09:00
Gilles Gouaillardet
77f199d1d7
coll/fca: add missing #include <alloca.h>
2015-12-24 14:33:58 +09:00
Ralph Castain
ac6289dca6
Cleanup the warnings from the ompi layer when compiling optimized under Mac OSX
...
Cleanup per George's comments
2015-12-17 17:39:15 -08:00
igor.ivanov@itseez.com
0a9956927a
ompi/coll: Fix warnings in fca components
...
warning: assignment from incompatible pointer type
2015-12-16 16:22:16 +02:00
igor.ivanov@itseez.com
8f45d83d46
ompi/coll: Fix warnings in hcoll component
...
warning: assignment from incompatible pointer type
2015-12-16 14:52:29 +02:00
Nathan Hjelm
9d659465b7
Merge pull request #1210 from artpol84/icbarrier_fix
...
Fix NBC iBarrier for inter-communicators.
2015-12-14 13:52:38 -08:00
Artem Polyakov
2d0919dbdc
Fix NBC iGatherv for inter-communicators.
...
We need to use remote size to form a schedule.
2015-12-14 12:19:10 +06:00
Artem Polyakov
fc17deca43
Fix NBC iBarrier for inter-communicators.
...
Remove send of the extra message. This bug hase triggered on
MPICH/coll/nbicbarrier test. In this test a series of communicators
are created.
This extre-message was reseived after original communicator was destroyed
and queued into non_existing_communicator_pending. When new completely
unrelated communicator with the same id as original was created this message
was pushed into the frags_cant_match queue and caused seq numbers skew and hang.
2015-12-12 13:27:31 +06:00
Gilles Gouaillardet
3a3b13ea12
coll/base: fix an integer overflow in ompi_coll_base_reduce_generic
...
Refs open-mpi/ompi#1198
2015-12-11 13:55:59 +09:00
Gilles Gouaillardet
37c978f5e9
coll/libnbc: correctly handle changed types.
...
this fixes open-mpi/ompi@d816d1c194
thanks Jeff for the review
2015-12-07 10:13:43 +09:00
George Bosilca
3a9664ac9d
Fix Coverity CIDs 1341584-1341589.
2015-12-06 14:06:36 -05:00
George Bosilca
688108cf7f
Patch submitted by @ggouaillardet on ticket #1091 .
2015-12-02 20:42:18 -05:00
George Bosilca
4d00c59b2e
Cleanup the memory handling for temporary buffers in
...
some of the collective modules. Added a new function
opan_datatype_span, to compute the memory span of
count number of datatype, excluding the gaps in the
beginning and at the end. If a memory allocation is
made using the returned value, the gap (also returned)
should be removed from the allocated pointer.
2015-12-02 20:42:18 -05:00
Ryan Grant
324534b191
Merge pull request #1161 from tkordenbrock/topic/add.triggered.scatter
...
coll-portals4: add scatter and iscatter implementations that use Portals4 triggered operations
2015-11-30 16:53:47 -07:00
Todd Kordenbrock
4721b70dd5
coll-portals4: add scatter and iscatter implementations that use Portals4 triggered operations
...
This commit adds implementations of scatter and iscatter using
Portals4 triggered operations. Currently, the only algorithm
is linear.
2015-11-30 15:07:18 -06:00
Todd Kordenbrock
f6f525e0d8
coll-portals4: remove unneeded code from gather
...
This commit removes two pieces of unneeded code from gather. First
it removes destroy_tree() calls from linear_top(), because the
linear algorithm does not create a tree, so there is no need to
destroy it. Second it removes unpack_bytes from the gather request
because it was calculated but never used.
2015-11-30 10:38:51 -06:00
Gilles Gouaillardet
d816d1c194
coll/libnbc: use PMPI_* and internal ompi_* insted of MPI_*
2015-11-20 13:46:19 +09:00
Ryan Grant
f60c506c68
Merge pull request #999 from tkordenbrock/topic/add.triggered.gather
...
coll-portals4: add gather and igather implementations that use Portals4 triggered operations
2015-10-20 14:59:09 -06:00
Gilles Gouaillardet
0f23037775
coll/base: fix memory allocation in mca_coll_base_alltoall_intra_basic_inplace
2015-10-19 16:47:59 +09:00
Jeff Squyres
62351f442a
help: remove stale help messages and files
...
Found by contrib/check-help-strings.pl.
2015-10-13 16:50:20 -04:00
Todd Kordenbrock
7c738fb657
coll-portals4: add gather and igather implementations that use Portals4 triggered operations
...
This commit adds implementations of gather and igather using
Portals4 triggered operations. The default algorithm is linear,
but binomial can be selected using an MCA parameter -
coll_portals4_use_binomial_gather_algorithm.
2015-10-13 11:26:35 -05:00
Nathan Hjelm
d8dc5292ed
Merge pull request #1002 from hjelmn/ompi_coverity
...
ompi: fix coverity issues
2015-10-09 12:27:41 -06:00
Nathan Hjelm
4cb42f8264
ompi: fix coverity issues
...
Fixes CID 715741: Logically dead code
Verified. Removed dead code.
Fixes CID 1320878: Resource leak
Free proc_list before returning.
Signed-off-by: Nathan Hjelm <hjelmn@me.com>
2015-10-09 08:41:27 -06:00
Gilles Gouaillardet
e946c82847
Revert "coll/basic: fix segmentation fault in neighborhood collectives if the degree"
...
This partially reverts commit open-mpi/ompi@76204dfafe .
2015-10-08 12:00:41 -04:00
Gilles Gouaillardet
99cca2cfd3
Revert "* comment on communicator creation in mca_topo_base_dist_graph_create(...)"
...
This partially reverts commit open-mpi/ompi@27e4389259 .
2015-10-08 12:00:41 -04:00
George Bosilca
a8bdd8f668
Don't lose the pointer to the request array. Patch provided by
...
@ggouaillardet.
2015-10-08 12:00:41 -04:00
George Bosilca
88492a1e12
Consistently use the request array for all modules (single array stored
...
in the base).
Correctly deal with persistent requests (they must be always freed when
they are stored in the request array associated with the communicator).
Always use MPI_STATUS_IGNORE for single request waiting functions.
2015-10-08 12:00:41 -04:00
George Bosilca
01b32caf98
Update the basic module to dynamically allocate the right
...
number of requests.
Remove unnecessary fields.We don't need these fields.
2015-10-08 12:00:41 -04:00
George Bosilca
a324602174
Never allocate a temporary array for the requests. Instead rely on the
...
module_data to hold one with the largest necessary size. This array is
only allocated when needed, and it is released upon communicator
destruction.
2015-10-08 12:00:41 -04:00
Todd Kordenbrock
f33b0c1cdf
coll-portals4: allreduce: remove extra %d from error message.
2015-10-08 07:57:33 -05:00
Devendar Bureddy
72f98ccf6c
HCOLL: Enable alltoall interface
2015-10-07 08:00:04 +03:00
Gilles Gouaillardet
de8de65b07
coll/tuned: remove unused prototypes from coll_tuned.h
2015-10-06 09:07:48 +09:00
Mike Dubman
e8d7373b14
COLL/FCA: revert to prev barrier if called from finalize
...
FCA barrier may not complete if FCA progress is not called periodically.
PMI/PMI2 API that can be used in rte barrier has no provision for calling
external progress function.
So it is possible that during finalize some ranks will be stuck
in fca barrier while others are in PMI barrier.
2015-10-04 09:40:19 +03:00
Devendar Bureddy
243b75aa80
HCOLL: Add alltoallv interface
2015-10-02 01:51:33 +03:00
Nathan Hjelm
12bd300c40
Merge pull request #929 from hjelmn/add_procs
...
Update add_procs support
2015-09-28 17:29:13 -06:00
Todd Kordenbrock
3e63a3458c
portals4: add support for dynamic add_procs() to all Portals4 components
...
In the default mode of operation, the Portals4 components support
dynamic add_procs().
The Portals4 components have two alternate modes (flow control and
logical-to-physical) that require knowledge of all procs at startup.
In these modes, mtl-portals4 sets the MCA_MTL_BASE_FLAG_REQUIRE_WORLD
flag and btl-portals4 sets the MCA_BTL_FLAGS_SINGLE_ADD_PROCS flag
to tell the PML that we need all the procs in one add_procs() call.
2015-09-24 22:12:57 -05:00
Nathan Hjelm
30f8d0b038
coll/libnbc: fix coverity errors
...
Fix CID 1196812: Resource Leak
dsts array was leaked on error.
Fix CID 710565: Copy-paste error
The line in question (nbc:513) is indeed a copy-paste error.
Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2015-09-23 16:14:49 -06:00
Rolf vandeVaart
2c51faa58d
Fix warnings due to missing const
2015-09-21 14:18:44 -04:00
Gilles Gouaillardet
a611274704
pml: fix commit open-mpi/ompi@6e6a3e965c
...
do not use the const modifier for allocator nor recv buffers
2015-09-18 09:54:18 +09:00
Gilles Gouaillardet
a1627feaf7
coll/ml, bcol: fix prototypes (e.g. use the const modifier)
2015-09-11 13:20:44 +09:00
Nathan Hjelm
a41889112c
Remove calls to ompi_group_peer_lookup in coll/sm and coll/fca
...
Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2015-09-10 08:55:54 -06:00
Gilles Gouaillardet
e01bac962f
coll: do not cast way the const modifier when this is not necessary
...
update the coll framework and mpi c bindings
2015-09-09 09:18:57 +09:00
Jeff Squyres
bc9e5652ff
whitespace: purge whitespace at end of lines
...
Generated by running "./contrib/whitespace-purge.sh".
2015-09-08 09:47:17 -07:00
Gilles Gouaillardet
c404e98dce
coll/ml: silence warnings (incorrect callback prototype)
2015-09-07 14:56:49 +09:00
Gilles Gouaillardet
56f8a7b840
coll/ml: declare a global variable as static to avoid an uninitialized common symbol.
2015-09-07 14:56:03 +09:00
rhc54
665b30376a
Merge pull request #868 from rhc54/topic/hwloc
...
Remove OPAL_HAVE_HWLOC qualifier and error out if --without-hwloc is given
2015-09-04 17:58:07 -07:00
Ralph Castain
d97bc29102
Remove OPAL_HAVE_HWLOC qualifier and error out if --without-hwloc is given
2015-09-04 16:54:40 -07:00
Pavel Shamis (Pasha)
32c69630ad
ML: Replace opal ignore with a zero priority
...
The priority set by default to 0. As a result component open reports
an error and the component is not loaded (no resources allocated).
2015-09-04 11:28:47 -04:00