Ralph Castain
4ef9d15d97
Revamp the opal mca paffinity interface. We ran into a problem when we encountered machines that had "holes" in their physical processor layout - e.g., machines that supported "hotplugging", or that had unpopulated sockets. To solve that problem, we had to clarify at the API level where we were describing physical vs logical processor info, and then translate accordingly in the underlying implementation.
...
See opal/mca/paffinity/paffinity.h for explanation as to the physical vs logical nature of the params used in the API.
Fixes trac:1435
This commit was SVN r19391.
The following Trac tickets were found above:
Ticket 1435 --> https://svn.open-mpi.org/trac/ompi/ticket/1435
2008-08-21 19:21:28 +00:00
Matthias Jurenz
7b61e02841
Fixed Coverity warnings
...
CIDs: 815,867,879,880,881,909,910,918,919,936
This commit was SVN r19386.
2008-08-21 15:01:32 +00:00
Matthias Jurenz
ea55900971
Corrected last checkin: potential buffer overflow
...
This commit was SVN r19385.
2008-08-21 15:00:44 +00:00
Matthias Jurenz
1bac115f7c
Added check for empty environment variables
...
This commit was SVN r19384.
2008-08-21 15:00:14 +00:00
Matthias Jurenz
67f1e35eb0
Fixed Coverity warnings
...
CIDs: 737,739,740,741,742,743,744,756,907,1110,1111
This commit was SVN r19376.
2008-08-20 15:50:15 +00:00
Edgar Gabriel
ef2bb46e45
no need to create and free the groups. We just want to translate the ranks and we can use the internal group structures right away for that operation. Fixes an issue with groups that have not been freed previously, due to the fact that ompi_group_free was not visible here (I know, this could have been solved also by setting OMPI_DECLSPEC on ompi_group_free, but this solution should be faster.)
...
This commit was SVN r19362.
2008-08-19 13:59:58 +00:00
Edgar Gabriel
149ecb8d7d
1. debug the four new algorithms
...
2. fix a bug in the initial communicator creation of llcomm
3. fix a bug which showed up as the result of fixing issue number 2: we have
to check now whether llcomm has really be created before freeing the
according llcomm in hierarch_destruct.
This commit was SVN r19361.
2008-08-18 21:54:35 +00:00
Edgar Gabriel
7cbc4a4077
adding four different algorithms for a hierarchical bcast which try to
...
generate an overlap between the different layers. Why four versions? Because
there is right now always the trade-off between using non-blocking operations
on a layer with a trivial, linear algorithm and using the more sophisticaed
algorithms in a blocking manner.
- bcast_intra_seg used the bcast of lcomm and llcomm, similarly
to original algorithm in hierarch. However, it can segment
the message, such that we might get an overlap between the two
layers. This overlap is based on the assumption, that a process
might be done early with a bcast and can start the next one.
- bcast_intra_seg1: replaces the llcomm->bcast by isend/irecvs
to increase the overlap, keeps the lcomm->bcast however
- bcast_intra_seg2: replaced lcomm->bcast by isend/irecvs
to increase the overlap, keeps however llcomm->bcast
- bcast_intra_seg3: replaced both lcomm->bcast and llcomm->bcast
by isend/irecvs
The code is lightly tested, more testing to follow right now.
This commit was SVN r19358.
2008-08-18 16:05:44 +00:00
Matthias Jurenz
19514f4df6
Fixed Coverity warnings
...
CIDs: 865,866,896,897,974,975,976
This commit was SVN r19356.
2008-08-18 14:24:41 +00:00
Matthias Jurenz
0f9693d8af
Fixed Coverity warnings
...
CIDs: 714,781,782,825,872,917
This commit was SVN r19354.
2008-08-18 14:24:06 +00:00
Matthias Jurenz
c65e8a6882
Fixed Coverity warnings
...
CIDs: 794,882,908,934,962
This commit was SVN r19352.
2008-08-18 14:23:25 +00:00
Matthias Jurenz
63d84e2626
Fixed Coverity warnings
...
CIDs: 977
This commit was SVN r19350.
2008-08-18 14:22:48 +00:00
Matthias Jurenz
aa05fba21f
Fixed Coverity warnings
...
CIDs: 823,824,905,906
This commit was SVN r19348.
2008-08-18 14:22:15 +00:00
Matthias Jurenz
406a61f599
Fixed Coverity warnings
...
CIDs: 821,822,903,904
This commit was SVN r19346.
2008-08-18 14:21:37 +00:00
Matthias Jurenz
7364bc9691
Fixed Coverity warnings
...
CIDs: 957,1109
This commit was SVN r19344.
2008-08-18 14:20:50 +00:00
Matthias Jurenz
33434d49fb
Fixed Coverity warnings
...
CIDs: 1105
This commit was SVN r19342.
2008-08-18 14:19:30 +00:00
Matthias Jurenz
daa8119dd0
Corrected provious checkin (Coverity warning CID: 875)
...
This commit was SVN r19340.
2008-08-18 14:18:48 +00:00
Matthias Jurenz
9fc72120b7
Fixed Coverity warnings
...
CIDs: 1104
This commit was SVN r19338.
2008-08-18 14:17:39 +00:00
Matthias Jurenz
a4491e1b4c
Fixed Coverity warnings
...
CIDs: 918,919
This commit was SVN r19336.
2008-08-18 14:16:23 +00:00
Matthias Jurenz
1555a8843f
Renamed 'args' to 'argv' to avoid Coverity warnings (TAINTED_STRING)
...
CIDs: 1106,1107,1108
This commit was SVN r19334.
2008-08-18 14:15:39 +00:00
Matthias Jurenz
5081fd0da6
Fixed Coverity warnings
...
CIDs: 727
This commit was SVN r19332.
2008-08-18 14:13:45 +00:00
George Bosilca
6982e8ecbc
Don't forget to release the temporary arrays used for converting
...
the datatypes from Fortran to C.
This commit was SVN r19314.
2008-08-17 21:57:59 +00:00
George Bosilca
2499112d1c
Fix indentation.
...
This commit was SVN r19313.
2008-08-17 20:10:54 +00:00
George Bosilca
a6e3a47102
Fix typo.
...
This commit was SVN r19312.
2008-08-17 20:08:38 +00:00
George Bosilca
a41dcbbc44
Play nicely with the PML. If the data is in the pending send queue, then
...
tell the PML we're still in charge of sending it.
This commit was SVN r19311.
2008-08-17 20:07:53 +00:00
George Bosilca
f3568a271a
Replace tabs with spaces.
...
This commit was SVN r19310.
2008-08-17 20:06:48 +00:00
George Bosilca
10612bef8a
Bring back the SM pending queue, to avoid deadlocks.
...
This commit fixes trac:1378.
This commit was SVN r19309.
The following Trac tickets were found above:
Ticket 1378 --> https://svn.open-mpi.org/trac/ompi/ticket/1378
2008-08-17 19:00:50 +00:00
Matthias Jurenz
c7ac98dd62
Fixed several Coverity-Warnings
...
This commit was SVN r19304.
2008-08-15 15:15:21 +00:00
Jeff Squyres
5946d84023
Add some "canary" code to the debugger DLL so that we'll hopefully get
...
a compiler error if OMPI data structs that are used in the DLL are
changed in the main code base.
This commit was SVN r19289.
2008-08-14 12:57:44 +00:00
Matthias Jurenz
a62f421d2b
Bugfix (Ticket #1447 ): Removed included system headers inside 'extern "C" {}'
...
This commit was SVN r19287.
2008-08-14 12:17:24 +00:00
Jeff Squyres
c9f3f2c682
From Ralph Campbell at QLogic:
...
Roland noticed that the QLogic HCA driver was using the PCIe vendor ID
for the ibv_query_device so the IEEE OUI value is now used. This means
the config file should recognize the vendor ID value 0x1175 too.
This commit was SVN r19277.
2008-08-13 18:35:37 +00:00
Ralph Castain
89ec513524
Change the #if checks to allow configurations --without-threads to work
...
This commit was SVN r19274.
2008-08-13 17:39:27 +00:00
George Bosilca
f030497072
Don't forget to set the node to some negative value or ... the memory will
...
be pinned to some random core.
This commit was SVN r19257.
2008-08-12 16:58:32 +00:00
Terry Dontje
d471f7d7eb
Correctly casted variable to make DEBUG print to not cause a warning.
...
This commit was SVN r19256.
2008-08-12 16:41:35 +00:00
Jeff Squyres
fc7e5f1c0d
Fix CID 1095: ensure to initialize the File
...
This commit was SVN r19252.
2008-08-12 13:13:02 +00:00
Terry Dontje
3559ecbadc
One more time. Some how got a newline between the last 2 zeros in the define.
...
This commit was SVN r19250.
2008-08-12 12:22:54 +00:00
Terry Dontje
512d7ca8c8
Restore the VERBOSE define but set it to 0x00000000
...
This commit was SVN r19249.
2008-08-12 12:18:13 +00:00
Terry Dontje
5641bd5549
Remove the #define VERBOSE line to stop debug message spew from happening.
...
This commit was SVN r19248.
2008-08-12 12:14:26 +00:00
Rich Graham
e64f028d62
add missing header file for errno.
...
This commit was SVN r19246.
2008-08-12 01:34:13 +00:00
George Bosilca
fc9ae0e835
Allow the DLL to correctly retrieve the pnding requests from MPI applications.
...
This commit was SVN r19244.
2008-08-11 23:40:09 +00:00
Jeff Squyres
93746cd594
Fixed CID 807: Remove unused variable
...
This commit was SVN r19239.
2008-08-11 20:50:09 +00:00
Jeff Squyres
9b14ee6d83
Fix CID 839: minor memory leak on error
...
This commit was SVN r19238.
2008-08-11 20:46:27 +00:00
Jeff Squyres
76b4040fbf
Fix CIDs 830, 831, 858: minor resource leaks on error
...
This commit was SVN r19237.
2008-08-11 20:40:04 +00:00
Jeff Squyres
54ab811426
Fix CID 1036: minor resource leak on error
...
This commit was SVN r19236.
2008-08-11 20:37:36 +00:00
Rainer Keller
ee1fe9015a
- Make sure, that the *param_index are > 0 (here, we don't pass
...
errors up...).
Coverity CID 1080 - 1090
- Really make sure, the user does not specify stupid negative values.
This commit was SVN r19233.
2008-08-11 11:21:04 +00:00
Rainer Keller
9cc83d7414
- Fix the freeing of already allocated buffers, if one fails.
...
Fixes Coverity CID 291 & CID 292
- Adjust the rc for other functions as well.
This commit was SVN r19232.
2008-08-11 09:43:01 +00:00
Jeff Squyres
da765cf68a
Gah; bml_base_endpoint.h was listed ''twice'' in this Makefile.am; I
...
missed that in r19226.
This commit was SVN r19231.
The following SVN revision numbers were found above:
r19226 --> open-mpi/ompi@d8860502df
2008-08-09 01:18:13 +00:00
Jeff Squyres
fa25de320e
Fixes CIDs 421, 422, 423, 424, 425 426
...
Possibly fixes CID 417
* ensure to initialize inner members upon default constructors using
the same syntax across all classes
* remove some member variables that aren't used anymore
* "initialize" the inner MPI_Status in the default constructor for
MPI::Status by calling the default constructor mpi_status(). This
may or may not silence CID 417; we'll see what happens in
subsequent Coverity Prevent runs.
This commit was SVN r19228.
2008-08-08 13:49:44 +00:00
Jeff Squyres
7af5f70cf3
Fix CID 529: potential static buffer overflow
...
This commit was SVN r19227.
2008-08-08 12:52:54 +00:00
Jeff Squyres
d8860502df
Fix CID 1092: remove a useless header file (bml_base_endpoint.h -- it
...
didn't contain anything!) and therefore remove some include file
recursion.
This commit was SVN r19226.
2008-08-08 12:39:30 +00:00