1
1
Граф коммитов

4020 Коммитов

Автор SHA1 Сообщение Дата
Matthias Jurenz
ea55900971 Corrected last checkin: potential buffer overflow
This commit was SVN r19385.
2008-08-21 15:00:44 +00:00
Matthias Jurenz
1bac115f7c Added check for empty environment variables
This commit was SVN r19384.
2008-08-21 15:00:14 +00:00
Matthias Jurenz
67f1e35eb0 Fixed Coverity warnings
CIDs: 737,739,740,741,742,743,744,756,907,1110,1111

This commit was SVN r19376.
2008-08-20 15:50:15 +00:00
Edgar Gabriel
ef2bb46e45 no need to create and free the groups. We just want to translate the ranks and we can use the internal group structures right away for that operation. Fixes an issue with groups that have not been freed previously, due to the fact that ompi_group_free was not visible here (I know, this could have been solved also by setting OMPI_DECLSPEC on ompi_group_free, but this solution should be faster.)
This commit was SVN r19362.
2008-08-19 13:59:58 +00:00
Edgar Gabriel
149ecb8d7d 1. debug the four new algorithms
2. fix a bug in the initial communicator creation of llcomm
3. fix a bug which showed up as the result of fixing issue number 2: we have
   to check now whether llcomm has really be created before freeing the 
   according llcomm in hierarch_destruct.

This commit was SVN r19361.
2008-08-18 21:54:35 +00:00
Edgar Gabriel
7cbc4a4077 adding four different algorithms for a hierarchical bcast which try to
generate an overlap between the different layers. Why four versions? Because
there is right now always the trade-off between using non-blocking operations
on a layer with a trivial, linear algorithm and using the more sophisticaed
algorithms in a blocking manner. 

- bcast_intra_seg used the bcast of lcomm and llcomm, similarly
  to original algorithm in hierarch. However, it can segment
  the message, such that we might get an overlap between the two
  layers. This overlap is based on the assumption, that a process
  might be done early with a bcast and can start the next one.
- bcast_intra_seg1: replaces the llcomm->bcast by isend/irecvs
  to increase the overlap, keeps the lcomm->bcast however
- bcast_intra_seg2: replaced lcomm->bcast by isend/irecvs
  to increase the overlap, keeps however llcomm->bcast
- bcast_intra_seg3: replaced both lcomm->bcast and llcomm->bcast
  by isend/irecvs

The code is lightly tested, more testing to follow right now.

This commit was SVN r19358.
2008-08-18 16:05:44 +00:00
Matthias Jurenz
19514f4df6 Fixed Coverity warnings
CIDs: 865,866,896,897,974,975,976

This commit was SVN r19356.
2008-08-18 14:24:41 +00:00
Matthias Jurenz
0f9693d8af Fixed Coverity warnings
CIDs: 714,781,782,825,872,917

This commit was SVN r19354.
2008-08-18 14:24:06 +00:00
Matthias Jurenz
c65e8a6882 Fixed Coverity warnings
CIDs: 794,882,908,934,962

This commit was SVN r19352.
2008-08-18 14:23:25 +00:00
Matthias Jurenz
63d84e2626 Fixed Coverity warnings
CIDs: 977

This commit was SVN r19350.
2008-08-18 14:22:48 +00:00
Matthias Jurenz
aa05fba21f Fixed Coverity warnings
CIDs: 823,824,905,906

This commit was SVN r19348.
2008-08-18 14:22:15 +00:00
Matthias Jurenz
406a61f599 Fixed Coverity warnings
CIDs: 821,822,903,904

This commit was SVN r19346.
2008-08-18 14:21:37 +00:00
Matthias Jurenz
7364bc9691 Fixed Coverity warnings
CIDs: 957,1109

This commit was SVN r19344.
2008-08-18 14:20:50 +00:00
Matthias Jurenz
33434d49fb Fixed Coverity warnings
CIDs: 1105

This commit was SVN r19342.
2008-08-18 14:19:30 +00:00
Matthias Jurenz
daa8119dd0 Corrected provious checkin (Coverity warning CID: 875)
This commit was SVN r19340.
2008-08-18 14:18:48 +00:00
Matthias Jurenz
9fc72120b7 Fixed Coverity warnings
CIDs: 1104

This commit was SVN r19338.
2008-08-18 14:17:39 +00:00
Matthias Jurenz
a4491e1b4c Fixed Coverity warnings
CIDs: 918,919

This commit was SVN r19336.
2008-08-18 14:16:23 +00:00
Matthias Jurenz
1555a8843f Renamed 'args' to 'argv' to avoid Coverity warnings (TAINTED_STRING)
CIDs: 1106,1107,1108

This commit was SVN r19334.
2008-08-18 14:15:39 +00:00
Matthias Jurenz
5081fd0da6 Fixed Coverity warnings
CIDs: 727

This commit was SVN r19332.
2008-08-18 14:13:45 +00:00
George Bosilca
6982e8ecbc Don't forget to release the temporary arrays used for converting
the datatypes from Fortran to C.

This commit was SVN r19314.
2008-08-17 21:57:59 +00:00
George Bosilca
2499112d1c Fix indentation.
This commit was SVN r19313.
2008-08-17 20:10:54 +00:00
George Bosilca
a6e3a47102 Fix typo.
This commit was SVN r19312.
2008-08-17 20:08:38 +00:00
George Bosilca
a41dcbbc44 Play nicely with the PML. If the data is in the pending send queue, then
tell the PML we're still in charge of sending it.

This commit was SVN r19311.
2008-08-17 20:07:53 +00:00
George Bosilca
f3568a271a Replace tabs with spaces.
This commit was SVN r19310.
2008-08-17 20:06:48 +00:00
George Bosilca
10612bef8a Bring back the SM pending queue, to avoid deadlocks.
This commit fixes trac:1378.

This commit was SVN r19309.

The following Trac tickets were found above:
  Ticket 1378 --> https://svn.open-mpi.org/trac/ompi/ticket/1378
2008-08-17 19:00:50 +00:00
Matthias Jurenz
c7ac98dd62 Fixed several Coverity-Warnings
This commit was SVN r19304.
2008-08-15 15:15:21 +00:00
Jeff Squyres
5946d84023 Add some "canary" code to the debugger DLL so that we'll hopefully get
a compiler error if OMPI data structs that are used in the DLL are
changed in the main code base.

This commit was SVN r19289.
2008-08-14 12:57:44 +00:00
Matthias Jurenz
a62f421d2b Bugfix (Ticket #1447): Removed included system headers inside 'extern "C" {}'
This commit was SVN r19287.
2008-08-14 12:17:24 +00:00
Jeff Squyres
c9f3f2c682 From Ralph Campbell at QLogic:
Roland noticed that the QLogic HCA driver was using the PCIe vendor ID
for the ibv_query_device so the IEEE OUI value is now used. This means
the config file should recognize the vendor ID value 0x1175 too.

This commit was SVN r19277.
2008-08-13 18:35:37 +00:00
Ralph Castain
89ec513524 Change the #if checks to allow configurations --without-threads to work
This commit was SVN r19274.
2008-08-13 17:39:27 +00:00
George Bosilca
f030497072 Don't forget to set the node to some negative value or ... the memory will
be pinned to some random core.

This commit was SVN r19257.
2008-08-12 16:58:32 +00:00
Terry Dontje
d471f7d7eb Correctly casted variable to make DEBUG print to not cause a warning.
This commit was SVN r19256.
2008-08-12 16:41:35 +00:00
Jeff Squyres
fc7e5f1c0d Fix CID 1095: ensure to initialize the File
This commit was SVN r19252.
2008-08-12 13:13:02 +00:00
Terry Dontje
3559ecbadc One more time. Some how got a newline between the last 2 zeros in the define.
This commit was SVN r19250.
2008-08-12 12:22:54 +00:00
Terry Dontje
512d7ca8c8 Restore the VERBOSE define but set it to 0x00000000
This commit was SVN r19249.
2008-08-12 12:18:13 +00:00
Terry Dontje
5641bd5549 Remove the #define VERBOSE line to stop debug message spew from happening.
This commit was SVN r19248.
2008-08-12 12:14:26 +00:00
Rich Graham
e64f028d62 add missing header file for errno.
This commit was SVN r19246.
2008-08-12 01:34:13 +00:00
George Bosilca
fc9ae0e835 Allow the DLL to correctly retrieve the pnding requests from MPI applications.
This commit was SVN r19244.
2008-08-11 23:40:09 +00:00
Jeff Squyres
93746cd594 Fixed CID 807: Remove unused variable
This commit was SVN r19239.
2008-08-11 20:50:09 +00:00
Jeff Squyres
9b14ee6d83 Fix CID 839: minor memory leak on error
This commit was SVN r19238.
2008-08-11 20:46:27 +00:00
Jeff Squyres
76b4040fbf Fix CIDs 830, 831, 858: minor resource leaks on error
This commit was SVN r19237.
2008-08-11 20:40:04 +00:00
Jeff Squyres
54ab811426 Fix CID 1036: minor resource leak on error
This commit was SVN r19236.
2008-08-11 20:37:36 +00:00
Rainer Keller
ee1fe9015a - Make sure, that the *param_index are > 0 (here, we don't pass
errors up...).
   Coverity CID 1080 - 1090
 - Really make sure, the user does not specify stupid negative values.

This commit was SVN r19233.
2008-08-11 11:21:04 +00:00
Rainer Keller
9cc83d7414 - Fix the freeing of already allocated buffers, if one fails.
Fixes Coverity CID 291 & CID 292
 - Adjust the rc for other functions as well.

This commit was SVN r19232.
2008-08-11 09:43:01 +00:00
Jeff Squyres
da765cf68a Gah; bml_base_endpoint.h was listed ''twice'' in this Makefile.am; I
missed that in r19226.

This commit was SVN r19231.

The following SVN revision numbers were found above:
  r19226 --> open-mpi/ompi@d8860502df
2008-08-09 01:18:13 +00:00
Jeff Squyres
fa25de320e Fixes CIDs 421, 422, 423, 424, 425 426
Possibly fixes CID 417

 * ensure to initialize inner members upon default constructors using
   the same syntax across all classes
 * remove some member variables that aren't used anymore
 * "initialize" the inner MPI_Status in the default constructor for
   MPI::Status by calling the default constructor mpi_status().  This
   may or may not silence CID 417; we'll see what happens in
   subsequent Coverity Prevent runs.

This commit was SVN r19228.
2008-08-08 13:49:44 +00:00
Jeff Squyres
7af5f70cf3 Fix CID 529: potential static buffer overflow
This commit was SVN r19227.
2008-08-08 12:52:54 +00:00
Jeff Squyres
d8860502df Fix CID 1092: remove a useless header file (bml_base_endpoint.h -- it
didn't contain anything!) and therefore remove some include file
recursion.

This commit was SVN r19226.
2008-08-08 12:39:30 +00:00
Jeff Squyres
735c1d8bee Add a missing OMPI_DECLSPEC
This commit was SVN r19221.
2008-08-07 20:36:11 +00:00
Jeff Squyres
797ec531aa Some more work on the man pages:
* Make the creation of the build dir for the man pages a bit more
   robust (thanks to suggestions from Ralf W.).
 * Only distribute the .Xin files, not the .X man pages themselves.
 * Make the .X files depend on opal_config.h so that if you re-run
   configure and change opal_config.h (e.g., a new version), the man
   pages should get rebuilt.
 * Man pages are now cleaned with "distclean", not "maintainer-clean".
 * Fix a typo in opal_crs.7in.
 * Udpate make_dist_tarball to update "date" in the VERSION file.
 * Make make_dist_tarball a bit friendlier to hg checkouts.

This commit was SVN r19219.
2008-08-07 19:20:40 +00:00
Jeff Squyres
f09dc4be31 Fix one item missed by r19175.
This commit was SVN r19216.

The following SVN revision numbers were found above:
  r19175 --> open-mpi/ompi@e105b3f254
2008-08-07 14:49:27 +00:00
Jeff Squyres
4aff8038f9 A compromise -- move the shutting down of the async thread to the
component_close, when we know all the btl modules are gone and there
will be no more of them created.

This commit was SVN r19214.
2008-08-07 13:48:38 +00:00
Jeff Squyres
e835c89242 Revert r19205.
This commit was SVN r19212.

The following SVN revision numbers were found above:
  r19205 --> open-mpi/ompi@58b3ea2f8b
2008-08-07 11:51:38 +00:00
Donald Kerr
7a88e2c6cb catch when mpool not created and prevent the subsequent segv
This commit was SVN r19211.
2008-08-07 11:33:28 +00:00
Jeff Squyres
6d9f047238 Somehow this sign ended up pointing the wrong way.
This commit was SVN r19207.
2008-08-06 20:35:42 +00:00
Ralph Castain
adf2b4dfda Correct an error output so the process names are sensible
This commit was SVN r19206.
2008-08-06 18:56:16 +00:00
Jeff Squyres
58b3ea2f8b The async thread should not be shut down by the module since it's a
per-device entity.  Also, we should shut down the CPCs after we have
destroyed both PP and SRQ QPs.

This commit was SVN r19205.
2008-08-06 18:26:53 +00:00
Jeff Squyres
9cffbecdaf Amend r19196 with a few extra bells and whistles:
* use "warn_on_fork" instead of "do_not_warn_on_fork" -- i.e.,
   use positive logic instead of negative logic
 * ensure that pthread_atfork() is only called once
 * amended the error message to include the hostname, PID, and
   MPI_COMM_WORLD rank of the offender
 * ensure that the warn_fork_cb() function is only defined if
   HAVE_PTHREAD_H so that we don't get a compiler warning if it isn't
   used

This commit was SVN r19204.

The following SVN revision numbers were found above:
  r19196 --> open-mpi/ompi@277e4ac292
2008-08-06 17:29:41 +00:00
George Bosilca
45beed78e9 Fix 2 derefenced NULL variables (Coverty fix 474 & 476).
This commit was SVN r19202.
2008-08-06 15:50:54 +00:00
George Bosilca
fb02c23389 Fix dereference of NULL variable (Coverty 473).
This commit was SVN r19201.
2008-08-06 15:46:09 +00:00
Ralph Castain
277e4ac292 Provide a warning message if a user's app executes a "fork" operation while using subsystems that may not cleanly support it - e.g., the openib btl. The provided warning is a generic one indicating that use of fork in current conditions is not recommended.
This is setup so that it only is issued once (as opposed to every time they do it), and goes through orte_show_help so the user doesn't get hammered by #procs copies of the warning. In addition, there is a new MCA param (can't have too many!) to shut the warning off altogether.

This closes ticket #1244

This commit was SVN r19196.
2008-08-06 14:22:03 +00:00
George Bosilca
3c8d43deed Remove unused variable (Coverty fix 178).
This commit was SVN r19195.
2008-08-06 14:09:43 +00:00
George Bosilca
567c691354 Remove unused variable (Coverty fix 177).
This commit was SVN r19194.
2008-08-06 14:08:34 +00:00
George Bosilca
f6ebdf8896 Remove unused variable (Coverty fix 176).
This commit was SVN r19193.
2008-08-06 14:07:20 +00:00
George Bosilca
c021427002 Remove unused variable (Coverty fix 175).
This commit was SVN r19192.
2008-08-06 14:06:08 +00:00
George Bosilca
6c8017e9b7 Remove unused variable (Coverty fix 174).
This commit was SVN r19191.
2008-08-06 14:04:54 +00:00
George Bosilca
afc79d1651 Remove unused variable (Coverty fix 173).
This commit was SVN r19190.
2008-08-06 14:03:33 +00:00
Rainer Keller
69a16b14bc - Fix variable set but not used
Coverity CID1057

This commit was SVN r19189.
2008-08-06 14:02:12 +00:00
George Bosilca
5e3a5b7c13 Remove unused variable (Coverty fix 172).
This commit was SVN r19188.
2008-08-06 14:01:33 +00:00
George Bosilca
d897710e4f Remove unused variable (Coverty fix 171).
This commit was SVN r19187.
2008-08-06 14:00:22 +00:00
George Bosilca
417b727006 Remove unused variable (Coverty fix 170).
This commit was SVN r19186.
2008-08-06 13:59:03 +00:00
George Bosilca
4f91b7806c Remove unused variable (Coverty fix 169).
This commit was SVN r19185.
2008-08-06 13:57:43 +00:00
Rainer Keller
23c2292478 - Fix variable set but not used
Coverity CID1058

This commit was SVN r19184.
2008-08-06 13:57:38 +00:00
George Bosilca
7720e7ea2d Fix recursion in include files (Coverty fix 153).
This commit was SVN r19180.
2008-08-06 13:49:03 +00:00
Rainer Keller
e84f1f6fdf - Mark the variable bytes_delivered as being unused
(it is just set within MCA_PML_OB1_RECV_REQUEST_UNPACK)
   Iff Coverity's prevent makes usage of __attribute__(unused),
   this should get rid of warning.
   Relates to CID1060

   Would then apply to a many int _rc; definitions, that are
   used in other macros in similar fashion...

This commit was SVN r19179.
2008-08-06 13:46:23 +00:00
George Bosilca
3dafa58b32 Fix coverty issue 1044.
This commit was SVN r19178.
2008-08-06 13:38:21 +00:00
Jeff Squyres
765749209f Fix CID 413: possible uninitialized variable
This commit was SVN r19176.
2008-08-06 12:25:56 +00:00
Rolf vandeVaart
e105b3f254 Finish work related to ticket #1392 where the versions
were bumped from v1.0.0 to v2.0.0.  

This change fixed #1439.

This commit was SVN r19175.
2008-08-06 12:16:54 +00:00
Jeff Squyres
262f865e77 Fix CID 387: be safer about string handling when using fixed-length
strings

This commit was SVN r19174.
2008-08-06 12:15:49 +00:00
Rainer Keller
33d7c52eed - Fix resource leak in case of error
Coverity CID1066

This commit was SVN r19169.
2008-08-06 08:12:12 +00:00
Rainer Keller
c1f2b8e476 - Fix resource leak in case of error.
Coverity CID1067

This commit was SVN r19168.
2008-08-06 08:04:27 +00:00
Rainer Keller
82580701fb - We may know the *_name is < MPI_MAX_OBJECT_NAME; Prevent does not.
Fix Coverity issues CID1068 and CID1069

This commit was SVN r19167.
2008-08-06 07:59:59 +00:00
Dan Lacher
0ef83a558e minor tweak to header line for ompi_crcp.7
This commit was SVN r19150.
2008-08-04 19:48:10 +00:00
Ralph Castain
5a2053ade2 Per July technical meeting:
Revise the scope precedence in the MPI_Publish, Unpublish, and Lookup functions. If a global server was specified and is available, then default to using it for all three functions. If not, then default to using local scope.

If an info_key was provided, then it takes preference. We always follow the user's direction - this change only impacts the scope ordering if the user -doesn't- tell us the order to use.

This commit was SVN r19146.
2008-08-04 16:43:12 +00:00
Jeff Squyres
b83ee7d82a * Fix a problem with VPATH builds if the destination directory didn't
already exist  
 * s/top_srcdir/top_builddir/ in a bunch of places; left over from the
   previous man page generation system

This commit was SVN r19141.
2008-08-04 15:17:50 +00:00
Jeff Squyres
8d5bcf9257 Fix a bunch of double quote issues
This commit was SVN r19140.
2008-08-04 15:13:29 +00:00
Edgar Gabriel
1adb3a6cda Fixes trac:1408
The optimization that was introduced a year ago for saving a collective
synchronization  step for certain communicator creation functions has to be
disabled for now. The bug has been exposed by the hierarch module, but could
appear as well for inter-communicator creations. The problem is, that within a
communicator creation step we invoke a comm_dup (for intercomm_create) or
other collective operations (in case of hierarch) before all processes have
been synchronized. This lead to the "Dropped message for non-existant
communicators" error. This commit disables the optimization without removing
it from the code base. In theory, it can be enabled again as soon as we have
the unexpected message queues for unknown cid's, which were required if I
remember right anyway for the multi-threaded scenarios and potentially for
fault tolerance.

Before moving the patch to 1.3 I would like to let it soak for a couple of
days on trunk. Please note, taht my 2nd comment on ticket #1408 was
semi-correct, since the order of activation of the communicator and quering
the collective module have already been changed earlier.

This commit was SVN r19139.

The following Trac tickets were found above:
  Ticket 1408 --> https://svn.open-mpi.org/trac/ompi/ticket/1408
2008-08-04 14:55:09 +00:00
Rainer Keller
4712a73db5 - Help the compiler, by noting that errors are unlikely.
This commit was SVN r19138.
2008-08-04 14:50:27 +00:00
Jeff Squyres
35f721a706 Suggestion from Ralf W. to clean up sub-make's properly.
This commit was SVN r19136.
2008-08-04 14:35:40 +00:00
Rainer Keller
0d08866786 - Declare functions in lex-files as extern "C" {} to get
rid of warnings.

This commit was SVN r19132.
2008-08-04 11:49:01 +00:00
Ralph Castain
fdde3de903 Combination of some changes by both Jeff and I. Few minor cleanups to the code (e.g., allow options to show-mca-params to be either case), and an enhancement that allows the user to specify multiple options separated by commas (e.g., "env,api").
This commit was SVN r19124.
2008-08-02 00:43:27 +00:00
Dan Lacher
9175da1e02 Putback for all changes to automate man page updates to strings of
versions, dates and build names.

Fixes trac:1387

Big thanks to Jeff and Brian for help and oversight.

This commit was SVN r19120.

The following Trac tickets were found above:
  Ticket 1387 --> https://svn.open-mpi.org/trac/ompi/ticket/1387
2008-08-01 21:14:37 +00:00
Jeff Squyres
4bdc093746 Fixes trac:1361: mainly add new internal MCA parameter that orterun will
set when it launches under debuggers using the --debug option.

This commit was SVN r19116.

The following Trac tickets were found above:
  Ticket 1361 --> https://svn.open-mpi.org/trac/ompi/ticket/1361
2008-07-31 22:11:46 +00:00
Jeff Squyres
b45d59ea2e Adjust API usage for new parameter in mca_base_param_lookup_source()
This commit was SVN r19115.
2008-07-31 21:56:20 +00:00
Ralph Castain
164c1ebba7 Ensure output of new source dat is in the parseable output of ompi_info too
This commit was SVN r19112.
2008-07-31 20:35:42 +00:00
Ralph Castain
f7d1c2d229 Extend the mca param display capability to allow independent output of the params based on where they were last set (default, enviro, file, or API), and to out
put the name of the file that set them if they were set by file. This is of great assistance to support personnel trying to understand why a user is having pro
blems.

Coordinated with Jeff.

This commit was SVN r19111.
2008-07-31 20:00:45 +00:00
Jeff Squyres
5ac6a4387c Fix MPI_CART_GET to take an array of logicals for the periods argument
(not integers)

This commit was SVN r19099.
2008-07-30 20:29:23 +00:00
George Bosilca
7f01be2830 Remove useless defines. The MCA was bumped to 2.0, there is no reason to keep
these defines around.

This commit was SVN r19091.
2008-07-30 10:40:18 +00:00
Jeff Squyres
fc7c58ede6 Missed updating the topo base check to look for v2.0.0, causing all
topology-related MPI tests to fail.

This commit was SVN r19088.
2008-07-30 00:50:42 +00:00
Donald Kerr
2899f64146 moving vendor_id info to top of file
This commit was SVN r19087.
2008-07-29 22:33:17 +00:00