Edgar Gabriel
c0bd8728fd
io/ompio: move aggregator selection code to a separate file
...
- move all functions related to aggregator selection to a single file
- perform code cleanup fixing many Coverty complains along the way.
2016-08-01 14:04:27 -05:00
Edgar Gabriel
160d9a78c1
Merge pull request #1886 from edgargabriel/pr/ompio-reorg
...
io/ompio: move io/ompio functionality to common/ompio
2016-07-29 12:24:21 -05:00
Edgar Gabriel
b0fa1fd2a1
move the internal file_open/close functions to common/ompio
2016-07-21 13:08:32 -05:00
Edgar Gabriel
ccf76b7791
moving the internal read/write functions to common/ompio
...
and update all fs/fcoll/sharedfp components to use these functions.
2016-07-21 13:08:32 -05:00
Edgar Gabriel
688710d408
make common/ompio compile
2016-07-21 13:08:32 -05:00
Edgar Gabriel
39ae93b87b
modify the fcoll components to use the common/ompio print queues
2016-07-21 13:08:32 -05:00
Edgar Gabriel
fe17410943
next step in making the print_queue functionality move to common/ompio
2016-07-21 13:08:32 -05:00
Edgar Gabriel
af67c8f239
first cut on moving some ompio functionality to common/ompio
2016-07-21 13:08:32 -05:00
Edgar Gabriel
a899c0fb38
fcoll/static: fix coverty warnings
...
fix coverty warnings CID 72144, CID 710677, CID 1364164
2016-07-21 13:08:15 -05:00
Edgar Gabriel
195ec89732
fcoll/base: mv coll_array functionis to fcoll base
...
the coll_array functions are truly only used by the fcoll modules, so move
them to fcoll/base. There is currently one exception to that rule (number of aggreagtors
logic), but that function will be moved in a long term also to fcoll/base.
2016-07-14 08:41:14 -05:00
Edgar Gabriel
1f1504ebbb
remove some unused code
2016-07-14 08:41:14 -05:00
Edgar Gabriel
3dd81e9e09
io/ompio: fix the request in case of a zero size write/read operation
2016-07-08 14:11:22 -05:00
Edgar Gabriel
1ddfd6cdca
io/ompio: fix the preallocate function
...
handle preallocating sizes less than the current file size correctly.
2016-06-14 10:50:32 -05:00
Edgar Gabriel
d6af5444a6
fix the get_byte_offset code
2016-06-03 11:36:53 -05:00
George Bosilca
50cec456fb
ompi_request_complete with signal
...
Rewrite the ompi_request_complete function to take in account the
with_signal argument. Change the comment to explain the expected
behavior.
Alter all the ompi_request_complete uses to make sure the status of the
request is set before calling ompi_request_complete.
bot🏷️ enhancement
2016-06-02 11:49:12 +09:00
bosilca
b90c83840f
Refactor the request completion ( #1422 )
...
* Remodel the request.
Added the wait sync primitive and integrate it into the PML and MTL
infrastructure. The multi-threaded requests are now significantly
less heavy and less noisy (only the threads associated with completed
requests are signaled).
* Fix the condition to release the request.
2016-05-24 18:20:51 -05:00
Edgar Gabriel
e65e189671
io/ompio: fix file size after file_preallocate
...
Thanks for @dalcini for reporting
Fixes open-mpi/ompi#1633
2016-05-06 08:20:59 -05:00
Edgar Gabriel
d358965134
io/ompio: fix envelope of datatype returned by getview
...
Thanks for @dalcini for reporting
Fixes open-mpi/ompi#1632
2016-05-06 08:19:48 -05:00
Jeff Squyres
f167be1c91
ompio: always return valid info from FILE_GET_INFO
...
MPI-3.1 says that even if no info keys are set on the file, we need to
return a new, empty info.
Thanks to Lisandro Dalcin for identifying the issue.
Fixes open-mpi/ompi#1630
Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
2016-05-05 12:03:29 -07:00
Edgar Gabriel
4bbb22bd0b
add a new field to the ompio data structure (stripe_count) and set it correctly on pvfs2 and lustre.
2016-01-17 09:48:49 -06:00
rhc54
aa17bdf6e8
Merge pull request #1239 from rhc54/topic/cleanup
...
Cleanup the warnings from the ompi layer when compiling optimized under Mac OSX
2015-12-21 07:23:31 -08:00
Edgar Gabriel
46c20a1246
correctly set all variables storing information on the file pointer position to zero when setting the file view
2015-12-21 09:41:39 +09:00
Ralph Castain
ac6289dca6
Cleanup the warnings from the ompi layer when compiling optimized under Mac OSX
...
Cleanup per George's comments
2015-12-17 17:39:15 -08:00
Gilles Gouaillardet
59a361b781
ompio: correctly handle zero f_cc_size in mca_io_ompio_simple_grouping
2015-12-08 17:00:11 +09:00
Edgar Gabriel
9e5ade4e8b
argh, a debugging sleep statement got into the source code.
2015-11-16 13:26:57 -06:00
Edgar Gabriel
dbfbcdecd5
make adjustments for the default settings of grouping parameters and the default contiguous group size option.
...
minor bug fix in the simple grouping strategy.
2015-11-16 08:17:27 -06:00
Edgar Gabriel
27628774c7
add a new option for a simple aggregator selection which has zero communication costs.
2015-11-16 08:17:26 -06:00
Edgar Gabriel
66c1ea5fcb
change the default value of the grouping option. Also add new grouping option which skips the refinement step in the aggregator selection.
2015-11-16 08:17:23 -06:00
Edgar Gabriel
e8e117503d
reduce the communication volume during MPI_File_set_view
2015-11-16 08:17:22 -06:00
Edgar Gabriel
f97655f28e
make sure the iov buffer is initialized to zero, otherwise bad things can happen for 0-byte contributions on a process.
2015-10-15 12:46:01 -05:00
Edgar Gabriel
3734a38370
this file should have been part of the previous commit. for removeing io_ompio_nbc.[ch]
2015-09-18 09:28:25 -05:00
Edgar Gabriel
cf46a6bd4d
remove the io_ompio_nbc.[ch] files, they are not used anymore at this point in time.
2015-09-18 09:26:25 -05:00
Gilles Gouaillardet
fe351f6801
io: do not cast way the const modifier when this is not necessary
...
update the io framework and mpi c bindings
2015-09-09 09:18:58 +09:00
Nathan Hjelm
f451876058
Merge pull request #825 from hjelmn/white_space_purge
...
periodic trailing whitespace purge
2015-08-25 19:23:52 -06:00
Edgar Gabriel
70078175ee
fix coverty warning 72107
2015-08-25 09:23:37 -05:00
Edgar Gabriel
a73f9470e0
fix coverty warning 1269829
2015-08-25 09:22:48 -05:00
Nathan Hjelm
156ce6af21
periodic whitespace purge
...
Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2015-08-24 09:32:33 -06:00
Edgar Gabriel
b0461f8d3c
the back pointer from the ompio_file structure to the ompi_file_t structure
...
has to be set earlier in case the user disables the lazy_open option.
2015-08-19 17:11:42 -05:00
Edgar Gabriel
7e370948c1
first cut on the fileview for shared filepointers fix.
2015-08-19 17:11:42 -05:00
Edgar Gabriel
072b18e197
Code cleanup for the time breakdown feature in ompio/fcoll
...
- make the internal structure follow the Open MPI naming convention
- provide a single flag/macro which controls the compilation/utilization of this
feature, to avoid that somebody using this has to modify every single
fcoll component. A configure option could be added later if desired.
2015-08-14 08:53:04 -05:00
Edgar Gabriel
4bfc6ae798
Performance tuning: incorporate the usage of non-blocking operations in our array group-communication operations.
2015-08-13 20:05:18 -05:00
Edgar Gabriel
0aa3049bfc
Performance tuning: change the default behavior of ompio to *not* segment individual read/write operations.
...
In most cases, performance seems to be better if not segmented.
2015-08-07 13:06:39 -05:00
Edgar Gabriel
db5af26de7
Performance tuning. make sure we catch if the user wants to set the default fileview and replace it with our optimized default file view. Otherwise, performance will suffer. file_get_view should still return the correct filetype, not our optimized default file view. This is the correct version compared to ffa67b96933acafb3cfacf39a074d3dc1fe134ae, which unfortunately broke
...
some test cases in mpi_test_suite. Thanks for @ggouaillardet for reporting this!
2015-08-07 12:49:58 -05:00
Edgar Gabriel
6f6c01ee8d
free the datatypes that were created using type_dup during file_set_view
2015-08-07 11:50:25 -05:00
Edgar Gabriel
1ae4f8c7e6
Revert "Performance tuning. make sure we catch if the user wants to set the default fileview and replace it with"
...
This reverts commit ffa67b96933acafb3cfacf39a074d3dc1fe134ae.
2015-08-07 09:53:07 -05:00
Edgar Gabriel
ffa67b9693
Performance tuning. make sure we catch if the user wants to set the default fileview and replace it with
...
our optimized default file view. Otherwise, performance will suffer. file_get_view should still return the correct filetype, not our optimized default file view
2015-07-30 19:15:00 -05:00
Edgar Gabriel
9b2a7e41f0
make sure the final number of aggregators is recorded correctly when not using
...
our aggregator selection logic.
2015-07-30 17:24:01 -05:00
Edgar Gabriel
824d488709
- make the split collective shared file pointer operations work
...
- minor code restructering in io/ompio required for that.
2015-07-28 09:05:05 -05:00
Edgar Gabriel
e380f8c235
- fix the delete priority of the ompio component
...
- some application use MPI_File_delete as a collective function (e.g. IOR), which I think is not really covered by the standard. Right now, one process succeeds and theother ones return an error code. Fix that by not returning no error if the file that we try to delete does not exist anymore, to make these applications work.
2015-07-27 15:53:40 -05:00
Edgar Gabriel
3fb0614566
mark the request as ACTIVE
2015-07-27 12:43:45 -05:00