1
1

6470 Коммитов

Автор SHA1 Сообщение Дата
George Bosilca
2d33c9ee39 Stop complaining about an overwritten default parameter.
This commit was SVN r28322.
2013-04-10 19:44:37 +00:00
Jeff Squyres
8405975bf6 Be a little more conservative about initializing devices and modules
(i.e., ensure that more data items get zeroed out/set to NULL) so that
if something goes wrong during initialization, we don't try to clean
up something that isn't there (and segv).

The chance of this happening on the trunk is very low (and will also
be low once the verbs improvements are brought over to v1.7).  But it
can actually happen in the v1.6 branch (e.g., if no CPC is available,
we'll try to get the length of the endpoints list, but the endpoints
list is NULL).  

Hence, even though the real goal is to get this functionality over to
v1.6, I figured I'd commit to the trunk/CMR to v1.7 just to try to
keep commonality in the openib between all three where possible.

This commit was SVN r28317.
2013-04-09 21:55:31 +00:00
Jeff Squyres
975ff4675e rc was used before it was initialized. Looks like this minor bug was
introduced in r28241.

This commit was SVN r28316.

The following SVN revision numbers were found above:
  r28241 --> open-mpi/ompi@9d4a26f47d
2013-04-09 21:49:15 +00:00
Ralph Castain
45af6cf59e The move of the orte_db framework to opal required that we create an opaque opal_identifier_t type as OPAL cannot know anything about the ORTE process name. However, passing a value down to opal and then having the db components reference it causes alignment issues on Solaris Sparc platforms. So pass the pointer instead and do the old "memcpy" trick to avoid the problem.
This commit was SVN r28308.
2013-04-08 23:34:16 +00:00
Nathan Hjelm
4e95d691a7 pml/ob1: do not reset the convertor if one was not created (size = 0).
This macro is only used on the failure path so the additional if statement
should not have any affect on performance.

cmr:v1.7

This commit was SVN r28292.
2013-04-05 01:40:11 +00:00
Pavel Shamis
fed6e60131 Fixing OpenIB BTL compilation failure for a cases when
BTL_OPENIB_MALLOC_HOOKS_ENABLED is disabled.

This commit was SVN r28290.
2013-04-04 20:17:18 +00:00
Pavel Shamis
aa1f5697b4 In order to prevent name conflicts in XRC (MOFED) enabled mode
OFACM's ib_address_t was renamed to ofacm_ib_address_t

This commit was SVN r28289.
2013-04-04 20:02:17 +00:00
Matthias Jurenz
90dc8cc191 Fixed Coverity CID 993726 (Use after free)
This commit was SVN r28287.
2013-04-04 06:57:00 +00:00
Nathan Hjelm
e8d9944456 sbgp/ibnet: fix param -> var update errors
This commit was SVN r28284.
2013-04-03 20:17:18 +00:00
Nathan Hjelm
75093155ab bcol/iboffload: fix still more errors from param -> var updates
This commit was SVN r28283.
2013-04-03 19:57:03 +00:00
Nathan Hjelm
47a1897710 bcol/iboffload: fix more errors from param -> var updates
This commit was SVN r28281.
2013-04-03 18:55:46 +00:00
Nathan Hjelm
31a498c2a1 bcol/iboffload: fix errors from param -> var updates
This commit was SVN r28280.
2013-04-03 18:33:19 +00:00
Ralph Castain
66f3a81488 Cleanup warnings found when building v1.7
cmr:v1.7

This commit was SVN r28279.
2013-04-03 17:37:02 +00:00
Vishwanath Venkatesan
74c418b860 Adding typecasting with intptr_t to remove warnings.
This commit was SVN r28278.
2013-04-03 17:07:43 +00:00
Vishwanath Venkatesan
784337aab1 typecasting with intptr_t to remove warnings
This commit was SVN r28276.
2013-04-03 17:06:02 +00:00
Matthias Jurenz
5c56f6f857 Fixed compiler warnings
This commit was SVN r28275.
2013-04-03 11:38:19 +00:00
Matthias Jurenz
b95ae12f43 Changes to VT/configure:
- Introduced configure option '--enable-fmpi'. If configuring Open MPI w/o Fortran bindings (--disable-mpi-f77/--disable-mpi-fortran), then this option (i.e. --disable-fmpi) will be implicitly passed to the VT configure to disable MPI Fortran support.

This commit was SVN r28260.
2013-03-28 15:53:03 +00:00
Jeff Squyres
64d39a4e97 Technically speaking, we're creating a QP with 1 send WQE and 1
receive WQE, so it's good form to have a CQ with 2 entries, not 1.

This commit was SVN r28256.
2013-03-28 13:11:31 +00:00
George Bosilca
9c6374b515 Swap the open and register.
This commit was SVN r28253.
2013-03-27 22:19:57 +00:00
Nathan Hjelm
f1fa290157 btl/vader: add missing return statement
This commit was SVN r28252.
2013-03-27 22:16:21 +00:00
Nathan Hjelm
113fadd749 btl/vader: do not use common/sm for shared memory fragments
This commit was SVN r28250.
2013-03-27 22:10:02 +00:00
Nathan Hjelm
17315bf360 Now that the entire codebase has been updated to use the MCA framework
system remove the last calls to the MCA parameter system.

This commit was SVN r28242.
2013-03-27 21:17:53 +00:00
Nathan Hjelm
9d4a26f47d Update OMPI frameworks to use the MCA framework system.
Notes:
  - This commit also eliminates the need for an available components list in use
    in several frameworks. None of the code in question was making use of the
    priority field of the priority component list item so these extra lists were
    removed.
  - Cleaned up selection code in several frameworks to sort lists using opal_list_sort.
  - Cleans up the ompi/orte-info functions. Expose the functions that construct the
    list of params so they can be used elsewhere.

patches for mtl/portals4 from brian

missed a few output variables in openib

This commit was SVN r28241.
2013-03-27 21:17:31 +00:00
Nathan Hjelm
c041156f60 Update ORTE frameworks to use the MCA framework system.
This commit was SVN r28240.
2013-03-27 21:14:43 +00:00
Nathan Hjelm
c3b67d0187 Automatically generate a list of installed frameworks in project/include/project/frameworks.h
This commit was SVN r28238.
2013-03-27 21:10:32 +00:00
Nathan Hjelm
cf377db823 MCA/base: Add new MCA variable system
Features:
 - Support for an override parameter file (openmpi-mca-param-override.conf).
   Variable values in this file can not be overridden by any file or environment
   value.
 - Support for boolean, unsigned, and unsigned long long variables.
 - Support for true/false values.
 - Support for enumerations on integer variables.
 - Support for MPIT scope, verbosity, and binding.
 - Support for command line source.
 - Support for setting variable source via the environment using
   OMPI_MCA_SOURCE_<var name>=source (either command or file:filename)
 - Cleaner API.
 - Support for variable groups (equivalent to MPIT categories).

Notes:
 - Variables must be created with a backing store (char **, int *, or bool *)
   that must live at least as long as the variable.
 - Creating a variable with the MCA_BASE_VAR_FLAG_SETTABLE enables the use of
   mca_base_var_set_value() to change the value.
 - String values are duplicated when the variable is registered. It is up to
   the caller to free the original value if necessary. The new value will be
   freed by the mca_base_var system and must not be freed by the user.
 - Variables with constant scope may not be settable.
 - Variable groups (and all associated variables) are deregistered when the
   component is closed or the component repository item is freed. This
   prevents a segmentation fault from accessing a variable after its component
   is unloaded.
 - After some discussion we decided we should remove the automatic registration
   of component priority variables. Few component actually made use of this
   feature.
 - The enumerator interface was updated to be general enough to handle
   future uses of the interface.
 - The code to generate ompi_info output has been moved into the MCA variable
   system. See mca_base_var_dump().

opal: update core and components to mca_base_var system
orte: update core and components to mca_base_var system
ompi: update core and components to mca_base_var system

This commit also modifies the rmaps framework. The following variables were
moved from ppr and lama: rmaps_base_pernode, rmaps_base_n_pernode,
rmaps_base_n_persocket. Both lama and ppr create synonyms for these variables.

This commit was SVN r28236.
2013-03-27 21:09:41 +00:00
Matthias Jurenz
4134d3be74 Changes to OTF:
- fixed Coverity CIDs: 72269, 743285, 743294, 743295, 993125

This commit was SVN r28231.
2013-03-27 13:37:22 +00:00
Matthias Jurenz
00fd159d02 Changes to VT:
- configure:
		- fixed passing FCFLAGS to the Fortran compiler when building libvt-fmpi
		- temporary disabled memory allocation tracing for multi-threaded applications (introduced in v5.14.1) due to broken counter values when memory is freed in a different thread than where it was allocated
		- do not build the unification library when building with HP/Platform MPI (needs linking libmpiCC, even if the C++ MPI interface isn't used)
		- removed 'libfmpi' from list of MPI Fortran libraries to be searched (causes that 'libvt-fmpi' will be built when configuring for HP/Platform MPI)
		- do not build the MPI Fortran library 'libvt-fmpi' when building VT inside Open MPI
	- Java tracing:
		- minor performance improvment: call vt_java_check_error (now vt_java_error) only if a JVMTI function returns an error

This commit was SVN r28228.
2013-03-27 10:04:33 +00:00
Jeff Squyres
cfd023bcda Ensure that MPI_LASTUSEDCODE is always >= MPI_ERR_LASTCODE. Thanks to
Dimitry Dontsov for reporting the issue and providing a patch.

This commit was SVN r28225.
2013-03-27 01:32:27 +00:00
Ralph Castain
317915225c Finish the binding cleanup by removing the no-longer-used binding level scheme. This proved to be fallible as there is no guarantee that the hierarchy it used matched physical reality of the machine (e.g., is L3 "above" the socket or not). Still have to complete the ppr update, but get the rest of it correct.
This commit was SVN r28223.
2013-03-26 20:09:49 +00:00
Jeff Squyres
44e371a65d Remove (bogus) port number from the opal_output -- there's no port
number associated with creating a QP.

This commit was SVN r28222.
2013-03-26 19:48:50 +00:00
Nathan Hjelm
36b940b685 ompi/include: Remove Makefile.include which is a duplicate of Makefile.am. This will make ompi consistent with opal and orte.
This commit was SVN r28220.
2013-03-26 18:44:01 +00:00
George Bosilca
1c281a224c Cleanup the communicator cid allocation function. The value of the old_com
that has been temporarily stored in the communicator_array should be removed
or the finalization will segfault (the same communicator will be released
twice).

This commit was SVN r28214.
2013-03-26 14:45:21 +00:00
George Bosilca
a856f926de Remove a bunch of unused variables.
This commit was SVN r28213.
2013-03-26 14:34:29 +00:00
George Bosilca
ab2ae0835a Only free the opal_byte_object_t if the fetch operation was succesful.
This commit was SVN r28208.
2013-03-25 00:36:57 +00:00
Brian Barrett
6c3f986d79 * Fix issue with duplicate symbol for the initialize hook due to it existing in both libmpi and libopen-pal by removing the one for libopen-pal. This won't work if we eventually need registration caching in opal/orte, but I'm hoping that by that point, OFED will have gotten off its butt and properly integrated ummunotify into the verbs layer so that this code can go away.
At the same time, fix a minor issue where the init hook was being called twice, once by the libc malloc and once by our malloc by removing the call from our malloc.

This commit was SVN r28202.
2013-03-21 23:05:54 +00:00
Matthias Jurenz
4fbc105b83 Changes to OTF:
- fixed even more Coverity warnings

This commit was SVN r28198.
2013-03-21 12:55:41 +00:00
Matthias Jurenz
7d4be1cb81 Changes to OTF:
- general: Fixed several Coverity warnings
	- otfprofile: Do not show helptext if '-V' given
	- otfinfo: Fixed counting of collective operations and markers

This commit was SVN r28195.
2013-03-21 11:25:05 +00:00
Vishwanath Venkatesan
e092cc34e0 Fixing the read all bugs discovered by Coverity
This commit was SVN r28189.
2013-03-20 20:27:09 +00:00
Matthias Jurenz
cf926da7e1 Changes to VT:
- configure: VPATH building: Moved adding of -I$top_srcdir to CPPFLAGS to the end of configure to prevent using this flags for configure checks
	- VT libs: Fixed potential segmentation fault (infinite recursion) when writing intermediate statistics (VT_STAT_INTV != 0)
	- vtunify: Fixed header include to disable OpenMP in the library version of vtunify (libvt-mpi-unify)
	- fixed several Coverity warnings

This commit was SVN r28187.
2013-03-20 15:22:21 +00:00
Samuel Gutierrez
8ce2041102 Cleanup in error path. Fixes CID 967211. Thanks, Jeff.
This commit was SVN r28183.
2013-03-19 20:00:08 +00:00
Jeff Squyres
2513122d31 Remove extraneous semicolon.
This commit was SVN r28180.
2013-03-18 23:58:11 +00:00
Jeff Squyres
7ac02fb9d4 Two fixes for the ROMIO io module:
* Don't call PMPI_* anything from our module code; that's terribly
   bad form (and disallowed!).  Instead, do the proper back-end stuff
   to reset the error handler on the file handle.
 * If we've already started to MPI_Finalize, then just give up and
   don't actually perform all the file closing actions (because
   ROMIO's file close calls MPI_Barrier, which will obviously fail if
   MPI_Finalize has already been invoked).  Bad user behavior should
   be punished (by leaking resources, not closing the file properly,
   etc.).

This commit was SVN r28177.
2013-03-18 20:11:20 +00:00
Jeff Squyres
447280b585 Fix Coverity CID 971095: minor memory leak
This commit was SVN r28170.
2013-03-15 15:04:35 +00:00
Brian Barrett
fc2b3b8d46 Ugh. Work around an issue with memory hooks and the change from one big
library to multiple libraries that are implicitly sucked into the executable
as a dependency of libmpi.  The initialize hook isn't visible to libc on some
linux distributions when it's in libopal and libopal isn't explicity linked
into the executable.  The fix is to have a duplicate initialize hook in
libmpi as well as libopal.  *sigh*.

This commit was SVN r28164.
2013-03-11 19:22:24 +00:00
Vasily Filipov
7bda23dd84 SBGP, BCOL: add missing "show_help.h" includes.
This commit was SVN r28163.
2013-03-10 09:11:09 +00:00
Matthias Jurenz
8094a57dc7 Changes to OTF:
- general:
		- incremented version number to 1.12.3
		- updated copyright information (2012->2013)
		- fixed compiler warnings occurred when NDEBUG is defined (--with-platform=optimized)
	- otfprofile, LaTeX output:
		- swapped x & y axis of the Message Data Rate Matrix
		- adapted labels to Vampir

Changes to VT:
	- general:
		- incremented version number to 5.14.3
		- updated copyright information (2012->2013)
		- fixed compiler warnings occurred when NDEBUG is defined (--with-platform=optimized)
	- configure / build system:
		- do not search for the MPI lib. when an MPI compiler wrapper was found (prevents double linkage of the MPI lib. when building vtunify-mpi and vtfilter-mpi)
		- prepend cross-prefix to the compiler wrappers *only* if '--with-cross-prefix[=PREFIX]' is given
		- removed unnecessary sources from libvt-java
	- VT libs:
		- extended inoffical API for manual region tracing: allow specifying a group name
		- plugin counters: Merge a set of post-mortem counters and write them under a single async key. This speeds up the unification.
		- Java tracing:
			- removed multiple asking for the current thread id when recording method enter/leave events
			- replaced hash function (id % prime) by Jenking's recommended one ( id & (hash_table_size-1) )
	- vtdyn: Do not instrument regions where inserting instrumentation would requires using a trap
	- vtsetup: Fixed availability state of the exec tracing feature

This commit was SVN r28162.
2013-03-08 13:50:26 +00:00
Brian Barrett
65109de931 Fix leak of comm and datatype references for mprobe/improbe and fix a request leak in improbe
This commit was SVN r28157.
2013-03-07 21:55:22 +00:00
Jeff Squyres
d9fed36793 This destruction logic was flat-out wrong. Harmless, but wrong.
Replace it with something much smaller and simpler.

This commit was SVN r28154.
2013-03-07 20:37:33 +00:00
Brian Barrett
db858827df Fill in more of the process info structure when using PMI
This commit was SVN r28152.
2013-03-06 19:32:47 +00:00