Add some error output to the plm rsh

This commit was SVN r19532.

orte/mca/plm/rsh/help-plm-rsh.txt

@@ -64,3 +64,14 @@ remove the debug-daemons flag.
 The user (%d) is unknown to the system (i.e. there is no corresponding
 entry in the password file). Please contact your system administrator
 for a fix.
+#
+[cannot-resolve-shell-with-prefix]
+The rsh launcher has been given a prefix to use, but could not determine
+the type of remote shell being used on the remote node. This is a fatal
+error as we cannot determine how to construct the cmd line to set your
+remote LD_LIBRARY_PATH and PATH environmental variables.
+
+The prefix we were given are:
+
+opal_prefix: %s
+prefix_dir: %s

orte/mca/plm/rsh/plm_rsh_module.c

@@ -579,6 +579,11 @@ static int setup_launch(int *argcptr, char ***argvptr,
                       (orted_prefix != NULL ? orted_prefix : ""),
                       prefix_dir, bin_base,
                       orted_cmd);
+        } else {
+            orte_show_help("help-plm-rsh.txt", "cannot-resolve-shell-with-prefix", true,
+                           (NULL == opal_prefix) ? "NULL" : opal_prefix,
+                           prefix_dir);
+            return ORTE_ERR_SILENT;
         }
     } else {
         /* no prefix directory, so just aggregate the result */

orte/runtime/data_type_support/orte_dt_print_fns.c

@@ -297,7 +297,7 @@ int orte_dt_print_node(char **output, char *prefix, orte_node_t *src, opal_data_
     }
     
     asprintf(&tmp, "\n%sData for node: Name: %s\t%s\tLaunch id: %ld\tArch: %0x\tState: %0x",
-             pfx2, src->name,
+             pfx2, (NULL == src->name) ? "UNKNOWN" : src->name,
              pfx2, (long)src->launch_id,
              src->arch, src->state);