Add a comment to clarify the relationship between
mca_base_cmd_line_process_args() and opal_init_util() so we do not forget their ordering needs, and subtle relationship. This commit was SVN r15412.
Этот коммит содержится в:
родитель
3bb6ca6a3d
Коммит
eeba2cb871
@ -251,6 +251,17 @@ int orte_daemon(int argc, char *argv[])
|
||||
mca_base_cmd_line_process_args(cmd_line, &environ, &environ);
|
||||
|
||||
/* Ensure that enough of OPAL is setup for us to be able to run */
|
||||
/*
|
||||
* NOTE: (JJH)
|
||||
* We need to allow 'mca_base_cmd_line_process_args()' to process command
|
||||
* line arguments *before* calling opal_init_util() since the command
|
||||
* line could contain MCA parameters that affect the way opal_init_util()
|
||||
* functions. AMCA parameters are one such option normally received on the
|
||||
* command line that affect the way opal_init_util() behaves.
|
||||
* It is "safe" to call mca_base_cmd_line_process_args() before
|
||||
* opal_init_util() since mca_base_cmd_line_process_args() does *not*
|
||||
* depend upon opal_init_util() functionality.
|
||||
*/
|
||||
if (OPAL_SUCCESS != opal_init_util()) {
|
||||
fprintf(stderr, "OPAL failed to initialize -- orted aborting\n");
|
||||
exit(1);
|
||||
|
@ -333,6 +333,17 @@ int orterun(int argc, char *argv[])
|
||||
}
|
||||
|
||||
/* Need to initialize OPAL so that install_dirs are filled in */
|
||||
/*
|
||||
* NOTE: (JJH)
|
||||
* We need to allow 'mca_base_cmd_line_process_args()' to process command
|
||||
* line arguments *before* calling opal_init_util() since the command
|
||||
* line could contain MCA parameters that affect the way opal_init_util()
|
||||
* functions. AMCA parameters are one such option normally received on the
|
||||
* command line that affect the way opal_init_util() behaves.
|
||||
* It is "safe" to call mca_base_cmd_line_process_args() before
|
||||
* opal_init_util() since mca_base_cmd_line_process_args() does *not*
|
||||
* depend upon opal_init_util() functionality.
|
||||
*/
|
||||
opal_init_util();
|
||||
|
||||
/* save the environment for launch purposes */
|
||||
|
Загрузка…
x
Ссылка в новой задаче
Block a user