Ticket: #673

Submitted by: Dan Lacher

This commit was SVN r12844.

ompi/mpi/c/type_create_f90_complex.c

@@ -9,6 +9,7 @@
  *                         University of Stuttgart.  All rights reserved.
  * Copyright (c) 2004-2005 The Regents of the University of California.
  *                         All rights reserved.
+ * Copyright (c) 2006      Sun Microsystems, Inc.  All rights reserved.
  * $COPYRIGHT$
  * 
  * Additional copyrights may follow
@@ -37,9 +38,13 @@ int MPI_Type_create_f90_complex(int p, int r, MPI_Datatype *newtype)
 {
     if (MPI_PARAM_CHECK) {
         OMPI_ERR_INIT_FINALIZE(FUNC_NAME);
-        if ((MPI_UNDEFINED == p && MPI_UNDEFINED == r) ||
-            (p < 0 && MPI_UNDEFINED != p) ||
-            (r < 0 && MPI_UNDEFINED != r)) {
+
+        /* Note: These functions accept negative integers for the p and r
+         * arguments.  This is because for the SELECTED_COMPLEX_KIND,
+         * negative numbers are equivalent to zero values.  See section
+         * 13.14.95 of the Fortran 95 standard. */
+
+        if ((MPI_UNDEFINED == p && MPI_UNDEFINED == r)) {
             return OMPI_ERRHANDLER_INVOKE(MPI_COMM_WORLD, MPI_ERR_ARG, FUNC_NAME);
         }
     }

ompi/mpi/c/type_create_f90_integer.c

@@ -9,6 +9,7 @@
  *                         University of Stuttgart.  All rights reserved.
  * Copyright (c) 2004-2005 The Regents of the University of California.
  *                         All rights reserved.
+ * Copyright (c) 2006      Sun Microsystems, Inc.  All rights reserved.
  * $COPYRIGHT$
  * 
  * Additional copyrights may follow
@@ -36,9 +37,12 @@ int MPI_Type_create_f90_integer(int r, MPI_Datatype *newtype)
 {
   if (MPI_PARAM_CHECK) {
     OMPI_ERR_INIT_FINALIZE(FUNC_NAME);
-    if (r < 0) {
-        return OMPI_ERRHANDLER_INVOKE(MPI_COMM_WORLD, MPI_ERR_ARG, FUNC_NAME);
-    }
+
+    /* Note: These functions accept negative integers for the p and r
+     * arguments.  This is because for the SELECTED_INTEGER_KIND,
+     * negative numbers are equivalent to zero values.  See section
+     * 13.14.95 of the Fortran 95 standard. */
+
   }
 
    if      (r > 38) *newtype = &ompi_mpi_datatype_null;

ompi/mpi/c/type_create_f90_real.c

@@ -9,6 +9,7 @@
  *                         University of Stuttgart.  All rights reserved.
  * Copyright (c) 2004-2005 The Regents of the University of California.
  *                         All rights reserved.
+ * Copyright (c) 2006      Sun Microsystems, Inc.  All rights reserved.
  * $COPYRIGHT$
  * 
  * Additional copyrights may follow
@@ -38,9 +39,13 @@ int MPI_Type_create_f90_real(int p, int r, MPI_Datatype *newtype)
 {
     if (MPI_PARAM_CHECK) {
         OMPI_ERR_INIT_FINALIZE(FUNC_NAME);
-        if ((MPI_UNDEFINED == p && MPI_UNDEFINED == r) ||
-            (p < 0 && MPI_UNDEFINED != p) ||
-            (r < 0 && MPI_UNDEFINED != r)) {
+
+        /* Note: These functions accept negative integers for the p and r
+         * arguments.  This is because for the SELECTED_REAL_KIND,
+         * negative numbers are equivalent to zero values.  See section
+         * 13.14.95 of the Fortran 95 standard. */
+
+        if ((MPI_UNDEFINED == p && MPI_UNDEFINED == r)) {
             return OMPI_ERRHANDLER_INVOKE(MPI_COMM_WORLD, MPI_ERR_ARG, FUNC_NAME);
         }
     }