1
1

usnic: fix Coverity false positives

Add some Coverity inline notation to tell Coverity that these
functions never return.

Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
Этот коммит содержится в:
Jeff Squyres 2019-05-14 13:53:25 -07:00
родитель 9442989e2c
Коммит df5f7afb14

Просмотреть файл

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2013-2017 Cisco Systems, Inc. All rights reserved * Copyright (c) 2013-2019 Cisco Systems, Inc. All rights reserved
* $COPYRIGHT$ * $COPYRIGHT$
* *
* Additional copyrights may follow * Additional copyrights may follow
@ -20,6 +20,10 @@
#include "btl_usnic_util.h" #include "btl_usnic_util.h"
// The following comment tells Coverity that this function does not return.
// See https://scan.coverity.com/tune.
/* coverity[+kill] */
void opal_btl_usnic_exit(opal_btl_usnic_module_t *module) void opal_btl_usnic_exit(opal_btl_usnic_module_t *module)
{ {
if (NULL == module) { if (NULL == module) {
@ -61,7 +65,14 @@ void opal_btl_usnic_exit(opal_btl_usnic_module_t *module)
/* /*
* Simple utility in a .c file, mainly so that inline functions in .h * Simple utility in a .c file, mainly so that inline functions in .h
* files don't need to include the show_help header file. * files don't need to include the show_help header file.
*
* The following comment tells Coverity that this function does not
* return. See https://scan.coverity.com/tune. Technically, we
* shouldn't need this, because opal_btl_usnic_exit() has the same
* annotation, but let's just help Coverity out.
*/ */
/* coverity[+kill] */
void opal_btl_usnic_util_abort(const char *msg, const char *file, int line) void opal_btl_usnic_util_abort(const char *msg, const char *file, int line)
{ {
opal_show_help("help-mpi-btl-usnic.txt", "internal error after init", opal_show_help("help-mpi-btl-usnic.txt", "internal error after init",