From d12db200892a29e15c7c378e6b8da6506faebefa Mon Sep 17 00:00:00 2001 From: Jeff Squyres Date: Wed, 29 Jul 2009 19:52:18 +0000 Subject: [PATCH] This function actually returns an int, not a bool (OPAL_SUCCESS or OPAL_ERROR). Also add a line to the docs describing that it's ok to pass in NULL for the source_file. This commit was SVN r21742. --- opal/mca/base/mca_base_param.c | 2 +- opal/mca/base/mca_base_param.h | 12 +++++++----- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/opal/mca/base/mca_base_param.c b/opal/mca/base/mca_base_param.c index f0609f5241..87b34585b2 100644 --- a/opal/mca/base/mca_base_param.c +++ b/opal/mca/base/mca_base_param.c @@ -557,7 +557,7 @@ int mca_base_param_set_string(int index, char *value) /* * Lookup the source of an MCA param's value */ -bool mca_base_param_lookup_source(int index, mca_base_param_source_t *source, char **source_file) +int mca_base_param_lookup_source(int index, mca_base_param_source_t *source, char **source_file) { mca_base_param_storage_t storage; diff --git a/opal/mca/base/mca_base_param.h b/opal/mca/base/mca_base_param.h index a992a99ac3..a65cc49755 100644 --- a/opal/mca/base/mca_base_param.h +++ b/opal/mca/base/mca_base_param.h @@ -527,8 +527,10 @@ extern "C" { * * @param index [in] Index of MCA parameter to set * @param source [out] Enum value indicating source - * @param source_file [out] If value came from source, name of the file - * that set it. The caller should not modify or free this string. + * @param source_file [out] If value came from source, name of the + * file that set it. The caller should not modify or free this + * string. It is permissable to specify source_file==NULL if the + * caller does not care to know the filename. * * @retval OPAL_ERROR If the parameter was not found. * @retval OPAL_SUCCESS Upon success. @@ -536,9 +538,9 @@ extern "C" { * This function looks up to see where the value of an MCA * parameter came from. */ - OPAL_DECLSPEC bool mca_base_param_lookup_source(int index, - mca_base_param_source_t *source, - char **source_file); + OPAL_DECLSPEC int mca_base_param_lookup_source(int index, + mca_base_param_source_t *source, + char **source_file); /** * Sets an "override" value for an integer MCA parameter.