Fix few COVERITY reported issues.

ompi/mca/coll/base/coll_base_allgatherv.c

@@ -3,7 +3,7 @@
  * Copyright (c) 2004-2005 The Trustees of Indiana University and Indiana
  *                         University Research and Technology
  *                         Corporation.  All rights reserved.
- * Copyright (c) 2004-2012 The University of Tennessee and The University
+ * Copyright (c) 2004-2015 The University of Tennessee and The University
  *                         of Tennessee Research Foundation.  All rights
  *                         reserved.
  * Copyright (c) 2004-2005 High Performance Computing Center Stuttgart,
@@ -200,7 +200,6 @@ int ompi_coll_base_allgatherv_intra_bruck(void *sbuf, int scount,
 
         ompi_datatype_destroy(&new_sdtype);
         ompi_datatype_destroy(&new_rdtype);
-
     }
 
     free(new_rcounts);
@@ -291,7 +290,6 @@ int ompi_coll_base_allgatherv_intra_ring(void *sbuf, int scount,
                                        recvfrom, MCA_COLL_BASE_TAG_ALLGATHERV,
                                        comm, MPI_STATUS_IGNORE, rank);
         if (MPI_SUCCESS != err) { line = __LINE__; goto err_hndl; }
-
     }
 
     return OMPI_SUCCESS;
@@ -632,7 +630,6 @@ ompi_coll_base_allgatherv_intra_basic_default(void *sbuf, int scount,
                                     rcounts[rank], send_type,rbuf,
                                     rcounts, disps, rdtype, 0,
                                     comm, comm->c_coll.coll_gatherv_module);
-    
     if (MPI_SUCCESS != err) {
         return err;
     }
@@ -668,4 +665,3 @@ ompi_coll_base_allgatherv_intra_basic_default(void *sbuf, int scount,
 }
 
 /* copied function (with appropriate renaming) ends here */
-

ompi/mca/coll/base/coll_base_gather.c

@@ -214,6 +214,7 @@ ompi_coll_base_gather_intra_linear_sync(void *sbuf, int scount,
                                          int first_segment_size)
 {
     int i, ret, line, rank, size, first_segment_count;
+    ompi_request_t **reqs = NULL;
     MPI_Aint extent, lb;
     size_t typelng;
     ompi_request_t **reqs = NULL;

ompi/mca/coll/base/coll_base_topo.c

@@ -2,7 +2,7 @@
  * Copyright (c) 2004-2005 The Trustees of Indiana University and Indiana
  *                         University Research and Technology
  *                         Corporation.  All rights reserved.
- * Copyright (c) 2004-2005 The University of Tennessee and The University
+ * Copyright (c) 2004-2015 The University of Tennessee and The University
  *                         of Tennessee Research Foundation.  All rights
  *                         reserved.
  * Copyright (c) 2004-2005 High Performance Computing Center Stuttgart,

ompi/mca/coll/tuned/coll_tuned_dynamic_file.c

@@ -96,6 +96,10 @@ int ompi_coll_tuned_read_rules_config_file (char *fname, ompi_coll_alg_rule_t**
 
     /* make space and init the algorithm rules for each of the n_collectives MPI collectives */
     alg_rules = ompi_coll_tuned_mk_alg_rules (n_collectives);
+    if (NULL == alg_rules) {
+        OPAL_OUTPUT((ompi_coll_tuned_stream,"cannot cannot allocate rules for file [%s]\n", fname));
+        goto on_file_error;
+    }
 
     if (NULL == alg_rules) {
         OPAL_OUTPUT((ompi_coll_tuned_stream,"cannot cannot allocate rules for file [%s]\n", fname));
@@ -126,10 +130,7 @@ int ompi_coll_tuned_read_rules_config_file (char *fname, ompi_coll_alg_rule_t**
 
         if (alg_rules[CI].alg_rule_id != CI) {
             OPAL_OUTPUT((ompi_coll_tuned_stream, "Internal error in handling collective ID %d\n", CI));
-            fclose(fptr);
-            ompi_coll_tuned_free_all_rules (alg_rules, n_collectives);
-            *rules = (ompi_coll_alg_rule_t*) NULL;
-            return (-4);
+            goto on_file_error;
         }
         OPAL_OUTPUT((ompi_coll_tuned_stream, "Reading dynamic rule for collective ID %d\n", CI));
         alg_p = &alg_rules[CI];