diff --git a/config/opal_check_pmi.m4 b/config/opal_check_pmi.m4 index 345115ad32..dfbdfdeed4 100644 --- a/config/opal_check_pmi.m4 +++ b/config/opal_check_pmi.m4 @@ -424,9 +424,11 @@ AC_DEFUN([OPAL_CHECK_PMIX],[ [Whether the external PMIx library is v1]) AM_CONDITIONAL([OPAL_WANT_PRUN], [test "$opal_prun_happy" = "yes"]) - AS_IF([test "$opal_external_pmix_version" = "1x"], - [OPAL_SUMMARY_ADD([[Miscellaneous]],[[PMIx support]], [opal_pmix], [1.2.x: WARNING - DYNAMIC OPS NOT SUPPORTED])], - [OPAL_SUMMARY_ADD([[Miscellaneous]],[[PMIx support]], [opal_pmix], [$opal_external_pmix_version])]) + AS_IF([test "$opal_external_pmix_happy" = "yes"], + [AS_IF([test "$opal_external_pmix_version" = "1x"], + [OPAL_SUMMARY_ADD([[Miscellaneous]],[[PMIx support]], [opal_pmix], [External (1.2.5) WARNING - DYNAMIC OPS NOT SUPPORTED])], + [OPAL_SUMMARY_ADD([[Miscellaneous]],[[PMIx support]], [opal_pmix], [External ($opal_external_pmix_version)])])], + [OPAL_SUMMARY_ADD([[Miscellaneous]], [[PMIx support]], [opal_pmix], [Internal])]) OPAL_VAR_SCOPE_POP ]) diff --git a/config/opal_config_subdir_args.m4 b/config/opal_config_subdir_args.m4 index 3b7a35580f..0d5f8febab 100644 --- a/config/opal_config_subdir_args.m4 +++ b/config/opal_config_subdir_args.m4 @@ -10,7 +10,7 @@ dnl Copyright (c) 2004-2005 High Performance Computing Center Stuttgart, dnl University of Stuttgart. All rights reserved. dnl Copyright (c) 2004-2005 The Regents of the University of California. dnl All rights reserved. -dnl Copyright (c) 2014-2015 Intel, Inc. All rights reserved. +dnl Copyright (c) 2014-2018 Intel, Inc. All rights reserved. dnl Copyright (c) 2015 Cisco Systems, Inc. All rights reserved. dnl $COPYRIGHT$ dnl @@ -60,6 +60,10 @@ do ;; -with-platform=* | --with-platform=*) ;; + --with*=internal) + ;; + --with*=external) + ;; *) case $subdir_arg in *\'*) subdir_arg=`echo "$subdir_arg" | sed "s/'/'\\\\\\\\''/g"` ;; diff --git a/opal/mca/pmix/ext2x/Makefile.am b/opal/mca/pmix/ext2x/Makefile.am index e527355843..194443d93a 100644 --- a/opal/mca/pmix/ext2x/Makefile.am +++ b/opal/mca/pmix/ext2x/Makefile.am @@ -1,5 +1,5 @@ # -# Copyright (c) 2014-2017 Intel, Inc. All rights reserved. +# Copyright (c) 2014-2018 Intel, Inc. All rights reserved. # Copyright (c) 2015 Cisco Systems, Inc. All rights reserved. # Copyright (c) 2015 Research Organization for Information Science # and Technology (RIST). All rights reserved. @@ -38,15 +38,15 @@ endif mcacomponentdir = $(opallibdir) mcacomponent_LTLIBRARIES = $(component_install) -mca_pmix_ext2x_la_SOURCES = $(sources) +mca_pmix_ext2x_la_SOURCES = $(sources) $(headers) mca_pmix_ext2x_la_CFLAGS = $(opal_pmix_ext2x_CFLAGS) -mca_pmix_ext2x_la_CPPFLAGS =$(opal_pmix_ext2x_CPPFLAGS) +mca_pmix_ext2x_la_CPPFLAGS = $(opal_pmix_ext2x_CPPFLAGS) mca_pmix_ext2x_la_LDFLAGS = -module -avoid-version $(opal_pmix_ext2x_LDFLAGS) mca_pmix_ext2x_la_LIBADD = $(top_builddir)/opal/lib@OPAL_LIB_PREFIX@open-pal.la \ $(opal_pmix_ext2x_LIBS) noinst_LTLIBRARIES = $(component_noinst) -libmca_pmix_ext2x_la_SOURCES =$(sources) +libmca_pmix_ext2x_la_SOURCES = $(sources) $(headers) libmca_pmix_ext2x_la_CFLAGS = $(opal_pmix_ext2x_CFLAGS) libmca_pmix_ext2x_la_CPPFLAGS = $(opal_pmix_ext2x_CPPFLAGS) libmca_pmix_ext2x_la_LDFLAGS = -module -avoid-version $(opal_pmix_ext2x_LDFLAGS) diff --git a/opal/mca/pmix/ext2x/ext2x.h b/opal/mca/pmix/ext2x/ext2x.h index 8e2012906c..0f28c8f667 100644 --- a/opal/mca/pmix/ext2x/ext2x.h +++ b/opal/mca/pmix/ext2x/ext2x.h @@ -37,12 +37,6 @@ BEGIN_C_DECLS -#ifdef OPAL_C_HAVE_VISIBILITY -#define PMIX_HAVE_VISIBILITY 1 -#else -#undef PMIX_HAVE_VISIBILITY -#endif - typedef struct { opal_pmix_base_component_t super; bool legacy_get; diff --git a/opal/mca/pmix/pmix3x/configure.m4 b/opal/mca/pmix/pmix3x/configure.m4 index 646e1debf8..6188960eb3 100644 --- a/opal/mca/pmix/pmix3x/configure.m4 +++ b/opal/mca/pmix/pmix3x/configure.m4 @@ -87,6 +87,9 @@ AC_DEFUN([MCA_opal_pmix_pmix3x_CONFIG],[ [AC_MSG_RESULT([no - disqualifying this component]) opal_pmix_pmix3x_happy=0], [AC_MSG_RESULT([yes - using the internal v3.x library]) + AS_IF([test "$opal_pmix_pmix3x_happy" = "0"], + [AC_MSG_WARN([INTERNAL PMIX FAILED TO CONFIGURE]) + AC_MSG_ERROR([CANNOT CONTINUE])]) # Build flags for our Makefile.am opal_pmix_pmix3x_LDFLAGS= opal_pmix_pmix3x_LIBS="$OPAL_TOP_BUILDDIR/$opal_pmix_pmix3x_basedir/pmix/src/libpmix.la" diff --git a/opal/mca/pmix/pmix3x/pmix/config/pmix_setup_hwloc.m4 b/opal/mca/pmix/pmix3x/pmix/config/pmix_setup_hwloc.m4 index 4ee046d9ab..86a9b9d447 100644 --- a/opal/mca/pmix/pmix3x/pmix/config/pmix_setup_hwloc.m4 +++ b/opal/mca/pmix/pmix3x/pmix/config/pmix_setup_hwloc.m4 @@ -24,6 +24,8 @@ AC_DEFUN([PMIX_HWLOC_CONFIG],[ [Search for hwloc libraries in DIR ])]) pmix_hwloc_support=0 + AS_IF([test "$with_hwloc" = "internal" || test "$with_hwloc" = "external"], + [with_hwloc=]) if test "$with_hwloc" != "no"; then AC_MSG_CHECKING([for hwloc in])