1
1

Fixes for error checking -- properly ignore arguments as they should

be

This commit was SVN r7347.
Этот коммит содержится в:
Jeff Squyres 2005-09-13 19:07:13 +00:00
родитель 9053790973
Коммит c89e8c3712
4 изменённых файлов: 21 добавлений и 13 удалений

Просмотреть файл

@ -57,7 +57,9 @@ int MPI_Gather(void *sendbuf, int sendcount, MPI_Datatype sendtype,
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_ROOT, FUNC_NAME); return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_ROOT, FUNC_NAME);
} }
OMPI_CHECK_DATATYPE_FOR_SEND(err, sendtype, sendcount); if (MPI_IN_PLACE != sendbuf) {
OMPI_CHECK_DATATYPE_FOR_SEND(err, sendtype, sendcount);
}
OMPI_ERRHANDLER_CHECK(err, comm, err, FUNC_NAME); OMPI_ERRHANDLER_CHECK(err, comm, err, FUNC_NAME);
/* Errors for the root. Some of these could have been /* Errors for the root. Some of these could have been

Просмотреть файл

@ -55,7 +55,7 @@ int MPI_Gatherv(void *sendbuf, int sendcount, MPI_Datatype sendtype,
if ((root >= ompi_comm_size(comm)) || (root < 0)) { if ((root >= ompi_comm_size(comm)) || (root < 0)) {
err = MPI_ERR_ROOT; err = MPI_ERR_ROOT;
} else { } else if (MPI_IN_PLACE != sendbuf) {
OMPI_CHECK_DATATYPE_FOR_SEND(err, sendtype, sendcount); OMPI_CHECK_DATATYPE_FOR_SEND(err, sendtype, sendcount);
} }
OMPI_ERRHANDLER_CHECK(err, comm, err, FUNC_NAME); OMPI_ERRHANDLER_CHECK(err, comm, err, FUNC_NAME);

Просмотреть файл

@ -55,11 +55,13 @@ int MPI_Scatter(void *sendbuf, int sendcount, MPI_Datatype sendtype,
/* Errors for all ranks */ /* Errors for all ranks */
if ((root >= ompi_comm_size(comm)) || (root < 0)) { if ((root >= ompi_comm_size(comm)) || (root < 0)) {
err = MPI_ERR_ROOT; err = MPI_ERR_ROOT;
} else if (recvcount < 0) { } else if (MPI_IN_PLACE != recvbuf) {
err = MPI_ERR_COUNT; if (recvcount < 0) {
} else if (MPI_DATATYPE_NULL == recvtype) { err = MPI_ERR_COUNT;
err = MPI_ERR_TYPE; } else if (MPI_DATATYPE_NULL == recvtype) {
err = MPI_ERR_TYPE;
}
} }
/* Errors for the root. Some of these could have been /* Errors for the root. Some of these could have been

Просмотреть файл

@ -57,12 +57,16 @@ int MPI_Scatterv(void *sendbuf, int *sendcounts, int *displs,
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_ROOT, FUNC_NAME); return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_ROOT, FUNC_NAME);
} }
if (recvcount < 0) { if (MPI_IN_PLACE != recvbuf) {
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_COUNT, FUNC_NAME); if (recvcount < 0) {
} return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_COUNT,
FUNC_NAME);
if (MPI_DATATYPE_NULL == recvtype) { }
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_TYPE, FUNC_NAME);
if (MPI_DATATYPE_NULL == recvtype) {
return OMPI_ERRHANDLER_INVOKE(comm, MPI_ERR_TYPE,
FUNC_NAME);
}
} }
/* Errors for the root. Some of these could have been /* Errors for the root. Some of these could have been