ports/openmpi
ports/openmpi
1
1
Форкнуть 0
Код Релизы Активность

Per Marco, rename ERROR tags to exit_ERROR to avoid cygwin reserved name issues.

Просмотр исходного кода 
Refs trac:4085

This commit was SVN r30239.

The following Trac tickets were found above:
  Ticket 4085 --> https://svn.open-mpi.org/trac/ompi/ticket/4085
Этот коммит содержится в:
Ralph Castain 2014-01-10 18:00:49 +00:00
родитель 962a14cf6d
Коммит c7a94a57d7
6 изменённых файлов: 97 добавлений и 97 удалений
Показать статистику Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

12
ompi/mca/bcol/basesmuma/bcol_basesmuma_bcast.c
Просмотреть файл

@ -372,7 +372,7 @@ int bcol_basesmuma_hdl_zerocopy_bcast(bcol_function_args_t *input_args,
ret = hdl->hdl_send(hdl, hdl->endpoint, hdl_desc);
if (ret != OMPI_SUCCESS) {
BASESMUMA_VERBOSE(1, ("send eror on rank %d ........", my_rank));
goto ERROR;
goto exit_ERROR;
}
}
}else if(LEAF_NODE == my_fanout_read_tree->my_node_type) {
@ -401,7 +401,7 @@ int bcol_basesmuma_hdl_zerocopy_bcast(bcol_function_args_t *input_args,
#endif
if (OMPI_SUCCESS != ret) {
BASESMUMA_VERBOSE(1, ("recvi eror on rank %d ........", my_rank));
goto ERROR;
goto exit_ERROR;
}
status = false;
@ -430,11 +430,11 @@ int bcol_basesmuma_hdl_zerocopy_bcast(bcol_function_args_t *input_args,
ret = hdl->hdl_recv(hdl, hdl->endpoint, hdl_desc);
if (OMPI_SUCCESS != ret) {
goto ERROR;
goto exit_ERROR;
}
if (OMPI_SUCCESS != ret) {
BASESMUMA_VERBOSE(1, ("recvi eror on rank %d ........", my_rank));
goto ERROR;
goto exit_ERROR;
}
/* Signal to children that they may read the data from my shared buffer */
@ -449,7 +449,7 @@ int bcol_basesmuma_hdl_zerocopy_bcast(bcol_function_args_t *input_args,
ret = hdl->hdl_send(hdl, hdl->endpoint, hdl_desc);
if (ret != OMPI_SUCCESS) {
BASESMUMA_VERBOSE(1, ("send eror on rank %d ........", my_rank));
goto ERROR;
goto exit_ERROR;
}
}
goto Release;
@ -467,7 +467,7 @@ Release:
my_ctl_pointer->starting_flag_value += 1;
return BCOL_FN_COMPLETE;
ERROR:
exit_ERROR:
return OMPI_ERROR;
}
#endif

16
ompi/mca/bcol/basesmuma/bcol_basesmuma_buf_mgmt.c
Просмотреть файл

@ -209,7 +209,7 @@ int bcol_basesmuma_bank_init(struct mca_coll_ml_module_t *ml_module,
pload_mgmt->data_buffs = malloc(malloc_size);
if( !pload_mgmt->data_buffs) {
ret = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
/* setup the input file for the shared memory connection manager */
@ -230,7 +230,7 @@ int bcol_basesmuma_bank_init(struct mca_coll_ml_module_t *ml_module,
input_file,
false);
if( OMPI_SUCCESS != ret ) {
goto ERROR;
goto exit_ERROR;
}
/* now we exchange offset info - don't assume symmetric virtual memory
@ -243,7 +243,7 @@ int bcol_basesmuma_bank_init(struct mca_coll_ml_module_t *ml_module,
(void **)pload_mgmt->data_buffs, mem_offset, 0,
pload_mgmt->size_of_group);
if( OMPI_SUCCESS != ret ) {
goto ERROR;
goto exit_ERROR;
}
/* convert memory offset to virtual address in current rank */
@ -281,7 +281,7 @@ int bcol_basesmuma_bank_init(struct mca_coll_ml_module_t *ml_module,
return OMPI_SUCCESS;
ERROR:
exit_ERROR:
return ret;
}
#endif
@ -383,7 +383,7 @@ int bcol_basesmuma_bank_init_opti(struct mca_coll_ml_module_t *ml_module,
pload_mgmt->data_buffs = (mca_bcol_basesmuma_payload_t *) malloc(malloc_size);
if( !pload_mgmt->data_buffs) {
ret = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
/* allocate some memory to hold the offsets */
@ -407,7 +407,7 @@ int bcol_basesmuma_bank_init_opti(struct mca_coll_ml_module_t *ml_module,
input_file,cs->payload_base_fname,
false);
if( OMPI_SUCCESS != ret ) {
goto ERROR;
goto exit_ERROR;
}
@ -425,7 +425,7 @@ int bcol_basesmuma_bank_init_opti(struct mca_coll_ml_module_t *ml_module,
sm_bcol_module->super.sbgp_partner_module->group_list,
sm_bcol_module->super.sbgp_partner_module->group_comm);
if( OMPI_SUCCESS != ret ) {
goto ERROR;
goto exit_ERROR;
}
/* convert memory offset to virtual address in current rank */
@ -521,7 +521,7 @@ int bcol_basesmuma_bank_init_opti(struct mca_coll_ml_module_t *ml_module,
return OMPI_SUCCESS;
ERROR:
exit_ERROR:
return ret;
}

6
ompi/mca/bcol/basesmuma/bcol_basesmuma_component.c
Просмотреть файл

@ -192,7 +192,7 @@ static int basesmuma_open(void)
roundup_to_power_radix(2,cs->basesmuma_num_mem_banks, &dummy);
if ( 0 == cs->basesmuma_num_mem_banks ) {
ret=OMPI_ERROR;
goto ERROR;
goto exit_ERROR;
}
/*
@ -202,7 +202,7 @@ static int basesmuma_open(void)
roundup_to_power_radix(2,cs->basesmuma_num_regions_per_bank, &dummy);
if ( 0 == cs->basesmuma_num_regions_per_bank ) {
ret=OMPI_ERROR;
goto ERROR;
goto exit_ERROR;
}
/* Portals initialization */
@ -244,7 +244,7 @@ static int basesmuma_open(void)
return ret;
ERROR:
exit_ERROR:
return ret;
}

50
ompi/mca/bcol/basesmuma/bcol_basesmuma_setup.c
Просмотреть файл

@ -73,7 +73,7 @@ int base_bcol_basesmuma_exchange_offsets(
sm_bcol_module->super.sbgp_partner_module->group_list,
sm_bcol_module->super.sbgp_partner_module->group_comm);
if( OMPI_SUCCESS != ret ) {
goto ERROR;
goto exit_ERROR;
}
/* get the control stucture offsets within the shared memory
@ -95,7 +95,7 @@ int base_bcol_basesmuma_exchange_offsets(
}
ERROR:
exit_ERROR:
/* clean up */
if( NULL != send_buff ) {
free(send_buff);
@ -146,7 +146,7 @@ int base_bcol_basesmuma_exchange_offsets(
fprintf(stderr,"Cannot allocate memory for sbuffer or rbuffer \n");
fflush(stderr);
ret = OMPI_ERROR;
goto ERROR;
goto exit_ERROR;
}
/* get my proc information */
@ -159,13 +159,13 @@ int base_bcol_basesmuma_exchange_offsets(
if (OMPI_SUCCESS != ret) {
fprintf(stderr,"Error packing my_index!!\n");
fflush(stderr);
goto ERROR;
goto exit_ERROR;
}
/* pack the offset of the allocated region */
ret = opal_dss.pack(send_buffer,&(mem_offset),1,OPAL_UINT64);
if (OMPI_SUCCESS != ret) {
goto ERROR;
goto exit_ERROR;
}
/* get the offsets from all procs, so can setup the control data
@ -174,7 +174,7 @@ int base_bcol_basesmuma_exchange_offsets(
if (OMPI_SUCCESS != (ret = ompi_rte_allgather_list(&peers, send_buffer, recv_buffer))) {
fprintf(stderr,"ompi_rte_allgather_list returned error %d\n", ret);
fflush(stderr);
goto ERROR;
goto exit_ERROR;
}
/* unpack the dummy */
@ -183,7 +183,7 @@ int base_bcol_basesmuma_exchange_offsets(
if (OMPI_SUCCESS != ret) {
fprintf(stderr,"unpack returned error %d for dummy \n",ret);
fflush(stderr);
goto ERROR;
goto exit_ERROR;
}
/* get the control stucture offsets within the shared memory
@ -199,7 +199,7 @@ int base_bcol_basesmuma_exchange_offsets(
if (OMPI_SUCCESS != ret) {
fprintf(stderr,"unpack returned error %d for remote index_in_group \n",ret);
fflush(stderr);
goto ERROR;
goto exit_ERROR;
}
/* get the offset */
@ -208,7 +208,7 @@ int base_bcol_basesmuma_exchange_offsets(
if (OMPI_SUCCESS != ret) {
fprintf(stderr,"unpack returned error %d for remote memory offset \n",ret);
fflush(stderr);
goto ERROR;
goto exit_ERROR;
}
array_id=SM_ARRAY_INDEX(leading_dim,0,index_in_group);
@ -232,7 +232,7 @@ int base_bcol_basesmuma_exchange_offsets(
return ret;
ERROR:
exit_ERROR:
/* free peer list */
peer=(ompi_namelist_t *)opal_list_remove_first(&peers);
@ -277,14 +277,14 @@ static int base_bcol_basesmuma_exchange_ctl_params(
sm_bcol_module->super.sbgp_partner_module->group_list,
sm_bcol_module->super.sbgp_partner_module->group_comm);
if( OMPI_SUCCESS != ret ) {
goto ERROR;
goto exit_ERROR;
}
#if 0
ret=base_bcol_basesmuma_exchange_offsets( sm_bcol_module,
(void **)ctl_mgmt->ctl_buffs, mem_offset, loop_limit, leading_dim);
if( OMPI_SUCCESS != ret ) {
goto ERROR;
goto exit_ERROR;
}
#endif
@ -326,7 +326,7 @@ static int base_bcol_basesmuma_exchange_ctl_params(
return ret;
ERROR:
exit_ERROR:
return ret;
}
@ -378,7 +378,7 @@ int base_bcol_basesmuma_setup_ctl_struct(
ctl_mgmt->ctl_buffs= malloc(malloc_size);
if( !ctl_mgmt->ctl_buffs ) {
ret=OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
/* exchange remote addressing information */
@ -404,7 +404,7 @@ int base_bcol_basesmuma_setup_ctl_struct(
fprintf(stderr,"Cannot allocate memory for shared_memory_scratch_space. \n");
fflush(stderr);
ret = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
for(i=0 ; i < sm_bcol_module->super.sbgp_partner_module->group_size ; i++ )
{
@ -431,7 +431,7 @@ int base_bcol_basesmuma_setup_ctl_struct(
fprintf(stderr,"Cannot allocate memory for ctl_buffs_mgmt. ret = %d \n",ret);
fflush(stderr);
ret = OMPI_ERROR;
goto ERROR;
goto exit_ERROR;
}
/* initialize each individual element */
@ -465,7 +465,7 @@ int base_bcol_basesmuma_setup_ctl_struct(
return ret;
ERROR:
exit_ERROR:
return ret;
}
@ -523,7 +523,7 @@ int base_bcol_basesmuma_setup_library_buffers(
list_data_t *item=OBJ_NEW(list_data_t);
if( !item ) {
ret=OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
item->data=(void *)data_ptr;
opal_list_append(&(cs->ctl_structures),(opal_list_item_t *)item);
@ -546,12 +546,12 @@ int base_bcol_basesmuma_setup_library_buffers(
opal_list_remove_last(&(cs->ctl_structures));
if( !sm_bcol_module->no_userdata_ctl) {
ret=OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
ret=base_bcol_basesmuma_setup_ctl_struct(
sm_bcol_module, cs, &(sm_bcol_module->colls_no_user_data));
if( OMPI_SUCCESS != ret ) {
goto ERROR;
goto exit_ERROR;
}
/* intialize userdata_ctl */
@ -559,13 +559,13 @@ int base_bcol_basesmuma_setup_library_buffers(
opal_list_remove_last(&(cs->ctl_structures));
if( !sm_bcol_module->userdata_ctl) {
ret=OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
ret=base_bcol_basesmuma_setup_ctl_struct(
sm_bcol_module, cs, &(sm_bcol_module->colls_with_user_data));
if( OMPI_SUCCESS != ret ) {
goto ERROR;
goto exit_ERROR;
}
/* used for blocking recursive doubling barrier */
@ -578,18 +578,18 @@ int base_bcol_basesmuma_setup_library_buffers(
ret= base_bcol_basesmuma_exchange_ctl_params(sm_bcol_module, cs,
&(sm_bcol_module->colls_no_user_data),sm_bcol_module->no_userdata_ctl);
if( OMPI_SUCCESS != ret ) {
goto ERROR;
goto exit_ERROR;
}
ret= base_bcol_basesmuma_exchange_ctl_params(sm_bcol_module, cs,
&(sm_bcol_module->colls_with_user_data),sm_bcol_module->userdata_ctl);
if( OMPI_SUCCESS != ret ) {
goto ERROR;
goto exit_ERROR;
}
return ret;
ERROR:
exit_ERROR:
return ret;
}

16
ompi/mca/coll/ml/coll_ml_allocation.c
Просмотреть файл

@ -47,12 +47,12 @@ ml_memory_block_desc_t *mca_coll_ml_allocate_block(
if (!memory_block->block){
ML_ERROR(("lmngr failed."));
ret = NULL;
goto ERROR;
goto exit_ERROR;
}
return memory_block;
ERROR:
exit_ERROR:
if (memory_block){
free(memory_block);
return ret;
@ -99,13 +99,13 @@ int mca_coll_ml_initialize_block(
if (NULL == ml_memblock){
ML_ERROR(("Memory block not initialized"));
ret = OMPI_ERROR;
goto ERROR;
goto exit_ERROR;
}
if (ml_memblock->size_block < (num_buffers * num_banks * buffer_size) ){
ML_ERROR(("Not enough memory for all buffers and banks in the memory block"));
ret = OMPI_ERROR;
goto ERROR;
goto exit_ERROR;
}
pbuff_descs = (ml_payload_buffer_desc_t*) malloc(sizeof(ml_payload_buffer_desc_t)
@ -136,19 +136,19 @@ int mca_coll_ml_initialize_block(
num_banks);
if (NULL == ml_memblock->bank_release_counters) {
ret = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
ml_memblock->ready_for_memsync = (bool *)malloc(sizeof(bool) * num_banks);
if (NULL == ml_memblock->ready_for_memsync) {
ret = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
ml_memblock->bank_is_busy = (bool *)malloc(sizeof(bool) * num_banks);
if (NULL == ml_memblock->bank_is_busy) {
ret = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
/* Set index for first bank to sync */
@ -177,7 +177,7 @@ int mca_coll_ml_initialize_block(
return ret;
ERROR:
exit_ERROR:
/* Free all buffer descriptors */
if (pbuff_descs){
free(pbuff_descs);

94
ompi/mca/coll/ml/coll_ml_module.c
Просмотреть файл

@ -578,7 +578,7 @@ static int check_global_view_of_subgroups( int n_procs_selected,
*/
ML_VERBOSE(0, ("More than a single leader for a group.\n"));
ret=OMPI_ERROR;
goto ERROR;
goto exit_ERROR;
} else {
local_leader_found=true;
}
@ -600,7 +600,7 @@ static int check_global_view_of_subgroups( int n_procs_selected,
fprintf(stderr,"n procs in %d\n",n_procs_in);
ML_VERBOSE(0, ("number of procs in the group unexpeted. Expected %d Got %d\n",n_procs_selected,sum));
ret=OMPI_ERROR;
goto ERROR;
goto exit_ERROR;
}
/* check to make sure that all have the same list of ranks.
*/
@ -609,14 +609,14 @@ static int check_global_view_of_subgroups( int n_procs_selected,
ll_p1!=-all_selected[module->group_list[i]] ) {
ret=OMPI_ERROR;
ML_VERBOSE(0, ("Mismatch in rank list - element #%d - %d \n",i,all_selected[module->group_list[i]]));
goto ERROR;
goto exit_ERROR;
}
}
/* return */
return ret;
ERROR:
exit_ERROR:
/* return */
return ret;
}
@ -958,7 +958,7 @@ static int ml_setup_full_tree_data(mca_coll_ml_topology_t *topo,
comm);
if (OPAL_UNLIKELY(OMPI_SUCCESS != ret)) {
ML_VERBOSE(10, ("comm_allreduce_pml failed. root reduction\n"));
goto ERROR;
goto exit_ERROR;
}
/* broadcast the number of groups */
@ -967,14 +967,14 @@ static int ml_setup_full_tree_data(mca_coll_ml_topology_t *topo,
map_to_comm_ranks,comm);
if (OPAL_UNLIKELY(OMPI_SUCCESS != ret)) {
ML_VERBOSE(10, ("comm_bcast_pml failed. num_total_subgroups bcast\n"));
goto ERROR;
goto exit_ERROR;
}
scratch_space=(int *)malloc(4*sizeof(int)*(*num_total_subgroups));
if (OPAL_UNLIKELY(NULL == scratch_space)) {
ML_VERBOSE(10, ("Cannot allocate memory scratch_space.\n"));
ret = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
if( my_rank == root ) {
sum=0;
@ -990,7 +990,7 @@ static int ml_setup_full_tree_data(mca_coll_ml_topology_t *topo,
map_to_comm_ranks, comm);
if (OPAL_UNLIKELY(OMPI_SUCCESS != ret)) {
ML_VERBOSE(10, ("comm_allreduce_pml failed. scratch_space bcast\n"));
goto ERROR;
goto exit_ERROR;
}
if( my_rank != root ) {
if( in_num_total_subgroups != (*num_total_subgroups) ) {
@ -1003,7 +1003,7 @@ static int ml_setup_full_tree_data(mca_coll_ml_topology_t *topo,
if (OPAL_UNLIKELY(NULL == (*array_of_all_subgroup_ranks))) {
ML_VERBOSE(10, ("Cannot allocate memory array_of_all_subgroup_ranks.\n"));
ret = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
for(i=0 ; i < (*num_total_subgroups) ; i++ ) {
(*array_of_all_subgroup_ranks)[i].root_rank_in_comm=scratch_space[4*i];
@ -1025,7 +1025,7 @@ static int ml_setup_full_tree_data(mca_coll_ml_topology_t *topo,
if (OPAL_UNLIKELY(NULL == (*list_of_ranks_in_all_subgroups))) {
ML_VERBOSE(10, ("Cannot allocate memory *list_of_ranks_in_all_subgroups.\n"));
ret = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
}
ret=comm_bcast_pml(*list_of_ranks_in_all_subgroups, root, sum,
@ -1033,7 +1033,7 @@ static int ml_setup_full_tree_data(mca_coll_ml_topology_t *topo,
map_to_comm_ranks, comm);
if (OPAL_UNLIKELY(OMPI_SUCCESS != ret)) {
ML_VERBOSE(10, ("Bcast failed for list_of_ranks_in_all_subgroups \n"));
goto ERROR;
goto exit_ERROR;
}
/* fill in subgroup ranks */
@ -1047,7 +1047,7 @@ static int ml_setup_full_tree_data(mca_coll_ml_topology_t *topo,
ML_VERBOSE(10, ("Cannot allocate memory for rank_data \n"));
ret = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
for(j=0 ; j < (*array_of_all_subgroup_ranks)[i].n_ranks ; j++ ) {
(*array_of_all_subgroup_ranks)[i].rank_data[j].rank=
@ -1198,7 +1198,7 @@ NextRank:
(*array_of_all_subgroup_ranks)[i_sg].list_connected_nodes)) {
ML_VERBOSE(10, ("Cannot allocate memory for list_connected_nodes - i_cnt %d\n",i_cnt));
ret = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
} else {
(*array_of_all_subgroup_ranks)[i_sg].list_connected_nodes=NULL;
@ -1222,7 +1222,7 @@ NextRank:
(*array_of_all_subgroup_ranks)[i_sg].rank_data[i_rank].list_connected_subgroups) ) {
ML_VERBOSE(10, ("Cannot allocate memory for rank list_connected_subgroups - cnt %d\n",cnt));
ret = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
/* reset the conuter, so can fill it in on the fly */
(*array_of_all_subgroup_ranks)[i_sg].rank_data[i_rank].
@ -1317,7 +1317,7 @@ NextRank:
if (OPAL_UNLIKELY(NULL == topo->sort_list)) {
ML_VERBOSE(10, ("Cannot allocate memory for sort_list.\n"));
ret = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
/* find subgroup index, and rank within that subgroup where I am
@ -1361,7 +1361,7 @@ NextRank:
return ret;
ERROR:
exit_ERROR:
if(scratch_space) {
free(scratch_space);
};
@ -1447,7 +1447,7 @@ static int get_new_subgroup_data (int32_t *all_selected, int size_of_all_selecte
if (OPAL_UNLIKELY(NULL == (*sub_group_meta_data))) {
ML_VERBOSE(10, ("Cannot allocate memory for sub_group_meta_data.\n"));
rc = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
(*sub_group_meta_data)[(*num_total_subgroups)].root_rank_in_comm=sg_root;
(*sub_group_meta_data)[(*num_total_subgroups)].n_ranks=1;
@ -1457,7 +1457,7 @@ static int get_new_subgroup_data (int32_t *all_selected, int size_of_all_selecte
if (OPAL_UNLIKELY(NULL == temp[knt2] ) ){
ML_VERBOSE(10, ("Cannot allocate memory for sub_group_meta_data.\n"));
rc = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
sg_id=(*num_total_subgroups);
(*num_total_subgroups)++;
@ -1488,7 +1488,7 @@ static int get_new_subgroup_data (int32_t *all_selected, int size_of_all_selecte
if (OPAL_UNLIKELY(NULL == (*list_of_ranks_in_all_subgroups))) {
ML_VERBOSE(10, ("Cannot allocate memory for list_of_ranks_in_all_subgroups.\n"));
rc = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
/* loop over new subgroups */
@ -1517,7 +1517,7 @@ static int get_new_subgroup_data (int32_t *all_selected, int size_of_all_selecte
/* return */
return rc;
ERROR:
exit_ERROR:
return rc;
}
@ -1638,7 +1638,7 @@ static int mca_coll_ml_read_allbcols_settings(mca_coll_ml_module_t *ml_module,
if (OPAL_UNLIKELY(NULL == bcols_in_use)) {
ML_VERBOSE(10, ("Cannot allocate memory for bcols_in_use.\n"));
ret = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
/* setup pointers to arrays that will hold bcol parameters. Since
* given bols are not instantiated in all processes, need to get this
@ -1670,7 +1670,7 @@ static int mca_coll_ml_read_allbcols_settings(mca_coll_ml_module_t *ml_module,
ranks_map = (int *) malloc(sizeof(int) * ompi_comm_size(ml_module->comm));
if (NULL == ranks_map) {
ret = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
for (i = 0; i < ompi_comm_size(ml_module->comm); i++) {
ranks_map[i] = i;
@ -1685,7 +1685,7 @@ static int mca_coll_ml_read_allbcols_settings(mca_coll_ml_module_t *ml_module,
ranks_map, ml_module->comm);
if (OPAL_UNLIKELY(OMPI_SUCCESS != ret)) {
ML_VERBOSE(10, ("comm_allreduce_pml failed. bcols_in_use reduction\n"));
goto ERROR;
goto exit_ERROR;
}
/*
@ -1807,7 +1807,7 @@ static int mca_coll_ml_read_allbcols_settings(mca_coll_ml_module_t *ml_module,
mca_coll_ml_component.payload_buffer_size,
ml_module->data_offset));
ERROR:
exit_ERROR:
if (NULL != ranks_map) {
free(ranks_map);
}
@ -1964,7 +1964,7 @@ static int mca_coll_ml_tree_hierarchy_discovery(mca_coll_ml_module_t *ml_module,
if (NULL != exclude_sbgp_name && NULL != include_sbgp_name) {
ret = OMPI_ERROR;
goto ERROR;
goto exit_ERROR;
}
ML_VERBOSE(10,("include %s exclude %s size %d", include_sbgp_name, exclude_sbgp_name, n_hierarchies));
@ -1974,14 +1974,14 @@ static int mca_coll_ml_tree_hierarchy_discovery(mca_coll_ml_module_t *ml_module,
if (OPAL_UNLIKELY(NULL == all_selected)) {
ML_VERBOSE(10, ("Cannot allocate memory.\n"));
ret = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
map_to_comm_ranks = (int *) calloc(ompi_comm_size(ml_module->comm), sizeof(int));
if (OPAL_UNLIKELY(NULL == map_to_comm_ranks)) {
ML_VERBOSE(10, ("Cannot allocate memory.\n"));
ret = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
/*
@ -1995,7 +1995,7 @@ static int mca_coll_ml_tree_hierarchy_discovery(mca_coll_ml_module_t *ml_module,
if (OPAL_UNLIKELY(NULL == copy_procs)) {
ML_VERBOSE(10, ("Cannot allocate memory.\n"));
ret = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
for (i = 0; i < ompi_comm_size(ml_module->comm); i++) {
@ -2011,7 +2011,7 @@ static int mca_coll_ml_tree_hierarchy_discovery(mca_coll_ml_module_t *ml_module,
if (OPAL_UNLIKELY(NULL == index_proc_selected)) {
ML_VERBOSE(10, ("Cannot allocate memory.\n"));
ret = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
/* get my proc pointer - used to identify myself in the list */
@ -2022,7 +2022,7 @@ static int mca_coll_ml_tree_hierarchy_discovery(mca_coll_ml_module_t *ml_module,
if (OPAL_UNLIKELY(NULL == topo->component_pairs)) {
ML_VERBOSE(10, ("Cannot allocate memory.\n"));
ret = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
n_hier = 0;
@ -2205,7 +2205,7 @@ static int mca_coll_ml_tree_hierarchy_discovery(mca_coll_ml_module_t *ml_module,
n_procs_in, map_to_comm_ranks ,ml_module->comm);
if (OPAL_UNLIKELY(OMPI_SUCCESS != ret)) {
ML_VERBOSE(10, ("comm_allreduce_pml failed.\n"));
goto ERROR;
goto exit_ERROR;
}
/* do some sanity checks */
@ -2214,7 +2214,7 @@ static int mca_coll_ml_tree_hierarchy_discovery(mca_coll_ml_module_t *ml_module,
n_procs_in, ll_p1, all_selected, module );
if (OPAL_UNLIKELY(OMPI_SUCCESS != ret)) {
ML_VERBOSE(10, ("check_global_view_of_subgroups failed.\n"));
goto ERROR;
goto exit_ERROR;
}
}
@ -2246,7 +2246,7 @@ static int mca_coll_ml_tree_hierarchy_discovery(mca_coll_ml_module_t *ml_module,
if( OMPI_SUCCESS != ret ) {
ML_VERBOSE(10, (" Error: get_new_subgroup_data returned %d \n",ret));
goto ERROR;
goto exit_ERROR;
}
/* am I done ? */
@ -2302,7 +2302,7 @@ static int mca_coll_ml_tree_hierarchy_discovery(mca_coll_ml_module_t *ml_module,
if (OPAL_UNLIKELY(NULL == pair->bcol_modules)) {
ML_VERBOSE(10, ("Failed to create new modules.\n"));
ret = OMPI_ERROR;
goto ERROR;
goto exit_ERROR;
}
if (pair->bcol_component->need_ordering) {
@ -2314,7 +2314,7 @@ static int mca_coll_ml_tree_hierarchy_discovery(mca_coll_ml_module_t *ml_module,
if (OPAL_UNLIKELY(OMPI_SUCCESS != append_new_network_context(pair))) {
ML_VERBOSE(10, ("Exit with error. - append new network context\n"));
ret = OMPI_ERROR;
goto ERROR;
goto exit_ERROR;
}
for (i = 0; i < pair->num_bcol_modules; ++i) {
@ -2444,11 +2444,11 @@ static int mca_coll_ml_tree_hierarchy_discovery(mca_coll_ml_module_t *ml_module,
NULL != include_sbgp_name ? include_sbgp_name : exclude_sbgp_name
));
ret = OMPI_ERROR;
goto ERROR;
goto exit_ERROR;
}
ML_VERBOSE(10, ("Empty hierarchy..."));
ret = OMPI_SUCCESS;
goto ERROR;
goto exit_ERROR;
}
topo->n_levels = n_hier;
@ -2471,7 +2471,7 @@ static int mca_coll_ml_tree_hierarchy_discovery(mca_coll_ml_module_t *ml_module,
map_to_comm_ranks, ml_module->comm);
if (OPAL_UNLIKELY(OMPI_SUCCESS != ret)) {
ML_VERBOSE(10, ("comm_allreduce_pml failed. all_reduce_buffer2_in reduction\n"));
goto ERROR;
goto exit_ERROR;
}
topo->global_lowest_hier_group_index = all_reduce_buffer2_out[0];
@ -2496,7 +2496,7 @@ static int mca_coll_ml_tree_hierarchy_discovery(mca_coll_ml_module_t *ml_module,
if (OPAL_UNLIKELY(OMPI_SUCCESS != ret)) {
ML_VERBOSE(10, ("comm_allreduce_pml failed: bcols_in_use reduction %d \n",ret));
goto ERROR;
goto exit_ERROR;
}
/* cache the ML hierarchical description on the tree */
@ -2509,7 +2509,7 @@ static int mca_coll_ml_tree_hierarchy_discovery(mca_coll_ml_module_t *ml_module,
ret = mca_coll_ml_fill_in_route_tab(topo, ml_module->comm);
if (OMPI_SUCCESS != ret) {
ML_ERROR(("mca_coll_ml_fill_in_route_tab returned an error.\n"));
goto ERROR;
goto exit_ERROR;
}
}
@ -2520,7 +2520,7 @@ static int mca_coll_ml_tree_hierarchy_discovery(mca_coll_ml_module_t *ml_module,
** correctly with this module.
*/
ERROR:
exit_ERROR:
ML_VERBOSE(10, ("Discovery done\n"));
@ -2707,7 +2707,7 @@ static int mca_coll_ml_fill_in_route_tab(mca_coll_ml_topology_t *topo, ompi_comm
if (NULL == all_reachable_ranks) {
ML_VERBOSE(10, ("Cannot allocate memory.\n"));
rc = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
for (i = 0; i < comm_size; ++i) {
@ -2718,7 +2718,7 @@ static int mca_coll_ml_fill_in_route_tab(mca_coll_ml_topology_t *topo, ompi_comm
if (NULL == route_table) {
ML_VERBOSE(10, ("Cannot allocate memory.\n"));
rc = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
topo->route_vector = (mca_coll_ml_route_info_t *)
@ -2726,7 +2726,7 @@ static int mca_coll_ml_fill_in_route_tab(mca_coll_ml_topology_t *topo, ompi_comm
if (NULL == topo->route_vector) {
ML_VERBOSE(10, ("Cannot allocate memory.\n"));
rc = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
all_reachable_ranks[my_rank] = IS_RECHABLE;
@ -2738,7 +2738,7 @@ static int mca_coll_ml_fill_in_route_tab(mca_coll_ml_topology_t *topo, ompi_comm
if (NULL == route_table[level]) {
ML_VERBOSE(10, ("Cannot allocate memory.\n"));
rc = OMPI_ERR_OUT_OF_RESOURCE;
goto ERROR;
goto exit_ERROR;
}
for (i = 0; i < comm_size; ++i) {
@ -2756,7 +2756,7 @@ static int mca_coll_ml_fill_in_route_tab(mca_coll_ml_topology_t *topo, ompi_comm
comm);
if (OMPI_SUCCESS != rc) {
ML_VERBOSE(10, ("comm_allreduce failed.\n"));
goto ERROR;
goto exit_ERROR;
}
for (i = 0; i < comm_size; ++i) {
@ -2862,7 +2862,7 @@ static int mca_coll_ml_fill_in_route_tab(mca_coll_ml_topology_t *topo, ompi_comm
return OMPI_SUCCESS;
ERROR:
exit_ERROR:
ML_VERBOSE(10, ("Exit with error status - %d.\n", rc));
if (NULL != route_table) {