From b9f1975141a5709b53270c6b4a9a90f84a24030a Mon Sep 17 00:00:00 2001 From: Jeff Squyres Date: Tue, 7 Dec 2004 22:35:10 +0000 Subject: [PATCH] Eliminating warnings: per Edgar's advice, this code is definitely not being used. I added some comments about why it's not being used (because one would naievely think that increasing / decreasing the refcount would be a Good Thing for the group constructor / destructor). This commit was SVN r3739. --- src/group/mpi_group_init.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/src/group/mpi_group_init.c b/src/group/mpi_group_init.c index cb8412869b..31314f2777 100644 --- a/src/group/mpi_group_init.c +++ b/src/group/mpi_group_init.c @@ -120,6 +120,11 @@ static void ompi_group_construct(ompi_group_t *new_group) { int ret_val; + /* Note that we do *NOT* increase the refcount on all the included + procs here because that is handled at a different level (e.g., + the proc counts are not decreased during the desstructor, + either). */ + /* assign entry in fortran <-> c translation array */ ret_val = ompi_pointer_array_add(ompi_group_f_to_c_table, new_group); new_group->grp_f_to_c_index = ret_val; @@ -135,13 +140,11 @@ static void ompi_group_construct(ompi_group_t *new_group) */ static void ompi_group_destruct(ompi_group_t *group) { - int proc; - - /* decrement proc reference count */ -/* for (proc = 0; proc < group->grp_proc_count; proc++) { - OBJ_RELEASE(group->grp_proc_pointers[proc]); - } -*/ + /* Note that we do *NOT* decrease the refcount on all the included + procs here because that is handled at a different level (e.g., + the proc counts are not increased during the constructor, + either). */ + /* release thegrp_proc_pointers memory */ if (NULL != group->grp_proc_pointers) free(group->grp_proc_pointers);