Provide a nicer error message when someone gives a bad signal number to opal_signal

cmr:v1.7.1

This commit was SVN r28188.

opal/runtime/opal_init.c

@@ -328,9 +328,11 @@ opal_init_util(int* pargc, char*** pargv)
     return OPAL_SUCCESS;
 
  return_error:
-    opal_show_help( "help-opal-runtime.txt",
-                    "opal_init:startup:internal-failure", true,
-                    error, ret );
+    if (OPAL_ERR_SILENT != ret) {
+        opal_show_help( "help-opal-runtime.txt",
+                        "opal_init:startup:internal-failure", true,
+                        error, ret );
+    }
     return ret;
 }
 

opal/util/help-opal-util.txt

@@ -23,7 +23,17 @@ install its own signal handler for this signal by setting the
 
   Signal: %d
   Current opal_signal value: %s
-*
+#
+[stacktrace bad signal]
+Open MPI was inserting a signal handler but was given an invalid
+signal number:
+
+  Signal string: %s
+  Bad value:     %s
+
+The given value must be an integer within the signal number
+range. Please correct the value and try again.
+#
 [malformed net_private_ipv4]
 Open MPI has detected at least one malformed IP address or netmask in
 the value of the opal_net_private_ipv4 MCA parameter.  The

opal/util/stacktrace.c

@@ -498,7 +498,10 @@ int opal_util_register_stackhandlers (void)
        *  Similarly for any number which is not in the signal-number range
        */
       if (((0 == sig) && (tmp == next)) || (0 > sig) || (_NSIG <= sig)) {
-	 return OPAL_ERR_BAD_PARAM;
+          opal_show_help("help-opal-util.txt",
+                         "stacktrace bad signal", true,
+                         string_value, tmp);
+          return OPAL_ERR_SILENT;
       } else if (next == NULL) {
 	 return OPAL_ERR_BAD_PARAM;
       } else if (':' == *next &&