Fix a bunch of compiler warnings. Some were actual problems; others

were the compiler unable to deduce that the action really was safe.

This commit was SVN r2852.

src/datatype/dt_sndrcv.c

@@ -29,7 +29,7 @@ int ompi_ddt_sndrcv(void *sbuf, int scount, MPI_Datatype sdtype, void *rbuf,
                     int rcount, MPI_Datatype rdtype, int tag, MPI_Comm comm)
 {
     int err;
-    int size;
+    unsigned int size;
     int rank;
     int position = 0;
     ompi_convertor_t *local_convertor;

src/mca/oob/base/oob_base_init.c

@@ -85,8 +85,8 @@ int mca_oob_base_init(bool *user_threads, bool *hidden_threads)
     mca_oob_t *module;
     extern ompi_list_t mca_oob_base_components;
     mca_oob_t *s_module = NULL;
-    bool s_user_threads;
+    bool s_user_threads = true;
-    bool s_hidden_threads;
+    bool s_hidden_threads = false;
     int  s_priority = -1;
 
     char** include = ompi_argv_split(mca_oob_base_include, ',');

src/mca/pcmclient/base/pcmclient_base_select.c

@@ -41,6 +41,9 @@ int mca_pcmclient_base_select(bool *allow_multi_user_threads,
 
   best_priority = -1;
   best_component = NULL;
+  best_module = NULL;
+  best_user_threads = true;
+  best_hidden_threads = false;
   for (item = ompi_list_get_first(&mca_pcmclient_base_components_available);
        ompi_list_get_end(&mca_pcmclient_base_components_available) != item;
        item = ompi_list_get_next(item)) {

src/mca/pml/base/pml_base_select.c

@@ -47,8 +47,9 @@ int mca_pml_base_select(mca_pml_base_module_t *selected,
 
   best_priority = -1;
   best_component = NULL;
-  user_threads = true;
+  modules = NULL;
-  hidden_threads = false;
+  best_user_threads = user_threads = true;
+  best_hidden_threads = hidden_threads = false;
   OBJ_CONSTRUCT(&opened, ompi_list_t);
   for (item = ompi_list_get_first(&mca_pml_base_components_available);
        ompi_list_get_end(&mca_pml_base_components_available) != item;

src/mca/pml/teg/src/pml_teg_test.c

@@ -45,7 +45,7 @@ int mca_pml_teg_test_all(size_t count,
                          int *completed, ompi_status_public_t * statuses)
 {
     size_t i;
-    size_t num_completed;
+    size_t num_completed = 0;
 
     ompi_atomic_mb();
     for (i = 0; i < count; i++) {

src/mca/pml/teg/src/pml_teg_wait.c

@@ -20,7 +20,7 @@ int mca_pml_teg_wait(size_t count,
 #endif
     int i;
     int completed = -1;
-    mca_pml_base_request_t *pml_request;
+    mca_pml_base_request_t *pml_request = NULL;
 
 #if MCA_PML_TEG_STATISTICS
     mca_pml_teg.teg_waits++;