Merge pull request #5943 from bosilca/fix/libnbc_warnings

Remove few warnings in libnbc identified by clang-1000.11.45.2

ompi/mca/coll/base/coll_base_bcast.c

@@ -646,7 +646,9 @@ ompi_coll_base_bcast_intra_basic_linear(void *buff, int count,
 
     /* Root sends data to all others. */
     preq = reqs = ompi_coll_base_comm_get_reqs(module->base_data, size-1);
-    if( NULL == reqs ) { err = OMPI_ERR_OUT_OF_RESOURCE; goto err_hndl; }
+    if( NULL == reqs ) {
+        return OMPI_ERR_OUT_OF_RESOURCE;
+    }
 
     for (i = 0; i < size; ++i) {
         if (i == rank) {

ompi/mca/coll/libnbc/nbc_iexscan.c

@@ -18,7 +18,7 @@
  * Author(s): Torsten Hoefler <htor@cs.indiana.edu>
  *
  */
-#include "opal/include/opal/align.h"
+#include "opal/align.h"
 #include "ompi/op/op.h"
 
 #include "nbc_internal.h"

ompi/mca/coll/libnbc/nbc_ireduce.c

@@ -19,7 +19,8 @@
  *
  */
 
-#include "opal/include/opal/align.h"
+#include "ompi_config.h"
+#include "opal/align.h"
 #include "opal/util/bit_ops.h"
 #include "ompi/op/op.h"
 

ompi/mca/coll/libnbc/nbc_ireduce_scatter.c

@@ -21,7 +21,7 @@
  * Author(s): Torsten Hoefler <htor@cs.indiana.edu>
  *
  */
-#include "opal/include/opal/align.h"
+#include "opal/align.h"
 
 #include "nbc_internal.h"
 

ompi/mca/coll/libnbc/nbc_ireduce_scatter_block.c

@@ -19,7 +19,7 @@
  * Author(s): Torsten Hoefler <htor@cs.indiana.edu>
  *
  */
-#include "opal/include/opal/align.h"
+#include "opal/align.h"
 
 #include "nbc_internal.h"
 

ompi/mca/coll/libnbc/nbc_iscan.c

@@ -18,7 +18,7 @@
  * Author(s): Torsten Hoefler <htor@cs.indiana.edu>
  *
  */
-#include "opal/include/opal/align.h"
+#include "opal/align.h"
 #include "ompi/op/op.h"
 
 #include "nbc_internal.h"