1
1

Improve the range and accuracy of MPI_Wtime.

As discussed on https://github.com/mpi-forum/mpi-issues/issues/77#issuecomment-369663119
the conversion to double in the MPI_Wtime decrease the range
and accuracy of the resulting timer. By setting the timer to
0 at the first usage we basically maintain the accuracy for
194 days even for gettimeofday.

Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
Этот коммит содержится в:
George Bosilca 2018-03-08 03:22:51 +09:00
родитель 2f0e8153a5
Коммит 9bced03213
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: 09C926752C9F09B1

Просмотреть файл

@ -2,7 +2,7 @@
* Copyright (c) 2004-2007 The Trustees of Indiana University and Indiana * Copyright (c) 2004-2007 The Trustees of Indiana University and Indiana
* University Research and Technology * University Research and Technology
* Corporation. All rights reserved. * Corporation. All rights reserved.
* Copyright (c) 2004-2005 The University of Tennessee and The University * Copyright (c) 2004-2018 The University of Tennessee and The University
* of Tennessee Research Foundation. All rights * of Tennessee Research Foundation. All rights
* reserved. * reserved.
* Copyright (c) 2004-2005 High Performance Computing Center Stuttgart, * Copyright (c) 2004-2005 High Performance Computing Center Stuttgart,
@ -40,6 +40,22 @@
#pragma weak MPI_Wtime = PMPI_Wtime #pragma weak MPI_Wtime = PMPI_Wtime
#endif #endif
#define MPI_Wtime PMPI_Wtime #define MPI_Wtime PMPI_Wtime
/**
* Have a base time set on the first call to wtime, to improve the range
* and accuracy of the user visible timer.
* More info: https://github.com/mpi-forum/mpi-issues/issues/77#issuecomment-369663119
*/
#if defined(__linux__) && OPAL_HAVE_CLOCK_GETTIME
struct timespec ompi_wtime_time_origin = {.tv_sec = 0};
#else
struct timeval ompi_wtime_time_origin = {.tv_sec = 0};
#endif
#else /* OMPI_BUILD_MPI_PROFILING */
#if defined(__linux__) && OPAL_HAVE_CLOCK_GETTIME
extern struct timespec ompi_wtime_time_origin;
#else
extern struct timeval ompi_wtime_time_origin;
#endif
#endif #endif
double MPI_Wtime(void) double MPI_Wtime(void)
@ -58,16 +74,22 @@ double MPI_Wtime(void)
#endif #endif
#else #else
#if defined(__linux__) && OPAL_HAVE_CLOCK_GETTIME #if defined(__linux__) && OPAL_HAVE_CLOCK_GETTIME
struct timespec tp = {.tv_sec = 0, .tv_nsec = 0}; struct timespec tp;
(void) clock_gettime(CLOCK_MONOTONIC, &tp); (void) clock_gettime(CLOCK_MONOTONIC, &tp);
wtime = tp.tv_sec; if( OPAL_UNLIKELY(0 == ompi_wtime_time_origin.tv_sec) ) {
wtime += tp.tv_nsec/1.0e+9; ompi_wtime_time_origin = tp;
}
wtime = (double)(tp.tv_nsec - ompi_wtime_time_origin.tv_nsec)/1.0e+9;
wtime += (tp.tv_sec - ompi_wtime_time_origin.tv_sec);
#else #else
/* Fall back to gettimeofday() if we have nothing else */ /* Fall back to gettimeofday() if we have nothing else */
struct timeval tv; struct timeval tv;
gettimeofday(&tv, NULL); gettimeofday(&tv, NULL);
wtime = tv.tv_sec; if( OPAL_UNLIKELY(0 == ompi_wtime_time_origin.tv_sec) ) {
wtime += (double)tv.tv_usec / 1000000.0; ompi_wtime_time_origin = tv;
}
wtime = (double)(tv.tv_usec - ompi_wtime_time_origin.tv_usec) / 1.0e+6;
wtime += (tv.tv_sec - ompi_wtime_time_origin.tv_sec);
#endif #endif
#endif #endif