Add ORTE_DECLSPEC, and few conversions.

This commit was SVN r13268.

orte/mca/pls/base/pls_private.h

@@ -63,7 +63,7 @@ extern "C" {
         orte_process_name_t *name;
         orte_jobid_t active_job;
       } orte_pls_daemon_info_t;
-    OBJ_CLASS_DECLARATION(orte_pls_daemon_info_t);
+    ORTE_DECLSPEC OBJ_CLASS_DECLARATION(orte_pls_daemon_info_t);
     
     
     /**
@@ -75,23 +75,23 @@ extern "C" {
     /**
      * Utilities for pls components that use proxy daemons
      */
-    int orte_pls_base_orted_exit(opal_list_t *daemons);
-    int orte_pls_base_orted_kill_local_procs(opal_list_t *daemons, orte_jobid_t job);
-    int orte_pls_base_orted_signal_local_procs(opal_list_t *daemons, int32_t signal);
+    ORTE_DECLSPEC int orte_pls_base_orted_exit(opal_list_t *daemons);
+    ORTE_DECLSPEC int orte_pls_base_orted_kill_local_procs(opal_list_t *daemons, orte_jobid_t job);
+    ORTE_DECLSPEC int orte_pls_base_orted_signal_local_procs(opal_list_t *daemons, int32_t signal);
     int orte_pls_base_orted_add_local_procs(opal_list_t *dmnlist, orte_gpr_notify_data_t *ndat);
 
-    int orte_pls_base_get_active_daemons(opal_list_t *daemons, orte_jobid_t job, opal_list_t *attrs);
-    int orte_pls_base_store_active_daemons(opal_list_t *daemons);
-    int orte_pls_base_remove_daemon(orte_pls_daemon_info_t *info);
+    ORTE_DECLSPEC int orte_pls_base_get_active_daemons(opal_list_t *daemons, orte_jobid_t job, opal_list_t *attrs);
+    ORTE_DECLSPEC int orte_pls_base_store_active_daemons(opal_list_t *daemons);
+    ORTE_DECLSPEC int orte_pls_base_remove_daemon(orte_pls_daemon_info_t *info);
     int orte_pls_base_check_avail_daemons(opal_list_t *daemons, orte_jobid_t job);
     
-    int orte_pls_base_launch_on_existing_daemons(orte_job_map_t *map);
+    ORTE_DECLSPEC int orte_pls_base_launch_on_existing_daemons(orte_job_map_t *map);
 
     /*
      * communications utilities
      */
     int orte_pls_base_comm_start(void);
-    int orte_pls_base_comm_stop(void);
+    ORTE_DECLSPEC int orte_pls_base_comm_stop(void);
     void orte_pls_base_recv(int status, orte_process_name_t* sender,
                             orte_buffer_t* buffer, orte_rml_tag_t tag,
                             void* cbdata);
@@ -99,7 +99,7 @@ extern "C" {
     /*
      * general utilities
      */
-    int orte_pls_base_mca_argv(int *argc, char ***argv);
+    ORTE_DECLSPEC int orte_pls_base_mca_argv(int *argc, char ***argv);
     void orte_pls_base_purge_mca_params(char ***env);
 
 #if defined(c_plusplus) || defined(__cplusplus)

orte/mca/pls/process/pls_process_component.c

@@ -227,7 +227,7 @@ static char **search(const char* agent_list)
         for (j = 0; '\0' != line[j] && isspace(line[j]); ++line) {
             continue;
         }
-        for (j = strlen(line) - 2; j > 0 && isspace(line[j]); ++j) {
+        for (j = (int)strlen(line) - 2; j > 0 && isspace(line[j]); ++j) {
             line[j] = '\0';
         }
         if (strlen(line) <= 0) {

orte/mca/pls/process/pls_process_module.c

@@ -802,7 +802,6 @@ int orte_pls_process_launch(orte_jobid_t jobid)
             char* name_string;
             char** env;
             char* var;
-            int fdmax = sysconf(_SC_OPEN_MAX);
 
             if (mca_pls_process_component.debug) {
                 opal_output(0, "pls:process: launching on node %s\n",