Remove clang compiler warnings.

This commit was SVN r26523.

ompi/mca/pml/dr/pml_dr_recvfrag.c

@@ -678,7 +678,7 @@ rematch:
              * update delivered sequence number information, if needed.
              */
             MCA_PML_DR_RECV_REQUEST_MATCHED(match,comm,proc,hdr);
-            if( (match->req_recv.req_base.req_type == MCA_PML_REQUEST_PROBE) ) {
+            if( match->req_recv.req_base.req_type == MCA_PML_REQUEST_PROBE ) {
 
                 /* complete the probe */
                 mca_pml_dr_recv_request_matched_probe(match,btl,segments,num_segments);
@@ -954,7 +954,7 @@ rematch:
                     /*
                      * If this was a probe need to queue fragment on unexpected list
                      */
-                    if( (match->req_recv.req_base.req_type == MCA_PML_REQUEST_PROBE) ) {
+                    if( match->req_recv.req_base.req_type == MCA_PML_REQUEST_PROBE ) {
 
                         /* complete the probe */
                         mca_pml_dr_recv_request_matched_probe(match,frag->btl,frag->segments,frag->num_segments);

opal/threads/mutex.h

@@ -177,7 +177,7 @@ static inline bool opal_set_using_threads(bool have)
 #if OPAL_ENABLE_MULTI_THREADS
     opal_uses_threads = have;
 #else
-    have = have;               /* just shut up the compiler */
+    have = true;               /* just shut up the compiler */
     opal_uses_threads = false;
 #endif
     return opal_uses_threads;

orte/mca/oob/tcp/oob_tcp.c

@@ -1286,9 +1286,9 @@ static void mca_oob_tcp_recv_handler(int sd, short flags, void* user)
     int rc;
 
     /* accept new connections on the listen socket */
-    if( (mca_oob_tcp_component.tcp_listen_sd == sd)
+    if( mca_oob_tcp_component.tcp_listen_sd == sd
 #if OPAL_WANT_IPV6
-        || (mca_oob_tcp_component.tcp6_listen_sd == sd)
+        || mca_oob_tcp_component.tcp6_listen_sd == sd
 #endif  /* OPAL_WANT_IPV6 */
        ) {
         mca_oob_tcp_accept(sd);

orte/tools/orte-ps/orte-ps.c

@@ -671,7 +671,6 @@ static int pretty_print_vpids(orte_job_t *job) {
         /*
          * Find my app context
          */
-        len_proc_name = len_proc_name;
         if( 0 >= (int)job->num_apps ) {
             if( 0 == vpid->name.vpid ) {
                 if( (int)strlen("orterun") > len_proc_name)