Transition to using "make distcheck" instead of "make dist", because

"distcheck" does a bunch of sanity checks on the tarball to ensure
that it's good.  Hence, if someone mucked up a Makefile.am, we'll find
out during distcheck rather than having all the nightly builds fail
(i.e., a new tarball won't be built and none of the builds will be
kicked off)

This commit was SVN r7572.

contrib/nightly/create_tarball.sh

@@ -187,7 +187,16 @@ do_command "./autogen.sh"
 do_command "./configure --enable-dist"
 
 # do make dist
-do_command "make dist"
+# distcheck does many things; we need to ensure it doesn't pick up any 
+# other OMPI installs via LD_LIBRARY_PATH.  It may be a bit Draconian
+# to totally clean LD_LIBRARY_PATH (i.e., we may need something in there),
+# but at least in the current building setup, we don't.  But be advised
+# that this may need to change in the future...
+save=$LD_LIBRARY_PATH
+LD_LIBRARY_PATH=
+do_command "make distcheck"
+LD_LIBRARY_PATH=$save
+save=
 
 # move the resulting tarballs to the destdir
 gz="`/bin/ls openmpi*tar.gz`"