From 7f271171f639d2b3fcfe5ec7a5db77d0aed25633 Mon Sep 17 00:00:00 2001 From: Nathan Hjelm Date: Mon, 18 Apr 2016 11:29:20 -0600 Subject: [PATCH] memory/patcher: fix coverity warning Fix CID 1358512: Error handling issues (NEGATIVE_RETURNS): C libraries usually handle read (-1, ...) fine but it is safer to avoid calling read with a negative handle. Added negative file descriptor check. Signed-off-by: Nathan Hjelm --- opal/mca/memory/patcher/memory_patcher_component.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/opal/mca/memory/patcher/memory_patcher_component.c b/opal/mca/memory/patcher/memory_patcher_component.c index 0b029ad15d..4771554b58 100644 --- a/opal/mca/memory/patcher/memory_patcher_component.c +++ b/opal/mca/memory/patcher/memory_patcher_component.c @@ -277,7 +277,9 @@ static size_t memory_patcher_get_shm_seg_size (const void *shmaddr) seg_size = 0; fd = open ("/proc/self/maps", O_RDONLY); - assert (fd >= 0); + if (fd < 0) { + return 0; + } for (size_t read_offset = 0 ; ; ) { ssize_t nread = read(fd, buffer + read_offset, sizeof(buffer) - 1 - read_offset);