Do not tolerate uninitialized variables.

This commit was SVN r25489.

ompi/runtime/ompi_mpi_init.c

@@ -443,7 +443,7 @@ int ompi_mpi_init(int argc, char **argv, int requested, int *provided)
         bool paffinity_enabled=false;
         orte_node_rank_t nrank;
         hwloc_obj_type_t target;
-        unsigned cache_level;
+        unsigned int cache_level = 0;
         struct hwloc_topology_support *support;
 
         /* see if we were bound when launched */

opal/mca/hwloc/base/hwloc_base_util.c

@@ -85,7 +85,7 @@ static hwloc_obj_t get_pu(hwloc_topology_t topo,  int lid)
 int opal_hwloc_base_filter_cpus(hwloc_topology_t topo)
 {
     hwloc_obj_t root, pu;
-    hwloc_cpuset_t avail, pucpus, res;
+    hwloc_cpuset_t avail = NULL, pucpus, res;
     opal_hwloc_topo_data_t *sum;
     char **ranges=NULL, **range=NULL;
     int idx, cpu, start, end;
@@ -93,12 +93,10 @@ int opal_hwloc_base_filter_cpus(hwloc_topology_t topo)
     root = hwloc_get_root_obj(topo);
 
     if (NULL == root->userdata) {
-        /* create the summary object */
+        root->userdata = (void*)OBJ_NEW(opal_hwloc_topo_data_t);
-        sum = OBJ_NEW(opal_hwloc_topo_data_t);
-        root->userdata = (void*)sum;
-    } else {
-        sum = (opal_hwloc_topo_data_t*)root->userdata;
     }
+    sum = (opal_hwloc_topo_data_t*)root->userdata;
+
     /* should only ever enter here once, but check anyway */
     if (NULL != sum->available) {
         OPAL_OUTPUT_VERBOSE((5, opal_hwloc_base_output,
@@ -1261,7 +1259,7 @@ char* opal_hwloc_base_print_binding(opal_binding_policy_t binding)
 
 char* opal_hwloc_base_print_level(opal_hwloc_level_t level)
 {
-    char *ret;
+    char *ret = "unknown";
 
     switch(level) {
     case OPAL_HWLOC_NODE_LEVEL:

orte/mca/ess/base/ess_base_std_orted.c

@@ -88,7 +88,7 @@ static void epipe_signal_callback(int fd, short flags, void *arg);
 
 int orte_ess_base_orted_setup(char **hosts)
 {
-    int ret;
+    int ret = ORTE_ERROR;
     int fd;
     char log_file[PATH_MAX];
     char *jobidstring;

orte/mca/rmaps/base/rmaps_base_binding.c

@@ -63,7 +63,7 @@ static int bind_upwards(orte_job_t *jdata,
     orte_proc_t *proc;
     hwloc_obj_t obj;
     hwloc_cpuset_t cpus;
-    unsigned int idx, ncpus, nobjs, nsave, *nbound=NULL;
+    unsigned int idx, ncpus, nobjs, nsave = 0, *nbound=NULL;
     struct hwloc_topology_support *support;
 
     opal_output_verbose(5, orte_rmaps_base.rmaps_output,
@@ -218,7 +218,7 @@ static int bind_downwards(orte_job_t *jdata,
     orte_proc_t *proc;
     hwloc_obj_t obj;
     hwloc_cpuset_t cpus;
-    unsigned int n, idx, minval, ncpus, nobjs, nsave, *nbound=NULL;
+    unsigned int n, idx, minval, ncpus, nobjs, nsave = 0, *nbound=NULL;
     struct hwloc_topology_support *support;
 
     opal_output_verbose(5, orte_rmaps_base.rmaps_output,
@@ -354,7 +354,7 @@ static int bind_in_place(orte_job_t *jdata,
     orte_node_t *node;
     orte_proc_t *proc;
     hwloc_cpuset_t cpus;
-    unsigned int idx, ncpus, nobjs, nsave, *nbound=NULL;
+    unsigned int idx, ncpus, nobjs, nsave = 0, *nbound=NULL;
     struct hwloc_topology_support *support;
 
     opal_output_verbose(5, orte_rmaps_base.rmaps_output,

orte/mca/rmaps/ppr/rmaps_ppr.c

@@ -51,7 +51,7 @@ static int ppr[OPAL_HWLOC_HWTHREAD_LEVEL+1];
 
 static int ppr_mapper(orte_job_t *jdata)
 {
-    int rc, j, n;
+    int rc = ORTE_SUCCESS, j, n;
     mca_base_component_t *c=&mca_rmaps_ppr_component.base_version;
     orte_node_t *node;
     orte_proc_t *proc;
@@ -396,10 +396,10 @@ static void prune(orte_jobid_t jobid,
     hwloc_obj_t obj, top;
     unsigned int i, nobjs;
     hwloc_obj_type_t lvl;
-    unsigned cache_level, k;
+    unsigned cache_level = 0, k;
     int nprocs;
     hwloc_cpuset_t avail, cpus, childcpus;
-    int n, limit, nmax, nunder, idx, idxmax;
+    int n, limit, nmax, nunder, idx, idxmax = 0;
     orte_proc_t *proc, *pptr, *procmax;
     opal_hwloc_level_t ll;
     char dang[64];