From 52c9e631de462bf84be3c264406a5f77110df364 Mon Sep 17 00:00:00 2001 From: Ralph Castain Date: Tue, 14 Mar 2017 07:30:42 -0700 Subject: [PATCH] Silence Coverity warnings Signed-off-by: Ralph Castain --- orte/mca/plm/rsh/plm_rsh_module.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/orte/mca/plm/rsh/plm_rsh_module.c b/orte/mca/plm/rsh/plm_rsh_module.c index 5d6509fd37..a8cd21e002 100644 --- a/orte/mca/plm/rsh/plm_rsh_module.c +++ b/orte/mca/plm/rsh/plm_rsh_module.c @@ -1106,7 +1106,8 @@ static void launch_daemons(int fd, short args, void *cbdata) true, mca_plm_rsh_component.num_concurrent, map->num_new_daemons); ORTE_ERROR_LOG(ORTE_ERR_FATAL); OBJ_RELEASE(state); - return; + rc = ORTE_ERR_SILENT; + goto cleanup; } /* @@ -1151,6 +1152,13 @@ static void launch_daemons(int fd, short args, void *cbdata) } } } + if (NULL == node) { + /* this should be impossible, but adding the check will + * silence code checkers that don't know better */ + ORTE_ERROR_LOG(ORTE_ERR_NOT_FOUND); + rc = ORTE_ERR_NOT_FOUND; + goto cleanup; + } /* if we are tree launching, find our children and create the launch cmd */ if (!mca_plm_rsh_component.no_tree_spawn) {