mca/base: silence some clang/coverity warnings

Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>

opal/mca/base/mca_base_component_repository.c

@@ -197,6 +197,8 @@ int mca_base_component_repository_add (const char *path)
         }
     } while (NULL != (dir = strtok_r (NULL, sep, &ctx)));
 
+    free (path_to_use);
+
 #endif /* OPAL_HAVE_DL_SUPPORT */
 
     return OPAL_SUCCESS;
@@ -401,6 +403,7 @@ int mca_base_component_repository_open (mca_base_framework_t *framework,
 
         /* done with the structure name */
         free (struct_name);
+        struct_name = NULL;
 
         /* We found the public struct.  Make sure its MCA major.minor
            version is the same as ours. TODO -- add checks for project version (from framework) */

opal/mca/base/mca_base_var_enum.c

@@ -126,7 +126,7 @@ int mca_base_var_enum_create (const char *name, const mca_base_var_enum_value_t
     /* make a copy of the values */
     new_enum->enum_values = calloc (new_enum->enum_value_count + 1, sizeof (*new_enum->enum_values));
     if (NULL == new_enum->enum_values) {
-        OBJ_DESTRUCT(new_enum);
+        OBJ_RELEASE(new_enum);
         return OPAL_ERR_OUT_OF_RESOURCE;
     }
 

opal/mca/base/mca_base_var_group.c

@@ -188,7 +188,12 @@ static int group_register (const char *project_name, const char *framework_name,
 
     group_id = group_find (project_name, framework_name, component_name, true);
     if (0 <= group_id) {
-        (void) mca_base_var_group_get_internal (group_id, &group, true);
+        ret = mca_base_var_group_get_internal (group_id, &group, true);
+        if (OPAL_SUCCESS != ret) {
+            /* something went horribly wrong */
+            assert (NULL != group);
+            return ret;
+        }
         group->group_isvalid = true;
         mca_base_var_groups_timestamp++;