ports/openmpi
ports/openmpi
1
1
Форкнуть 0
Код Релизы Активность

Grrrr....fix ALL the cases where the membind warning occurs.

Просмотр исходного кода 
This commit was SVN r25715.
Этот коммит содержится в:
Ralph Castain 2012-01-11 23:51:18 +00:00
родитель ce7ddd0e10
Коммит 477582abef
1 изменённых файлов: 32 добавлений и 9 удалений
Показать статистику Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

41
orte/mca/rmaps/base/rmaps_base_binding.c
Просмотреть файл

@ -79,7 +79,6 @@ static int bind_upwards(orte_job_t *jdata,
if (NULL == (node = (orte_node_t*)opal_pointer_array_get_item(map->nodes, i))) {
continue;
}
/* check if topology supports cpubind - if not, then we cannot bind */
support = (struct hwloc_topology_support*)hwloc_topology_get_support(node->topology);
/* check if topology supports cpubind - have to be careful here
* as Linux doesn't currently support thread-level binding. This
@ -247,9 +246,14 @@ static int bind_downwards(orte_job_t *jdata,
if (NULL == (node = (orte_node_t*)opal_pointer_array_get_item(map->nodes, i))) {
continue;
}
/* check if topology supports cpubind - if not, then we cannot bind */
support = (struct hwloc_topology_support*)hwloc_topology_get_support(node->topology);
if (!support->cpubind->set_thisproc_cpubind) {
/* check if topology supports cpubind - have to be careful here
* as Linux doesn't currently support thread-level binding. This
* may change in the future, though, and it isn't clear how hwloc
* interprets the current behavior. So check both flags to be sure.
*/
if (!support->cpubind->set_thisproc_cpubind &&
!support->cpubind->set_thisthread_cpubind) {
if (!OPAL_BINDING_REQUIRED(opal_hwloc_binding_policy)) {
/* we are not required to bind, so ignore this */
continue;
@ -260,8 +264,15 @@ static int bind_downwards(orte_job_t *jdata,
}
return ORTE_ERR_SILENT;
}
/* check if topology supports membind */
if (!support->membind->set_thisproc_membind) {
/* check if topology supports membind - have to be careful here
* as hwloc treats this differently than I (at least) would have
* expected. Per hwloc, Linux memory binding is at the thread,
* and not process, level. Thus, hwloc sets the "thisproc" flag
* to "false" on all Linux systems, and uses the "thisthread" flag
* to indicate binding capability
*/
if (!support->membind->set_thisproc_membind &&
!support->membind->set_thisthread_membind) {
if (OPAL_HWLOC_BASE_MBFA_WARN == opal_hwloc_base_mbfa && !membind_warned) {
orte_show_help("help-orte-rmaps-base.txt", "rmaps:membind-not-supported", true, node->name);
membind_warned = true;
@ -383,9 +394,14 @@ static int bind_in_place(orte_job_t *jdata,
if (NULL == (node = (orte_node_t*)opal_pointer_array_get_item(map->nodes, i))) {
continue;
}
/* check if topology supports cpubind - if not, then we cannot bind */
support = (struct hwloc_topology_support*)hwloc_topology_get_support(node->topology);
if (!support->cpubind->set_thisproc_cpubind) {
/* check if topology supports cpubind - have to be careful here
* as Linux doesn't currently support thread-level binding. This
* may change in the future, though, and it isn't clear how hwloc
* interprets the current behavior. So check both flags to be sure.
*/
if (!support->cpubind->set_thisproc_cpubind &&
!support->cpubind->set_thisthread_cpubind) {
if (!OPAL_BINDING_REQUIRED(opal_hwloc_binding_policy)) {
/* we are not required to bind, so ignore this */
continue;
@ -396,8 +412,15 @@ static int bind_in_place(orte_job_t *jdata,
}
return ORTE_ERR_SILENT;
}
/* check if topology supports membind */
if (!support->membind->set_thisproc_membind) {
/* check if topology supports membind - have to be careful here
* as hwloc treats this differently than I (at least) would have
* expected. Per hwloc, Linux memory binding is at the thread,
* and not process, level. Thus, hwloc sets the "thisproc" flag
* to "false" on all Linux systems, and uses the "thisthread" flag
* to indicate binding capability
*/
if (!support->membind->set_thisproc_membind &&
!support->membind->set_thisthread_membind) {
if (OPAL_HWLOC_BASE_MBFA_WARN == opal_hwloc_base_mbfa && !membind_warned) {
orte_show_help("help-orte-rmaps-base.txt", "rmaps:membind-not-supported", true, node->name);
membind_warned = true;