Per Jeff's request (which made a lot of sense), setup the default buffer type to be DESCRIBED for debug/devel builds, and NON-DESC for optimized builds. The user can still select the default buffer type via mca parameter at runtime - this just sets the default default. :-)

Also, change the dss buffer type mca param to something more easily remembered (it is now "dss_buffer_type"). Heck, even I had to keep looking at the darn code to remember it.

This commit was SVN r12728.

orte/dss/dss_open_close.c

@@ -144,6 +144,7 @@ int orte_dss_open(void)
     char *enviro_val;
     int id, page_size, rc;
     orte_data_type_t tmp;
+    int def_type;
 
     if (orte_dss_initialized) {
         return ORTE_SUCCESS;
@@ -156,20 +157,21 @@ int orte_dss_open(void)
         orte_dss_debug = false;
     }
 
-    /** set the default buffer type. If we are in debug mode - as given by
-     * the orte_debug param being set - then we use fully described buffers.
-     * Otherwise, we default to non-described for brevity
+    /** set the default buffer type. If we are in debug mode, then we default
+     * to fully described buffers. Otherwise, we default to non-described for brevity
+     * and performance
      */
-    id = mca_base_param_register_int("dss", "describe", "buffer",
-                                     "Set the default mode for OpenRTE buffers (0=non-described [default], 1=described",
-                                     0);
+#if OMPI_ENABLE_DEBUG
+    def_type = ORTE_DSS_BUFFER_FULLY_DESC;
+#else
+    def_type = ORTE_DSS_BUFFER_NON_DESC;
+#endif
+
+    id = mca_base_param_register_int("dss", "buffer", "type",
+                                     "Set the default mode for OpenRTE buffers (0=non-described, 1=described",
+                                     def_type);
     mca_base_param_lookup_int(id, &rc);
-    if (0 == rc) {
-        /* param not set - assume non-described buffers */
-        default_buf_type = ORTE_DSS_BUFFER_NON_DESC;
-    } else {
-        default_buf_type = ORTE_DSS_BUFFER_FULLY_DESC;
-    }
+    default_buf_type = rc;
 
     /* setup the page size -this is for use by the BUFFER system, NOT the data type
        manager that keeps track of registered data types!! It must be converted to

orte/dss/dss_types.h

@@ -61,8 +61,8 @@ ORTE_DECLSPEC OBJ_CLASS_DECLARATION(orte_data_value_t);
  * buffer type
  */
 typedef uint8_t orte_dss_buffer_type_t;
+#define ORTE_DSS_BUFFER_NON_DESC        0x00
 #define ORTE_DSS_BUFFER_FULLY_DESC      0x01
-#define ORTE_DSS_BUFFER_NON_DESC        0x02
 
 /**
      * Structure for holding a buffer to be used with the RML or OOB