From 2503b5f10faa3810c5f36900cf248df0e7177c84 Mon Sep 17 00:00:00 2001 From: Joseph Schuchart Date: Tue, 21 Apr 2020 22:49:48 +0200 Subject: [PATCH] RDMA osc: remove extra retain on pending_op Signed-off-by: Joseph Schuchart (cherry picked from commit de67ada44251b2792f3fef19d890dc7aad39dd73) --- ompi/mca/osc/rdma/osc_rdma_lock.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/ompi/mca/osc/rdma/osc_rdma_lock.h b/ompi/mca/osc/rdma/osc_rdma_lock.h index 7af4d703f6..9e7ec485f0 100644 --- a/ompi/mca/osc/rdma/osc_rdma_lock.h +++ b/ompi/mca/osc/rdma/osc_rdma_lock.h @@ -45,9 +45,7 @@ static inline int ompi_osc_rdma_btl_fop (ompi_osc_rdma_module_t *module, struct pending_op = OBJ_NEW(ompi_osc_rdma_pending_op_t); assert (NULL != pending_op); - if (wait_for_completion) { - OBJ_RETAIN(pending_op); - } else { + if (!wait_for_completion) { /* NTH: need to keep track of pending ops to avoid a potential teardown problem */ pending_op->module = module; (void) opal_atomic_fetch_add_32 (&module->pending_ops, 1);