Merge pull request #615 from hjelmn/opal_coverity

event/libevent2022: fix coverity issue

opal/mca/crs/none/crs_none_module.c

@@ -1,8 +1,11 @@
+/* -*- Mode: C; c-basic-offset:4 ; indent-tabs-mode:nil -*- */
 /*
  * Copyright (c) 2004-2010 The Trustees of Indiana University.
  *                         All rights reserved.
  *
  * Copyright (c) 2015 Cisco Systems, Inc.  All rights reserved.
+ * Copyright (c) 2015      Los Alamos National Security, LLC. All rights
+ *                         reserved.
  * $COPYRIGHT$
  * 
  * Additional copyrights may follow
@@ -101,8 +104,7 @@ int opal_crs_none_restart(opal_crs_base_snapshot_t *base_snapshot, bool spawn_ch
             opal_output(0,
                         "crs:none: checkpoint(): Error: Unable to open the file (%s)",
                         base_snapshot->metadata_filename);
-            exit_status = OPAL_ERROR;
+            return OPAL_ERROR;
-            goto cleanup;
         }
     }
 
@@ -131,10 +133,9 @@ int opal_crs_none_restart(opal_crs_base_snapshot_t *base_snapshot, bool spawn_ch
     if( !spawn_child ) {
         opal_output_verbose(10, opal_crs_base_framework.framework_output,
                             "crs:none: none_restart: exec :(%s, %s):",
-                            strdup(cr_argv[0]),
+                            cr_argv[0], tmp_argv[0]);
-                            opal_argv_join(cr_argv, ' '));
 
-        status = execvp(strdup(cr_argv[0]), cr_argv);
+        status = execvp(cr_argv[0], cr_argv);
 
         if(status < 0) {
             opal_output(opal_crs_base_framework.framework_output,
@@ -152,10 +153,11 @@ int opal_crs_none_restart(opal_crs_base_snapshot_t *base_snapshot, bool spawn_ch
     }
 
  cleanup:
-    if (NULL != base_snapshot->metadata) {
+    if (cr_argv) {
-        fclose(base_snapshot->metadata);
+        opal_argv_free (cr_argv);
     }
-    base_snapshot->metadata = NULL;
+
+    fclose(base_snapshot->metadata);
     
     return exit_status;
 }

opal/mca/event/libevent2022/libevent2022_component.c

@@ -125,7 +125,7 @@ static int libevent2022_register (void)
     const struct eventop** _eventop = eventops;
     char available_eventops[1024] = "none";
     char *help_msg = NULL;
-    int ret, len = 1024;
+    int ret;
 
     /* Retrieve the upper level specified event system, if any.
      * Default to select() on OS X and poll() everywhere else because
@@ -153,17 +153,15 @@ static int libevent2022_register (void)
      */
 
     if (NULL != (*_eventop)) {
-        available_eventops[0] = '\0';
+        const int len = sizeof (available_eventops);
-    }
+        int cur_len = snprintf (available_eventops, len, "%s", (*(_eventop++))->name);
 
-    while( NULL != (*_eventop) ) {
+        for (int i = 1 ; eventops[i] && cur_len < len ; ++i) {
-        if( available_eventops[0] != '\0' ) {
+            cur_len += snprintf (available_eventops + cur_len, len - cur_len, ", %s",
-            (void) strncat (available_eventops, ", ", len);
+                                 eventops[i]->name);
         }
-        (void) strncat (available_eventops, (*_eventop)->name,
+        /* ensure the available_eventops string is always NULL-terminated  */
-                        len);
+        available_eventops[len - 1] = '\0';
-        _eventop++;  /* go to the next available eventop */
-        len = 1024 - strlen(available_eventops);
     }
 
 #ifdef __APPLE__