1
1

Do not alter ompi_coll_tuned_use_dynamic_rules.

This is set globally as an MCA parameter and should be never
altered based on a single communicator setting.
Этот коммит содержится в:
George Bosilca 2016-10-25 12:16:18 -04:00
родитель 253eb80e26
Коммит 028e747470
2 изменённых файлов: 0 добавлений и 13 удалений

Просмотреть файл

@ -160,7 +160,6 @@ static int tuned_register(void)
MCA_BASE_VAR_SCOPE_READONLY,
&ompi_coll_tuned_alltoall_intermediate_msg);
ompi_coll_tuned_use_dynamic_rules = false;
(void) mca_base_component_var_register(&mca_coll_tuned_component.super.collm_version,
"use_dynamic_rules",
"Switch used to decide if we use static (compiled/if statements) or dynamic (built at runtime) decision function rules",

Просмотреть файл

@ -152,7 +152,6 @@ ompi_coll_tuned_forced_getvalues( enum COLLTYPE type,
(TMOD)->com_rules[(TYPE)] = NULL; \
if( 0 != (TMOD)->user_forced[(TYPE)].algorithm ) { \
need_dynamic_decision = 1; \
EXECUTE; \
} \
if( NULL != mca_coll_tuned_component.all_base_rules ) { \
(TMOD)->com_rules[(TYPE)] \
@ -164,7 +163,6 @@ ompi_coll_tuned_forced_getvalues( enum COLLTYPE type,
} \
if( 1 == need_dynamic_decision ) { \
OPAL_OUTPUT((ompi_coll_tuned_stream,"coll:tuned: enable dynamic selection for "#TYPE)); \
ompi_coll_tuned_use_dynamic_rules = true; \
EXECUTE; \
} \
}
@ -208,10 +206,6 @@ tuned_module_enable( mca_coll_base_module_t *module,
if (ompi_coll_tuned_use_dynamic_rules) {
OPAL_OUTPUT((ompi_coll_tuned_stream,"coll:tuned:module_init MCW & Dynamic"));
/**
* Reset it to 0, it will be enabled again if we discover any need for dynamic decisions.
*/
ompi_coll_tuned_use_dynamic_rules = false;
/**
* next dynamic state, recheck all forced rules as well
@ -249,12 +243,6 @@ tuned_module_enable( mca_coll_base_module_t *module,
tuned_module->super.coll_scatter = ompi_coll_tuned_scatter_intra_dec_dynamic);
COLL_TUNED_EXECUTE_IF_DYNAMIC(tuned_module, SCATTERV,
tuned_module->super.coll_scatterv = NULL);
if( false == ompi_coll_tuned_use_dynamic_rules ) {
/* no real need for dynamic decisions */
OPAL_OUTPUT((ompi_coll_tuned_stream, "coll:tuned:module_enable switch back to fixed"
" decision by lack of dynamic rules"));
}
}
/* general n fan out tree */