ports/openmpi
ports/openmpi
1
1
Форкнуть 0
Код Релизы Активность

btl/ofi: fix memory leaks in error handling path

Просмотр исходного кода 
Currently, mca_btl_ofi_put (get, aop, afop, acswp) will allocate
a mca_btl_ofi_rdma_completion_t object and use it as the context
for fi_write/fi_read/fi_atomic/fi_fetch_atomic/fi_compare_atomic.

In normal code path, this completion object when processing completion
entry. However, when error happened when calling

fi_write/fi_read/fi_atomic/fi_fetch_atomic/fi_compare_atomic,

there will be no completion entry from libfabric, in this case the
completion object's memory is leaked.

This patch address the issue by calling opal_free_list_return() in
the error handling code path.

Signed-off-by: Wei Zhang <wzam@amazon.com>
Этот коммит содержится в:
Wei Zhang 2020-12-22 21:25:07 +00:00
родитель 3f6877b510
Коммит 01f5d6896d
2 изменённых файлов: 10 добавлений и 0 удалений
Показать статистику Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

6
opal/mca/btl/ofi/btl_ofi_atomics.c
Просмотреть файл

@ -73,8 +73,10 @@ int mca_btl_ofi_afop (struct mca_btl_base_module_t *btl, struct mca_btl_base_end
fi_datatype, fi_op, &comp->comp_ctx);
if (rc == -FI_EAGAIN) {
opal_free_list_return(comp->base.my_list, (opal_free_list_item_t*) comp);
return OPAL_ERR_OUT_OF_RESOURCE;
} else if (rc < 0) {
opal_free_list_return(comp->base.my_list, (opal_free_list_item_t*) comp);
BTL_ERROR(("fi_fetch_atomic failed with rc=%d (%s)", rc, fi_strerror(-rc)));
MCA_BTL_OFI_ABORT();
}
@ -125,8 +127,10 @@ int mca_btl_ofi_aop (struct mca_btl_base_module_t *btl, mca_btl_base_endpoint_t
fi_datatype, fi_op, &comp->comp_ctx);
if (rc == -FI_EAGAIN) {
opal_free_list_return(comp->base.my_list, (opal_free_list_item_t*) comp);
return OPAL_ERR_OUT_OF_RESOURCE;
} else if (rc < 0) {
opal_free_list_return(comp->base.my_list, (opal_free_list_item_t*) comp);
BTL_ERROR(("fi_atomic failed with rc=%d (%s)", rc, fi_strerror(-rc)));
MCA_BTL_OFI_ABORT();
}
@ -181,8 +185,10 @@ int mca_btl_ofi_acswap (struct mca_btl_base_module_t *btl, struct mca_btl_base_e
&comp->comp_ctx);
if (rc == -FI_EAGAIN) {
opal_free_list_return(comp->base.my_list, (opal_free_list_item_t*) comp);
return OPAL_ERR_OUT_OF_RESOURCE;
} else if (rc < 0) {
opal_free_list_return(comp->base.my_list, (opal_free_list_item_t*) comp);
BTL_ERROR(("fi_compare_atomic failed with rc=%d (%s)", rc, fi_strerror(-rc)));
MCA_BTL_OFI_ABORT();
}

4
opal/mca/btl/ofi/btl_ofi_rdma.c
Просмотреть файл

@ -88,10 +88,12 @@ int mca_btl_ofi_get (mca_btl_base_module_t *btl, mca_btl_base_endpoint_t *endpoi
&comp->comp_ctx); /* completion context */
if (-FI_EAGAIN == rc) {
opal_free_list_return(comp->base.my_list, (opal_free_list_item_t*) comp);
return OPAL_ERR_OUT_OF_RESOURCE;
}
if (0 != rc) {
opal_free_list_return(comp->base.my_list, (opal_free_list_item_t*) comp);
BTL_ERROR(("fi_read failed with %d:%s", rc, fi_strerror(-rc)));
MCA_BTL_OFI_ABORT();
}
@ -133,10 +135,12 @@ int mca_btl_ofi_put (mca_btl_base_module_t *btl, mca_btl_base_endpoint_t *endpoi
&comp->comp_ctx); /* completion context */
if (-FI_EAGAIN == rc) {
opal_free_list_return(comp->base.my_list, (opal_free_list_item_t*) comp);
return OPAL_ERR_OUT_OF_RESOURCE;
}
if (0 != rc) {
opal_free_list_return(comp->base.my_list, (opal_free_list_item_t*) comp);
BTL_ERROR(("fi_write failed with %d:%s", rc, fi_strerror(-rc)));
MCA_BTL_OFI_ABORT();
}