diff --git a/ompi/mca/osc/rdma/osc_rdma_component.c b/ompi/mca/osc/rdma/osc_rdma_component.c index 45191f2fb0..a7698522f4 100644 --- a/ompi/mca/osc/rdma/osc_rdma_component.c +++ b/ompi/mca/osc/rdma/osc_rdma_component.c @@ -170,69 +170,88 @@ static int ompi_osc_rdma_pvar_read (const struct mca_base_pvar_t *pvar, void *va static int ompi_osc_rdma_component_register (void) { + char *description_str; mca_osc_rdma_component.no_locks = false; + asprintf(&description_str, "Enable optimizations available only if MPI_LOCK is " + "not used. Info key of same name overrides this value (default: %s)", + mca_osc_rdma_component.no_locks ? "true" : "false"); (void) mca_base_component_var_register(&mca_osc_rdma_component.super.osc_version, - "no_locks", "Enable optimizations available only if MPI_LOCK is " - "not used. Info key of same name overrides this value (default: false)", + "no_locks", description_str, MCA_BASE_VAR_TYPE_BOOL, NULL, 0, 0, OPAL_INFO_LVL_5, MCA_BASE_VAR_SCOPE_GROUP, &mca_osc_rdma_component.no_locks); + free(description_str); mca_osc_rdma_component.acc_single_intrinsic = false; + asprintf(&description_str, "Enable optimizations for MPI_Fetch_and_op, MPI_Accumulate, etc for codes " + "that will not use anything more than a single predefined datatype (default: %s)", + mca_osc_rdma_component.acc_single_intrinsic ? "true" : "false"); (void) mca_base_component_var_register(&mca_osc_rdma_component.super.osc_version, "acc_single_intrinsic", - "Enable optimizations for MPI_Fetch_and_op, MPI_Accumulate, etc for codes " - "that will not use anything more than a single predefined datatype (default: false)", + description_str, MCA_BASE_VAR_TYPE_BOOL, NULL, 0, 0, OPAL_INFO_LVL_5, MCA_BASE_VAR_SCOPE_GROUP, &mca_osc_rdma_component.acc_single_intrinsic); + free(description_str); mca_osc_rdma_component.acc_use_amo = true; + asprintf(&description_str, "Enable the use of network atomic memory operations when using single " + "intrinsic optimizations. If not set network compare-and-swap will be " + "used instread (default: %s)", mca_osc_rdma_component.acc_use_amo ? "true" : "false"); (void) mca_base_component_var_register(&mca_osc_rdma_component.super.osc_version, "acc_use_amo", - "Enable the use of network atomic memory operations when using single " - "intrinsic optimizations. If not set network compare-and-swap will be " - "used instread (default: true)", MCA_BASE_VAR_TYPE_BOOL, NULL, 0, 0, OPAL_INFO_LVL_5, + description_str, MCA_BASE_VAR_TYPE_BOOL, NULL, 0, 0, OPAL_INFO_LVL_5, MCA_BASE_VAR_SCOPE_GROUP, &mca_osc_rdma_component.acc_use_amo); + free(description_str); mca_osc_rdma_component.buffer_size = 32768; + asprintf(&description_str, "Size of temporary buffers (default: %d)", mca_osc_rdma_component.buffer_size); (void) mca_base_component_var_register (&mca_osc_rdma_component.super.osc_version, "buffer_size", - "Size of temporary buffers (default: 32k)", MCA_BASE_VAR_TYPE_UNSIGNED_INT, + description_str, MCA_BASE_VAR_TYPE_UNSIGNED_INT, NULL, 0, 0, OPAL_INFO_LVL_3, MCA_BASE_VAR_SCOPE_LOCAL, &mca_osc_rdma_component.buffer_size); + free(description_str); mca_osc_rdma_component.max_attach = 32; + asprintf(&description_str, "Maximum number of buffers that can be attached to a dynamic window. " + "Keep in mind that each attached buffer will use a potentially limited " + "resource (default: %d)", mca_osc_rdma_component.max_attach); (void) mca_base_component_var_register (&mca_osc_rdma_component.super.osc_version, "max_attach", - "Maximum number of buffers that can be attached to a dynamic window. " - "Keep in mind that each attached buffer will use a potentially limited " - "resource (default: 32)", MCA_BASE_VAR_TYPE_UNSIGNED_INT, NULL, 0, 0, + description_str , MCA_BASE_VAR_TYPE_UNSIGNED_INT, NULL, 0, 0, OPAL_INFO_LVL_3, MCA_BASE_VAR_SCOPE_GROUP, &mca_osc_rdma_component.max_attach); + free(description_str); mca_osc_rdma_component.aggregation_limit = 1024; + asprintf(&description_str, "Maximum size of an aggregated put/get. Messages are aggregated for consecutive" + "put and get operations. In some cases this may lead to higher latency but " + "should also lead to higher bandwidth utilization. Set to 0 to disable (default: %d)", + mca_osc_rdma_component.aggregation_limit); (void) mca_base_component_var_register (&mca_osc_rdma_component.super.osc_version, "aggregation_limit", - "Maximum size of an aggregated put/get. Messages are aggregated for consecutive" - "put and get operations. In some cases this may lead to higher latency but " - "should also lead to higher bandwidth utilization. Set to 0 to disable (default:" - " 1k)", MCA_BASE_VAR_TYPE_UNSIGNED_INT, NULL, 0, 0, OPAL_INFO_LVL_3, + description_str, MCA_BASE_VAR_TYPE_UNSIGNED_INT, NULL, 0, 0, OPAL_INFO_LVL_3, MCA_BASE_VAR_SCOPE_GROUP, &mca_osc_rdma_component.aggregation_limit); + free(description_str); mca_osc_rdma_component.priority = 90; + asprintf(&description_str, "Priority of the osc/rdma component (default: %d)", + mca_osc_rdma_component.priority); (void) mca_base_component_var_register (&mca_osc_rdma_component.super.osc_version, "priority", - "Priority of the osc/rdma component (default: 90)", - MCA_BASE_VAR_TYPE_UNSIGNED_INT, NULL, 0, 0, OPAL_INFO_LVL_3, + description_str, MCA_BASE_VAR_TYPE_UNSIGNED_INT, NULL, 0, 0, OPAL_INFO_LVL_3, MCA_BASE_VAR_SCOPE_GROUP, &mca_osc_rdma_component.priority); + free(description_str); ompi_osc_rdma_btl_names = "openib,ugni"; + asprintf(&description_str, "Comma-delimited list of BTL component names to allow without verifying " + "connectivity. Do not add a BTL to to this list unless it can reach all " + "processes in any communicator used with an MPI window (default: %s)", + ompi_osc_rdma_btl_names); (void) mca_base_component_var_register (&mca_osc_rdma_component.super.osc_version, "btls", - "Comma-delimited list of BTL component names to allow without verifying " - "connectivity. Do not add a BTL to to this list unless it can reach all " - "processes in any communicator used with an MPI window (default: openib,ugni)", - MCA_BASE_VAR_TYPE_STRING, NULL, 0, 0, OPAL_INFO_LVL_3, + description_str, MCA_BASE_VAR_TYPE_STRING, NULL, 0, 0, OPAL_INFO_LVL_3, MCA_BASE_VAR_SCOPE_GROUP, &ompi_osc_rdma_btl_names); + free(description_str); ompi_osc_rdma_mtl_names = "psm2"; + asprintf(&description_str, "Comma-delimited list of MTL component names to lower the priority of rdma " + "osc component favoring pt2pt osc (default: %s)", ompi_osc_rdma_mtl_names); (void) mca_base_component_var_register (&mca_osc_rdma_component.super.osc_version, "mtls", - "Comma-delimited list of MTL component names to lower the priority of rdma " - "osc component favoring pt2pt osc (default: psm2)", - MCA_BASE_VAR_TYPE_STRING, NULL, 0, 0, OPAL_INFO_LVL_3, + description_str, MCA_BASE_VAR_TYPE_STRING, NULL, 0, 0, OPAL_INFO_LVL_3, MCA_BASE_VAR_SCOPE_GROUP, &ompi_osc_rdma_mtl_names); - + free(description_str); /* register performance variables */ @@ -726,16 +745,20 @@ static int allocate_state_shared (ompi_osc_rdma_module_t *module, void **base, s static int ompi_osc_rdma_query_mtls (void) { char **mtls_to_use; + bool mtl_match = false; mtls_to_use = opal_argv_split (ompi_osc_rdma_mtl_names, ','); if (mtls_to_use && ompi_mtl_base_selected_component) { - for (int i = 0 ; mtls_to_use[i] ; ++i) { - if (0 == strcmp (mtls_to_use[i], ompi_mtl_base_selected_component->mtl_version.mca_component_name)) { - return OMPI_SUCCESS; - } - } + for (int i = 0 ; mtls_to_use[i] ; ++i) { + if (0 == strcmp (mtls_to_use[i], ompi_mtl_base_selected_component->mtl_version.mca_component_name)) { + mtl_match = true; + break; + } + } } - return -1; + + opal_argv_free (mtls_to_use); + return mtl_match ? OMPI_SUCCESS : OMPI_ERR_NOT_FOUND; } static int ompi_osc_rdma_query_btls (ompi_communicator_t *comm, struct mca_btl_base_module_t **btl)