2014-05-15 22:28:03 +04:00
|
|
|
/* -*- Mode: C; c-basic-offset:4 ; indent-tabs-mode:nil -*- */
|
2004-01-15 09:08:25 +03:00
|
|
|
/*
|
2010-03-13 02:57:50 +03:00
|
|
|
* Copyright (c) 2004-2010 The Trustees of Indiana University and Indiana
|
2005-11-05 22:57:48 +03:00
|
|
|
* University Research and Technology
|
|
|
|
|
* Corporation. All rights reserved.
|
2011-10-04 18:50:31 +04:00
|
|
|
* Copyright (c) 2004-2011 The University of Tennessee and The University
|
2005-11-05 22:57:48 +03:00
|
|
|
* of Tennessee Research Foundation. All rights
|
|
|
|
|
* reserved.
|
2004-11-28 23:09:25 +03:00
|
|
|
* Copyright (c) 2004-2005 High Performance Computing Center Stuttgart,
|
|
|
|
|
* University of Stuttgart. All rights reserved.
|
2005-03-24 15:43:37 +03:00
|
|
|
* Copyright (c) 2004-2005 The Regents of the University of California.
|
|
|
|
|
* All rights reserved.
|
2013-12-24 15:05:51 +04:00
|
|
|
* Copyright (c) 2006-2013 Cisco Systems, Inc. All rights reserved.
|
2014-05-15 22:28:03 +04:00
|
|
|
* Copyright (c) 2006-2014 Los Alamos National Security, LLC. All rights
|
2006-11-22 05:06:52 +03:00
|
|
|
* reserved.
|
2006-12-05 22:07:02 +03:00
|
|
|
* Copyright (c) 2006 University of Houston. All rights reserved.
|
2009-02-24 20:17:33 +03:00
|
|
|
* Copyright (c) 2009 Sun Microsystems, Inc. All rights reserved.
|
2012-02-06 21:35:21 +04:00
|
|
|
* Copyright (c) 2011 Sandia National Laboratories. All rights reserved.
|
2014-01-13 21:43:24 +04:00
|
|
|
* Copyright (c) 2014 Intel, Inc. All rights reserved.
|
2012-06-27 05:28:28 +04:00
|
|
|
*
|
2004-11-22 04:38:40 +03:00
|
|
|
* $COPYRIGHT$
|
|
|
|
|
*
|
|
|
|
|
* Additional copyrights may follow
|
|
|
|
|
*
|
2004-01-15 09:08:25 +03:00
|
|
|
* $HEADER$
|
|
|
|
|
*/
|
|
|
|
|
|
2006-02-12 04:33:29 +03:00
|
|
|
#include "ompi_config.h"
|
2004-01-15 09:08:25 +03:00
|
|
|
|
2006-04-13 21:00:36 +04:00
|
|
|
#ifdef HAVE_SYS_TYPES_H
|
|
|
|
|
#include <sys/types.h>
|
|
|
|
|
#endif
|
|
|
|
|
#ifdef HAVE_UNISTD_H
|
|
|
|
|
#include <unistd.h>
|
|
|
|
|
#endif
|
|
|
|
|
#ifdef HAVE_SYS_PARAM_H
|
|
|
|
|
#include <sys/param.h>
|
|
|
|
|
#endif
|
|
|
|
|
#ifdef HAVE_NETDB_H
|
|
|
|
|
#include <netdb.h>
|
|
|
|
|
#endif
|
|
|
|
|
|
Update libevent to the 2.0 series, currently at 2.0.7rc. We will update to their final release when it becomes available. Currently known errors exist in unused portions of the libevent code. This revision passes the IBM test suite on a Linux machine and on a standalone Mac.
This is a fairly intrusive change, but outside of the moving of opal/event to opal/mca/event, the only changes involved (a) changing all calls to opal_event functions to reflect the new framework instead, and (b) ensuring that all opal_event_t objects are properly constructed since they are now true opal_objects.
Note: Shiqing has just returned from vacation and has not yet had a chance to complete the Windows integration. Thus, this commit almost certainly breaks Windows support on the trunk. However, I want this to have a chance to soak for as long as possible before I become less available a week from today (going to be at a class for 5 days, and thus will only be sparingly available) so we can find and fix any problems.
Biggest change is moving the libevent code from opal/event to a new opal/mca/event framework. This was done to make it much easier to update libevent in the future. New versions can be inserted as a new component and tested in parallel with the current version until validated, then we can remove the earlier version if we so choose. This is a statically built framework ala installdirs, so only one component will build at a time. There is no selection logic - the sole compiled component simply loads its function pointers into the opal_event struct.
I have gone thru the code base and converted all the libevent calls I could find. However, I cannot compile nor test every environment. It is therefore quite likely that errors remain in the system. Please keep an eye open for two things:
1. compile-time errors: these will be obvious as calls to the old functions (e.g., opal_evtimer_new) must be replaced by the new framework APIs (e.g., opal_event.evtimer_new)
2. run-time errors: these will likely show up as segfaults due to missing constructors on opal_event_t objects. It appears that it became a typical practice for people to "init" an opal_event_t by simply using memset to zero it out. This will no longer work - you must either OBJ_NEW or OBJ_CONSTRUCT an opal_event_t. I tried to catch these cases, but may have missed some. Believe me, you'll know when you hit it.
There is also the issue of the new libevent "no recursion" behavior. As I described on a recent email, we will have to discuss this and figure out what, if anything, we need to do.
This commit was SVN r23925.
2010-10-24 22:35:54 +04:00
|
|
|
#include "opal/mca/event/event.h"
|
2009-02-14 05:26:12 +03:00
|
|
|
#include "opal/util/output.h"
|
2005-07-04 01:57:43 +04:00
|
|
|
#include "opal/runtime/opal_progress.h"
|
2005-08-26 14:56:39 +04:00
|
|
|
#include "opal/mca/base/base.h"
|
2006-04-13 21:00:36 +04:00
|
|
|
#include "opal/sys/atomic.h"
|
2009-02-12 17:15:25 +03:00
|
|
|
#include "opal/runtime/opal.h"
|
2013-02-13 01:10:11 +04:00
|
|
|
#include "opal/util/show_help.h"
|
2004-08-14 05:56:05 +04:00
|
|
|
|
2005-08-26 14:56:39 +04:00
|
|
|
#include "mpi.h"
|
2006-02-12 04:33:29 +03:00
|
|
|
#include "ompi/constants.h"
|
2005-08-26 14:56:39 +04:00
|
|
|
#include "ompi/errhandler/errcode.h"
|
|
|
|
|
#include "ompi/communicator/communicator.h"
|
2009-07-13 08:59:13 +04:00
|
|
|
#include "ompi/datatype/ompi_datatype.h"
|
2012-02-06 21:35:21 +04:00
|
|
|
#include "ompi/message/message.h"
|
2005-08-26 14:56:39 +04:00
|
|
|
#include "ompi/op/op.h"
|
|
|
|
|
#include "ompi/file/file.h"
|
|
|
|
|
#include "ompi/info/info.h"
|
|
|
|
|
#include "ompi/runtime/mpiruntime.h"
|
|
|
|
|
#include "ompi/attribute/attribute.h"
|
|
|
|
|
#include "ompi/mca/pml/pml.h"
|
2014-01-17 10:09:29 +04:00
|
|
|
#include "ompi/mca/bml/bml.h"
|
2005-08-26 14:56:39 +04:00
|
|
|
#include "ompi/mca/pml/base/base.h"
|
2014-01-17 10:09:29 +04:00
|
|
|
#include "ompi/mca/bml/base/base.h"
|
2006-01-28 18:38:37 +03:00
|
|
|
#include "ompi/mca/osc/base/base.h"
|
2005-08-26 14:56:39 +04:00
|
|
|
#include "ompi/mca/coll/base/base.h"
|
2013-01-28 03:25:10 +04:00
|
|
|
#include "ompi/mca/rte/rte.h"
|
2014-01-13 21:43:24 +04:00
|
|
|
#include "ompi/mca/rte/base/base.h"
|
2005-08-26 14:56:39 +04:00
|
|
|
#include "ompi/mca/topo/base/base.h"
|
|
|
|
|
#include "ompi/mca/io/io.h"
|
|
|
|
|
#include "ompi/mca/io/base/base.h"
|
|
|
|
|
#include "ompi/mca/mpool/base/base.h"
|
2009-03-04 18:35:54 +03:00
|
|
|
#include "ompi/mca/mpool/base/mpool_base_tree.h"
|
2005-09-13 02:28:23 +04:00
|
|
|
#include "ompi/mca/rcache/base/base.h"
|
2007-07-17 18:50:52 +04:00
|
|
|
#include "ompi/mca/pml/base/pml_base_bsend.h"
|
2014-05-15 23:52:06 +04:00
|
|
|
#include "ompi/mca/allocator/base/base.h"
|
2007-08-02 01:33:25 +04:00
|
|
|
#include "ompi/runtime/params.h"
|
2008-02-28 04:57:57 +03:00
|
|
|
#include "ompi/mca/dpm/base/base.h"
|
|
|
|
|
#include "ompi/mca/pubsub/base/base.h"
|
2010-08-17 08:44:22 +04:00
|
|
|
#include "ompi/mpiext/mpiext.h"
|
2004-01-29 22:40:22 +03:00
|
|
|
|
2010-03-13 02:57:50 +03:00
|
|
|
#if OPAL_ENABLE_FT_CR == 1
|
2007-03-17 02:11:45 +03:00
|
|
|
#include "ompi/mca/crcp/crcp.h"
|
|
|
|
|
#include "ompi/mca/crcp/base/base.h"
|
|
|
|
|
#endif
|
|
|
|
|
#include "ompi/runtime/ompi_cr.h"
|
|
|
|
|
|
2013-03-28 01:09:41 +04:00
|
|
|
extern bool ompi_enable_timing;
|
2012-04-06 18:23:13 +04:00
|
|
|
|
2004-06-07 19:33:53 +04:00
|
|
|
int ompi_mpi_finalize(void)
|
2004-01-15 09:08:25 +03:00
|
|
|
{
|
2013-03-28 01:17:31 +04:00
|
|
|
int ret;
|
2006-04-13 21:00:36 +04:00
|
|
|
static int32_t finalize_has_already_started = 0;
|
2007-12-07 16:09:07 +03:00
|
|
|
opal_list_item_t *item;
|
2009-01-07 00:30:12 +03:00
|
|
|
struct timeval ompistart, ompistop;
|
2013-01-28 03:25:10 +04:00
|
|
|
ompi_rte_collective_t *coll;
|
2014-02-06 22:37:19 +04:00
|
|
|
ompi_proc_t** procs;
|
|
|
|
|
size_t nprocs;
|
2004-01-15 09:08:25 +03:00
|
|
|
|
2006-04-13 21:00:36 +04:00
|
|
|
/* Be a bit social if an erroneous program calls MPI_FINALIZE in
|
|
|
|
|
two different threads, otherwise we may deadlock in
|
|
|
|
|
ompi_comm_free() (or run into other nasty lions, tigers, or
|
|
|
|
|
bears) */
|
|
|
|
|
|
|
|
|
|
if (! opal_atomic_cmpset_32(&finalize_has_already_started, 0, 1)) {
|
|
|
|
|
/* Note that if we're already finalized, we cannot raise an
|
|
|
|
|
MPI exception. The best that we can do is write something
|
|
|
|
|
to stderr. */
|
|
|
|
|
char hostname[MAXHOSTNAMELEN];
|
|
|
|
|
pid_t pid = getpid();
|
2011-11-30 03:24:52 +04:00
|
|
|
gethostname(hostname, sizeof(hostname));
|
2006-04-13 21:00:36 +04:00
|
|
|
|
2013-02-13 01:10:11 +04:00
|
|
|
opal_show_help("help-mpi-runtime.txt",
|
2006-04-13 21:00:36 +04:00
|
|
|
"mpi_finalize:invoked_multiple_times",
|
|
|
|
|
true, hostname, pid);
|
|
|
|
|
return MPI_ERR_OTHER;
|
|
|
|
|
}
|
|
|
|
|
|
2010-08-17 08:44:22 +04:00
|
|
|
ompi_mpiext_fini();
|
|
|
|
|
|
2006-04-13 21:00:36 +04:00
|
|
|
/* Per MPI-2:4.8, we have to free MPI_COMM_SELF before doing
|
|
|
|
|
anything else in MPI_FINALIZE (to include setting up such that
|
|
|
|
|
MPI_FINALIZED will return true). */
|
2006-04-12 05:16:45 +04:00
|
|
|
|
2009-02-24 20:17:33 +03:00
|
|
|
if (NULL != ompi_mpi_comm_self.comm.c_keyhash) {
|
2006-04-12 05:16:45 +04:00
|
|
|
ompi_attr_delete_all(COMM_ATTR, &ompi_mpi_comm_self,
|
2009-02-24 20:17:33 +03:00
|
|
|
ompi_mpi_comm_self.comm.c_keyhash);
|
|
|
|
|
OBJ_RELEASE(ompi_mpi_comm_self.comm.c_keyhash);
|
|
|
|
|
ompi_mpi_comm_self.comm.c_keyhash = NULL;
|
2006-04-12 05:16:45 +04:00
|
|
|
}
|
|
|
|
|
|
2006-04-13 21:00:36 +04:00
|
|
|
/* Proceed with MPI_FINALIZE */
|
|
|
|
|
|
2004-11-20 22:12:43 +03:00
|
|
|
ompi_mpi_finalized = true;
|
2006-08-02 02:23:57 +04:00
|
|
|
|
2014-01-26 21:26:40 +04:00
|
|
|
/* As finalize is the last legal MPI call, we are allowed to force the release
|
|
|
|
|
* of the user buffer used for bsend, before going anywhere further.
|
|
|
|
|
*/
|
|
|
|
|
(void)mca_pml_base_bsend_detach(NULL, NULL);
|
|
|
|
|
|
Update libevent to the 2.0 series, currently at 2.0.7rc. We will update to their final release when it becomes available. Currently known errors exist in unused portions of the libevent code. This revision passes the IBM test suite on a Linux machine and on a standalone Mac.
This is a fairly intrusive change, but outside of the moving of opal/event to opal/mca/event, the only changes involved (a) changing all calls to opal_event functions to reflect the new framework instead, and (b) ensuring that all opal_event_t objects are properly constructed since they are now true opal_objects.
Note: Shiqing has just returned from vacation and has not yet had a chance to complete the Windows integration. Thus, this commit almost certainly breaks Windows support on the trunk. However, I want this to have a chance to soak for as long as possible before I become less available a week from today (going to be at a class for 5 days, and thus will only be sparingly available) so we can find and fix any problems.
Biggest change is moving the libevent code from opal/event to a new opal/mca/event framework. This was done to make it much easier to update libevent in the future. New versions can be inserted as a new component and tested in parallel with the current version until validated, then we can remove the earlier version if we so choose. This is a statically built framework ala installdirs, so only one component will build at a time. There is no selection logic - the sole compiled component simply loads its function pointers into the opal_event struct.
I have gone thru the code base and converted all the libevent calls I could find. However, I cannot compile nor test every environment. It is therefore quite likely that errors remain in the system. Please keep an eye open for two things:
1. compile-time errors: these will be obvious as calls to the old functions (e.g., opal_evtimer_new) must be replaced by the new framework APIs (e.g., opal_event.evtimer_new)
2. run-time errors: these will likely show up as segfaults due to missing constructors on opal_event_t objects. It appears that it became a typical practice for people to "init" an opal_event_t by simply using memset to zero it out. This will no longer work - you must either OBJ_NEW or OBJ_CONSTRUCT an opal_event_t. I tried to catch these cases, but may have missed some. Believe me, you'll know when you hit it.
There is also the issue of the new libevent "no recursion" behavior. As I described on a recent email, we will have to discuss this and figure out what, if anything, we need to do.
This commit was SVN r23925.
2010-10-24 22:35:54 +04:00
|
|
|
#if OMPI_ENABLE_PROGRESS_THREADS == 0
|
2010-10-27 00:29:22 +04:00
|
|
|
opal_progress_set_event_flag(OPAL_EVLOOP_ONCE | OPAL_EVLOOP_NONBLOCK);
|
2004-10-28 19:40:46 +04:00
|
|
|
#endif
|
2006-08-02 02:23:57 +04:00
|
|
|
|
2006-11-22 05:06:52 +03:00
|
|
|
/* Redo ORTE calling opal_progress_event_users_increment() during
|
|
|
|
|
MPI lifetime, to get better latency when not using TCP */
|
|
|
|
|
opal_progress_event_users_increment();
|
2006-08-02 02:23:57 +04:00
|
|
|
|
2009-01-07 00:30:12 +03:00
|
|
|
/* check to see if we want timing information */
|
2013-03-28 01:09:41 +04:00
|
|
|
if (ompi_enable_timing != 0 && 0 == OMPI_PROC_MY_NAME->vpid) {
|
2009-01-07 00:30:12 +03:00
|
|
|
gettimeofday(&ompistart, NULL);
|
|
|
|
|
}
|
|
|
|
|
|
2009-02-28 15:58:12 +03:00
|
|
|
/* NOTE: MPI-2.1 requires that MPI_FINALIZE is "collective" across
|
|
|
|
|
*all* connected processes. This only means that all processes
|
|
|
|
|
have to call it. It does *not* mean that all connected
|
|
|
|
|
processes need to synchronize (either directly or indirectly).
|
|
|
|
|
|
|
|
|
|
For example, it is quite easy to construct complicated
|
|
|
|
|
scenarios where one job is "connected" to another job via
|
|
|
|
|
transitivity, but have no direct knowledge of each other.
|
|
|
|
|
Consider the following case: job A spawns job B, and job B
|
|
|
|
|
later spawns job C. A "connectedness" graph looks something
|
|
|
|
|
like this:
|
|
|
|
|
|
|
|
|
|
A <--> B <--> C
|
|
|
|
|
|
|
|
|
|
So what are we *supposed* to do in this case? If job A is
|
|
|
|
|
still connected to B when it calls FINALIZE, should it block
|
|
|
|
|
until jobs B and C also call FINALIZE?
|
|
|
|
|
|
|
|
|
|
After lengthy discussions many times over the course of this
|
|
|
|
|
project, the issue was finally decided at the Louisville Feb
|
|
|
|
|
2009 meeting: no.
|
|
|
|
|
|
|
|
|
|
Rationale:
|
|
|
|
|
|
|
|
|
|
- "Collective" does not mean synchronizing. It only means that
|
|
|
|
|
every process call it. Hence, in this scenario, every
|
|
|
|
|
process in A, B, and C must call FINALIZE.
|
|
|
|
|
|
|
|
|
|
- KEY POINT: if A calls FINALIZE, then it is erroneous for B or
|
|
|
|
|
C to try to communicate with A again.
|
|
|
|
|
|
|
|
|
|
- Hence, OMPI is *correct* to only effect a barrier across each
|
|
|
|
|
jobs' MPI_COMM_WORLD before exiting. Specifically, if A
|
|
|
|
|
calls FINALIZE long before B or C, it's *correct* if A exits
|
|
|
|
|
at any time (and doesn't notify B or C that it is exiting).
|
|
|
|
|
|
|
|
|
|
- Arguably, if B or C do try to communicate with the now-gone
|
|
|
|
|
A, OMPI should try to print a nice error ("you tried to
|
|
|
|
|
communicate with a job that is already gone...") instead of
|
|
|
|
|
segv or other Badness. However, that is an *extremely*
|
|
|
|
|
difficult problem -- sure, it's easy for A to tell B that it
|
|
|
|
|
is finalizing, but how can A tell C? A doesn't even know
|
|
|
|
|
about C. You'd need to construct a "connected" graph in a
|
|
|
|
|
distributed fashion, which is fraught with race conditions,
|
|
|
|
|
etc.
|
|
|
|
|
|
|
|
|
|
Hence, our conclusion is: OMPI is *correct* in its current
|
|
|
|
|
behavior (of only doing a barrier across its own COMM_WORLD)
|
|
|
|
|
before exiting. Any problems that occur are as a result of
|
|
|
|
|
erroneous MPI applications. We *could* tighten up the erroneous
|
|
|
|
|
cases and ensure that we print nice error messages / don't
|
|
|
|
|
crash, but that is such a difficult problem that we decided we
|
|
|
|
|
have many other, much higher priority issues to handle that deal
|
|
|
|
|
with non-erroneous cases. */
|
|
|
|
|
|
These changes were mostly captured in a prior RFC (except for #2 below) and are aimed specifically at improving startup performance and setting up the remaining modifications described in that RFC.
The commit has been tested for C/R and Cray operations, and on Odin (SLURM, rsh) and RoadRunner (TM). I tried to update all environments, but obviously could not test them. I know that Windows needs some work, and have highlighted what is know to be needed in the odls process component.
This represents a lot of work by Brian, Tim P, Josh, and myself, with much advice from Jeff and others. For posterity, I have appended a copy of the email describing the work that was done:
As we have repeatedly noted, the modex operation in MPI_Init is the single greatest consumer of time during startup. To-date, we have executed that operation as an ORTE stage gate that held the process until a startup message containing all required modex (and OOB contact info - see #3 below) info could be sent to it. Each process would send its data to the HNP's registry, which assembled and sent the message when all processes had reported in.
In addition, ORTE had taken responsibility for monitoring process status as it progressed through a series of "stage gates". The process reported its status at each gate, and ORTE would then send a "release" message once all procs had reported in.
The incoming changes revamp these procedures in three ways:
1. eliminating the ORTE stage gate system and cleanly delineating responsibility between the OMPI and ORTE layers for MPI init/finalize. The modex stage gate (STG1) has been replaced by a collective operation in the modex itself that performs an allgather on the required modex info. The allgather is implemented using the orte_grpcomm framework since the BTL's are not active at that point. At the moment, the grpcomm framework only has a "basic" component analogous to OMPI's "basic" coll framework - I would recommend that the MPI team create additional, more advanced components to improve performance of this step.
The other stage gates have been replaced by orte_grpcomm barrier functions. We tried to use MPI barriers instead (since the BTL's are active at that point), but - as we discussed on the telecon - these are not currently true barriers so the job would hang when we fell through while messages were still in process. Note that the grpcomm barrier doesn't actually resolve that problem, but Brian has pointed out that we are unlikely to ever see it violated. Again, you might want to spend a little time on an advanced barrier algorithm as the one in "basic" is very simplistic.
Summarizing this change: ORTE no longer tracks process state nor has direct responsibility for synchronizing jobs. This is now done via collective operations within the MPI layer, albeit using ORTE collective communication services. I -strongly- urge the MPI team to implement advanced collective algorithms to improve the performance of this critical procedure.
2. reducing the volume of data exchanged during modex. Data in the modex consisted of the process name, the name of the node where that process is located (expressed as a string), plus a string representation of all contact info. The nodename was required in order for the modex to determine if the process was local or not - in addition, some people like to have it to print pretty error messages when a connection failed.
The size of this data has been reduced in three ways:
(a) reducing the size of the process name itself. The process name consisted of two 32-bit fields for the jobid and vpid. This is far larger than any current system, or system likely to exist in the near future, can support. Accordingly, the default size of these fields has been reduced to 16-bits, which means you can have 32k procs in each of 32k jobs. Since the daemons must have a vpid, and we require one daemon/node, this also restricts the default configuration to 32k nodes.
To support any future "mega-clusters", a configuration option --enable-jumbo-apps has been added. This option increases the jobid and vpid field sizes to 32-bits. Someday, if necessary, someone can add yet another option to increase them to 64-bits, I suppose.
(b) replacing the string nodename with an integer nodeid. Since we have one daemon/node, the nodeid corresponds to the local daemon's vpid. This replaces an often lengthy string with only 2 (or at most 4) bytes, a substantial reduction.
(c) when the mca param requesting that nodenames be sent to support pretty error messages, a second mca param is now used to request FQDN - otherwise, the domain name is stripped (by default) from the message to save space. If someone wants to combine those into a single param somehow (perhaps with an argument?), they are welcome to do so - I didn't want to alter what people are already using.
While these may seem like small savings, they actually amount to a significant impact when aggregated across the entire modex operation. Since every proc must receive the modex data regardless of the collective used to send it, just reducing the size of the process name removes nearly 400MBytes of communication from a 32k proc job (admittedly, much of this comm may occur in parallel). So it does add up pretty quickly.
3. routing RML messages to reduce connections. The default messaging system remains point-to-point - i.e., each proc opens a socket to every proc it communicates with and sends its messages directly. A new option uses the orteds as routers - i.e., each proc only opens a single socket to its local orted. All messages are sent from the proc to the orted, which forwards the message to the orted on the node where the intended recipient proc is located - that orted then forwards the message to its local proc (the recipient). This greatly reduces the connection storm we have encountered during startup.
It also has the benefit of removing the sharing of every proc's OOB contact with every other proc. The orted routing tables are populated during launch since every orted gets a map of where every proc is being placed. Each proc, therefore, only needs to know the contact info for its local daemon, which is passed in via the environment when the proc is fork/exec'd by the daemon. This alone removes ~50 bytes/process of communication that was in the current STG1 startup message - so for our 32k proc job, this saves us roughly 32k*50 = 1.6MBytes sent to 32k procs = 51GBytes of messaging.
Note that you can use the new routing method by specifying -mca routed tree - if you so desire. This mode will become the default at some point in the future.
There are a few minor additional changes in the commit that I'll just note in passing:
* propagation of command line mca params to the orteds - fixes ticket #1073. See note there for details.
* requiring of "finalize" prior to "exit" for MPI procs - fixes ticket #1144. See note there for details.
* cleanup of some stale header files
This commit was SVN r16364.
2007-10-05 23:48:23 +04:00
|
|
|
/* wait for everyone to reach this point
|
|
|
|
|
This is a grpcomm barrier instead of an MPI barrier because an
|
|
|
|
|
MPI barrier doesn't ensure that all messages have been transmitted
|
|
|
|
|
before exiting, so the possibility of a stranded message exists.
|
|
|
|
|
*/
|
2013-01-28 03:25:10 +04:00
|
|
|
coll = OBJ_NEW(ompi_rte_collective_t);
|
|
|
|
|
coll->id = ompi_process_info.peer_fini_barrier;
|
As per the RFC, bring in the ORTE async progress code and the rewrite of OOB:
*** THIS RFC INCLUDES A MINOR CHANGE TO THE MPI-RTE INTERFACE ***
Note: during the course of this work, it was necessary to completely separate the MPI and RTE progress engines. There were multiple places in the MPI layer where ORTE_WAIT_FOR_COMPLETION was being used. A new OMPI_WAIT_FOR_COMPLETION macro was created (defined in ompi/mca/rte/rte.h) that simply cycles across opal_progress until the provided flag becomes false. Places where the MPI layer blocked waiting for RTE to complete an event have been modified to use this macro.
***************************************************************************************
I am reissuing this RFC because of the time that has passed since its original release. Since its initial release and review, I have debugged it further to ensure it fully supports tests like loop_spawn. It therefore seems ready for merge back to the trunk. Given its prior review, I have set the timeout for one week.
The code is in https://bitbucket.org/rhc/ompi-oob2
WHAT: Rewrite of ORTE OOB
WHY: Support asynchronous progress and a host of other features
WHEN: Wed, August 21
SYNOPSIS:
The current OOB has served us well, but a number of limitations have been identified over the years. Specifically:
* it is only progressed when called via opal_progress, which can lead to hangs or recursive calls into libevent (which is not supported by that code)
* we've had issues when multiple NICs are available as the code doesn't "shift" messages between transports - thus, all nodes had to be available via the same TCP interface.
* the OOB "unloads" incoming opal_buffer_t objects during the transmission, thus preventing use of OBJ_RETAIN in the code when repeatedly sending the same message to multiple recipients
* there is no failover mechanism across NICs - if the selected NIC (or its attached switch) fails, we are forced to abort
* only one transport (i.e., component) can be "active"
The revised OOB resolves these problems:
* async progress is used for all application processes, with the progress thread blocking in the event library
* each available TCP NIC is supported by its own TCP module. The ability to asynchronously progress each module independently is provided, but not enabled by default (a runtime MCA parameter turns it "on")
* multi-address TCP NICs (e.g., a NIC with both an IPv4 and IPv6 address, or with virtual interfaces) are supported - reachability is determined by comparing the contact info for a peer against all addresses within the range covered by the address/mask pairs for the NIC.
* a message that arrives on one TCP NIC is automatically shifted to whatever NIC that is connected to the next "hop" if that peer cannot be reached by the incoming NIC. If no TCP module will reach the peer, then the OOB attempts to send the message via all other available components - if none can reach the peer, then an "error" is reported back to the RML, which then calls the errmgr for instructions.
* opal_buffer_t now conforms to standard object rules re OBJ_RETAIN as we no longer "unload" the incoming object
* NIC failure is reported to the TCP component, which then tries to resend the message across any other available TCP NIC. If that doesn't work, then the message is given back to the OOB base to try using other components. If all that fails, then the error is reported to the RML, which reports to the errmgr for instructions
* obviously from the above, multiple OOB components (e.g., TCP and UD) can be active in parallel
* the matching code has been moved to the RML (and out of the OOB/TCP component) so it is independent of transport
* routing is done by the individual OOB modules (as opposed to the RML). Thus, both routed and non-routed transports can simultaneously be active
* all blocking send/recv APIs have been removed. Everything operates asynchronously.
KNOWN LIMITATIONS:
* although provision is made for component failover as described above, the code for doing so has not been fully implemented yet. At the moment, if all connections for a given peer fail, the errmgr is notified of a "lost connection", which by default results in termination of the job if it was a lifeline
* the IPv6 code is present and compiles, but is not complete. Since the current IPv6 support in the OOB doesn't work anyway, I don't consider this a blocker
* routing is performed at the individual module level, yet the active routed component is selected on a global basis. We probably should update that to reflect that different transports may need/choose to route in different ways
* obviously, not every error path has been tested nor necessarily covered
* determining abnormal termination is more challenging than in the old code as we now potentially have multiple ways of connecting to a process. Ideally, we would declare "connection failed" when *all* transports can no longer reach the process, but that requires some additional (possibly complex) code. For now, the code replicates the old behavior only somewhat modified - i.e., if a module sees its connection fail, it checks to see if it is a lifeline. If so, it notifies the errmgr that the lifeline is lost - otherwise, it notifies the errmgr that a non-lifeline connection was lost.
* reachability is determined solely on the basis of a shared subnet address/mask - more sophisticated algorithms (e.g., the one used in the tcp btl) are required to handle routing via gateways
* the RML needs to assign sequence numbers to each message on a per-peer basis. The receiving RML will then deliver messages in order, thus preventing out-of-order messaging in the case where messages travel across different transports or a message needs to be redirected/resent due to failure of a NIC
This commit was SVN r29058.
2013-08-22 20:37:40 +04:00
|
|
|
coll->active = true;
|
2013-01-28 03:25:10 +04:00
|
|
|
if (OMPI_SUCCESS != (ret = ompi_rte_barrier(coll))) {
|
|
|
|
|
OMPI_ERROR_LOG(ret);
|
2005-03-14 23:57:21 +03:00
|
|
|
return ret;
|
|
|
|
|
}
|
2007-03-17 02:11:45 +03:00
|
|
|
|
2012-06-27 05:28:28 +04:00
|
|
|
/* wait for barrier to complete */
|
As per the RFC, bring in the ORTE async progress code and the rewrite of OOB:
*** THIS RFC INCLUDES A MINOR CHANGE TO THE MPI-RTE INTERFACE ***
Note: during the course of this work, it was necessary to completely separate the MPI and RTE progress engines. There were multiple places in the MPI layer where ORTE_WAIT_FOR_COMPLETION was being used. A new OMPI_WAIT_FOR_COMPLETION macro was created (defined in ompi/mca/rte/rte.h) that simply cycles across opal_progress until the provided flag becomes false. Places where the MPI layer blocked waiting for RTE to complete an event have been modified to use this macro.
***************************************************************************************
I am reissuing this RFC because of the time that has passed since its original release. Since its initial release and review, I have debugged it further to ensure it fully supports tests like loop_spawn. It therefore seems ready for merge back to the trunk. Given its prior review, I have set the timeout for one week.
The code is in https://bitbucket.org/rhc/ompi-oob2
WHAT: Rewrite of ORTE OOB
WHY: Support asynchronous progress and a host of other features
WHEN: Wed, August 21
SYNOPSIS:
The current OOB has served us well, but a number of limitations have been identified over the years. Specifically:
* it is only progressed when called via opal_progress, which can lead to hangs or recursive calls into libevent (which is not supported by that code)
* we've had issues when multiple NICs are available as the code doesn't "shift" messages between transports - thus, all nodes had to be available via the same TCP interface.
* the OOB "unloads" incoming opal_buffer_t objects during the transmission, thus preventing use of OBJ_RETAIN in the code when repeatedly sending the same message to multiple recipients
* there is no failover mechanism across NICs - if the selected NIC (or its attached switch) fails, we are forced to abort
* only one transport (i.e., component) can be "active"
The revised OOB resolves these problems:
* async progress is used for all application processes, with the progress thread blocking in the event library
* each available TCP NIC is supported by its own TCP module. The ability to asynchronously progress each module independently is provided, but not enabled by default (a runtime MCA parameter turns it "on")
* multi-address TCP NICs (e.g., a NIC with both an IPv4 and IPv6 address, or with virtual interfaces) are supported - reachability is determined by comparing the contact info for a peer against all addresses within the range covered by the address/mask pairs for the NIC.
* a message that arrives on one TCP NIC is automatically shifted to whatever NIC that is connected to the next "hop" if that peer cannot be reached by the incoming NIC. If no TCP module will reach the peer, then the OOB attempts to send the message via all other available components - if none can reach the peer, then an "error" is reported back to the RML, which then calls the errmgr for instructions.
* opal_buffer_t now conforms to standard object rules re OBJ_RETAIN as we no longer "unload" the incoming object
* NIC failure is reported to the TCP component, which then tries to resend the message across any other available TCP NIC. If that doesn't work, then the message is given back to the OOB base to try using other components. If all that fails, then the error is reported to the RML, which reports to the errmgr for instructions
* obviously from the above, multiple OOB components (e.g., TCP and UD) can be active in parallel
* the matching code has been moved to the RML (and out of the OOB/TCP component) so it is independent of transport
* routing is done by the individual OOB modules (as opposed to the RML). Thus, both routed and non-routed transports can simultaneously be active
* all blocking send/recv APIs have been removed. Everything operates asynchronously.
KNOWN LIMITATIONS:
* although provision is made for component failover as described above, the code for doing so has not been fully implemented yet. At the moment, if all connections for a given peer fail, the errmgr is notified of a "lost connection", which by default results in termination of the job if it was a lifeline
* the IPv6 code is present and compiles, but is not complete. Since the current IPv6 support in the OOB doesn't work anyway, I don't consider this a blocker
* routing is performed at the individual module level, yet the active routed component is selected on a global basis. We probably should update that to reflect that different transports may need/choose to route in different ways
* obviously, not every error path has been tested nor necessarily covered
* determining abnormal termination is more challenging than in the old code as we now potentially have multiple ways of connecting to a process. Ideally, we would declare "connection failed" when *all* transports can no longer reach the process, but that requires some additional (possibly complex) code. For now, the code replicates the old behavior only somewhat modified - i.e., if a module sees its connection fail, it checks to see if it is a lifeline. If so, it notifies the errmgr that the lifeline is lost - otherwise, it notifies the errmgr that a non-lifeline connection was lost.
* reachability is determined solely on the basis of a shared subnet address/mask - more sophisticated algorithms (e.g., the one used in the tcp btl) are required to handle routing via gateways
* the RML needs to assign sequence numbers to each message on a per-peer basis. The receiving RML will then deliver messages in order, thus preventing out-of-order messaging in the case where messages travel across different transports or a message needs to be redirected/resent due to failure of a NIC
This commit was SVN r29058.
2013-08-22 20:37:40 +04:00
|
|
|
OMPI_WAIT_FOR_COMPLETION(coll->active);
|
2012-06-27 05:28:28 +04:00
|
|
|
OBJ_RELEASE(coll);
|
|
|
|
|
|
2009-01-07 00:30:12 +03:00
|
|
|
/* check for timing request - get stop time and report elapsed
|
|
|
|
|
time if so */
|
2013-03-28 01:09:41 +04:00
|
|
|
if (ompi_enable_timing && 0 == OMPI_PROC_MY_NAME->vpid) {
|
2009-01-07 00:30:12 +03:00
|
|
|
gettimeofday(&ompistop, NULL);
|
|
|
|
|
opal_output(0, "ompi_mpi_finalize[%ld]: time to execute barrier %ld usec",
|
2013-01-28 03:25:10 +04:00
|
|
|
(long)OMPI_PROC_MY_NAME->vpid,
|
2009-01-07 00:30:12 +03:00
|
|
|
(long int)((ompistop.tv_sec - ompistart.tv_sec)*1000000 +
|
|
|
|
|
(ompistop.tv_usec - ompistart.tv_usec)));
|
|
|
|
|
}
|
|
|
|
|
|
2007-03-17 02:11:45 +03:00
|
|
|
/*
|
|
|
|
|
* Shutdown the Checkpoint/Restart Mech.
|
|
|
|
|
*/
|
|
|
|
|
if (OMPI_SUCCESS != (ret = ompi_cr_finalize())) {
|
2013-01-28 03:25:10 +04:00
|
|
|
OMPI_ERROR_LOG(ret);
|
2007-03-17 02:11:45 +03:00
|
|
|
}
|
|
|
|
|
|
2007-12-07 16:09:07 +03:00
|
|
|
/* Shut down any bindings-specific issues: C++, F77, F90 */
|
|
|
|
|
|
|
|
|
|
/* Remove all memory associated by MPI_REGISTER_DATAREP (per
|
|
|
|
|
MPI-2:9.5.3, there is no way for an MPI application to
|
|
|
|
|
*un*register datareps, but we don't want the OMPI layer causing
|
|
|
|
|
memory leaks). */
|
|
|
|
|
while (NULL != (item = opal_list_remove_first(&ompi_registered_datareps))) {
|
|
|
|
|
OBJ_RELEASE(item);
|
|
|
|
|
}
|
2008-09-01 10:01:06 +04:00
|
|
|
OBJ_DESTRUCT(&ompi_registered_datareps);
|
2004-11-20 22:12:43 +03:00
|
|
|
|
2008-09-01 02:37:26 +04:00
|
|
|
/* Remove all F90 types from the hash tables. As the OBJ_DESTRUCT will
|
|
|
|
|
* call a special destructor able to release predefined types, we can
|
|
|
|
|
* simply call the OBJ_DESTRUCT on the hash table and all memory will
|
|
|
|
|
* be correctly released.
|
|
|
|
|
*/
|
|
|
|
|
OBJ_DESTRUCT( &ompi_mpi_f90_integer_hashtable );
|
|
|
|
|
OBJ_DESTRUCT( &ompi_mpi_f90_real_hashtable );
|
|
|
|
|
OBJ_DESTRUCT( &ompi_mpi_f90_complex_hashtable );
|
|
|
|
|
|
2004-11-20 22:12:43 +03:00
|
|
|
/* Free communication objects */
|
|
|
|
|
|
|
|
|
|
/* free file resources */
|
|
|
|
|
if (OMPI_SUCCESS != (ret = ompi_file_finalize())) {
|
2007-09-13 18:00:59 +04:00
|
|
|
return ret;
|
2004-11-20 22:12:43 +03:00
|
|
|
}
|
|
|
|
|
|
2006-01-28 18:38:37 +03:00
|
|
|
/* free window resources */
|
|
|
|
|
if (OMPI_SUCCESS != (ret = ompi_win_finalize())) {
|
2007-09-13 18:00:59 +04:00
|
|
|
return ret;
|
2006-01-28 18:38:37 +03:00
|
|
|
}
|
|
|
|
|
if (OMPI_SUCCESS != (ret = ompi_osc_base_finalize())) {
|
2007-09-13 18:00:59 +04:00
|
|
|
return ret;
|
2006-01-28 18:38:37 +03:00
|
|
|
}
|
|
|
|
|
|
2014-05-15 22:28:03 +04:00
|
|
|
/* free communicator resources. this MUST come before finalizing the PML
|
|
|
|
|
* as this will call into the pml */
|
|
|
|
|
if (OMPI_SUCCESS != (ret = ompi_comm_finalize())) {
|
|
|
|
|
return ret;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
nprocs = 0;
|
|
|
|
|
procs = ompi_proc_world(&nprocs);
|
|
|
|
|
MCA_PML_CALL(del_procs(procs, nprocs));
|
|
|
|
|
free(procs);
|
|
|
|
|
|
2007-10-09 19:28:56 +04:00
|
|
|
/* free pml resource */
|
|
|
|
|
if(OMPI_SUCCESS != (ret = mca_pml_base_finalize())) {
|
|
|
|
|
return ret;
|
|
|
|
|
}
|
2004-11-20 22:12:43 +03:00
|
|
|
|
|
|
|
|
/* free requests */
|
|
|
|
|
if (OMPI_SUCCESS != (ret = ompi_request_finalize())) {
|
2007-09-13 18:00:59 +04:00
|
|
|
return ret;
|
2004-11-20 22:12:43 +03:00
|
|
|
}
|
|
|
|
|
|
2012-02-06 21:35:21 +04:00
|
|
|
if (OMPI_SUCCESS != (ret = ompi_message_finalize())) {
|
|
|
|
|
return ret;
|
|
|
|
|
}
|
|
|
|
|
|
2007-08-02 01:33:25 +04:00
|
|
|
/* If requested, print out a list of memory allocated by ALLOC_MEM
|
|
|
|
|
but not freed by FREE_MEM */
|
|
|
|
|
if (0 != ompi_debug_show_mpi_alloc_mem_leaks) {
|
|
|
|
|
mca_mpool_base_tree_print();
|
|
|
|
|
}
|
|
|
|
|
|
2004-12-02 16:28:10 +03:00
|
|
|
/* Now that all MPI objects dealing with communications are gone,
|
|
|
|
|
shut down MCA types having to do with communications */
|
2013-03-28 01:17:31 +04:00
|
|
|
if (OMPI_SUCCESS != (ret = mca_base_framework_close(&ompi_pml_base_framework) ) ) {
|
|
|
|
|
OMPI_ERROR_LOG(ret);
|
2007-09-13 18:00:59 +04:00
|
|
|
return ret;
|
2004-12-02 16:28:10 +03:00
|
|
|
}
|
|
|
|
|
|
2007-07-17 18:50:52 +04:00
|
|
|
/* shut down buffered send code */
|
|
|
|
|
mca_pml_base_bsend_fini();
|
|
|
|
|
|
2010-03-13 02:57:50 +03:00
|
|
|
#if OPAL_ENABLE_FT_CR == 1
|
2007-03-17 02:11:45 +03:00
|
|
|
/*
|
|
|
|
|
* Shutdown the CRCP Framework, must happen after PML shutdown
|
|
|
|
|
*/
|
2013-03-28 01:17:31 +04:00
|
|
|
if (OMPI_SUCCESS != (ret = mca_base_framework_close(&ompi_crcp_base_framework) ) ) {
|
2013-01-28 03:25:10 +04:00
|
|
|
OMPI_ERROR_LOG(ret);
|
2007-03-17 02:11:45 +03:00
|
|
|
return ret;
|
|
|
|
|
}
|
|
|
|
|
#endif
|
2004-12-02 16:28:10 +03:00
|
|
|
|
2004-11-20 22:12:43 +03:00
|
|
|
/* Free secondary resources */
|
|
|
|
|
|
|
|
|
|
/* free attr resources */
|
|
|
|
|
if (OMPI_SUCCESS != (ret = ompi_attr_finalize())) {
|
2007-09-13 18:00:59 +04:00
|
|
|
return ret;
|
2004-11-20 22:12:43 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* free group resources */
|
|
|
|
|
if (OMPI_SUCCESS != (ret = ompi_group_finalize())) {
|
2007-09-13 18:00:59 +04:00
|
|
|
return ret;
|
2004-11-20 22:12:43 +03:00
|
|
|
}
|
|
|
|
|
|
2004-12-02 16:28:10 +03:00
|
|
|
/* free proc resources */
|
|
|
|
|
if ( OMPI_SUCCESS != (ret = ompi_proc_finalize())) {
|
2007-09-13 18:00:59 +04:00
|
|
|
return ret;
|
2004-12-02 16:28:10 +03:00
|
|
|
}
|
2008-02-28 04:57:57 +03:00
|
|
|
|
|
|
|
|
/* finalize the pubsub functions */
|
2013-03-28 01:17:31 +04:00
|
|
|
if (OMPI_SUCCESS != (ret = mca_base_framework_close(&ompi_pubsub_base_framework) ) ) {
|
2008-02-28 04:57:57 +03:00
|
|
|
return ret;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* finalize the DPM framework */
|
2013-03-28 01:17:31 +04:00
|
|
|
if ( OMPI_SUCCESS != (ret = mca_base_framework_close(&ompi_dpm_base_framework))) {
|
2008-02-28 04:57:57 +03:00
|
|
|
return ret;
|
|
|
|
|
}
|
|
|
|
|
|
2004-11-20 22:12:43 +03:00
|
|
|
/* free internal error resources */
|
|
|
|
|
if (OMPI_SUCCESS != (ret = ompi_errcode_intern_finalize())) {
|
2007-09-13 18:00:59 +04:00
|
|
|
return ret;
|
2004-11-20 22:12:43 +03:00
|
|
|
}
|
2004-08-29 13:05:14 +04:00
|
|
|
|
2004-11-20 22:12:43 +03:00
|
|
|
/* free error code resources */
|
|
|
|
|
if (OMPI_SUCCESS != (ret = ompi_mpi_errcode_finalize())) {
|
2007-09-13 18:00:59 +04:00
|
|
|
return ret;
|
2004-11-20 22:12:43 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* free errhandler resources */
|
|
|
|
|
if (OMPI_SUCCESS != (ret = ompi_errhandler_finalize())) {
|
2007-09-13 18:00:59 +04:00
|
|
|
return ret;
|
2004-11-20 22:12:43 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Free all other resources */
|
|
|
|
|
|
|
|
|
|
/* free op resources */
|
|
|
|
|
if (OMPI_SUCCESS != (ret = ompi_op_finalize())) {
|
2007-09-13 18:00:59 +04:00
|
|
|
return ret;
|
2004-11-20 22:12:43 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* free ddt resources */
|
2009-07-13 08:59:13 +04:00
|
|
|
if (OMPI_SUCCESS != (ret = ompi_datatype_finalize())) {
|
2007-09-13 18:00:59 +04:00
|
|
|
return ret;
|
2004-11-20 22:12:43 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* free info resources */
|
|
|
|
|
if (OMPI_SUCCESS != (ret = ompi_info_finalize())) {
|
2007-09-13 18:00:59 +04:00
|
|
|
return ret;
|
2004-11-20 22:12:43 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Close down MCA modules */
|
|
|
|
|
|
2005-01-04 18:43:26 +03:00
|
|
|
/* io is opened lazily, so it's only necessary to close it if it
|
|
|
|
|
was actually opened */
|
2013-03-28 01:17:31 +04:00
|
|
|
if (0 < ompi_io_base_framework.framework_refcnt) {
|
|
|
|
|
/* May have been "opened" multiple times. We want it closed now */
|
|
|
|
|
ompi_io_base_framework.framework_refcnt = 1;
|
2005-01-04 18:43:26 +03:00
|
|
|
|
2013-03-28 01:17:31 +04:00
|
|
|
if (OMPI_SUCCESS != mca_base_framework_close(&ompi_io_base_framework)) {
|
2005-01-04 18:43:26 +03:00
|
|
|
return ret;
|
|
|
|
|
}
|
2004-11-20 22:12:43 +03:00
|
|
|
}
|
2013-03-28 01:17:31 +04:00
|
|
|
(void) mca_base_framework_close(&ompi_topo_base_framework);
|
|
|
|
|
if (OMPI_SUCCESS != (ret = mca_base_framework_close(&ompi_osc_base_framework))) {
|
2007-09-13 18:00:59 +04:00
|
|
|
return ret;
|
2006-01-28 18:38:37 +03:00
|
|
|
}
|
2013-03-28 01:17:31 +04:00
|
|
|
if (OMPI_SUCCESS != (ret = mca_base_framework_close(&ompi_coll_base_framework))) {
|
2007-09-13 18:00:59 +04:00
|
|
|
return ret;
|
2004-11-20 22:12:43 +03:00
|
|
|
}
|
2014-01-17 10:09:29 +04:00
|
|
|
if (OMPI_SUCCESS != (ret = mca_base_framework_close(&ompi_bml_base_framework))) {
|
|
|
|
|
return ret;
|
|
|
|
|
}
|
2013-03-28 01:17:31 +04:00
|
|
|
if (OMPI_SUCCESS != (ret = mca_base_framework_close(&ompi_mpool_base_framework))) {
|
2007-09-13 18:00:59 +04:00
|
|
|
return ret;
|
2005-01-15 16:20:26 +03:00
|
|
|
}
|
2013-03-28 01:17:31 +04:00
|
|
|
if (OMPI_SUCCESS != (ret = mca_base_framework_close(&ompi_rcache_base_framework))) {
|
2005-09-13 02:28:23 +04:00
|
|
|
return ret;
|
|
|
|
|
}
|
2014-05-15 19:59:51 +04:00
|
|
|
if (OMPI_SUCCESS != (ret = mca_base_framework_close(&ompi_allocator_base_framework))) {
|
|
|
|
|
return ret;
|
|
|
|
|
}
|
2009-02-13 06:40:53 +03:00
|
|
|
|
2013-12-24 15:05:51 +04:00
|
|
|
if (NULL != ompi_mpi_main_thread) {
|
|
|
|
|
OBJ_RELEASE(ompi_mpi_main_thread);
|
|
|
|
|
ompi_mpi_main_thread = NULL;
|
|
|
|
|
}
|
|
|
|
|
|
2012-06-27 05:28:28 +04:00
|
|
|
/* Leave the RTE */
|
|
|
|
|
|
2013-01-28 03:25:10 +04:00
|
|
|
if (OMPI_SUCCESS != (ret = ompi_rte_finalize())) {
|
2007-09-13 18:00:59 +04:00
|
|
|
return ret;
|
2004-11-20 22:12:43 +03:00
|
|
|
}
|
When we abort during MPI_Init, we currently emit a totally incorrect error message stating that we were unable to aggregate error messages and cannot guarantee all other processes were killed. This simply isn't true IF the rte has been initialized.
So track that the rte has reached that point, and only emit the new message if it is accurate.
Note that we still generate a TON of output for a minor error:
Ralphs-iMac:examples rhc$ mpirun -n 3 -mca btl sm ./hello_c
--------------------------------------------------------------------------
At least one pair of MPI processes are unable to reach each other for
MPI communications. This means that no Open MPI device has indicated
that it can be used to communicate between these processes. This is
an error; Open MPI requires that all MPI processes be able to reach
each other. This error can sometimes be the result of forgetting to
specify the "self" BTL.
Process 1 ([[50239,1],2]) is on host: Ralphs-iMac
Process 2 ([[50239,1],2]) is on host: Ralphs-iMac
BTLs attempted: sm
Your MPI job is now going to abort; sorry.
--------------------------------------------------------------------------
*** An error occurred in MPI_Init
*** on a NULL communicator
*** MPI_ERRORS_ARE_FATAL (processes in this communicator will now abort,
*** and potentially your MPI job)
*** An error occurred in MPI_Init
*** on a NULL communicator
*** MPI_ERRORS_ARE_FATAL (processes in this communicator will now abort,
*** and potentially your MPI job)
*** An error occurred in MPI_Init
*** on a NULL communicator
*** MPI_ERRORS_ARE_FATAL (processes in this communicator will now abort,
*** and potentially your MPI job)
--------------------------------------------------------------------------
MPI_INIT has failed because at least one MPI process is unreachable
from another. This *usually* means that an underlying communication
plugin -- such as a BTL or an MTL -- has either not loaded or not
allowed itself to be used. Your MPI job will now abort.
You may wish to try to narrow down the problem;
* Check the output of ompi_info to see which BTL/MTL plugins are
available.
* Run your application with MPI_THREAD_SINGLE.
* Set the MCA parameter btl_base_verbose to 100 (or mtl_base_verbose,
if using MTL-based communications) to see exactly which
communication plugins were considered and/or discarded.
--------------------------------------------------------------------------
-------------------------------------------------------
Primary job terminated normally, but 1 process returned
a non-zero exit code.. Per user-direction, the job has been aborted.
-------------------------------------------------------
--------------------------------------------------------------------------
mpirun detected that one or more processes exited with non-zero status, thus causing
the job to be terminated. The first process to do so was:
Process name: [[50239,1],2]
Exit code: 1
--------------------------------------------------------------------------
[Ralphs-iMac.local:23227] 2 more processes have sent help message help-mca-bml-r2.txt / unreachable proc
[Ralphs-iMac.local:23227] Set MCA parameter "orte_base_help_aggregate" to 0 to see all help / error messages
[Ralphs-iMac.local:23227] 2 more processes have sent help message help-mpi-runtime / mpi_init:startup:pml-add-procs-fail
Ralphs-iMac:examples rhc$
Hopefully, we can agree on a way to reduce this verbage!
This commit was SVN r31686.
The following SVN revision numbers were found above:
r2 --> open-mpi/ompi@58fdc188553052bc2e893ba28fb28fddbe78435a
2014-05-08 19:48:16 +04:00
|
|
|
ompi_rte_initialized = false;
|
2004-08-29 13:05:14 +04:00
|
|
|
|
2014-01-13 21:43:24 +04:00
|
|
|
/* now close the rte framework */
|
|
|
|
|
if (OMPI_SUCCESS != (ret = mca_base_framework_close(&ompi_rte_base_framework) ) ) {
|
|
|
|
|
OMPI_ERROR_LOG(ret);
|
|
|
|
|
return ret;
|
|
|
|
|
}
|
|
|
|
|
|
2011-10-04 18:50:31 +04:00
|
|
|
if (OPAL_SUCCESS != (ret = opal_finalize_util())) {
|
2009-02-12 00:01:56 +03:00
|
|
|
return ret;
|
|
|
|
|
}
|
|
|
|
|
|
2004-11-20 22:12:43 +03:00
|
|
|
/* All done */
|
2004-01-15 09:08:25 +03:00
|
|
|
|
2004-11-20 22:12:43 +03:00
|
|
|
return MPI_SUCCESS;
|
2004-01-15 09:08:25 +03:00
|
|
|
}
|