Update libevent to the 2.0 series, currently at 2.0.7rc. We will update to their final release when it becomes available. Currently known errors exist in unused portions of the libevent code. This revision passes the IBM test suite on a Linux machine and on a standalone Mac.
This is a fairly intrusive change, but outside of the moving of opal/event to opal/mca/event, the only changes involved (a) changing all calls to opal_event functions to reflect the new framework instead, and (b) ensuring that all opal_event_t objects are properly constructed since they are now true opal_objects.
Note: Shiqing has just returned from vacation and has not yet had a chance to complete the Windows integration. Thus, this commit almost certainly breaks Windows support on the trunk. However, I want this to have a chance to soak for as long as possible before I become less available a week from today (going to be at a class for 5 days, and thus will only be sparingly available) so we can find and fix any problems.
Biggest change is moving the libevent code from opal/event to a new opal/mca/event framework. This was done to make it much easier to update libevent in the future. New versions can be inserted as a new component and tested in parallel with the current version until validated, then we can remove the earlier version if we so choose. This is a statically built framework ala installdirs, so only one component will build at a time. There is no selection logic - the sole compiled component simply loads its function pointers into the opal_event struct.
I have gone thru the code base and converted all the libevent calls I could find. However, I cannot compile nor test every environment. It is therefore quite likely that errors remain in the system. Please keep an eye open for two things:
1. compile-time errors: these will be obvious as calls to the old functions (e.g., opal_evtimer_new) must be replaced by the new framework APIs (e.g., opal_event.evtimer_new)
2. run-time errors: these will likely show up as segfaults due to missing constructors on opal_event_t objects. It appears that it became a typical practice for people to "init" an opal_event_t by simply using memset to zero it out. This will no longer work - you must either OBJ_NEW or OBJ_CONSTRUCT an opal_event_t. I tried to catch these cases, but may have missed some. Believe me, you'll know when you hit it.
There is also the issue of the new libevent "no recursion" behavior. As I described on a recent email, we will have to discuss this and figure out what, if anything, we need to do.
This commit was SVN r23925.
2010-10-24 22:35:54 +04:00
|
|
|
dnl -*- shell-script -*-
|
|
|
|
|
dnl
|
|
|
|
|
dnl Copyright (c) 2010 Cisco Systems, Inc. All rights reserved.
|
|
|
|
|
dnl $COPYRIGHT$
|
|
|
|
|
dnl
|
|
|
|
|
dnl Additional copyrights may follow
|
|
|
|
|
dnl
|
|
|
|
|
dnl $HEADER$
|
|
|
|
|
dnl
|
|
|
|
|
|
2010-10-28 19:22:46 +04:00
|
|
|
# There will only be one component used in this framework, and it will
|
|
|
|
|
# be selected at configure time by priority. Components must set
|
|
|
|
|
# their priorities in their configure.m4 files. They must also set
|
|
|
|
|
# the shell variable $event_base_include to a header file name
|
|
|
|
|
# (relative to the top OMPI source directory) that will be included in
|
|
|
|
|
# opal/mca/event/event.h. Optionally, components may also set the
|
|
|
|
|
# shell variable $event_base_include_cppflags if additional CPPFLAGS
|
|
|
|
|
# must be used with this header file. The event framework will add
|
|
|
|
|
# the winning component's $event_base_include_cppflags to the global
|
|
|
|
|
# $CPPFLAGS.
|
|
|
|
|
|
Update libevent to the 2.0 series, currently at 2.0.7rc. We will update to their final release when it becomes available. Currently known errors exist in unused portions of the libevent code. This revision passes the IBM test suite on a Linux machine and on a standalone Mac.
This is a fairly intrusive change, but outside of the moving of opal/event to opal/mca/event, the only changes involved (a) changing all calls to opal_event functions to reflect the new framework instead, and (b) ensuring that all opal_event_t objects are properly constructed since they are now true opal_objects.
Note: Shiqing has just returned from vacation and has not yet had a chance to complete the Windows integration. Thus, this commit almost certainly breaks Windows support on the trunk. However, I want this to have a chance to soak for as long as possible before I become less available a week from today (going to be at a class for 5 days, and thus will only be sparingly available) so we can find and fix any problems.
Biggest change is moving the libevent code from opal/event to a new opal/mca/event framework. This was done to make it much easier to update libevent in the future. New versions can be inserted as a new component and tested in parallel with the current version until validated, then we can remove the earlier version if we so choose. This is a statically built framework ala installdirs, so only one component will build at a time. There is no selection logic - the sole compiled component simply loads its function pointers into the opal_event struct.
I have gone thru the code base and converted all the libevent calls I could find. However, I cannot compile nor test every environment. It is therefore quite likely that errors remain in the system. Please keep an eye open for two things:
1. compile-time errors: these will be obvious as calls to the old functions (e.g., opal_evtimer_new) must be replaced by the new framework APIs (e.g., opal_event.evtimer_new)
2. run-time errors: these will likely show up as segfaults due to missing constructors on opal_event_t objects. It appears that it became a typical practice for people to "init" an opal_event_t by simply using memset to zero it out. This will no longer work - you must either OBJ_NEW or OBJ_CONSTRUCT an opal_event_t. I tried to catch these cases, but may have missed some. Believe me, you'll know when you hit it.
There is also the issue of the new libevent "no recursion" behavior. As I described on a recent email, we will have to discuss this and figure out what, if anything, we need to do.
This commit was SVN r23925.
2010-10-24 22:35:54 +04:00
|
|
|
dnl We only want one winning component.
|
|
|
|
|
m4_define(MCA_opal_event_CONFIGURE_MODE, STOP_AT_FIRST_PRIORITY)
|
|
|
|
|
|
|
|
|
|
AC_DEFUN([MCA_opal_event_CONFIG],[
|
|
|
|
|
# configure all the components
|
|
|
|
|
MCA_CONFIGURE_FRAMEWORK($1, $2, 1)
|
|
|
|
|
|
|
|
|
|
# We must have found exactly 1 static component, or we can't
|
|
|
|
|
# continue. STOP_AT_FIRST_PRIORITY will guarantee that we find at
|
|
|
|
|
# most one. We need to check here that we found *at least* one.
|
|
|
|
|
AS_IF([test "$MCA_opal_event_STATIC_COMPONENTS" = ""],
|
|
|
|
|
[AC_MSG_WARN([Did not find a suitable static opal event component])
|
|
|
|
|
AC_MSG_ERROR([Cannot continue])])
|
|
|
|
|
|
|
|
|
|
# We need to find out what the underlying component set
|
|
|
|
|
# HAVE_WORKING_EVENTOPS was set to. This is for systems that
|
|
|
|
|
# don't have working poll(), etc. (e.g., Cray) -- we still need an
|
|
|
|
|
# event component (for timers, etc.), but we don't have working
|
|
|
|
|
# event ops. Ensure that it was set by the component.
|
|
|
|
|
echo " "
|
|
|
|
|
AC_MSG_CHECKING([if have working event ops for the event framework])
|
|
|
|
|
AS_IF([test "$OPAL_HAVE_WORKING_EVENTOPS" = ""],
|
|
|
|
|
[AC_MSG_RESULT([unknown])
|
|
|
|
|
AC_MSG_WARN([Event component did not set OPAL_HAVE_WORKING_EVENTOPS])
|
|
|
|
|
AC_MSG_ERROR([Cannot continue])],
|
|
|
|
|
[AS_IF([test "$OPAL_HAVE_WORKING_EVENTOPS" = "1"],
|
|
|
|
|
[AC_MSG_RESULT([yes])],
|
|
|
|
|
[AC_MSG_RESULT([no])])])
|
|
|
|
|
AC_DEFINE_UNQUOTED(OPAL_HAVE_WORKING_EVENTOPS,
|
|
|
|
|
[$OPAL_HAVE_WORKING_EVENTOPS],
|
|
|
|
|
[Whether our event component has working event operations or not (if not, then assumedly it only has working timers and signals)])
|
2010-10-28 19:22:46 +04:00
|
|
|
|
|
|
|
|
# someone should have set this...
|
|
|
|
|
AS_IF([test "$event_base_include" = ""],
|
|
|
|
|
[AC_MSG_WARN([Missing implementation header])
|
|
|
|
|
AC_MSG_ERROR([Cannot continue])])
|
|
|
|
|
|
|
|
|
|
AC_DEFINE_UNQUOTED([MCA_event_IMPLEMENTATION_HEADER],
|
|
|
|
|
["opal/mca/event/$event_base_include"],
|
|
|
|
|
[Header to include for event implementation])
|
|
|
|
|
AC_MSG_CHECKING([for winning component additional CPPFLAGS])
|
|
|
|
|
AS_IF([test "$event_base_include_cppflags" != ""],
|
|
|
|
|
[AC_MSG_RESULT([$event_base_include_cppflags])
|
2010-10-30 02:07:52 +04:00
|
|
|
CPPFLAGS="$CPPFLAGS $event_base_include_cppflags"],
|
2010-10-28 19:22:46 +04:00
|
|
|
[AC_MSG_RESULT([none])])
|
Update libevent to the 2.0 series, currently at 2.0.7rc. We will update to their final release when it becomes available. Currently known errors exist in unused portions of the libevent code. This revision passes the IBM test suite on a Linux machine and on a standalone Mac.
This is a fairly intrusive change, but outside of the moving of opal/event to opal/mca/event, the only changes involved (a) changing all calls to opal_event functions to reflect the new framework instead, and (b) ensuring that all opal_event_t objects are properly constructed since they are now true opal_objects.
Note: Shiqing has just returned from vacation and has not yet had a chance to complete the Windows integration. Thus, this commit almost certainly breaks Windows support on the trunk. However, I want this to have a chance to soak for as long as possible before I become less available a week from today (going to be at a class for 5 days, and thus will only be sparingly available) so we can find and fix any problems.
Biggest change is moving the libevent code from opal/event to a new opal/mca/event framework. This was done to make it much easier to update libevent in the future. New versions can be inserted as a new component and tested in parallel with the current version until validated, then we can remove the earlier version if we so choose. This is a statically built framework ala installdirs, so only one component will build at a time. There is no selection logic - the sole compiled component simply loads its function pointers into the opal_event struct.
I have gone thru the code base and converted all the libevent calls I could find. However, I cannot compile nor test every environment. It is therefore quite likely that errors remain in the system. Please keep an eye open for two things:
1. compile-time errors: these will be obvious as calls to the old functions (e.g., opal_evtimer_new) must be replaced by the new framework APIs (e.g., opal_event.evtimer_new)
2. run-time errors: these will likely show up as segfaults due to missing constructors on opal_event_t objects. It appears that it became a typical practice for people to "init" an opal_event_t by simply using memset to zero it out. This will no longer work - you must either OBJ_NEW or OBJ_CONSTRUCT an opal_event_t. I tried to catch these cases, but may have missed some. Believe me, you'll know when you hit it.
There is also the issue of the new libevent "no recursion" behavior. As I described on a recent email, we will have to discuss this and figure out what, if anything, we need to do.
This commit was SVN r23925.
2010-10-24 22:35:54 +04:00
|
|
|
])
|