2003-12-22 19:29:21 +03:00
|
|
|
#
|
2005-11-05 22:57:48 +03:00
|
|
|
# Copyright (c) 2004-2005 The Trustees of Indiana University and Indiana
|
|
|
|
|
# University Research and Technology
|
|
|
|
|
# Corporation. All rights reserved.
|
|
|
|
|
# Copyright (c) 2004-2005 The University of Tennessee and The University
|
|
|
|
|
# of Tennessee Research Foundation. All rights
|
|
|
|
|
# reserved.
|
2005-09-07 22:52:28 +04:00
|
|
|
# Copyright (c) 2004-2005 High Performance Computing Center Stuttgart,
|
2004-11-28 23:09:25 +03:00
|
|
|
# University of Stuttgart. All rights reserved.
|
2005-03-24 15:43:37 +03:00
|
|
|
# Copyright (c) 2004-2005 The Regents of the University of California.
|
|
|
|
|
# All rights reserved.
|
2015-02-16 18:17:33 +03:00
|
|
|
# Copyright (c) 2007-2015 Cisco Systems, Inc. All rights reserved.
|
2013-02-11 19:11:47 +04:00
|
|
|
# Copyright (c) 2013 NVIDIA Corporation. All rights reserved.
|
2013-07-14 22:57:20 +04:00
|
|
|
# Copyright (c) 2013 Intel, Inc. All rights reserved
|
2016-03-23 00:27:06 +03:00
|
|
|
# Copyright (c) 2016 Los Alamos National Security, LLC. All rights
|
|
|
|
|
# reserved.
|
2016-05-26 08:51:32 +03:00
|
|
|
# Copyright (c) 2016 Research Organization for Information Science
|
|
|
|
|
# and Technology (RIST). All rights reserved.
|
fixes for Dave's get/set info code
The expected sequence of events for processing info during object creation
is that if there's an incoming info arg, it is opal_info_dup()ed into the obj
at obj->s_info first. Then interested components register callbacks for
keys they want to know about using opal_infosubscribe_infosubscribe().
Inside info_subscribe_subscribe() the specified callback() is called with
whatever matching k/v is in the object's info, or with the default. The
return string from the callback goes into the new k/v stored in info, and
the input k/v is saved as __IN_<key>/<val>. It's saved the same way
whether the input came from info or whether it was a default. A null return
from the callback indicates an ignored key/val, and no k/v is stored for
it, but an __IN_<key>/<val> is still kept so we still have access to the
original.
At MPI_*_set_info() time, opal_infosubscribe_change_info() is used. That
function calls the registered callbacks for each item in the provided info.
If the callback returns non-null, the info is updated with that k/v, or if
the callback returns null, that key is deleted from info. An __IN_<key>/<val>
is saved either way, and overwrites any previously saved value.
When MPI_*_get_info() is called, opal_info_dup_mpistandard() is used, which
allows relatively easy changes in interpretation of the standard, by looking
at both the <key>/<val> and __IN_<key>/<val> in info. Right now it does
1. includes system extras, eg k/v defaults not expliclty set by the user
2. omits ignored keys
3. shows input values, not callback modifications, eg not the internal values
Currently the callbacks are doing things like
return some_condition ? "true" : "false"
that is, returning static strings that are not to be freed. If the return
strings start becoming more dynamic in the future I don't see how unallocated
strings could support that, so I'd propose a change for the future that
the callback()s registered with info_subscribe_subscribe() do a strdup on
their return, and we change the callers of callback() to free the strings
it returns (there are only two callers).
Rough outline of the smaller changes spread over the less central files:
comm.c
initialize comm->super.s_info to NULL
copy into comm->super.s_info in comm creation calls that provide info
OBJ_RELEASE comm->super.s_info at free time
comm_init.c
initialize comm->super.s_info to NULL
file.c
copy into file->super.s_info if file creation provides info
OBJ_RELEASE file->super.s_info at free time
win.c
copy into win->super.s_info if win creation provides info
OBJ_RELEASE win->super.s_info at free time
comm_get_info.c
file_get_info.c
win_get_info.c
change_info() if there's no info attached (shouldn't happen if callbacks
are registered)
copy the info for the user
The other category of change is generally addressing compiler warnings where
ompi_info_t and opal_info_t were being used a little too interchangably. An
ompi_info_t* contains an opal_info_t*, at &(ompi_info->super)
Also this commit updates the copyrights.
Signed-off-by: Mark Allen <markalle@us.ibm.com>
2017-01-31 04:29:50 +03:00
|
|
|
# Copyright (c) 2016-2017 IBM Corporation. All rights reserved.
|
2004-11-22 04:38:40 +03:00
|
|
|
# $COPYRIGHT$
|
2005-09-07 22:52:28 +04:00
|
|
|
#
|
2004-11-22 04:38:40 +03:00
|
|
|
# Additional copyrights may follow
|
2005-09-07 22:52:28 +04:00
|
|
|
#
|
2004-01-07 11:03:01 +03:00
|
|
|
# $HEADER$
|
|
|
|
|
#
|
|
|
|
|
|
2006-01-16 05:00:10 +03:00
|
|
|
SUBDIRS = keyval
|
2003-12-22 19:29:21 +03:00
|
|
|
|
2014-05-08 18:32:24 +04:00
|
|
|
dist_opaldata_DATA = help-opal-util.txt
|
2009-03-20 04:05:30 +03:00
|
|
|
|
2005-07-04 06:38:44 +04:00
|
|
|
AM_LFLAGS = -Popal_show_help_yy
|
|
|
|
|
LEX_OUTPUT_ROOT = lex.opal_show_help_yy
|
2004-09-05 20:05:37 +04:00
|
|
|
|
2005-07-02 18:08:19 +04:00
|
|
|
noinst_LTLIBRARIES = libopalutil.la
|
2003-12-22 19:29:21 +03:00
|
|
|
|
2013-02-12 04:41:03 +04:00
|
|
|
AM_CPPFLAGS = $(LTDLINCL)
|
|
|
|
|
|
2004-01-09 00:43:53 +03:00
|
|
|
# Source code files
|
|
|
|
|
|
|
|
|
|
headers = \
|
2014-02-26 03:41:55 +04:00
|
|
|
alfg.h \
|
2008-04-18 00:43:56 +04:00
|
|
|
arch.h \
|
2005-07-02 18:08:19 +04:00
|
|
|
argv.h \
|
|
|
|
|
basename.h \
|
2017-09-14 21:36:48 +03:00
|
|
|
bipartite_graph.h \
|
|
|
|
|
bipartite_graph_internal.h \
|
2005-07-02 18:08:19 +04:00
|
|
|
bit_ops.h \
|
|
|
|
|
cmd_line.h \
|
2005-11-29 04:07:30 +03:00
|
|
|
crc.h \
|
2005-07-02 18:08:19 +04:00
|
|
|
daemon_init.h \
|
2016-05-04 09:21:25 +03:00
|
|
|
ethtool.h \
|
2005-09-07 22:52:28 +04:00
|
|
|
error.h \
|
2010-07-20 23:53:49 +04:00
|
|
|
fd.h \
|
2015-10-29 04:58:02 +03:00
|
|
|
few.h \
|
2005-07-02 18:08:19 +04:00
|
|
|
if.h \
|
2010-05-18 02:53:33 +04:00
|
|
|
keyval_parse.h \
|
2005-07-02 18:08:19 +04:00
|
|
|
malloc.h \
|
2010-05-18 02:53:33 +04:00
|
|
|
net.h \
|
2005-07-02 18:08:19 +04:00
|
|
|
numtostr.h \
|
2005-07-04 05:36:20 +04:00
|
|
|
opal_environ.h \
|
2008-02-28 04:57:57 +03:00
|
|
|
opal_getcwd.h \
|
2010-05-18 02:53:33 +04:00
|
|
|
opal_pty.h \
|
2006-07-04 02:23:07 +04:00
|
|
|
os_dirpath.h \
|
2005-07-02 18:08:19 +04:00
|
|
|
os_path.h \
|
|
|
|
|
output.h \
|
|
|
|
|
path.h \
|
|
|
|
|
printf.h \
|
George did the work and deserves all the credit for it. Ralph did the merge, and deserves whatever blame results from errors in it :-)
WHAT: Open our low-level communication infrastructure by moving all necessary components (btl/rcache/allocator/mpool) down in OPAL
All the components required for inter-process communications are currently deeply integrated in the OMPI layer. Several groups/institutions have express interest in having a more generic communication infrastructure, without all the OMPI layer dependencies. This communication layer should be made available at a different software level, available to all layers in the Open MPI software stack. As an example, our ORTE layer could replace the current OOB and instead use the BTL directly, gaining access to more reactive network interfaces than TCP. Similarly, external software libraries could take advantage of our highly optimized AM (active message) communication layer for their own purpose. UTK with support from Sandia, developped a version of Open MPI where the entire communication infrastucture has been moved down to OPAL (btl/rcache/allocator/mpool). Most of the moved components have been updated to match the new schema, with few exceptions (mainly BTLs where I have no way of compiling/testing them). Thus, the completion of this RFC is tied to being able to completing this move for all BTLs. For this we need help from the rest of the Open MPI community, especially those supporting some of the BTLs. A non-exhaustive list of BTLs that qualify here is: mx, portals4, scif, udapl, ugni, usnic.
This commit was SVN r32317.
2014-07-26 04:47:28 +04:00
|
|
|
proc.h \
|
2005-07-02 18:08:19 +04:00
|
|
|
qsort.h \
|
|
|
|
|
show_help.h \
|
|
|
|
|
show_help_lex.h \
|
|
|
|
|
stacktrace.h \
|
2005-09-07 22:52:28 +04:00
|
|
|
strncpy.h \
|
2007-04-23 22:53:47 +04:00
|
|
|
sys_limits.h \
|
2014-09-15 22:00:46 +04:00
|
|
|
timings.h \
|
Major structural changes to data types: .super infosubscriber
ompi_communicator_t, ompi_win_t, ompi_file_t all have a super class of type opal_infosubscriber_t instead of a base/super type of opal_object_t (in previous code comm used c_base, but file used super). It may be a bit bold to say that being a subscriber of MPI_Info is the foundational piece that ties these three things together, but if you object, then I would prefer to turn infosubscriber into a more general name that encompasses other common features rather than create a different super class. The key here is that we want to be able to pass comm, win and file objects as if they were opal_infosubscriber_t, so that one routine can heandle all 3 types of objects being passed to it.
MPI_INFO_NULL is still an ompi_predefined_info_t type since an MPI_Info is part of ompi but the internal details of the underlying information concept is part of opal.
An ompi_info_t type still exists for exposure to the user, but it is simply a wrapper for the opal object.
Routines such as ompi_info_dup, etc have all been moved to opal_info_dup and related to the opal directory.
Fortran to C translation tables are only used for MPI_Info that is exposed to the application and are therefore part of the ompi_info_t and not the opal_info_t
The data structure changes are primarily in the following files:
communicator/communicator.h
ompi/info/info.h
ompi/win/win.h
ompi/file/file.h
The following new files were created:
opal/util/info.h
opal/util/info.c
opal/util/info_subscriber.h
opal/util/info_subscriber.c
This infosubscriber concept is that communicators, files and windows can have subscribers that subscribe to any changes in the info associated with the comm/file/window. When xxx_set_info is called, the new info is presented to each subscriber who can modify the info in any way they want. The new value is presented to the next subscriber and so on until all subscribers have had a chance to modify the value. Therefore, the order of subscribers can make a difference but we hope that there is generally only one subscriber that cares or modifies any given key/value pair. The final info is then stored and returned by a call to xxx_get_info.
The new model can be seen in the following files:
ompi/mpi/c/comm_get_info.c
ompi/mpi/c/comm_set_info.c
ompi/mpi/c/file_get_info.c
ompi/mpi/c/file_set_info.c
ompi/mpi/c/win_get_info.c
ompi/mpi/c/win_set_info.c
The current subscribers where changed as follows:
mca/io/ompio/io_ompio_file_open.c
mca/io/ompio/io_ompio_module.c
mca/osc/rmda/osc_rdma_component.c (This one actually subscribes to "no_locks")
mca/osc/sm/osc_sm_component.c (This one actually subscribes to "blocking_fence" and "alloc_shared_contig")
Signed-off-by: Mark Allen <markalle@us.ibm.com>
Conflicts:
AUTHORS
ompi/communicator/comm.c
ompi/debuggers/ompi_mpihandles_dll.c
ompi/file/file.c
ompi/file/file.h
ompi/info/info.c
ompi/mca/io/ompio/io_ompio.h
ompi/mca/io/ompio/io_ompio_file_open.c
ompi/mca/io/ompio/io_ompio_file_set_view.c
ompi/mca/osc/pt2pt/osc_pt2pt.h
ompi/mca/sharedfp/addproc/sharedfp_addproc.h
ompi/mca/sharedfp/addproc/sharedfp_addproc_file_open.c
ompi/mca/topo/treematch/topo_treematch_dist_graph_create.c
ompi/mpi/c/lookup_name.c
ompi/mpi/c/publish_name.c
ompi/mpi/c/unpublish_name.c
opal/mca/mpool/base/mpool_base_alloc.c
opal/util/Makefile.am
2016-01-22 20:02:01 +03:00
|
|
|
uri.h \
|
|
|
|
|
info_subscriber.h \
|
|
|
|
|
info.h
|
2004-01-09 00:43:53 +03:00
|
|
|
|
2005-07-02 18:08:19 +04:00
|
|
|
libopalutil_la_SOURCES = \
|
|
|
|
|
$(headers) \
|
2014-02-26 03:41:55 +04:00
|
|
|
alfg.c \
|
2008-04-18 00:43:56 +04:00
|
|
|
arch.c \
|
2005-07-02 18:08:19 +04:00
|
|
|
argv.c \
|
|
|
|
|
basename.c \
|
2017-09-14 21:36:48 +03:00
|
|
|
bipartite_graph.c \
|
2005-07-02 18:08:19 +04:00
|
|
|
cmd_line.c \
|
2005-11-28 20:20:21 +03:00
|
|
|
crc.c \
|
2005-07-02 18:08:19 +04:00
|
|
|
daemon_init.c \
|
2016-05-04 09:21:25 +03:00
|
|
|
ethtool.c \
|
2005-09-07 22:52:28 +04:00
|
|
|
error.c \
|
2015-10-29 04:58:02 +03:00
|
|
|
fd.c \
|
2005-07-02 18:08:19 +04:00
|
|
|
few.c \
|
|
|
|
|
if.c \
|
2010-05-18 02:53:33 +04:00
|
|
|
keyval_parse.c \
|
2005-07-02 18:08:19 +04:00
|
|
|
malloc.c \
|
2010-05-18 02:53:33 +04:00
|
|
|
net.c \
|
2005-07-02 18:08:19 +04:00
|
|
|
numtostr.c \
|
2005-07-04 05:36:20 +04:00
|
|
|
opal_environ.c \
|
2008-02-28 04:57:57 +03:00
|
|
|
opal_getcwd.c \
|
2010-05-18 02:53:33 +04:00
|
|
|
opal_pty.c \
|
2006-07-04 02:23:07 +04:00
|
|
|
os_dirpath.c \
|
2005-07-02 18:08:19 +04:00
|
|
|
os_path.c \
|
|
|
|
|
output.c \
|
|
|
|
|
path.c \
|
|
|
|
|
printf.c \
|
George did the work and deserves all the credit for it. Ralph did the merge, and deserves whatever blame results from errors in it :-)
WHAT: Open our low-level communication infrastructure by moving all necessary components (btl/rcache/allocator/mpool) down in OPAL
All the components required for inter-process communications are currently deeply integrated in the OMPI layer. Several groups/institutions have express interest in having a more generic communication infrastructure, without all the OMPI layer dependencies. This communication layer should be made available at a different software level, available to all layers in the Open MPI software stack. As an example, our ORTE layer could replace the current OOB and instead use the BTL directly, gaining access to more reactive network interfaces than TCP. Similarly, external software libraries could take advantage of our highly optimized AM (active message) communication layer for their own purpose. UTK with support from Sandia, developped a version of Open MPI where the entire communication infrastucture has been moved down to OPAL (btl/rcache/allocator/mpool). Most of the moved components have been updated to match the new schema, with few exceptions (mainly BTLs where I have no way of compiling/testing them). Thus, the completion of this RFC is tied to being able to completing this move for all BTLs. For this we need help from the rest of the Open MPI community, especially those supporting some of the BTLs. A non-exhaustive list of BTLs that qualify here is: mx, portals4, scif, udapl, ugni, usnic.
This commit was SVN r32317.
2014-07-26 04:47:28 +04:00
|
|
|
proc.c \
|
2005-07-02 18:08:19 +04:00
|
|
|
qsort.c \
|
|
|
|
|
show_help.c \
|
|
|
|
|
show_help_lex.l \
|
|
|
|
|
stacktrace.c \
|
2005-09-07 22:52:28 +04:00
|
|
|
strncpy.c \
|
2007-04-23 22:53:47 +04:00
|
|
|
sys_limits.c \
|
Major structural changes to data types: .super infosubscriber
ompi_communicator_t, ompi_win_t, ompi_file_t all have a super class of type opal_infosubscriber_t instead of a base/super type of opal_object_t (in previous code comm used c_base, but file used super). It may be a bit bold to say that being a subscriber of MPI_Info is the foundational piece that ties these three things together, but if you object, then I would prefer to turn infosubscriber into a more general name that encompasses other common features rather than create a different super class. The key here is that we want to be able to pass comm, win and file objects as if they were opal_infosubscriber_t, so that one routine can heandle all 3 types of objects being passed to it.
MPI_INFO_NULL is still an ompi_predefined_info_t type since an MPI_Info is part of ompi but the internal details of the underlying information concept is part of opal.
An ompi_info_t type still exists for exposure to the user, but it is simply a wrapper for the opal object.
Routines such as ompi_info_dup, etc have all been moved to opal_info_dup and related to the opal directory.
Fortran to C translation tables are only used for MPI_Info that is exposed to the application and are therefore part of the ompi_info_t and not the opal_info_t
The data structure changes are primarily in the following files:
communicator/communicator.h
ompi/info/info.h
ompi/win/win.h
ompi/file/file.h
The following new files were created:
opal/util/info.h
opal/util/info.c
opal/util/info_subscriber.h
opal/util/info_subscriber.c
This infosubscriber concept is that communicators, files and windows can have subscribers that subscribe to any changes in the info associated with the comm/file/window. When xxx_set_info is called, the new info is presented to each subscriber who can modify the info in any way they want. The new value is presented to the next subscriber and so on until all subscribers have had a chance to modify the value. Therefore, the order of subscribers can make a difference but we hope that there is generally only one subscriber that cares or modifies any given key/value pair. The final info is then stored and returned by a call to xxx_get_info.
The new model can be seen in the following files:
ompi/mpi/c/comm_get_info.c
ompi/mpi/c/comm_set_info.c
ompi/mpi/c/file_get_info.c
ompi/mpi/c/file_set_info.c
ompi/mpi/c/win_get_info.c
ompi/mpi/c/win_set_info.c
The current subscribers where changed as follows:
mca/io/ompio/io_ompio_file_open.c
mca/io/ompio/io_ompio_module.c
mca/osc/rmda/osc_rdma_component.c (This one actually subscribes to "no_locks")
mca/osc/sm/osc_sm_component.c (This one actually subscribes to "blocking_fence" and "alloc_shared_contig")
Signed-off-by: Mark Allen <markalle@us.ibm.com>
Conflicts:
AUTHORS
ompi/communicator/comm.c
ompi/debuggers/ompi_mpihandles_dll.c
ompi/file/file.c
ompi/file/file.h
ompi/info/info.c
ompi/mca/io/ompio/io_ompio.h
ompi/mca/io/ompio/io_ompio_file_open.c
ompi/mca/io/ompio/io_ompio_file_set_view.c
ompi/mca/osc/pt2pt/osc_pt2pt.h
ompi/mca/sharedfp/addproc/sharedfp_addproc.h
ompi/mca/sharedfp/addproc/sharedfp_addproc_file_open.c
ompi/mca/topo/treematch/topo_treematch_dist_graph_create.c
ompi/mpi/c/lookup_name.c
ompi/mpi/c/publish_name.c
ompi/mpi/c/unpublish_name.c
opal/mca/mpool/base/mpool_base_alloc.c
opal/util/Makefile.am
2016-01-22 20:02:01 +03:00
|
|
|
uri.c \
|
|
|
|
|
info_subscriber.c \
|
|
|
|
|
info.c
|
2012-10-25 21:15:17 +04:00
|
|
|
|
2014-09-23 16:59:54 +04:00
|
|
|
if OPAL_COMPILE_TIMING
|
|
|
|
|
libopalutil_la_SOURCES += timings.c
|
|
|
|
|
endif
|
|
|
|
|
|
2006-01-16 04:48:03 +03:00
|
|
|
libopalutil_la_LIBADD = \
|
2010-05-18 02:53:33 +04:00
|
|
|
keyval/libopalutilkeyval.la
|
2006-01-16 04:48:03 +03:00
|
|
|
libopalutil_la_DEPENDENCIES = \
|
2010-05-18 02:53:33 +04:00
|
|
|
keyval/libopalutilkeyval.la
|
2004-01-09 00:43:53 +03:00
|
|
|
|
|
|
|
|
# Conditionally install the header files
|
|
|
|
|
|
|
|
|
|
if WANT_INSTALL_HEADERS
|
2014-05-08 06:01:35 +04:00
|
|
|
opaldir = $(opalincludedir)/$(subdir)
|
2010-09-18 03:04:06 +04:00
|
|
|
opal_HEADERS = $(headers)
|
2004-01-09 00:43:53 +03:00
|
|
|
endif
|
2016-05-26 08:51:32 +03:00
|
|
|
|
|
|
|
|
maintainer-clean-local:
|
|
|
|
|
rm -f show_help_lex.c
|