ports/openmpi
ports/openmpi
1
1
Форкнуть 0
Код Релизы Активность
005400a937
openmpi/ompi/mca/coll/libnbc/nbc_neighbor_helpers.c

104 строки
3.1 KiB
C
Исходник Обычный вид История

coll/libnbc: rewrite parts of libnbc This commit rewrites parts of libnbc to fix issues identified by coverity and myself. The changes are as follows: - libnbc function would return invalid error codes (internal to libnbc) to the mpi layer. These codes names are of the form NBC_. They do not match up with the error codes expected by the mpi layer. I purged the use of all these error codes with the exception of NBC_OK and NBC_CONTINUE in progress. These codes are used to identify when a request handle is complete. - Handles and schedules were leaked by all collective routines on error. A new routine was added to return a collective handle (NBC_Return_handle). - Temporary buffers containting in/out neighbors for neighborhood collectives were always leaked. - Neigborhood collectives contained code to handle MPI_IN_PLACE which is never a valid input for the send or receive buffer. Stipped this code out. - Files were inconsistently named. Most are nbc_isomething.c but one was named coll_libnbc_ireduce_scatter_block.c. - Made the NBC_Schedule "structure" and object so it can be retained/released. This may enable the use of schedule caching at a later time. More testing will be needed to ensure the caching code works. If it doesn't the code should be stripped out completely. - Added code to simply common case of scheduling send/recv + barrier. - Code cleanup for readability. The code now passes the clang static analyzer. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2015-07-09 01:51:29 +03:00
/* -*- Mode: C; c-basic-offset:2 ; indent-tabs-mode:nil -*- */
MPI-3: Add support for neighborhood collectives Blocking versions are simple linear algorithms implemented in coll/basic. Non- blocking versions are from libnbc 1.1.1. All algorithms have been tested with simple test cases. cmr=v1.7.4:reviewer=jsquyres This commit was SVN r29265.
2013-09-27 01:55:08 +04:00
/*
* Copyright (c) 2006 The Trustees of Indiana University and Indiana
* University Research and Technology
* Corporation. All rights reserved.
* Copyright (c) 2006 The Technical University of Chemnitz. All
* rights reserved.
coll/libnbc: rewrite parts of libnbc This commit rewrites parts of libnbc to fix issues identified by coverity and myself. The changes are as follows: - libnbc function would return invalid error codes (internal to libnbc) to the mpi layer. These codes names are of the form NBC_. They do not match up with the error codes expected by the mpi layer. I purged the use of all these error codes with the exception of NBC_OK and NBC_CONTINUE in progress. These codes are used to identify when a request handle is complete. - Handles and schedules were leaked by all collective routines on error. A new routine was added to return a collective handle (NBC_Return_handle). - Temporary buffers containting in/out neighbors for neighborhood collectives were always leaked. - Neigborhood collectives contained code to handle MPI_IN_PLACE which is never a valid input for the send or receive buffer. Stipped this code out. - Files were inconsistently named. Most are nbc_isomething.c but one was named coll_libnbc_ireduce_scatter_block.c. - Made the NBC_Schedule "structure" and object so it can be retained/released. This may enable the use of schedule caching at a later time. More testing will be needed to ensure the caching code works. If it doesn't the code should be stripped out completely. - Added code to simply common case of scheduling send/recv + barrier. - Code cleanup for readability. The code now passes the clang static analyzer. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2015-07-09 01:51:29 +03:00
* Copyright (c) 2015 Los Alamos National Security, LLC. All rights
* reserved.
MPI-3: Add support for neighborhood collectives Blocking versions are simple linear algorithms implemented in coll/basic. Non- blocking versions are from libnbc 1.1.1. All algorithms have been tested with simple test cases. cmr=v1.7.4:reviewer=jsquyres This commit was SVN r29265.
2013-09-27 01:55:08 +04:00
*
* Author(s): Torsten Hoefler <htor@cs.indiana.edu>
*
*/
coll/libnbc: rewrite parts of libnbc This commit rewrites parts of libnbc to fix issues identified by coverity and myself. The changes are as follows: - libnbc function would return invalid error codes (internal to libnbc) to the mpi layer. These codes names are of the form NBC_. They do not match up with the error codes expected by the mpi layer. I purged the use of all these error codes with the exception of NBC_OK and NBC_CONTINUE in progress. These codes are used to identify when a request handle is complete. - Handles and schedules were leaked by all collective routines on error. A new routine was added to return a collective handle (NBC_Return_handle). - Temporary buffers containting in/out neighbors for neighborhood collectives were always leaked. - Neigborhood collectives contained code to handle MPI_IN_PLACE which is never a valid input for the send or receive buffer. Stipped this code out. - Files were inconsistently named. Most are nbc_isomething.c but one was named coll_libnbc_ireduce_scatter_block.c. - Made the NBC_Schedule "structure" and object so it can be retained/released. This may enable the use of schedule caching at a later time. More testing will be needed to ensure the caching code works. If it doesn't the code should be stripped out completely. - Added code to simply common case of scheduling send/recv + barrier. - Code cleanup for readability. The code now passes the clang static analyzer. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2015-07-09 01:51:29 +03:00
MPI-3: Add support for neighborhood collectives Blocking versions are simple linear algorithms implemented in coll/basic. Non- blocking versions are from libnbc 1.1.1. All algorithms have been tested with simple test cases. cmr=v1.7.4:reviewer=jsquyres This commit was SVN r29265.
2013-09-27 01:55:08 +04:00
#include "nbc_internal.h"
coll/libnbc: rewrite parts of libnbc This commit rewrites parts of libnbc to fix issues identified by coverity and myself. The changes are as follows: - libnbc function would return invalid error codes (internal to libnbc) to the mpi layer. These codes names are of the form NBC_. They do not match up with the error codes expected by the mpi layer. I purged the use of all these error codes with the exception of NBC_OK and NBC_CONTINUE in progress. These codes are used to identify when a request handle is complete. - Handles and schedules were leaked by all collective routines on error. A new routine was added to return a collective handle (NBC_Return_handle). - Temporary buffers containting in/out neighbors for neighborhood collectives were always leaked. - Neigborhood collectives contained code to handle MPI_IN_PLACE which is never a valid input for the send or receive buffer. Stipped this code out. - Files were inconsistently named. Most are nbc_isomething.c but one was named coll_libnbc_ireduce_scatter_block.c. - Made the NBC_Schedule "structure" and object so it can be retained/released. This may enable the use of schedule caching at a later time. More testing will be needed to ensure the caching code works. If it doesn't the code should be stripped out completely. - Added code to simply common case of scheduling send/recv + barrier. - Code cleanup for readability. The code now passes the clang static analyzer. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2015-07-09 01:51:29 +03:00
#include "ompi/mca/topo/base/base.h"
int NBC_Comm_neighbors_count (ompi_communicator_t *comm, int *indegree, int *outdegree) {
if (OMPI_COMM_IS_CART(comm)) {
/* cartesian */
/* outdegree is always 2*ndims because we need to iterate over empty buffers for MPI_PROC_NULL */
*outdegree = *indegree = 2 * comm->c_topo->mtc.cart->ndims;
} else if (OMPI_COMM_IS_GRAPH(comm)) {
/* graph */
int rank, nneighbors;
rank = ompi_comm_rank (comm);
mca_topo_base_graph_neighbors_count (comm, rank, &nneighbors);
MPI-3: Add support for neighborhood collectives Blocking versions are simple linear algorithms implemented in coll/basic. Non- blocking versions are from libnbc 1.1.1. All algorithms have been tested with simple test cases. cmr=v1.7.4:reviewer=jsquyres This commit was SVN r29265.
2013-09-27 01:55:08 +04:00
coll/libnbc: rewrite parts of libnbc This commit rewrites parts of libnbc to fix issues identified by coverity and myself. The changes are as follows: - libnbc function would return invalid error codes (internal to libnbc) to the mpi layer. These codes names are of the form NBC_. They do not match up with the error codes expected by the mpi layer. I purged the use of all these error codes with the exception of NBC_OK and NBC_CONTINUE in progress. These codes are used to identify when a request handle is complete. - Handles and schedules were leaked by all collective routines on error. A new routine was added to return a collective handle (NBC_Return_handle). - Temporary buffers containting in/out neighbors for neighborhood collectives were always leaked. - Neigborhood collectives contained code to handle MPI_IN_PLACE which is never a valid input for the send or receive buffer. Stipped this code out. - Files were inconsistently named. Most are nbc_isomething.c but one was named coll_libnbc_ireduce_scatter_block.c. - Made the NBC_Schedule "structure" and object so it can be retained/released. This may enable the use of schedule caching at a later time. More testing will be needed to ensure the caching code works. If it doesn't the code should be stripped out completely. - Added code to simply common case of scheduling send/recv + barrier. - Code cleanup for readability. The code now passes the clang static analyzer. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2015-07-09 01:51:29 +03:00
*outdegree = *indegree = nneighbors;
} else if (OMPI_COMM_IS_DIST_GRAPH(comm)) {
/* graph */
*indegree = comm->c_topo->mtc.dist_graph->indegree;
*outdegree = comm->c_topo->mtc.dist_graph->outdegree;
} else {
return OMPI_ERR_BAD_PARAM;
MPI-3: Add support for neighborhood collectives Blocking versions are simple linear algorithms implemented in coll/basic. Non- blocking versions are from libnbc 1.1.1. All algorithms have been tested with simple test cases. cmr=v1.7.4:reviewer=jsquyres This commit was SVN r29265.
2013-09-27 01:55:08 +04:00
}
coll/libnbc: rewrite parts of libnbc This commit rewrites parts of libnbc to fix issues identified by coverity and myself. The changes are as follows: - libnbc function would return invalid error codes (internal to libnbc) to the mpi layer. These codes names are of the form NBC_. They do not match up with the error codes expected by the mpi layer. I purged the use of all these error codes with the exception of NBC_OK and NBC_CONTINUE in progress. These codes are used to identify when a request handle is complete. - Handles and schedules were leaked by all collective routines on error. A new routine was added to return a collective handle (NBC_Return_handle). - Temporary buffers containting in/out neighbors for neighborhood collectives were always leaked. - Neigborhood collectives contained code to handle MPI_IN_PLACE which is never a valid input for the send or receive buffer. Stipped this code out. - Files were inconsistently named. Most are nbc_isomething.c but one was named coll_libnbc_ireduce_scatter_block.c. - Made the NBC_Schedule "structure" and object so it can be retained/released. This may enable the use of schedule caching at a later time. More testing will be needed to ensure the caching code works. If it doesn't the code should be stripped out completely. - Added code to simply common case of scheduling send/recv + barrier. - Code cleanup for readability. The code now passes the clang static analyzer. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2015-07-09 01:51:29 +03:00
return OMPI_SUCCESS;
MPI-3: Add support for neighborhood collectives Blocking versions are simple linear algorithms implemented in coll/basic. Non- blocking versions are from libnbc 1.1.1. All algorithms have been tested with simple test cases. cmr=v1.7.4:reviewer=jsquyres This commit was SVN r29265.
2013-09-27 01:55:08 +04:00
}
coll/libnbc: rewrite parts of libnbc This commit rewrites parts of libnbc to fix issues identified by coverity and myself. The changes are as follows: - libnbc function would return invalid error codes (internal to libnbc) to the mpi layer. These codes names are of the form NBC_. They do not match up with the error codes expected by the mpi layer. I purged the use of all these error codes with the exception of NBC_OK and NBC_CONTINUE in progress. These codes are used to identify when a request handle is complete. - Handles and schedules were leaked by all collective routines on error. A new routine was added to return a collective handle (NBC_Return_handle). - Temporary buffers containting in/out neighbors for neighborhood collectives were always leaked. - Neigborhood collectives contained code to handle MPI_IN_PLACE which is never a valid input for the send or receive buffer. Stipped this code out. - Files were inconsistently named. Most are nbc_isomething.c but one was named coll_libnbc_ireduce_scatter_block.c. - Made the NBC_Schedule "structure" and object so it can be retained/released. This may enable the use of schedule caching at a later time. More testing will be needed to ensure the caching code works. If it doesn't the code should be stripped out completely. - Added code to simply common case of scheduling send/recv + barrier. - Code cleanup for readability. The code now passes the clang static analyzer. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2015-07-09 01:51:29 +03:00
int NBC_Comm_neighbors (ompi_communicator_t *comm, int **sources, int *source_count, int **destinations, int *dest_count) {
int res, indeg, outdeg;
*sources = *destinations = NULL;
res = NBC_Comm_neighbors_count(comm, &indeg, &outdeg);
if (OMPI_SUCCESS != res) {
return res;
}
*source_count = indeg;
*dest_count = outdeg;
if (indeg) {
*sources = malloc (sizeof (int) * indeg);
if (OPAL_UNLIKELY(NULL == *sources)) {
return OMPI_ERR_OUT_OF_RESOURCE;
}
} else {
*sources = NULL;
}
if (outdeg) {
*destinations = malloc (sizeof (int) * outdeg);
if (OPAL_UNLIKELY(NULL == *destinations)) {
free (*sources);
*sources = NULL;
return OMPI_ERR_OUT_OF_RESOURCE;
}
} else {
*destinations = NULL;
}
/* silence clang static analyzer warning about NULL-dereference */
if (0 == indeg && 0 == outdeg) {
return OMPI_SUCCESS;
}
if (OMPI_COMM_IS_CART(comm)) {
/* cartesian */
int rpeer, speer;
/* silence clang static analyzer warning */
assert (indeg == outdeg);
for (int dim = 0, i = 0 ; dim < comm->c_topo->mtc.cart->ndims ; ++dim) {
mca_topo_base_cart_shift (comm, dim, 1, &rpeer, &speer);
sources[0][i] = destinations[0][i] = rpeer; i++;
sources[0][i] = destinations[0][i] = speer; i++;
}
} else if (OMPI_COMM_IS_GRAPH(comm)) {
/* graph */
mca_topo_base_graph_neighbors (comm, ompi_comm_rank (comm), indeg, sources[0]);
memcpy (destinations[0], sources[0], indeg * sizeof (int));
} else if (OMPI_COMM_IS_DIST_GRAPH(comm)) {
/* dist graph */
mca_topo_base_dist_graph_neighbors (comm, indeg, sources[0], MPI_UNWEIGHTED, outdeg, destinations[0],
MPI_UNWEIGHTED);
MPI-3: Add support for neighborhood collectives Blocking versions are simple linear algorithms implemented in coll/basic. Non- blocking versions are from libnbc 1.1.1. All algorithms have been tested with simple test cases. cmr=v1.7.4:reviewer=jsquyres This commit was SVN r29265.
2013-09-27 01:55:08 +04:00
}
coll/libnbc: rewrite parts of libnbc This commit rewrites parts of libnbc to fix issues identified by coverity and myself. The changes are as follows: - libnbc function would return invalid error codes (internal to libnbc) to the mpi layer. These codes names are of the form NBC_. They do not match up with the error codes expected by the mpi layer. I purged the use of all these error codes with the exception of NBC_OK and NBC_CONTINUE in progress. These codes are used to identify when a request handle is complete. - Handles and schedules were leaked by all collective routines on error. A new routine was added to return a collective handle (NBC_Return_handle). - Temporary buffers containting in/out neighbors for neighborhood collectives were always leaked. - Neigborhood collectives contained code to handle MPI_IN_PLACE which is never a valid input for the send or receive buffer. Stipped this code out. - Files were inconsistently named. Most are nbc_isomething.c but one was named coll_libnbc_ireduce_scatter_block.c. - Made the NBC_Schedule "structure" and object so it can be retained/released. This may enable the use of schedule caching at a later time. More testing will be needed to ensure the caching code works. If it doesn't the code should be stripped out completely. - Added code to simply common case of scheduling send/recv + barrier. - Code cleanup for readability. The code now passes the clang static analyzer. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
2015-07-09 01:51:29 +03:00
return OMPI_SUCCESS;
MPI-3: Add support for neighborhood collectives Blocking versions are simple linear algorithms implemented in coll/basic. Non- blocking versions are from libnbc 1.1.1. All algorithms have been tested with simple test cases. cmr=v1.7.4:reviewer=jsquyres This commit was SVN r29265.
2013-09-27 01:55:08 +04:00
}
Копировать постоянную ссылку