From 36facc201c35e3bb5c13cb6a7ad6ee35ef153b90 Mon Sep 17 00:00:00 2001 From: Pavel Roskin Date: Wed, 22 Dec 1999 04:04:23 +0000 Subject: [PATCH] vfs/vfs.h: use #warning only for gcc. Not all compilers understand it src/main.c, src/view.c: #warning's replaced with FIXME's. They were not for users, but for developers --- src/ChangeLog | 5 +++++ src/main.c | 2 +- src/view.c | 7 ++++++- vfs/ChangeLog | 5 +++++ vfs/vfs.h | 2 ++ 5 files changed, 19 insertions(+), 2 deletions(-) diff --git a/src/ChangeLog b/src/ChangeLog index fc42ebc17..d8a9c7205 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,3 +1,8 @@ +1999-12-21 Pavel Roskin + + * src/main.c, src/view.c: #warning's replaced with FIXME's. + They were not for users, but for developers + 1999-11-11 Pavel Machek * main.c, cmd.c: add possibility to free VFS now diff --git a/src/main.c b/src/main.c index e997df795..b1887cdad 100644 --- a/src/main.c +++ b/src/main.c @@ -450,7 +450,7 @@ update_one_panel_widget (WPanel *panel, int force_update, char *current_file) #if 0 ftpfs_flushdir (); #endif -#warning Should supply flushdir method +/* FIXME: Should supply flushdir method */ memset (&(panel->dir_stat), 0, sizeof (panel->dir_stat)); } diff --git a/src/view.c b/src/view.c index bffd34fe5..91fd48c44 100644 --- a/src/view.c +++ b/src/view.c @@ -239,7 +239,12 @@ get_byte (WView *view, unsigned int byte_index) n = fread (p, 1, VIEW_PAGE_SIZE, view->stdfile); else n = mc_read (view->file, p, VIEW_PAGE_SIZE); -#warning FIXME: Errors are ignored at this point, also should report preliminary EOF + +/* + * FIXME: Errors are ignored at this point + * Also should report preliminary EOF + */ + if (n != -1) view->bytes_read += n; if (view->s.st_size < view->bytes_read){ diff --git a/vfs/ChangeLog b/vfs/ChangeLog index b6270f679..a3c931ae2 100644 --- a/vfs/ChangeLog +++ b/vfs/ChangeLog @@ -1,3 +1,8 @@ +1999-12-21 Pavel Roskin + + * vfs/vfs.h: use #warning only for gcc. Not all compilers + understand it + 1999-12-15 Pavel Machek * Merged changes by Andrew V. Samoilov . They are diff --git a/vfs/vfs.h b/vfs/vfs.h index 40f18a5e5..0e2206da1 100644 --- a/vfs/vfs.h +++ b/vfs/vfs.h @@ -378,7 +378,9 @@ extern void mc_vfs_done( void ); listed above and O_APPEND */ #if (O_ALL & O_APPEND) +#ifdef __GNUC__ #warning Unexpected problem with flags, O_LINEAR disabled, contact pavel@ucw.cz +#endif #define O_LINEAR 0 #define IS_LINEAR(a) 0 #define NO_LINEAR(a) a