I still don't know why mc_chmod doesn't work, but other then that, this

seems fine.

1999-01-21  Jonathan Blandford  <jrb@redhat.com>

	* glayout.c: comment out compare panels.

	* gnome-file-property-dialog.h: new file.  This is a new widget
	for the file-properties dialog.  It doesn't handle mode changes
	quite right yet, but does everything else beautifully...

	* gnome-file-property-dialog.c: new file

	* gpopup.c (panel_action_properties): use new dialog
	(dicon_properties): as above.

gnome/ChangeLog

@@ -1,3 +1,16 @@
+1999-01-21  Jonathan Blandford  <jrb@redhat.com>
+
+	* glayout.c: comment out compare panels.
+
+	* gnome-file-property-dialog.h: new file.  This is a new widget
+	for the file-properties dialog.  It doesn't handle mode changes
+	quite right yet, but does everything else beautifully...
+
+	* gnome-file-property-dialog.c: new file
+
+	* gpopup.c (panel_action_properties): use new dialog
+	(dicon_properties): as above.
+
 1999-01-21  Federico Mena Quintero  <federico@nuclecu.unam.mx>
 
 	* gscreen.c (panel_create_file_list): Added GDK_ACTION_ASK to the

gnome/Makefile.in

@@ -50,6 +50,7 @@ GNOMESRCS = 		\
 	gpopup.c	\
 	gprefs.c	\
 	gprop.c		\
+	gnome-file-property-dialog.c \
 	gscreen.c 	\
 	gtools.c 	\
 	gtkdtree.c	\
@@ -75,6 +76,7 @@ GNOMEHDRS = 		\
 	gpopup.h	\
 	gprefs.h	\
 	gprop.h		\
+	gnome-file-property-dialog.h \
 	gscreen.h	\
 	gtkdtree.h	\
 	gtree.h		\
@@ -139,6 +141,7 @@ OBJS = 			\
 	gpopup.o	\
 	gprefs.o	\
 	gprop.o		\
+	gnome-file-property-dialog.o \
 	gscreen.o 	\
 	gtools.o 	\
 	gtree.o		\

gnome/gdesktop.h

@@ -8,7 +8,7 @@
 
 #ifndef GDESKTOP_H
 #define GDESKTOP_H
-
+#include "dir.h"
 
 /* Snap granularity for desktop icons -- maybe these should be calculated in
  * terms of the font size?

gnome/glayout.c

@@ -303,7 +303,7 @@ GnomeUIInfo gnome_panel_file_menu [] = {
 	{ GNOME_APP_UI_ITEM, N_("_Open"),              N_("Opens the selected files"), gnome_open_files },
 /*	{ GNOME_APP_UI_ITEM, N_("Open _FTP site"),     N_("Opens an FTP site"), ftplink_cmd },*/
 	{ GNOME_APP_UI_ITEM, N_("_Copy..."),           N_("Copy files"), copy_cmd, NULL},
-	{ GNOME_APP_UI_ITEM, N_("_Delete..."),         N_("Delete files from disk"), delete_cmd },
+	{ GNOME_APP_UI_ITEM, N_("_Delete..."),         N_("Delete files from disk"), delete_cmd, NULL, NULL, 0, NULL, 'd', GDK_CONTROL_MASK},
 	{ GNOME_APP_UI_ITEM, N_("_Move..."),           N_("Rename or move files"), ren_cmd },
 	{ GNOME_APP_UI_SEPARATOR },
 	{ GNOME_APP_UI_ITEM, N_("C_lose"),             N_("Close this panel"), gnome_close_panel, NULL,
@@ -313,11 +313,7 @@ GnomeUIInfo gnome_panel_file_menu [] = {
 };
 
 GnomeUIInfo gnome_panel_edit_menu [] = {
-	GNOMEUIINFO_MENU_CUT_ITEM(NULL, NULL),
-	GNOMEUIINFO_MENU_COPY_ITEM(NULL, NULL),
-	GNOMEUIINFO_MENU_PASTE_ITEM(NULL, NULL),
-	{ GNOME_APP_UI_SEPARATOR },
-	{ GNOME_APP_UI_ITEM, N_("_Select All"),        N_("Select all files in the current Panel"), gnome_select_all_cmd },
+	{ GNOME_APP_UI_ITEM, N_("Select _All"),        N_("Select all files in the current Panel"), gnome_select_all_cmd, NULL, NULL, 0, NULL, 'a', GDK_CONTROL_MASK  },
 	{ GNOME_APP_UI_ITEM, N_("_Select Files..."),   N_("Select a group of files"), select_cmd },
 	{ GNOME_APP_UI_ITEM, N_("_Invert Selection"),  N_("Reverses the list of tagged files"), reverse_selection_cmd },
 	{ GNOME_APP_UI_SEPARATOR },
@@ -348,7 +344,7 @@ GnomeUIInfo gnome_panel_commands_menu [] = {
 	{ GNOME_APP_UI_ITEM, N_("_Find File..."),      N_("Locate files on disk"),   find_cmd, NULL,
 	  NULL, GNOME_APP_PIXMAP_STOCK, GNOME_STOCK_MENU_JUMP_TO},
 	  
-	{ GNOME_APP_UI_ITEM, N_("_Compare panels..."), N_("Compare two panel contents"), gnome_compare_panels },
+/*	{ GNOME_APP_UI_ITEM, N_("_Compare panels..."), N_("Compare two panel contents"), gnome_compare_panels },*/
 	{ GNOME_APP_UI_ITEM, N_("_Run Command..."),               N_("Runs a command"), run_cmd, NULL,
 	  NULL, GNOME_APP_PIXMAP_STOCK, GNOME_STOCK_MENU_OPEN, GDK_F2, 0 },
 	{ GNOME_APP_UI_ITEM, N_("_Run Command in panel..."),N_("Run a command and put the results in a panel"), gnome_external_panelize },

gnome/gpopup.c

@@ -17,7 +17,7 @@
 #include "gpageprop.h"
 #include "gpopup.h"
 #include "main.h"
-
+#include "gnome-file-property-dialog.h"
 #define CLIST_FROM_SW(panel_list) GTK_CLIST (GTK_BIN (panel_list)->child)
 
 
@@ -82,11 +82,17 @@ panel_action_edit (GtkWidget *widget, WPanel *panel)
 static void
 dicon_properties (GtkWidget *widget, DesktopIconInfo *dii)
 {
-	int retval;
+	int retval = 1;
 	char *path;
+	GtkWidget *dlg;
 	
 	path = g_strconcat (getenv("HOME"), "/desktop/", dii->filename, NULL);
-	retval = item_properties (dii->dicon, path, dii);
+/*	retval = item_properties (dii->dicon, path, dii);*/
+	dlg = gnome_file_property_dialog_new (path);
+	gtk_widget_show_all (dlg);
+	if (gnome_dialog_run (GNOME_DIALOG (dlg)) == 0)
+		retval = gnome_file_property_dialog_make_changes (GNOME_FILE_PROPERTY_DIALOG (dlg));
+	gtk_widget_destroy (dlg);
 	g_free(path);
 	if (retval)
 		reread_cmd ();
@@ -102,13 +108,20 @@ dicon_execute (GtkWidget *widget, DesktopIconInfo *dii)
 static void
 panel_action_properties (GtkWidget *widget, WPanel *panel)
 {
+	gint retval;
 	file_entry *fe = &panel->dir.list [panel->selected];
 	char *full_name = concat_dir_and_file (panel->cwd, fe->fname);
+	GtkWidget *dlg;
 
-	if (item_properties (GTK_WIDGET (CLIST_FROM_SW (panel->list)), full_name, NULL) != 0)
-		reread_cmd ();
-
+/*	if (item_properties (GTK_WIDGET (CLIST_FROM_SW (panel->list)), full_name, NULL) != 0)
+	reread_cmd ();*/
+	dlg = gnome_file_property_dialog_new (full_name);
+	if (gnome_dialog_run (GNOME_DIALOG (dlg)) == 0)
+		retval = gnome_file_property_dialog_make_changes (GNOME_FILE_PROPERTY_DIALOG (dlg));
+		gtk_widget_destroy (dlg);
 	free (full_name);
+	if (retval)
+		reread_cmd ();
 }
 
 static void

src/dir.h

@@ -4,6 +4,7 @@
 #define MIN_FILES 128
 #define RESIZE_STEPS 128
 
+#include <sys/stat.h>
 typedef struct {
 
     /* File attributes */