Jon Simons
d4f5a0e6ab
server: fix pubkey reply for key probes
...
Per RFC 4252, it is required to send back only one of either
SSH_MSG_USERAUTH_PK_OK or SSH_MSG_USERAUTH_FAILURE for public
key probes.
Update the handling of 'auth_pubkey_function' to send back PK_OK
instead of SSH_MSG_USERAUTH_SUCCESS for the case that the state
of the message at hand is SSH_PUBLICKEY_STATE_NONE.
With this change, it is now possible to process an initial key probe
and then subsequent signature validation using the server callbacks.
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-11-02 21:02:56 +01:00
William Orr
ce1d73e0f0
ssh_options_get can now return ProxyCommand
...
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-11-02 21:02:56 +01:00
Jon Simons
20caa68b84
connect: fix memory leak in ssh_select
...
Balance 'ssh_event_add_fd' with 'ssh_event_remove_fd' in 'ssh_select'.
BUG: https://red.libssh.org/issues/128
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-10-31 12:45:21 +01:00
Andreas Schneider
b00a6e3885
tests: Add a test for ssh_channel().
2013-10-31 12:44:48 +01:00
Jon Simons
ffc33ca28c
poll: fix leak in ssh_poll_ctx_free
...
Fix a memory leak in 'ssh_poll_ctx_free': issue 'ssh_poll_free'
to remove the poll handle from its context and free it.
BUG: https://red.libssh.org/issues/128
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-10-31 11:55:09 +01:00
Alan Dunn
ee95c05c08
SSH_AUTH_OK -> SSH_AUTH_SUCCESS in comments
...
A few callback descriptions refer to a non-existent value SSH_AUTH_OK,
which should be SSH_AUTH_SUCCESS. This commit fixes these.
Signed-off-by: Alan Dunn <amdunn@gmail.com>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-10-31 08:18:55 +01:00
Andreas Schneider
cfea381307
cmake: Check for isblank().
2013-10-30 17:30:07 +01:00
Jon Simons
099b914fd9
bind: fix leak in ssh_bind_accept error path
...
Use 'ssh_socket_free' to cleanup if 'ssh_bind_accept_fd'
fails, to be sure to free the ssh_socket in/out buffers.
2013-10-24 10:37:37 +02:00
Andreas Schneider
afd35fa98c
tests: Add a sftp_read blocking test.
2013-10-23 15:49:07 +02:00
Colin Walters
f02bc4768e
auth: docs: Fix typo optoins -> options
...
I'm just getting my feet wet with this codebase.
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-10-23 09:55:09 +02:00
Andreas Schneider
bcb162816e
doc: Improve sftp_read_sync() example.
2013-10-23 09:53:16 +02:00
Andreas Schneider
5baa6aed6b
include: Fix build on platforms without ECC.
2013-10-21 07:15:59 +02:00
Andreas Schneider
6a6e85752e
tests: Add a test for ssh_channel_request_env().
2013-10-20 17:05:35 +02:00
Andreas Schneider
4421540b7b
tests: We can't test the accept right now.
2013-10-20 13:28:53 +02:00
Andreas Schneider
d3c186b04c
tests: Fix torture_forward.
2013-10-20 13:23:31 +02:00
Andreas Schneider
e30acdb58a
channel: Reinit the buffer and reset the state on error.
...
BUG: https://red.libssh.org/issues/126
2013-10-20 12:46:57 +02:00
Andreas Schneider
b0cbe88b0b
channel: Fix ssh_global_request_termination().
...
BUG: https://red.libssh.org/issues/126
2013-10-20 12:46:17 +02:00
Andreas Schneider
3afba83134
tests: Add torture forward test.
2013-10-20 12:46:17 +02:00
Andreas Schneider
b8d47a438c
pki: Don't leak a buffer.
2013-10-19 10:41:57 +02:00
Andreas Schneider
5201c5850e
wrapper: Fix compilation with gcrypt.
2013-10-19 10:39:00 +02:00
Andreas Schneider
bd8ab422d0
pki_crpypto: Fix ecdsa signature to blob.
...
BUG: https://red.libssh.org/issues/118
2013-10-18 23:48:21 +02:00
Andreas Schneider
33890daf41
pki: Add support for ECDSA private key signing.
2013-10-18 23:22:24 +02:00
Andreas Schneider
ac4c5699b1
pki: Add the type as a char pointer.
2013-10-18 23:22:24 +02:00
Andreas Schneider
15e31eb464
wrapper: Add more evp functions.
2013-10-18 23:22:24 +02:00
Andreas Schneider
2e81dd61dd
client: Fix the build.
2013-10-18 21:18:36 +02:00
Oliver Stöneberg
f2c2687ca6
scp: Fixed result of ssh_scp_string_mode() to get SCP working.
...
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-10-18 14:58:47 +02:00
Oliver Stöneberg
4c300313c3
client: Added a missing NULL pointer check.
...
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-10-18 14:57:33 +02:00
Andreas Schneider
bec13a6ac0
doc: Make sure we have the defines to build all docs.
2013-10-14 15:39:33 +02:00
Andreas Schneider
423d8c9b6a
channel: Fix packets termination timeout in global_request().
...
BUG: https://red.libssh.org/issues/126
2013-10-01 14:50:56 +02:00
Andreas Schneider
685fe1d0b6
session: Try the ecdsa default key first.
2013-10-01 14:45:01 +02:00
Tristan CACQUERAY
e588e2325d
callbacks: add support for auth_none_function
2013-09-27 15:34:45 +02:00
Aris Adamantiadis
04fd756c49
doc: Documentation of curve25519-sha256@libssh.org
2013-09-27 15:32:52 +02:00
Aris Adamantiadis
4cb6afcbd4
kex: implement curve25519-sha256@libssh.org
2013-09-27 15:32:44 +02:00
Andreas Schneider
4eae4d592c
channels: Correctly handle timeouts in channel functions.
2013-09-17 11:23:56 +02:00
Andreas Schneider
566d842405
channel: Use the correct timeout option in channel_open().
...
BUG: https://red.libssh.org/issues/124
2013-09-17 11:19:49 +02:00
Andreas Schneider
5e2fbbc202
callbacks: Improve the documentation of ssh_threads_set_callbacks().
...
BUG: https://red.libssh.org/issues/123
2013-09-16 10:54:30 +02:00
Andreas Schneider
8e703b9974
callbacks: Improve the documentation of ssh_threads_get_noop().
...
BUG: https://red.libssh.org/issues/123
2013-09-16 10:50:25 +02:00
Andreas Schneider
89853607c5
session: Document return value of ssh_get_serverbanner().
...
BUG: https://red.libssh.org/issues/122
2013-09-16 10:38:14 +02:00
Andreas Schneider
20658abc78
session: Remove obsolete status variables.
...
BUG: https://red.libssh.org/issues/121
2013-09-16 10:38:14 +02:00
Andreas Schneider
8823dee51a
client: Add example code for ssh_get_openssh_version().
...
BUG: https://red.libssh.org/issues/120
2013-09-16 10:38:14 +02:00
Andreas Schneider
3e07359a35
channels: Correctly decrement timeout value in ssh_channel_accept().
...
BUG: https://red.libssh.org/issues/116
2013-09-16 10:38:14 +02:00
Andreas Schneider
e9242a7a31
channel: Document SSH_AGAIN in ssh_channel_read().
...
BUG: https://red.libssh.org/issues/115
2013-09-16 10:38:14 +02:00
Andreas Schneider
b9ada25296
cmake: Allow to build without examples.
...
BUG: https://red.libssh.org/issues/114
2013-09-16 10:38:14 +02:00
Andreas Schneider
33cb1bc08b
doc: Improve the PKI documentation a bit.
2013-09-10 06:59:25 +02:00
Andreas Schneider
6da54688eb
doc: Update documentation of ssh_set_blocking().
...
This should work correctly in libssh 0.6.0. If not then you hit a bug.
2013-09-09 16:43:46 +02:00
Andreas Schneider
ef6d19fbb1
clang_complete: Update definitons.
2013-08-13 12:09:59 +02:00
Andreas Schneider
acbca6a562
ecdh: Refactor ecdh_build_k to check errors codes.
2013-08-13 12:09:36 +02:00
Andreas Schneider
fc8081cd06
channel: Refactor channel_write_common() code.
...
This makes it easier to read and easier to debug.
2013-08-13 08:22:28 +02:00
Andreas Schneider
7a64dd1b9a
channel: Make channel_write_common() static.
2013-08-13 08:17:15 +02:00
Andreas Schneider
5045133dc2
channel: Use MIN macro in channel_write_common().
2013-08-13 08:15:37 +02:00