Jon Simons
20b5734649
channel: fix setting of channel->flags
...
Fix the setting of 'channel->flags' to use '|='. Before this
change, one bug symptom can be that channels are never fully
free'd via ssh_channel_free, resulting in memory leaks.
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-12-11 21:02:47 +01:00
Jon Simons
0557f57c63
client: use ssh_channel_do_free in ssh_disconnect
...
Ensure to use 'ssh_channel_do_free' in 'ssh_disconnect', when removing and
free'ing up a session's channels. This matches the behavior in 'ssh_free',
and is necessary to fully free any channel which may not have been closed
completely (see usage of flags SSH_CHANNEL_FLAG_CLOSED_REMOTE,
SSH_CHANNEL_FLAG_FREED_LOCAL).
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-12-11 21:02:05 +01:00
Andreas Schneider
4f4e917187
bind: Correctly free all memory in ssh_bind_free().
...
Thanks to Jacob Baines.
2013-12-09 19:49:54 +01:00
Jon Simons
a1f0b2acfc
session: Add ssh_get_clientbanner().
2013-12-07 16:24:33 +01:00
Andreas Schneider
d65777b570
channels: Add a ssh_channel_read_timeout function.
2013-12-04 20:34:13 +01:00
Andreas Schneider
2df00fd84c
tests: Try to fix torture_forward.
2013-12-04 14:21:52 +01:00
Andreas Schneider
d1d3beac33
tests: Fix memory leaks.
2013-11-28 14:40:11 +01:00
Andreas Schneider
ad0abff8b3
tests: Add missing line breaks.
2013-11-28 11:49:11 +01:00
Andreas Schneider
cdd7a6cb8d
pki: Fix a memory leak.
...
CID #1132819
2013-11-28 09:09:45 +01:00
Andreas Schneider
004240af48
tests: Add torture_pki_write_privkey_ecdsa test.
2013-11-27 22:54:13 +01:00
Andreas Schneider
4e3d16e291
tests: Add torture_pki_write_privkey_dsa test.
2013-11-27 22:54:13 +01:00
Andreas Schneider
7933aef747
tests: Add torture_pki_write_privkey_rsa test.
2013-11-27 22:54:13 +01:00
Andreas Schneider
136efd6ed5
pki: Add ssh_pki_import_privkey_file().
2013-11-27 22:54:13 +01:00
Andreas Schneider
94969cf263
pki_crypto: Add pki_private_key_to_pem().
2013-11-27 22:54:13 +01:00
Andreas Schneider
68c3c26029
pki_gcrypt: Add pki_private_key_to_pem() stub.
2013-11-27 22:54:13 +01:00
Andreas Schneider
fd185acbea
curve25519: Fix memory leaks in ssh_server_curve25519_init().
...
CID #1125255
2013-11-27 20:26:14 +01:00
Andreas Schneider
7a4e8e58f0
curve25519: Do not leak q_s_string.
...
CID #1125256
2013-11-27 20:20:07 +01:00
Andreas Schneider
cbeb2a9de7
curve25519: Fix a memory leak.
...
CID #1125257
2013-11-27 20:18:25 +01:00
Andreas Schneider
d61fcbf7b2
examples: Fix else branch.
...
CID #1127816
2013-11-27 20:16:09 +01:00
Andreas Schneider
75e61f498b
packet: Remove logically dead code.
...
CID #1128796
2013-11-27 20:14:02 +01:00
Andreas Schneider
09edee123a
tests: Try to fix valgrind warnings.
2013-11-27 18:04:44 +01:00
Andreas Schneider
060171028c
tests: Fix a valgrind warning.
2013-11-27 17:55:48 +01:00
Andreas Schneider
7ecdc3e0d5
ecdh: Check if we have ECC support.
2013-11-27 17:38:21 +01:00
Andreas Schneider
67a080874b
ecdh: Use bignum_bin2bn.
2013-11-27 17:35:36 +01:00
Nicolas Viennot
7b63fe2f22
server: Add a ssh_send_keepalive() function.
...
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-11-24 23:21:04 +01:00
Jon Simons
3d934f3ddc
channel: fix infinite loop in channel_write_common
...
BUG: https://red.libssh.org/issues/130
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-11-22 10:34:23 +01:00
Rod Vagg
06cc94eecf
flush channel after EOF and CLOSE
2013-11-18 17:22:30 +01:00
Aris Adamantiadis
f6443b725a
logging: fix server-side logging
2013-11-18 15:29:27 +01:00
Aris Adamantiadis
d8ead516de
gssapi: fix logging
2013-11-18 15:11:26 +01:00
Aris Adamantiadis
ccdc0f1805
sockets: null pointer check
2013-11-18 14:42:40 +01:00
Simo Sorce
66e7e7023b
gssapi: Fix support of delegated credentials
...
In a previous refactoring patch, the code underpinning the
ssh_gssapi_set_creds() API was inadvertently removed. This patch
fixes the problem.
Also clarify what variable holds which credentials and insure that
credentials created within the library are propelry freed.
Signed-off-by: Simo Sorce <simo@redhat.com>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-11-15 23:32:20 -05:00
Simo Sorce
b4fc5d9524
gssapi: Add support for GSSAPIDelegateCredentials config option.
...
Signed-off-by: Simo Sorce <simo@redhat.com>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-11-15 16:53:59 -05:00
Simo Sorce
811c645f2a
options: Add SSH_OPTIONS_GSSAPI_DELEGATE_CREDENTIALS option.
...
Signed-off-by: Simo Sorce <simo@redhat.com>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-11-15 16:10:29 -05:00
Andreas Schneider
c2312f9dda
gssapi: Add error checks and cleanup the code in ssh_gssapi_auth_mic().
2013-11-15 16:28:49 +01:00
Simo Sorce
440d2ec0ea
gssapi: Use GSSAPIClientIdentity to acquire creds
...
Signed-off-by: Simo Sorce <simo@redhat.com>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-11-15 16:19:28 +01:00
Andreas Schneider
47e53deebd
gssapi: Add support for GSSAPIClientIdentity config option.
2013-11-15 15:50:09 +01:00
Andreas Schneider
095a01b70c
options: Add SSH_OPTIONS_GSSAPI_CLIENT_IDENTITY option.
2013-11-15 15:50:09 +01:00
Andreas Schneider
503c729bb0
gssapi: Add support for GSSAPIServerIdentity config option.
2013-11-15 15:50:09 +01:00
Andreas Schneider
41d99d32e8
gssapi: Add suppport to set GSSAPI server identity.
2013-11-15 15:50:09 +01:00
Simo Sorce
c481f9dafd
Fix gssapi credential handling.
...
- Properly acquire and inquitre credentials to get the list of available
credentials.
- Avoid enforcing a specific username it breaks some use cases (k5login).
- Remove confusing references to delegated credentials as there is no code
that actually uses delegated credentials in the initialization case.
Signed-off-by: Siom Sorce <simo@redhat.com>
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-11-15 14:49:29 +01:00
Andreas Schneider
f240ecf328
socket: Fix connect if we pass in a fd.
...
BUG: https://red.libssh.org/issues/106
Thanks to Saju Panikulam.
2013-11-15 08:47:58 +01:00
Andreas Schneider
1972a27fe0
packet: Remove dead code.
2013-11-14 11:43:49 +01:00
Andreas Schneider
097760db17
packet: Set the packet to the processed data position.
...
Else we could end up with packet - current_macsize if to_be_read is 0.
2013-11-14 11:42:21 +01:00
Andreas Schneider
b3a08ba8d3
dh: Fix wrong assignment.
...
Ups, sorry.
2013-11-14 08:08:49 +01:00
Andreas Schneider
fef7e1dffe
poll: Fix realloc in ssh_poll_ctx_resize().
2013-11-09 13:27:59 +01:00
Andreas Schneider
6d7bbe63fe
dh: Avoid possible memory leaks with realloc.
2013-11-09 13:20:13 +01:00
Andreas Schneider
387e26c837
packet: Refactor ssh_packet_socket_callback().
...
Make error checking more readable and add additional NULL checks.
2013-11-09 13:10:41 +01:00
Andreas Schneider
e8e99ec6de
server: Fix malloc call.
2013-11-09 12:47:02 +01:00
Colin Walters
13c4499449
session: Always request POLLIN
...
The assumption is that if libssh functions are being invoked, we want
to read data.
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-11-09 12:29:07 +01:00
Colin Walters
4cc7f4ad03
Add ssh_get_poll_flags()
...
For integration with an external mainloop, we need to know how to
replicate libssh's internal poll() calls. We originally through
ssh_get_status() was that API, but it's not really - those flags only
get updated from the *result* of a poll(), where what we really need
is to know how libssh would *start* a poll().
Reviewed-by: Andreas Schneider <asn@cryptomilk.org>
2013-11-09 12:26:19 +01:00